* [PATCH 1/7] boost: Compile out stdlib unary/binary_functions for c++11 and newer
@ 2022-08-16 16:58 Khem Raj
2022-08-16 16:58 ` [PATCH 2/7] vulkan-samples: Qualify move as std::move Khem Raj
` (5 more replies)
0 siblings, 6 replies; 10+ messages in thread
From: Khem Raj @ 2022-08-16 16:58 UTC (permalink / raw)
To: openembedded-core; +Cc: Khem Raj
These base classes are deprecated/removed from libcpp15
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
...y-binary_function-base-classes-are-d.patch | 34 +++++++++++++++++++
meta/recipes-support/boost/boost_1.79.0.bb | 1 +
2 files changed, 35 insertions(+)
create mode 100644 meta/recipes-support/boost/boost/0001-The-std-lib-unary-binary_function-base-classes-are-d.patch
diff --git a/meta/recipes-support/boost/boost/0001-The-std-lib-unary-binary_function-base-classes-are-d.patch b/meta/recipes-support/boost/boost/0001-The-std-lib-unary-binary_function-base-classes-are-d.patch
new file mode 100644
index 00000000000..49603348eee
--- /dev/null
+++ b/meta/recipes-support/boost/boost/0001-The-std-lib-unary-binary_function-base-classes-are-d.patch
@@ -0,0 +1,34 @@
+From f9b55f5a1fab85bf73c95e6372779d6f50f75e84 Mon Sep 17 00:00:00 2001
+From: jzmaddock <john@johnmaddock.co.uk>
+Date: Mon, 11 Jul 2022 18:26:07 +0100
+Subject: [PATCH] The std lib unary/binary_function base classes are
+ deprecated/removed from libcpp15. Fixes
+ https://github.com/boostorg/container_hash/issues/24.
+
+Upstream-Status: Backport [https://github.com/boostorg/config/pull/440/commits/f0af4a9184457939b89110795ae2d293582c5f66]
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ boost/config/stdlib/libcpp.hpp | 9 +++++++++
+ 1 file changed, 9 insertions(+)
+
+diff --git a/boost/config/stdlib/libcpp.hpp b/boost/config/stdlib/libcpp.hpp
+index bc8536ead..0e9f2445e 100644
+--- a/boost/config/stdlib/libcpp.hpp
++++ b/boost/config/stdlib/libcpp.hpp
+@@ -168,4 +168,13 @@
+ # define BOOST_NO_CXX14_HDR_SHARED_MUTEX
+ #endif
+
++#if _LIBCPP_VERSION >= 15000
++//
++// Unary function is now deprecated in C++11 and later:
++//
++#if __cplusplus >= 201103L
++#define BOOST_NO_CXX98_FUNCTION_BASE
++#endif
++#endif
++
+ // --- end ---
+--
+2.37.2
+
diff --git a/meta/recipes-support/boost/boost_1.79.0.bb b/meta/recipes-support/boost/boost_1.79.0.bb
index dd5d6eadd61..09e25567903 100644
--- a/meta/recipes-support/boost/boost_1.79.0.bb
+++ b/meta/recipes-support/boost/boost_1.79.0.bb
@@ -5,4 +5,5 @@ SRC_URI += "file://boost-CVE-2012-2677.patch \
file://boost-math-disable-pch-for-gcc.patch \
file://0001-Don-t-set-up-arch-instruction-set-flags-we-do-that-o.patch \
file://0001-dont-setup-compiler-flags-m32-m64.patch \
+ file://0001-The-std-lib-unary-binary_function-base-classes-are-d.patch \
"
--
2.37.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/7] vulkan-samples: Qualify move as std::move
2022-08-16 16:58 [PATCH 1/7] boost: Compile out stdlib unary/binary_functions for c++11 and newer Khem Raj
@ 2022-08-16 16:58 ` Khem Raj
2022-08-16 16:58 ` [PATCH 3/7] rpm: Remove -Wimplicit-function-declaration warnings Khem Raj
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Khem Raj @ 2022-08-16 16:58 UTC (permalink / raw)
To: openembedded-core; +Cc: Khem Raj
Fixes build with clang
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
.../0001-Qualify-move-as-std-move.patch | 405 ++++++++++++++++++
.../vulkan/vulkan-samples_git.bb | 1 +
2 files changed, 406 insertions(+)
create mode 100644 meta/recipes-graphics/vulkan/vulkan-samples/0001-Qualify-move-as-std-move.patch
diff --git a/meta/recipes-graphics/vulkan/vulkan-samples/0001-Qualify-move-as-std-move.patch b/meta/recipes-graphics/vulkan/vulkan-samples/0001-Qualify-move-as-std-move.patch
new file mode 100644
index 00000000000..80ee521499f
--- /dev/null
+++ b/meta/recipes-graphics/vulkan/vulkan-samples/0001-Qualify-move-as-std-move.patch
@@ -0,0 +1,405 @@
+From 9e061b12b9305eee96a4d3129b646c244cc02347 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Sun, 14 Aug 2022 19:16:45 -0700
+Subject: [PATCH] Qualify move as std::move
+
+Seeing errors like below with clang-15
+
+spirv_common.hpp:692:19: error: unqualified call to std::move
+
+squashed Backport of following upstream commits
+
+https://github.com/KhronosGroup/SPIRV-Cross/commit/44c3333a1c315ead00c24f7aef5fa8a7ccf49299
+https://github.com/KhronosGroup/SPIRV-Cross/commit/0eda71c40936586ea812d0d20d93c11a3e9af192
+
+Upstream-Status: Backport [https://github.com/KhronosGroup/SPIRV-Cross/commit/0eda71c40936586ea812d0d20d93c11a3e9af192]
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ main.cpp | 38 +++++++++++++++++++-------------------
+ spirv_common.hpp | 2 +-
+ spirv_cpp.hpp | 2 +-
+ spirv_cross.cpp | 18 +++++++++---------
+ spirv_glsl.cpp | 2 +-
+ spirv_glsl.hpp | 2 +-
+ spirv_hlsl.cpp | 4 ++--
+ spirv_hlsl.hpp | 2 +-
+ spirv_msl.cpp | 2 +-
+ spirv_parser.cpp | 4 ++--
+ spirv_reflect.hpp | 2 +-
+ 11 files changed, 39 insertions(+), 39 deletions(-)
+
+diff --git a/main.cpp b/main.cpp
+index 78991094..581c5e3b 100644
+--- a/main.cpp
++++ b/main.cpp
+@@ -65,7 +65,7 @@ struct CLICallbacks
+ struct CLIParser
+ {
+ CLIParser(CLICallbacks cbs_, int argc_, char *argv_[])
+- : cbs(move(cbs_))
++ : cbs(std::move(cbs_))
+ , argc(argc_)
+ , argv(argv_)
+ {
+@@ -722,7 +722,7 @@ static int main_inner(int argc, char *argv[])
+ auto old_name = parser.next_string();
+ auto new_name = parser.next_string();
+ auto model = stage_to_execution_model(parser.next_string());
+- args.entry_point_rename.push_back({ old_name, new_name, move(model) });
++ args.entry_point_rename.push_back({ old_name, new_name, std::move(model) });
+ });
+ cbs.add("--entry", [&args](CLIParser &parser) { args.entry = parser.next_string(); });
+ cbs.add("--stage", [&args](CLIParser &parser) { args.entry_stage = parser.next_string(); });
+@@ -731,20 +731,20 @@ static int main_inner(int argc, char *argv[])
+ HLSLVertexAttributeRemap remap;
+ remap.location = parser.next_uint();
+ remap.semantic = parser.next_string();
+- args.hlsl_attr_remap.push_back(move(remap));
++ args.hlsl_attr_remap.push_back(std::move(remap));
+ });
+
+ cbs.add("--remap", [&args](CLIParser &parser) {
+ string src = parser.next_string();
+ string dst = parser.next_string();
+ uint32_t components = parser.next_uint();
+- args.remaps.push_back({ move(src), move(dst), components });
++ args.remaps.push_back({ std::move(src), std::move(dst), components });
+ });
+
+ cbs.add("--remap-variable-type", [&args](CLIParser &parser) {
+ string var_name = parser.next_string();
+ string new_type = parser.next_string();
+- args.variable_type_remaps.push_back({ move(var_name), move(new_type) });
++ args.variable_type_remaps.push_back({ std::move(var_name), std::move(new_type) });
+ });
+
+ cbs.add("--rename-interface-variable", [&args](CLIParser &parser) {
+@@ -757,18 +757,18 @@ static int main_inner(int argc, char *argv[])
+
+ uint32_t loc = parser.next_uint();
+ string var_name = parser.next_string();
+- args.interface_variable_renames.push_back({ cls, loc, move(var_name) });
++ args.interface_variable_renames.push_back({ cls, loc, std::move(var_name) });
+ });
+
+ cbs.add("--pls-in", [&args](CLIParser &parser) {
+ auto fmt = pls_format(parser.next_string());
+ auto name = parser.next_string();
+- args.pls_in.push_back({ move(fmt), move(name) });
++ args.pls_in.push_back({ std::move(fmt), std::move(name) });
+ });
+ cbs.add("--pls-out", [&args](CLIParser &parser) {
+ auto fmt = pls_format(parser.next_string());
+ auto name = parser.next_string();
+- args.pls_out.push_back({ move(fmt), move(name) });
++ args.pls_out.push_back({ std::move(fmt), std::move(name) });
+ });
+ cbs.add("--shader-model", [&args](CLIParser &parser) {
+ args.shader_model = parser.next_uint();
+@@ -788,7 +788,7 @@ static int main_inner(int argc, char *argv[])
+ cbs.default_handler = [&args](const char *value) { args.input = value; };
+ cbs.error_handler = [] { print_help(); };
+
+- CLIParser parser{ move(cbs), argc - 1, argv + 1 };
++ CLIParser parser{ std::move(cbs), argc - 1, argv + 1 };
+ if (!parser.parse())
+ {
+ return EXIT_FAILURE;
+@@ -808,14 +808,14 @@ static int main_inner(int argc, char *argv[])
+ auto spirv_file = read_spirv_file(args.input);
+ if (spirv_file.empty())
+ return EXIT_FAILURE;
+- Parser spirv_parser(move(spirv_file));
++ Parser spirv_parser(std::move(spirv_file));
+
+ spirv_parser.parse();
+
+ // Special case reflection because it has little to do with the path followed by code-outputting compilers
+ if (!args.reflect.empty())
+ {
+- CompilerReflection compiler(move(spirv_parser.get_parsed_ir()));
++ CompilerReflection compiler(std::move(spirv_parser.get_parsed_ir()));
+ compiler.set_format(args.reflect);
+ auto json = compiler.compile();
+ if (args.output)
+@@ -831,13 +831,13 @@ static int main_inner(int argc, char *argv[])
+
+ if (args.cpp)
+ {
+- compiler.reset(new CompilerCPP(move(spirv_parser.get_parsed_ir())));
++ compiler.reset(new CompilerCPP(std::move(spirv_parser.get_parsed_ir())));
+ if (args.cpp_interface_name)
+ static_cast<CompilerCPP *>(compiler.get())->set_interface_name(args.cpp_interface_name);
+ }
+ else if (args.msl)
+ {
+- compiler.reset(new CompilerMSL(move(spirv_parser.get_parsed_ir())));
++ compiler.reset(new CompilerMSL(std::move(spirv_parser.get_parsed_ir())));
+
+ auto *msl_comp = static_cast<CompilerMSL *>(compiler.get());
+ auto msl_opts = msl_comp->get_msl_options();
+@@ -850,13 +850,13 @@ static int main_inner(int argc, char *argv[])
+ msl_comp->set_msl_options(msl_opts);
+ }
+ else if (args.hlsl)
+- compiler.reset(new CompilerHLSL(move(spirv_parser.get_parsed_ir())));
++ compiler.reset(new CompilerHLSL(std::move(spirv_parser.get_parsed_ir())));
+ else
+ {
+ combined_image_samplers = !args.vulkan_semantics;
+ if (!args.vulkan_semantics)
+ build_dummy_sampler = true;
+- compiler.reset(new CompilerGLSL(move(spirv_parser.get_parsed_ir())));
++ compiler.reset(new CompilerGLSL(std::move(spirv_parser.get_parsed_ir())));
+ }
+
+ if (!args.variable_type_remaps.empty())
+@@ -867,7 +867,7 @@ static int main_inner(int argc, char *argv[])
+ out = remap.new_variable_type;
+ };
+
+- compiler->set_variable_type_remap_callback(move(remap_cb));
++ compiler->set_variable_type_remap_callback(std::move(remap_cb));
+ }
+
+ for (auto &rename : args.entry_point_rename)
+@@ -1019,7 +1019,7 @@ static int main_inner(int argc, char *argv[])
+ {
+ auto active = compiler->get_active_interface_variables();
+ res = compiler->get_shader_resources(active);
+- compiler->set_enabled_interface_variables(move(active));
++ compiler->set_enabled_interface_variables(std::move(active));
+ }
+ else
+ res = compiler->get_shader_resources();
+@@ -1034,7 +1034,7 @@ static int main_inner(int argc, char *argv[])
+
+ auto pls_inputs = remap_pls(args.pls_in, res.stage_inputs, &res.subpass_inputs);
+ auto pls_outputs = remap_pls(args.pls_out, res.stage_outputs, nullptr);
+- compiler->remap_pixel_local_storage(move(pls_inputs), move(pls_outputs));
++ compiler->remap_pixel_local_storage(std::move(pls_inputs), std::move(pls_outputs));
+
+ for (auto &ext : args.extensions)
+ compiler->require_extension(ext);
+@@ -1101,7 +1101,7 @@ static int main_inner(int argc, char *argv[])
+ for (uint32_t i = 0; i < args.iterations; i++)
+ {
+ if (args.hlsl)
+- glsl = static_cast<CompilerHLSL *>(compiler.get())->compile(move(args.hlsl_attr_remap));
++ glsl = static_cast<CompilerHLSL *>(compiler.get())->compile(std::move(args.hlsl_attr_remap));
+ else
+ glsl = compiler->compile();
+ }
+diff --git a/spirv_common.hpp b/spirv_common.hpp
+index aa32142d..0daf5ad5 100644
+--- a/spirv_common.hpp
++++ b/spirv_common.hpp
+@@ -536,7 +536,7 @@ struct SPIRExpression : IVariant
+
+ // Only created by the backend target to avoid creating tons of temporaries.
+ SPIRExpression(std::string expr, uint32_t expression_type_, bool immutable_)
+- : expression(move(expr))
++ : expression(std::move(expr))
+ , expression_type(expression_type_)
+ , immutable(immutable_)
+ {
+diff --git a/spirv_cpp.hpp b/spirv_cpp.hpp
+index bcdb669b..b4da84b9 100644
+--- a/spirv_cpp.hpp
++++ b/spirv_cpp.hpp
+@@ -27,7 +27,7 @@ class CompilerCPP : public CompilerGLSL
+ {
+ public:
+ explicit CompilerCPP(std::vector<uint32_t> spirv_)
+- : CompilerGLSL(move(spirv_))
++ : CompilerGLSL(std::move(spirv_))
+ {
+ }
+
+diff --git a/spirv_cross.cpp b/spirv_cross.cpp
+index 19bac301..d21dbd41 100644
+--- a/spirv_cross.cpp
++++ b/spirv_cross.cpp
+@@ -28,16 +28,16 @@ using namespace spirv_cross;
+
+ Compiler::Compiler(vector<uint32_t> ir_)
+ {
+- Parser parser(move(ir_));
++ Parser parser(std::move(ir_));
+ parser.parse();
+- set_ir(move(parser.get_parsed_ir()));
++ set_ir(std::move(parser.get_parsed_ir()));
+ }
+
+ Compiler::Compiler(const uint32_t *ir_, size_t word_count)
+ {
+ Parser parser(ir_, word_count);
+ parser.parse();
+- set_ir(move(parser.get_parsed_ir()));
++ set_ir(std::move(parser.get_parsed_ir()));
+ }
+
+ Compiler::Compiler(const ParsedIR &ir_)
+@@ -47,12 +47,12 @@ Compiler::Compiler(const ParsedIR &ir_)
+
+ Compiler::Compiler(ParsedIR &&ir_)
+ {
+- set_ir(move(ir_));
++ set_ir(std::move(ir_));
+ }
+
+ void Compiler::set_ir(ParsedIR &&ir_)
+ {
+- ir = move(ir_);
++ ir = std::move(ir_);
+ parse_fixup();
+ }
+
+@@ -716,7 +716,7 @@ unordered_set<uint32_t> Compiler::get_active_interface_variables() const
+
+ void Compiler::set_enabled_interface_variables(std::unordered_set<uint32_t> active_variables)
+ {
+- active_interface_variables = move(active_variables);
++ active_interface_variables = std::move(active_variables);
+ check_active_interface_variables = true;
+ }
+
+@@ -2163,7 +2163,7 @@ void Compiler::CombinedImageSamplerHandler::push_remap_parameters(const SPIRFunc
+ unordered_map<uint32_t, uint32_t> remapping;
+ for (uint32_t i = 0; i < length; i++)
+ remapping[func.arguments[i].id] = remap_parameter(args[i]);
+- parameter_remapping.push(move(remapping));
++ parameter_remapping.push(std::move(remapping));
+ }
+
+ void Compiler::CombinedImageSamplerHandler::pop_remap_parameters()
+@@ -3611,7 +3611,7 @@ void Compiler::analyze_image_and_sampler_usage()
+
+ CombinedImageSamplerUsageHandler handler(*this, dref_handler.dref_combined_samplers);
+ traverse_all_reachable_opcodes(get<SPIRFunction>(ir.default_entry_point), handler);
+- comparison_ids = move(handler.comparison_ids);
++ comparison_ids = std::move(handler.comparison_ids);
+ need_subpass_input = handler.need_subpass_input;
+
+ // Forward information from separate images and samplers into combined image samplers.
+@@ -3650,7 +3650,7 @@ void Compiler::build_function_control_flow_graphs_and_analyze()
+ CFGBuilder handler(*this);
+ handler.function_cfgs[ir.default_entry_point].reset(new CFG(*this, get<SPIRFunction>(ir.default_entry_point)));
+ traverse_all_reachable_opcodes(get<SPIRFunction>(ir.default_entry_point), handler);
+- function_cfgs = move(handler.function_cfgs);
++ function_cfgs = std::move(handler.function_cfgs);
+
+ for (auto &f : function_cfgs)
+ {
+diff --git a/spirv_glsl.cpp b/spirv_glsl.cpp
+index a8855987..fabbb105 100644
+--- a/spirv_glsl.cpp
++++ b/spirv_glsl.cpp
+@@ -6876,7 +6876,7 @@ void CompilerGLSL::emit_instruction(const Instruction &instruction)
+ bool ptr_chain = opcode == OpPtrAccessChain;
+ auto e = access_chain(ops[2], &ops[3], length - 3, get<SPIRType>(ops[0]), &meta, ptr_chain);
+
+- auto &expr = set<SPIRExpression>(ops[1], move(e), ops[0], should_forward(ops[2]));
++ auto &expr = set<SPIRExpression>(ops[1], std::move(e), ops[0], should_forward(ops[2]));
+
+ auto *backing_variable = maybe_get_backing_variable(ops[2]);
+ expr.loaded_from = backing_variable ? backing_variable->self : ops[2];
+diff --git a/spirv_glsl.hpp b/spirv_glsl.hpp
+index caf0ad3b..aac1196e 100644
+--- a/spirv_glsl.hpp
++++ b/spirv_glsl.hpp
+@@ -138,7 +138,7 @@ public:
+ }
+
+ explicit CompilerGLSL(std::vector<uint32_t> spirv_)
+- : Compiler(move(spirv_))
++ : Compiler(std::move(spirv_))
+ {
+ init();
+ }
+diff --git a/spirv_hlsl.cpp b/spirv_hlsl.cpp
+index a5b6d2dc..0933017e 100644
+--- a/spirv_hlsl.cpp
++++ b/spirv_hlsl.cpp
+@@ -2028,7 +2028,7 @@ void CompilerHLSL::emit_function_prototype(SPIRFunction &func, const Bitset &ret
+ out_argument += " ";
+ out_argument += "SPIRV_Cross_return_value";
+ out_argument += type_to_array_glsl(type);
+- arglist.push_back(move(out_argument));
++ arglist.push_back(std::move(out_argument));
+ }
+
+ for (auto &arg : func.arguments)
+@@ -4553,7 +4553,7 @@ void CompilerHLSL::require_texture_query_variant(const SPIRType &type)
+
+ string CompilerHLSL::compile(std::vector<HLSLVertexAttributeRemap> vertex_attributes)
+ {
+- remap_vertex_attributes = move(vertex_attributes);
++ remap_vertex_attributes = std::move(vertex_attributes);
+ return compile();
+ }
+
+diff --git a/spirv_hlsl.hpp b/spirv_hlsl.hpp
+index b2b60fca..3503c674 100644
+--- a/spirv_hlsl.hpp
++++ b/spirv_hlsl.hpp
+@@ -63,7 +63,7 @@ public:
+ };
+
+ explicit CompilerHLSL(std::vector<uint32_t> spirv_)
+- : CompilerGLSL(move(spirv_))
++ : CompilerGLSL(std::move(spirv_))
+ {
+ }
+
+diff --git a/spirv_msl.cpp b/spirv_msl.cpp
+index 0e1e733d..fbfcdba5 100644
+--- a/spirv_msl.cpp
++++ b/spirv_msl.cpp
+@@ -32,7 +32,7 @@ static const uint32_t k_aux_mbr_idx_swizzle_const = 0u;
+
+ CompilerMSL::CompilerMSL(vector<uint32_t> spirv_, vector<MSLVertexAttr> *p_vtx_attrs,
+ vector<MSLResourceBinding> *p_res_bindings)
+- : CompilerGLSL(move(spirv_))
++ : CompilerGLSL(std::move(spirv_))
+ {
+ if (p_vtx_attrs)
+ for (auto &va : *p_vtx_attrs)
+diff --git a/spirv_parser.cpp b/spirv_parser.cpp
+index 1725b4ca..0fcd7691 100644
+--- a/spirv_parser.cpp
++++ b/spirv_parser.cpp
+@@ -24,7 +24,7 @@ namespace spirv_cross
+ {
+ Parser::Parser(std::vector<uint32_t> spirv)
+ {
+- ir.spirv = move(spirv);
++ ir.spirv = std::move(spirv);
+ }
+
+ Parser::Parser(const uint32_t *spirv_data, size_t word_count)
+@@ -223,7 +223,7 @@ void Parser::parse(const Instruction &instruction)
+ case OpExtension:
+ {
+ auto ext = extract_string(ir.spirv, instruction.offset);
+- ir.declared_extensions.push_back(move(ext));
++ ir.declared_extensions.push_back(std::move(ext));
+ break;
+ }
+
+diff --git a/spirv_reflect.hpp b/spirv_reflect.hpp
+index 13b5b431..f5c6a6ff 100644
+--- a/spirv_reflect.hpp
++++ b/spirv_reflect.hpp
+@@ -34,7 +34,7 @@ class CompilerReflection : public CompilerGLSL
+
+ public:
+ explicit CompilerReflection(std::vector<uint32_t> spirv_)
+- : Parent(move(spirv_))
++ : Parent(std::move(spirv_))
+ {
+ options.vulkan_semantics = true;
+ }
+--
+2.37.2
+
diff --git a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb
index 41cb4a437d3..54994c683d2 100644
--- a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb
+++ b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb
@@ -9,6 +9,7 @@ SRC_URI = "gitsm://github.com/KhronosGroup/Vulkan-Samples.git;branch=master;prot
file://0001-CMakeLists.txt-do-not-hardcode-lib-as-installation-t.patch \
file://debugfix.patch \
file://0001-framework-core-hpp_vulkan_resource.h-add-header-incl.patch \
+ file://0001-Qualify-move-as-std-move.patch;patchdir=third_party/spirv-cross \
"
UPSTREAM_CHECK_COMMITS = "1"
--
2.37.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/7] rpm: Remove -Wimplicit-function-declaration warnings
2022-08-16 16:58 [PATCH 1/7] boost: Compile out stdlib unary/binary_functions for c++11 and newer Khem Raj
2022-08-16 16:58 ` [PATCH 2/7] vulkan-samples: Qualify move as std::move Khem Raj
@ 2022-08-16 16:58 ` Khem Raj
2022-08-16 16:58 ` [PATCH 4/7] nfs-utils: Upgrade to 2.6.2 Khem Raj
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Khem Raj @ 2022-08-16 16:58 UTC (permalink / raw)
To: openembedded-core; +Cc: Khem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
...ude-lib-rpmchroot.h-for-rpmChrootOut.patch | 26 +++++++++++++++++++
meta/recipes-devtools/rpm/rpm_4.17.1.bb | 1 +
2 files changed, 27 insertions(+)
create mode 100644 meta/recipes-devtools/rpm/files/0001-rpmscript-Include-lib-rpmchroot.h-for-rpmChrootOut.patch
diff --git a/meta/recipes-devtools/rpm/files/0001-rpmscript-Include-lib-rpmchroot.h-for-rpmChrootOut.patch b/meta/recipes-devtools/rpm/files/0001-rpmscript-Include-lib-rpmchroot.h-for-rpmChrootOut.patch
new file mode 100644
index 00000000000..2e0665853bf
--- /dev/null
+++ b/meta/recipes-devtools/rpm/files/0001-rpmscript-Include-lib-rpmchroot.h-for-rpmChrootOut.patch
@@ -0,0 +1,26 @@
+From fee6dd39e7223700cc4f7e073924b18409b645b6 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Mon, 15 Aug 2022 22:45:23 -0700
+Subject: [PATCH] rpmscript: Include lib/rpmchroot.h for rpmChrootOut()
+
+This fixes implicit function declarations warning
+
+Upstream-Status: Submitted [https://github.com/rpm-software-management/rpm/pull/2152]
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ lib/rpmscript.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/lib/rpmscript.c b/lib/rpmscript.c
+index 3e3a0027a..6d6d4c507 100644
+--- a/lib/rpmscript.c
++++ b/lib/rpmscript.c
+@@ -17,7 +17,7 @@
+ #include "rpmio/rpmio_internal.h"
+
+ #include "lib/rpmplugins.h" /* rpm plugins hooks */
+-
++#include "lib/rpmchroot.h" /* rpmChrootOut */
+ #include "debug.h"
+
+ struct scriptNextFileFunc_s {
diff --git a/meta/recipes-devtools/rpm/rpm_4.17.1.bb b/meta/recipes-devtools/rpm/rpm_4.17.1.bb
index 9b6446f265f..66955ad98ca 100644
--- a/meta/recipes-devtools/rpm/rpm_4.17.1.bb
+++ b/meta/recipes-devtools/rpm/rpm_4.17.1.bb
@@ -40,6 +40,7 @@ SRC_URI = "git://github.com/rpm-software-management/rpm;branch=rpm-4.17.x;protoc
file://0001-docs-do-not-build-manpages-requires-pandoc.patch \
file://0001-build-pack.c-do-not-insert-payloadflags-into-.rpm-me.patch \
file://0001-configure.ac-add-linux-gnux32-variant-to-triplet-han.patch \
+ file://0001-rpmscript-Include-lib-rpmchroot.h-for-rpmChrootOut.patch \
"
PE = "1"
--
2.37.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/7] nfs-utils: Upgrade to 2.6.2
2022-08-16 16:58 [PATCH 1/7] boost: Compile out stdlib unary/binary_functions for c++11 and newer Khem Raj
2022-08-16 16:58 ` [PATCH 2/7] vulkan-samples: Qualify move as std::move Khem Raj
2022-08-16 16:58 ` [PATCH 3/7] rpm: Remove -Wimplicit-function-declaration warnings Khem Raj
@ 2022-08-16 16:58 ` Khem Raj
2022-08-16 16:58 ` [PATCH 5/7] apt: Do not use std::binary_function Khem Raj
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Khem Raj @ 2022-08-16 16:58 UTC (permalink / raw)
To: openembedded-core; +Cc: Khem Raj
Fix build with clang
Package new rpcctl utility into a new package
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
...td-Check-for-return-of-stat-function.patch | 34 +++++++
.../0006-Fix-function-prototypes.patch | 93 +++++++++++++++++++
...{nfs-utils_2.6.1.bb => nfs-utils_2.6.2.bb} | 11 ++-
3 files changed, 135 insertions(+), 3 deletions(-)
create mode 100644 meta/recipes-connectivity/nfs-utils/nfs-utils/0005-mountd-Check-for-return-of-stat-function.patch
create mode 100644 meta/recipes-connectivity/nfs-utils/nfs-utils/0006-Fix-function-prototypes.patch
rename meta/recipes-connectivity/nfs-utils/{nfs-utils_2.6.1.bb => nfs-utils_2.6.2.bb} (92%)
diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils/0005-mountd-Check-for-return-of-stat-function.patch b/meta/recipes-connectivity/nfs-utils/nfs-utils/0005-mountd-Check-for-return-of-stat-function.patch
new file mode 100644
index 00000000000..13a21e53070
--- /dev/null
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils/0005-mountd-Check-for-return-of-stat-function.patch
@@ -0,0 +1,34 @@
+From 887ecc7837962e9be77a4fea7d9122648f73a84a Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Mon, 15 Aug 2022 14:47:53 -0700
+Subject: [PATCH] mountd: Check for return of stat function
+
+simplify the check, stat() return 0 on success -1 on failure
+
+Fixes clang reported errors e.g.
+
+| v4clients.c:29:6: error: logical not is only applied to the left hand side of this comparison [-Werror,-Wlogical-not-parentheses]
+| if (!stat("/proc/fs/nfsd/clients", &sb) == 0 ||
+| ^ ~~
+
+Upstream-Status: Submitted [https://patchwork.kernel.org/project/linux-nfs/patch/20220816024403.2694169-1-raj.khem@gmail.com/]
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+Cc: Konstantin Khorenko <khorenko@virtuozzo.com>
+Cc: Steve Dickson <steved@redhat.com>
+---
+ support/export/v4clients.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/support/export/v4clients.c b/support/export/v4clients.c
+index 5f15b61..3230251 100644
+--- a/support/export/v4clients.c
++++ b/support/export/v4clients.c
+@@ -26,7 +26,7 @@ void v4clients_init(void)
+ {
+ struct stat sb;
+
+- if (!stat("/proc/fs/nfsd/clients", &sb) == 0 ||
++ if (stat("/proc/fs/nfsd/clients", &sb) != 0 ||
+ !S_ISDIR(sb.st_mode))
+ return;
+ if (clients_fd >= 0)
diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils/0006-Fix-function-prototypes.patch b/meta/recipes-connectivity/nfs-utils/nfs-utils/0006-Fix-function-prototypes.patch
new file mode 100644
index 00000000000..793bc4651cd
--- /dev/null
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils/0006-Fix-function-prototypes.patch
@@ -0,0 +1,93 @@
+From cf0ffbb5c8fa167376926d12a63613f15aa7602f Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Mon, 15 Aug 2022 14:50:15 -0700
+Subject: [PATCH] Fix function prototypes
+
+Clang is now erroring out on functions with out parameter types
+
+Fixes errors like
+error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
+
+Upstream-Status: Submitted [https://patchwork.kernel.org/project/linux-nfs/patch/20220816024403.2694169-2-raj.khem@gmail.com/]
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ support/export/auth.c | 2 +-
+ support/export/v4root.c | 2 +-
+ support/export/xtab.c | 2 +-
+ utils/exportfs/exportfs.c | 4 ++--
+ utils/mount/network.c | 2 +-
+ 5 files changed, 6 insertions(+), 6 deletions(-)
+
+diff --git a/support/export/auth.c b/support/export/auth.c
+index 03ce4b8..2d7960f 100644
+--- a/support/export/auth.c
++++ b/support/export/auth.c
+@@ -82,7 +82,7 @@ check_useipaddr(void)
+ }
+
+ unsigned int
+-auth_reload()
++auth_reload(void)
+ {
+ struct stat stb;
+ static ino_t last_inode;
+diff --git a/support/export/v4root.c b/support/export/v4root.c
+index c12a7d8..fbb0ad5 100644
+--- a/support/export/v4root.c
++++ b/support/export/v4root.c
+@@ -198,7 +198,7 @@ static int v4root_add_parents(nfs_export *exp)
+ * looking for components of the v4 mount.
+ */
+ void
+-v4root_set()
++v4root_set(void)
+ {
+ nfs_export *exp;
+ int i;
+diff --git a/support/export/xtab.c b/support/export/xtab.c
+index c888a80..e210ca9 100644
+--- a/support/export/xtab.c
++++ b/support/export/xtab.c
+@@ -135,7 +135,7 @@ xtab_write(char *xtab, char *xtabtmp, char *lockfn, int is_export)
+ }
+
+ int
+-xtab_export_write()
++xtab_export_write(void)
+ {
+ return xtab_write(etab.statefn, etab.tmpfn, etab.lockfn, 1);
+ }
+diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
+index 6ba615d..0897b22 100644
+--- a/utils/exportfs/exportfs.c
++++ b/utils/exportfs/exportfs.c
+@@ -69,14 +69,14 @@ static int _lockfd = -1;
+ * need these additional lockfile() routines.
+ */
+ static void
+-grab_lockfile()
++grab_lockfile(void)
+ {
+ _lockfd = open(lockfile, O_CREAT|O_RDWR, 0666);
+ if (_lockfd != -1)
+ lockf(_lockfd, F_LOCK, 0);
+ }
+ static void
+-release_lockfile()
++release_lockfile(void)
+ {
+ if (_lockfd != -1) {
+ lockf(_lockfd, F_ULOCK, 0);
+diff --git a/utils/mount/network.c b/utils/mount/network.c
+index ed2f825..01ead49 100644
+--- a/utils/mount/network.c
++++ b/utils/mount/network.c
+@@ -179,7 +179,7 @@ static const unsigned long probe_mnt3_only[] = {
+
+ static const unsigned int *nfs_default_proto(void);
+ #ifdef MOUNT_CONFIG
+-static const unsigned int *nfs_default_proto()
++static const unsigned int *nfs_default_proto(void)
+ {
+ extern unsigned long config_default_proto;
+ /*
diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_2.6.1.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_2.6.2.bb
similarity index 92%
rename from meta/recipes-connectivity/nfs-utils/nfs-utils_2.6.1.bb
rename to meta/recipes-connectivity/nfs-utils/nfs-utils_2.6.2.bb
index bbed5aea59b..42311c66c73 100644
--- a/meta/recipes-connectivity/nfs-utils/nfs-utils_2.6.1.bb
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_2.6.2.bb
@@ -30,8 +30,10 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/nfs-utils/${PV}/nfs-utils-${PV}.tar.x
file://bugfix-adjust-statd-service-name.patch \
file://0001-Makefile.am-fix-undefined-function-for-libnsm.a.patch \
file://clang-warnings.patch \
+ file://0005-mountd-Check-for-return-of-stat-function.patch \
+ file://0006-Fix-function-prototypes.patch \
"
-SRC_URI[sha256sum] = "60dfcd94a9f3d72a12bc7058d811787ec87a6d593d70da2123faf9aad3d7a1df"
+SRC_URI[sha256sum] = "5200873e81c4d610e2462fc262fe18135f2dbe78b7979f95accd159ae64d5011"
# Only kernel-module-nfsd is required here (but can be built-in) - the nfsd module will
# pull in the remainder of the dependencies.
@@ -70,7 +72,7 @@ PACKAGECONFIG[nfsv41] = "--enable-nfsv41,--disable-nfsv41,libdevmapper,libdevmap
# keyutils is available in meta-oe
PACKAGECONFIG[nfsv4] = "--enable-nfsv4,--disable-nfsv4,keyutils,python3-core"
-PACKAGES =+ "${PN}-client ${PN}-mount ${PN}-stats"
+PACKAGES =+ "${PN}-client ${PN}-mount ${PN}-stats ${PN}-rpcctl"
CONFFILES:${PN}-client += "${localstatedir}/lib/nfs/etab \
${localstatedir}/lib/nfs/rmtab \
@@ -93,9 +95,12 @@ FILES:${PN}-mount = "${base_sbindir}/*mount.nfs*"
FILES:${PN}-stats = "${sbindir}/mountstats ${sbindir}/nfsiostat ${sbindir}/nfsdclnts"
RDEPENDS:${PN}-stats = "python3-core"
+FILES:${PN}-rpcctl = "${sbindir}/rpcctl"
+RDEPENDS:${PN}-rpcctl = "python3-core"
+
FILES:${PN}-staticdev += "${libdir}/libnfsidmap/*.a"
-FILES:${PN} += "${systemd_unitdir} ${libdir}/libnfsidmap/"
+FILES:${PN} += "${systemd_unitdir} ${libdir}/libnfsidmap/ ${nonarch_base_libdir}/modprobe.d"
do_configure:prepend() {
sed -i -e 's,sbindir = /sbin,sbindir = ${base_sbindir},g' \
--
2.37.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/7] apt: Do not use std::binary_function
2022-08-16 16:58 [PATCH 1/7] boost: Compile out stdlib unary/binary_functions for c++11 and newer Khem Raj
` (2 preceding siblings ...)
2022-08-16 16:58 ` [PATCH 4/7] nfs-utils: Upgrade to 2.6.2 Khem Raj
@ 2022-08-16 16:58 ` Khem Raj
2022-08-16 16:58 ` [PATCH 6/7] ltp: Fix sys/mount.h and linux/mount.h conflict Khem Raj
2022-08-16 16:58 ` [PATCH v2 7/7] spirv-tools: Update to 1.3.224.0 Khem Raj
5 siblings, 0 replies; 10+ messages in thread
From: Khem Raj @ 2022-08-16 16:58 UTC (permalink / raw)
To: openembedded-core; +Cc: Khem Raj
This feature is removed from c++17
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
...-init-tables-from-dpkg-configuration.patch | 4 +-
...001-Remove-using-std-binary_function.patch | 87 +++++++++++++++++++
...n-dpkg-configure-a-at-the-end-of-our.patch | 4 +-
meta/recipes-devtools/apt/apt_2.4.5.bb | 1 +
4 files changed, 92 insertions(+), 4 deletions(-)
create mode 100644 meta/recipes-devtools/apt/apt/0001-Remove-using-std-binary_function.patch
diff --git a/meta/recipes-devtools/apt/apt/0001-Do-not-init-tables-from-dpkg-configuration.patch b/meta/recipes-devtools/apt/apt/0001-Do-not-init-tables-from-dpkg-configuration.patch
index 59b9cd190f5..37a31330102 100644
--- a/meta/recipes-devtools/apt/apt/0001-Do-not-init-tables-from-dpkg-configuration.patch
+++ b/meta/recipes-devtools/apt/apt/0001-Do-not-init-tables-from-dpkg-configuration.patch
@@ -1,4 +1,4 @@
-From 11ba49594ae9d11f0070198c146b5e437fa83022 Mon Sep 17 00:00:00 2001
+From b84280fec4e1d0d33eca78e76556023f8f8fe5b7 Mon Sep 17 00:00:00 2001
From: Alexander Kanavin <alex.kanavin@gmail.com>
Date: Fri, 10 May 2019 16:47:38 +0200
Subject: [PATCH] Do not init tables from dpkg configuration
@@ -13,7 +13,7 @@ Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/apt-pkg/init.cc b/apt-pkg/init.cc
-index b9d9b15..1725c59 100644
+index b9d9b15d2..1725c5966 100644
--- a/apt-pkg/init.cc
+++ b/apt-pkg/init.cc
@@ -281,8 +281,8 @@ bool pkgInitSystem(Configuration &Cnf,pkgSystem *&Sys)
diff --git a/meta/recipes-devtools/apt/apt/0001-Remove-using-std-binary_function.patch b/meta/recipes-devtools/apt/apt/0001-Remove-using-std-binary_function.patch
new file mode 100644
index 00000000000..3065210a04b
--- /dev/null
+++ b/meta/recipes-devtools/apt/apt/0001-Remove-using-std-binary_function.patch
@@ -0,0 +1,87 @@
+From e91fb0618ce0a5d42f239d0fca602544858f0819 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Tue, 16 Aug 2022 08:44:18 -0700
+Subject: [PATCH] Remove using std::binary_function
+
+std::binary_function and std::unary_function are deprecated since c++11
+and removed in c++17, therefore remove it and use lambda functions to get same
+functionality implemented.
+
+Upstream-Status: Submitted [https://salsa.debian.org/apt-team/apt/-/merge_requests/253]
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ ftparchive/apt-ftparchive.cc | 33 ++++++++++-----------------------
+ 1 file changed, 10 insertions(+), 23 deletions(-)
+
+diff --git a/ftparchive/apt-ftparchive.cc b/ftparchive/apt-ftparchive.cc
+index 87ce9153c..56fdc2246 100644
+--- a/ftparchive/apt-ftparchive.cc
++++ b/ftparchive/apt-ftparchive.cc
+@@ -48,6 +48,11 @@
+ using namespace std;
+ unsigned Quiet = 0;
+
++auto ContentsCompare = [](const auto &a, const auto &b) { return a.ContentsMTime < b.ContentsMTime; };
++auto DBCompare = [](const auto &a, const auto &b) { return a.BinCacheDB < b.BinCacheDB; };
++auto SrcDBCompare = [](const auto &a, const auto &b) { return a.SrcCacheDB < b.SrcCacheDB; };
++
++
+ static struct timeval GetTimevalFromSteadyClock() /*{{{*/
+ {
+ auto const Time = std::chrono::steady_clock::now().time_since_epoch();
+@@ -116,24 +121,6 @@ struct PackageMap
+ bool SrcDone;
+ time_t ContentsMTime;
+
+- struct ContentsCompare : public binary_function<PackageMap,PackageMap,bool>
+- {
+- inline bool operator() (const PackageMap &x,const PackageMap &y)
+- {return x.ContentsMTime < y.ContentsMTime;};
+- };
+-
+- struct DBCompare : public binary_function<PackageMap,PackageMap,bool>
+- {
+- inline bool operator() (const PackageMap &x,const PackageMap &y)
+- {return x.BinCacheDB < y.BinCacheDB;};
+- };
+-
+- struct SrcDBCompare : public binary_function<PackageMap,PackageMap,bool>
+- {
+- inline bool operator() (const PackageMap &x,const PackageMap &y)
+- {return x.SrcCacheDB < y.SrcCacheDB;};
+- };
+-
+ void GetGeneral(Configuration &Setup,Configuration &Block);
+ bool GenPackages(Configuration &Setup,struct CacheDB::Stats &Stats);
+ bool GenSources(Configuration &Setup,struct CacheDB::Stats &Stats);
+@@ -869,7 +856,7 @@ static bool DoGenerateContents(Configuration &Setup,
+ else
+ I->ContentsMTime = A.st_mtime;
+ }
+- stable_sort(PkgList.begin(),PkgList.end(),PackageMap::ContentsCompare());
++ stable_sort(PkgList.begin(),PkgList.end(),ContentsCompare);
+
+ /* Now for Contents.. The process here is to do a make-like dependency
+ check. Each contents file is verified to be newer than the package files
+@@ -941,8 +928,8 @@ static bool Generate(CommandLine &CmdL)
+ LoadBinDir(PkgList,Setup);
+
+ // Sort by cache DB to improve IO locality.
+- stable_sort(PkgList.begin(),PkgList.end(),PackageMap::DBCompare());
+- stable_sort(PkgList.begin(),PkgList.end(),PackageMap::SrcDBCompare());
++ stable_sort(PkgList.begin(),PkgList.end(),DBCompare);
++ stable_sort(PkgList.begin(),PkgList.end(),SrcDBCompare);
+
+ // Generate packages
+ if (_config->FindB("APT::FTPArchive::ContentsOnly", false) == false)
+@@ -993,8 +980,8 @@ static bool Clean(CommandLine &CmdL)
+ LoadBinDir(PkgList,Setup);
+
+ // Sort by cache DB to improve IO locality.
+- stable_sort(PkgList.begin(),PkgList.end(),PackageMap::DBCompare());
+- stable_sort(PkgList.begin(),PkgList.end(),PackageMap::SrcDBCompare());
++ stable_sort(PkgList.begin(),PkgList.end(),DBCompare);
++ stable_sort(PkgList.begin(),PkgList.end(),SrcDBCompare);
+
+ string CacheDir = Setup.FindDir("Dir::CacheDir");
+
diff --git a/meta/recipes-devtools/apt/apt/0001-Revert-always-run-dpkg-configure-a-at-the-end-of-our.patch b/meta/recipes-devtools/apt/apt/0001-Revert-always-run-dpkg-configure-a-at-the-end-of-our.patch
index 593ed7d0968..6f4d5b6e729 100644
--- a/meta/recipes-devtools/apt/apt/0001-Revert-always-run-dpkg-configure-a-at-the-end-of-our.patch
+++ b/meta/recipes-devtools/apt/apt/0001-Revert-always-run-dpkg-configure-a-at-the-end-of-our.patch
@@ -1,4 +1,4 @@
-From 47c2b42af60ceefd8ed52b32a3a365facf0e05b8 Mon Sep 17 00:00:00 2001
+From a2dd661484536492b47d4c88998f2bf516749bc8 Mon Sep 17 00:00:00 2001
From: Alexander Kanavin <alex.kanavin@gmail.com>
Date: Thu, 21 May 2020 20:13:25 +0000
Subject: [PATCH] Revert "always run 'dpkg --configure -a' at the end of our
@@ -20,7 +20,7 @@ Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/apt-pkg/deb/dpkgpm.cc b/apt-pkg/deb/dpkgpm.cc
-index 93effa9..4375781 100644
+index 93effa959..4375781d1 100644
--- a/apt-pkg/deb/dpkgpm.cc
+++ b/apt-pkg/deb/dpkgpm.cc
@@ -1199,12 +1199,6 @@ void pkgDPkgPM::BuildPackagesProgressMap()
diff --git a/meta/recipes-devtools/apt/apt_2.4.5.bb b/meta/recipes-devtools/apt/apt_2.4.5.bb
index 53849f80a30..564bdeec410 100644
--- a/meta/recipes-devtools/apt/apt_2.4.5.bb
+++ b/meta/recipes-devtools/apt/apt_2.4.5.bb
@@ -13,6 +13,7 @@ SRC_URI = "${DEBIAN_MIRROR}/main/a/apt/${BPN}_${PV}.tar.xz \
file://0001-cmake-Do-not-build-po-files.patch \
file://0001-Hide-fstatat64-and-prlimit64-defines-on-musl.patch \
file://0001-aptwebserver.cc-Include-array.patch \
+ file://0001-Remove-using-std-binary_function.patch \
"
SRC_URI:append:class-native = " \
--
2.37.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 6/7] ltp: Fix sys/mount.h and linux/mount.h conflict
2022-08-16 16:58 [PATCH 1/7] boost: Compile out stdlib unary/binary_functions for c++11 and newer Khem Raj
` (3 preceding siblings ...)
2022-08-16 16:58 ` [PATCH 5/7] apt: Do not use std::binary_function Khem Raj
@ 2022-08-16 16:58 ` Khem Raj
2022-08-16 16:58 ` [PATCH v2 7/7] spirv-tools: Update to 1.3.224.0 Khem Raj
5 siblings, 0 replies; 10+ messages in thread
From: Khem Raj @ 2022-08-16 16:58 UTC (permalink / raw)
To: openembedded-core; +Cc: Khem Raj
backport needed patches
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
...ove-duplicate-include-of-sys-mount.h.patch | 30 --------
| 71 +++++++++++++++++++
| 60 ++++++++++++++++
meta/recipes-extended/ltp/ltp_20220527.bb | 3 +-
4 files changed, 133 insertions(+), 31 deletions(-)
delete mode 100644 meta/recipes-extended/ltp/ltp/0001-Remove-duplicate-include-of-sys-mount.h.patch
create mode 100644 meta/recipes-extended/ltp/ltp/0001-lapi-fsmount-resolve-conflict-in-different-header-fi.patch
create mode 100644 meta/recipes-extended/ltp/ltp/0001-lapi-pidfd-adding-pidfd-header-file.patch
diff --git a/meta/recipes-extended/ltp/ltp/0001-Remove-duplicate-include-of-sys-mount.h.patch b/meta/recipes-extended/ltp/ltp/0001-Remove-duplicate-include-of-sys-mount.h.patch
deleted file mode 100644
index fc7fea02f9b..00000000000
--- a/meta/recipes-extended/ltp/ltp/0001-Remove-duplicate-include-of-sys-mount.h.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-From 463f3f85e326253feb35015a022ab6d1e03fe1d5 Mon Sep 17 00:00:00 2001
-From: Khem Raj <raj.khem@gmail.com>
-Date: Sat, 6 Aug 2022 20:50:27 -0700
-Subject: [PATCH] Remove duplicate include of <sys/mount.h>
-
-<sys/mount.h> is already included by lapi/mount.h.
-
-This fixes build with glibc 2.36+
-
-Upstream-Status: Submitted [https://github.com/linux-test-project/ltp/pull/953]
-Signed-off-by: Khem Raj <raj.khem@gmail.com>
----
- testcases/kernel/syscalls/statx/statx09.c | 1 -
- 1 file changed, 1 deletion(-)
-
-diff --git a/testcases/kernel/syscalls/statx/statx09.c b/testcases/kernel/syscalls/statx/statx09.c
-index aea329e086..34c5f41f87 100644
---- a/testcases/kernel/syscalls/statx/statx09.c
-+++ b/testcases/kernel/syscalls/statx/statx09.c
-@@ -18,7 +18,6 @@
- */
-
- #define _GNU_SOURCE
--#include <sys/mount.h>
- #include <stdlib.h>
- #include "tst_test.h"
- #include "lapi/fs.h"
---
-2.37.1
-
--git a/meta/recipes-extended/ltp/ltp/0001-lapi-fsmount-resolve-conflict-in-different-header-fi.patch b/meta/recipes-extended/ltp/ltp/0001-lapi-fsmount-resolve-conflict-in-different-header-fi.patch
new file mode 100644
index 00000000000..cdbcf6b2888
--- /dev/null
+++ b/meta/recipes-extended/ltp/ltp/0001-lapi-fsmount-resolve-conflict-in-different-header-fi.patch
@@ -0,0 +1,71 @@
+From b857f8723f30a4b9554bf6b0ff8fa52fd07e8b60 Mon Sep 17 00:00:00 2001
+From: Li Wang <liwang@redhat.com>
+Date: Fri, 5 Aug 2022 14:34:01 +0800
+Subject: [PATCH] lapi/fsmount: resolve conflict in different header files
+
+The latest glibc added new wrappers (e.g. mount_setattr, fsopen) support
+in sys/mount.h, which partly conflicts with linux/mount.h at the same time.
+
+We need to make adjustments to header files to fix compiling error on
+different platforms.
+
+Upstream-Status: Backport [https://github.com/linux-test-project/ltp/commit/b857f8723f30a4b9554bf6b0ff8fa52fd07e8b60]
+Signed-off-by: Li Wang <liwang@redhat.com>
+Reviewed-by: Petr Vorel <pvorel@suse.cz>
+---
+ configure.ac | 1 +
+ include/lapi/fs.h | 6 ++++--
+ include/lapi/fsmount.h | 7 +++++--
+ 3 files changed, 10 insertions(+), 4 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index d50ec1ea7..dbd53cab6 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -113,6 +113,7 @@ AC_CHECK_FUNCS_ONCE([ \
+ mkdirat \
+ mknodat \
+ modify_ldt \
++ mount_setattr \
+ move_mount \
+ name_to_handle_at \
+ open_tree \
+diff --git a/include/lapi/fs.h b/include/lapi/fs.h
+index 27b3a183c..84a168a67 100644
+--- a/include/lapi/fs.h
++++ b/include/lapi/fs.h
+@@ -6,8 +6,10 @@
+ * Email: code@zilogic.com
+ */
+
+-#ifdef HAVE_LINUX_FS_H
+-# include <linux/fs.h>
++#ifndef HAVE_MOUNT_SETATTR
++# ifdef HAVE_LINUX_FS_H
++# include <linux/fs.h>
++# endif
+ #endif
+
+ #include <sys/user.h>
+diff --git a/include/lapi/fsmount.h b/include/lapi/fsmount.h
+index b11e7a7bd..07eb42ffa 100644
+--- a/include/lapi/fsmount.h
++++ b/include/lapi/fsmount.h
+@@ -11,9 +11,12 @@
+ #include "config.h"
+ #include <sys/syscall.h>
+ #include <sys/types.h>
++#include <sys/mount.h>
+
+-#ifdef HAVE_LINUX_MOUNT_H
+-# include <linux/mount.h>
++#ifndef HAVE_FSOPEN
++# ifdef HAVE_LINUX_MOUNT_H
++# include <linux/mount.h>
++# endif
+ #endif
+
+ #include "lapi/fcntl.h"
+--
+2.37.2
+
--git a/meta/recipes-extended/ltp/ltp/0001-lapi-pidfd-adding-pidfd-header-file.patch b/meta/recipes-extended/ltp/ltp/0001-lapi-pidfd-adding-pidfd-header-file.patch
new file mode 100644
index 00000000000..184c42640ae
--- /dev/null
+++ b/meta/recipes-extended/ltp/ltp/0001-lapi-pidfd-adding-pidfd-header-file.patch
@@ -0,0 +1,60 @@
+From dbc9c14c92a5acf450d07868a735ac8cd6ec5b90 Mon Sep 17 00:00:00 2001
+From: Li Wang <liwang@redhat.com>
+Date: Fri, 5 Aug 2022 14:34:00 +0800
+Subject: [PATCH] lapi/pidfd: adding pidfd header file
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+The newer Glibc already provided wrapper for the series pidfd syscall,
+so let's include the header file conditionally.
+
+ # rpm -q glibc-devel
+ glibc-devel-2.35.9000-31.fc37.ppc64le
+ # rpm -ql glibc-devel | grep pidfd
+ /usr/include/sys/pidfd.h
+
+To get rid of compiling error from fedora-rawhide:
+
+ tst_safe_macros.c: In function ‘safe_pidfd_open’:
+ tst_safe_macros.c:135:16: error: implicit declaration of function ‘pidfd_open’ [-Werror=implicit-function-declaration]
+ 135 | rval = pidfd_open(pid, flags);
+ | ^~~~~~~~~~
+
+Upstream-Status: Backport [https://github.com/linux-test-project/ltp/commit/dbc9c14c92a5acf450d07868a735ac8cd6ec5b90]
+Signed-off-by: Li Wang <liwang@redhat.com>
+Reviewed-by: Petr Vorel <pvorel@suse.cz>
+---
+ configure.ac | 1 +
+ include/lapi/pidfd.h | 3 +++
+ 2 files changed, 4 insertions(+)
+
+diff --git a/configure.ac b/configure.ac
+index 69b145b5f..d50ec1ea7 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -71,6 +71,7 @@ AC_CHECK_HEADERS_ONCE([ \
+ sys/epoll.h \
+ sys/fanotify.h \
+ sys/inotify.h \
++ sys/pidfd.h
+ sys/prctl.h \
+ sys/shm.h \
+ sys/timerfd.h \
+diff --git a/include/lapi/pidfd.h b/include/lapi/pidfd.h
+index 244d3acaf..9ca8e5aa2 100644
+--- a/include/lapi/pidfd.h
++++ b/include/lapi/pidfd.h
+@@ -8,6 +8,9 @@
+ #define LAPI_PIDFD_H__
+
+ #include <fcntl.h>
++#ifdef HAVE_SYS_PIDFD_H
++# include <sys/pidfd.h>
++#endif
+ #include "config.h"
+ #include "lapi/syscalls.h"
+
+--
+2.37.2
+
diff --git a/meta/recipes-extended/ltp/ltp_20220527.bb b/meta/recipes-extended/ltp/ltp_20220527.bb
index 6d812958cdd..a547298828b 100644
--- a/meta/recipes-extended/ltp/ltp_20220527.bb
+++ b/meta/recipes-extended/ltp/ltp_20220527.bb
@@ -37,7 +37,8 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git;branch=master;protocol=ht
file://0001-netstress-Restore-runtime-to-5m.patch \
file://0001-net_stress-Fix-usage-of-variables-from-tst_net.sh.patch \
file://0001-memcg-functional-Fix-usage-of-PAGESIZE-from-memcg_li.patch \
- file://0001-Remove-duplicate-include-of-sys-mount.h.patch \
+ file://0001-lapi-pidfd-adding-pidfd-header-file.patch \
+ file://0001-lapi-fsmount-resolve-conflict-in-different-header-fi.patch \
"
S = "${WORKDIR}/git"
--
2.37.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 7/7] spirv-tools: Update to 1.3.224.0
2022-08-16 16:58 [PATCH 1/7] boost: Compile out stdlib unary/binary_functions for c++11 and newer Khem Raj
` (4 preceding siblings ...)
2022-08-16 16:58 ` [PATCH 6/7] ltp: Fix sys/mount.h and linux/mount.h conflict Khem Raj
@ 2022-08-16 16:58 ` Khem Raj
2022-08-16 17:03 ` [OE-core] " Alexander Kanavin
5 siblings, 1 reply; 10+ messages in thread
From: Khem Raj @ 2022-08-16 16:58 UTC (permalink / raw)
To: openembedded-core; +Cc: Khem Raj
Fixes build with clang
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
v2: Drop uprev of vulkan-headers recipe, there was no change
.../spir/{spirv-tools_1.3.216.0.bb => spirv-tools_1.3.224.0.bb} | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
rename meta/recipes-graphics/spir/{spirv-tools_1.3.216.0.bb => spirv-tools_1.3.224.0.bb} (96%)
diff --git a/meta/recipes-graphics/spir/spirv-tools_1.3.216.0.bb b/meta/recipes-graphics/spir/spirv-tools_1.3.224.0.bb
similarity index 96%
rename from meta/recipes-graphics/spir/spirv-tools_1.3.216.0.bb
rename to meta/recipes-graphics/spir/spirv-tools_1.3.224.0.bb
index eb907326c43..cfea28a6efe 100644
--- a/meta/recipes-graphics/spir/spirv-tools_1.3.216.0.bb
+++ b/meta/recipes-graphics/spir/spirv-tools_1.3.224.0.bb
@@ -7,7 +7,7 @@ SECTION = "graphics"
LICENSE = "Apache-2.0"
LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
-SRCREV = "c94501352d545e84c821ce031399e76d1af32d18"
+SRCREV = "5e61ea2098220059e89523f1f47b0bcd8c33b89a"
SRC_URI = "git://github.com/KhronosGroup/SPIRV-Tools.git;branch=master;protocol=https"
PE = "1"
UPSTREAM_CHECK_GITTAGREGEX = "sdk-(?P<pver>\d+(\.\d+)+)"
--
2.37.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [OE-core] [PATCH v2 7/7] spirv-tools: Update to 1.3.224.0
2022-08-16 16:58 ` [PATCH v2 7/7] spirv-tools: Update to 1.3.224.0 Khem Raj
@ 2022-08-16 17:03 ` Alexander Kanavin
2022-08-16 17:29 ` Khem Raj
0 siblings, 1 reply; 10+ messages in thread
From: Alexander Kanavin @ 2022-08-16 17:03 UTC (permalink / raw)
To: Khem Raj; +Cc: OE-core
On Tue, 16 Aug 2022 at 18:59, Khem Raj <raj.khem@gmail.com> wrote:
> -SRCREV = "c94501352d545e84c821ce031399e76d1af32d18"
> +SRCREV = "5e61ea2098220059e89523f1f47b0bcd8c33b89a"
Sorry but this does not address my previous feedback. There is no
1.3.224 version released so this is effectively a random development
snapshot, and vulkan items need to be all upgraded in lockstep to the
same version. If you need a clang fix, please backport it.
Alex
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [OE-core] [PATCH v2 7/7] spirv-tools: Update to 1.3.224.0
2022-08-16 17:03 ` [OE-core] " Alexander Kanavin
@ 2022-08-16 17:29 ` Khem Raj
2022-08-16 17:46 ` Alexander Kanavin
0 siblings, 1 reply; 10+ messages in thread
From: Khem Raj @ 2022-08-16 17:29 UTC (permalink / raw)
To: Alexander Kanavin; +Cc: OE-core
On Tue, Aug 16, 2022 at 10:03 AM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> On Tue, 16 Aug 2022 at 18:59, Khem Raj <raj.khem@gmail.com> wrote:
> > -SRCREV = "c94501352d545e84c821ce031399e76d1af32d18"
> > +SRCREV = "5e61ea2098220059e89523f1f47b0bcd8c33b89a"
>
> Sorry but this does not address my previous feedback. There is no
> 1.3.224 version released so this is effectively a random development
> snapshot, and vulkan items need to be all upgraded in lockstep to the
> same version. If you need a clang fix, please backport it.
>
lets drop it. I will send a targetted backport of a fix I need.
> Alex
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [OE-core] [PATCH v2 7/7] spirv-tools: Update to 1.3.224.0
2022-08-16 17:29 ` Khem Raj
@ 2022-08-16 17:46 ` Alexander Kanavin
0 siblings, 0 replies; 10+ messages in thread
From: Alexander Kanavin @ 2022-08-16 17:46 UTC (permalink / raw)
To: Khem Raj; +Cc: OE-core
Thanks!
Alex
On Tue, 16 Aug 2022 at 19:30, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Tue, Aug 16, 2022 at 10:03 AM Alexander Kanavin
> <alex.kanavin@gmail.com> wrote:
> >
> > On Tue, 16 Aug 2022 at 18:59, Khem Raj <raj.khem@gmail.com> wrote:
> > > -SRCREV = "c94501352d545e84c821ce031399e76d1af32d18"
> > > +SRCREV = "5e61ea2098220059e89523f1f47b0bcd8c33b89a"
> >
> > Sorry but this does not address my previous feedback. There is no
> > 1.3.224 version released so this is effectively a random development
> > snapshot, and vulkan items need to be all upgraded in lockstep to the
> > same version. If you need a clang fix, please backport it.
> >
>
> lets drop it. I will send a targetted backport of a fix I need.
>
> > Alex
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-08-16 17:47 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-16 16:58 [PATCH 1/7] boost: Compile out stdlib unary/binary_functions for c++11 and newer Khem Raj
2022-08-16 16:58 ` [PATCH 2/7] vulkan-samples: Qualify move as std::move Khem Raj
2022-08-16 16:58 ` [PATCH 3/7] rpm: Remove -Wimplicit-function-declaration warnings Khem Raj
2022-08-16 16:58 ` [PATCH 4/7] nfs-utils: Upgrade to 2.6.2 Khem Raj
2022-08-16 16:58 ` [PATCH 5/7] apt: Do not use std::binary_function Khem Raj
2022-08-16 16:58 ` [PATCH 6/7] ltp: Fix sys/mount.h and linux/mount.h conflict Khem Raj
2022-08-16 16:58 ` [PATCH v2 7/7] spirv-tools: Update to 1.3.224.0 Khem Raj
2022-08-16 17:03 ` [OE-core] " Alexander Kanavin
2022-08-16 17:29 ` Khem Raj
2022-08-16 17:46 ` Alexander Kanavin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.