* [PATCH] cachefiles: make on-demand request distribution fairer
@ 2022-08-17 6:52 Xin Yin
2022-08-17 7:14 ` [Linux-cachefs] " Gao Xiang
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Xin Yin @ 2022-08-17 6:52 UTC (permalink / raw)
To: dhowells, xiang, jefflexu
Cc: linux-cachefs, linux-fsdevel, zhujia.zj, Xin Yin, Yongqing Li
For now, enqueuing and dequeuing on-demand requests all start from
idx 0, this makes request distribution unfair. In the weighty
concurrent I/O scenario, the request stored in higher idx will starve.
Searching requests cyclically in cachefiles_ondemand_daemon_read,
makes distribution fairer.
Reported-by: Yongqing Li <liyongqing@bytedance.com>
Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
---
fs/cachefiles/internal.h | 1 +
fs/cachefiles/ondemand.c | 12 +++++++++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h
index 6cba2c6de2f9..2ad58c465208 100644
--- a/fs/cachefiles/internal.h
+++ b/fs/cachefiles/internal.h
@@ -111,6 +111,7 @@ struct cachefiles_cache {
char *tag; /* cache binding tag */
refcount_t unbind_pincount;/* refcount to do daemon unbind */
struct xarray reqs; /* xarray of pending on-demand requests */
+ unsigned long req_id_next;
struct xarray ondemand_ids; /* xarray for ondemand_id allocation */
u32 ondemand_id_next;
};
diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c
index 1fee702d5529..247961d65369 100644
--- a/fs/cachefiles/ondemand.c
+++ b/fs/cachefiles/ondemand.c
@@ -238,14 +238,19 @@ ssize_t cachefiles_ondemand_daemon_read(struct cachefiles_cache *cache,
unsigned long id = 0;
size_t n;
int ret = 0;
- XA_STATE(xas, &cache->reqs, 0);
+ XA_STATE(xas, &cache->reqs, cache->req_id_next);
/*
- * Search for a request that has not ever been processed, to prevent
- * requests from being processed repeatedly.
+ * Cyclically search for a request that has not ever been processed,
+ * to prevent requests from being processed repeatedly, and make
+ * request distribution fair.
*/
xa_lock(&cache->reqs);
req = xas_find_marked(&xas, UINT_MAX, CACHEFILES_REQ_NEW);
+ if (!req && cache->req_id_next > 0) {
+ xas_set(&xas, 0);
+ req = xas_find_marked(&xas, cache->req_id_next - 1, CACHEFILES_REQ_NEW);
+ }
if (!req) {
xa_unlock(&cache->reqs);
return 0;
@@ -260,6 +265,7 @@ ssize_t cachefiles_ondemand_daemon_read(struct cachefiles_cache *cache,
}
xas_clear_mark(&xas, CACHEFILES_REQ_NEW);
+ cache->req_id_next = xas.xa_index + 1;
xa_unlock(&cache->reqs);
id = xas.xa_index;
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Linux-cachefs] [PATCH] cachefiles: make on-demand request distribution fairer
2022-08-17 6:52 [PATCH] cachefiles: make on-demand request distribution fairer Xin Yin
@ 2022-08-17 7:14 ` Gao Xiang
2022-08-17 9:16 ` [External] " Xin Yin
2022-08-17 12:15 ` JeffleXu
2022-08-24 10:25 ` David Howells
2 siblings, 1 reply; 11+ messages in thread
From: Gao Xiang @ 2022-08-17 7:14 UTC (permalink / raw)
To: Xin Yin
Cc: dhowells, xiang, jefflexu, linux-fsdevel, zhujia.zj,
linux-cachefs, Yongqing Li
Hi Yin,
On Wed, Aug 17, 2022 at 02:52:00PM +0800, Xin Yin wrote:
> For now, enqueuing and dequeuing on-demand requests all start from
> idx 0, this makes request distribution unfair. In the weighty
> concurrent I/O scenario, the request stored in higher idx will starve.
>
> Searching requests cyclically in cachefiles_ondemand_daemon_read,
> makes distribution fairer.
Yeah, thanks for the catch. The previous approach could cause somewhat
unfairness and make some requests starving... But we don't need strict
FIFO here.
>
> Reported-by: Yongqing Li <liyongqing@bytedance.com>
> Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
> ---
> fs/cachefiles/internal.h | 1 +
> fs/cachefiles/ondemand.c | 12 +++++++++---
> 2 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h
> index 6cba2c6de2f9..2ad58c465208 100644
> --- a/fs/cachefiles/internal.h
> +++ b/fs/cachefiles/internal.h
> @@ -111,6 +111,7 @@ struct cachefiles_cache {
> char *tag; /* cache binding tag */
> refcount_t unbind_pincount;/* refcount to do daemon unbind */
> struct xarray reqs; /* xarray of pending on-demand requests */
> + unsigned long req_id_next;
unsigned long ondemand_req_id_next; ?
Otherwise it looks good to me,
Thanks,
Gao Xiang
> struct xarray ondemand_ids; /* xarray for ondemand_id allocation */
> u32 ondemand_id_next;
> };
> diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c
> index 1fee702d5529..247961d65369 100644
> --- a/fs/cachefiles/ondemand.c
> +++ b/fs/cachefiles/ondemand.c
> @@ -238,14 +238,19 @@ ssize_t cachefiles_ondemand_daemon_read(struct cachefiles_cache *cache,
> unsigned long id = 0;
> size_t n;
> int ret = 0;
> - XA_STATE(xas, &cache->reqs, 0);
> + XA_STATE(xas, &cache->reqs, cache->req_id_next);
>
> /*
> - * Search for a request that has not ever been processed, to prevent
> - * requests from being processed repeatedly.
> + * Cyclically search for a request that has not ever been processed,
> + * to prevent requests from being processed repeatedly, and make
> + * request distribution fair.
> */
> xa_lock(&cache->reqs);
> req = xas_find_marked(&xas, UINT_MAX, CACHEFILES_REQ_NEW);
> + if (!req && cache->req_id_next > 0) {
> + xas_set(&xas, 0);
> + req = xas_find_marked(&xas, cache->req_id_next - 1, CACHEFILES_REQ_NEW);
> + }
> if (!req) {
> xa_unlock(&cache->reqs);
> return 0;
> @@ -260,6 +265,7 @@ ssize_t cachefiles_ondemand_daemon_read(struct cachefiles_cache *cache,
> }
>
> xas_clear_mark(&xas, CACHEFILES_REQ_NEW);
> + cache->req_id_next = xas.xa_index + 1;
> xa_unlock(&cache->reqs);
>
> id = xas.xa_index;
> --
> 2.25.1
>
> --
> Linux-cachefs mailing list
> Linux-cachefs@redhat.com
> https://listman.redhat.com/mailman/listinfo/linux-cachefs
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [External] Re: [Linux-cachefs] [PATCH] cachefiles: make on-demand request distribution fairer
2022-08-17 7:14 ` [Linux-cachefs] " Gao Xiang
@ 2022-08-17 9:16 ` Xin Yin
2022-08-17 9:34 ` [Linux-cachefs] [External] " Gao Xiang
2022-08-24 10:24 ` David Howells
0 siblings, 2 replies; 11+ messages in thread
From: Xin Yin @ 2022-08-17 9:16 UTC (permalink / raw)
To: Xin Yin, dhowells, xiang, jefflexu, linux-fsdevel, zhujia.zj,
linux-cachefs, Yongqing Li
On Wed, Aug 17, 2022 at 3:14 PM Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
>
> Hi Yin,
>
> On Wed, Aug 17, 2022 at 02:52:00PM +0800, Xin Yin wrote:
> > For now, enqueuing and dequeuing on-demand requests all start from
> > idx 0, this makes request distribution unfair. In the weighty
> > concurrent I/O scenario, the request stored in higher idx will starve.
> >
> > Searching requests cyclically in cachefiles_ondemand_daemon_read,
> > makes distribution fairer.
>
> Yeah, thanks for the catch. The previous approach could cause somewhat
> unfairness and make some requests starving... But we don't need strict
> FIFO here.
>
> >
> > Reported-by: Yongqing Li <liyongqing@bytedance.com>
> > Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
> > ---
> > fs/cachefiles/internal.h | 1 +
> > fs/cachefiles/ondemand.c | 12 +++++++++---
> > 2 files changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h
> > index 6cba2c6de2f9..2ad58c465208 100644
> > --- a/fs/cachefiles/internal.h
> > +++ b/fs/cachefiles/internal.h
> > @@ -111,6 +111,7 @@ struct cachefiles_cache {
> > char *tag; /* cache binding tag */
> > refcount_t unbind_pincount;/* refcount to do daemon unbind */
> > struct xarray reqs; /* xarray of pending on-demand requests */
> > + unsigned long req_id_next;
>
> unsigned long ondemand_req_id_next; ?
Hi Xiang,
Thanks for the detailed review , whether "ondemand_req_id_next" is a
little long ? struct cachefiles_cache only holds on-demand requests ,
so I think "req_id_next" will not cause ambiguity. Does this make
sense?
Thanks,
Xin Yin
>
> Otherwise it looks good to me,
>
> Thanks,
> Gao Xiang
>
> > struct xarray ondemand_ids; /* xarray for ondemand_id allocation */
> > u32 ondemand_id_next;
> > };
> > diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c
> > index 1fee702d5529..247961d65369 100644
> > --- a/fs/cachefiles/ondemand.c
> > +++ b/fs/cachefiles/ondemand.c
> > @@ -238,14 +238,19 @@ ssize_t cachefiles_ondemand_daemon_read(struct cachefiles_cache *cache,
> > unsigned long id = 0;
> > size_t n;
> > int ret = 0;
> > - XA_STATE(xas, &cache->reqs, 0);
> > + XA_STATE(xas, &cache->reqs, cache->req_id_next);
> >
> > /*
> > - * Search for a request that has not ever been processed, to prevent
> > - * requests from being processed repeatedly.
> > + * Cyclically search for a request that has not ever been processed,
> > + * to prevent requests from being processed repeatedly, and make
> > + * request distribution fair.
> > */
> > xa_lock(&cache->reqs);
> > req = xas_find_marked(&xas, UINT_MAX, CACHEFILES_REQ_NEW);
> > + if (!req && cache->req_id_next > 0) {
> > + xas_set(&xas, 0);
> > + req = xas_find_marked(&xas, cache->req_id_next - 1, CACHEFILES_REQ_NEW);
> > + }
> > if (!req) {
> > xa_unlock(&cache->reqs);
> > return 0;
> > @@ -260,6 +265,7 @@ ssize_t cachefiles_ondemand_daemon_read(struct cachefiles_cache *cache,
> > }
> >
> > xas_clear_mark(&xas, CACHEFILES_REQ_NEW);
> > + cache->req_id_next = xas.xa_index + 1;
> > xa_unlock(&cache->reqs);
> >
> > id = xas.xa_index;
> > --
> > 2.25.1
> >
> > --
> > Linux-cachefs mailing list
> > Linux-cachefs@redhat.com
> > https://listman.redhat.com/mailman/listinfo/linux-cachefs
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Linux-cachefs] [External] Re: [PATCH] cachefiles: make on-demand request distribution fairer
2022-08-17 9:16 ` [External] " Xin Yin
@ 2022-08-17 9:34 ` Gao Xiang
2022-08-24 10:24 ` David Howells
1 sibling, 0 replies; 11+ messages in thread
From: Gao Xiang @ 2022-08-17 9:34 UTC (permalink / raw)
To: Xin Yin
Cc: dhowells, xiang, jefflexu, linux-fsdevel, zhujia.zj,
linux-cachefs, Yongqing Li
On Wed, Aug 17, 2022 at 05:16:25PM +0800, Xin Yin wrote:
> On Wed, Aug 17, 2022 at 3:14 PM Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> >
> > Hi Yin,
> >
> > On Wed, Aug 17, 2022 at 02:52:00PM +0800, Xin Yin wrote:
> > > For now, enqueuing and dequeuing on-demand requests all start from
> > > idx 0, this makes request distribution unfair. In the weighty
> > > concurrent I/O scenario, the request stored in higher idx will starve.
> > >
> > > Searching requests cyclically in cachefiles_ondemand_daemon_read,
> > > makes distribution fairer.
> >
> > Yeah, thanks for the catch. The previous approach could cause somewhat
> > unfairness and make some requests starving... But we don't need strict
> > FIFO here.
> >
> > >
> > > Reported-by: Yongqing Li <liyongqing@bytedance.com>
> > > Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
> > > ---
> > > fs/cachefiles/internal.h | 1 +
> > > fs/cachefiles/ondemand.c | 12 +++++++++---
> > > 2 files changed, 10 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h
> > > index 6cba2c6de2f9..2ad58c465208 100644
> > > --- a/fs/cachefiles/internal.h
> > > +++ b/fs/cachefiles/internal.h
> > > @@ -111,6 +111,7 @@ struct cachefiles_cache {
> > > char *tag; /* cache binding tag */
> > > refcount_t unbind_pincount;/* refcount to do daemon unbind */
> > > struct xarray reqs; /* xarray of pending on-demand requests */
> > > + unsigned long req_id_next;
> >
> > unsigned long ondemand_req_id_next; ?
> Hi Xiang,
>
> Thanks for the detailed review , whether "ondemand_req_id_next" is a
> little long ? struct cachefiles_cache only holds on-demand requests ,
> so I think "req_id_next" will not cause ambiguity. Does this make
> sense?
If David is fine with "req_id_next", I'm okay with that as well.
Thanks,
Gao Xiang
>
> Thanks,
> Xin Yin
> >
> > Otherwise it looks good to me,
> >
> > Thanks,
> > Gao Xiang
> >
> > > struct xarray ondemand_ids; /* xarray for ondemand_id allocation */
> > > u32 ondemand_id_next;
> > > };
> > > diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c
> > > index 1fee702d5529..247961d65369 100644
> > > --- a/fs/cachefiles/ondemand.c
> > > +++ b/fs/cachefiles/ondemand.c
> > > @@ -238,14 +238,19 @@ ssize_t cachefiles_ondemand_daemon_read(struct cachefiles_cache *cache,
> > > unsigned long id = 0;
> > > size_t n;
> > > int ret = 0;
> > > - XA_STATE(xas, &cache->reqs, 0);
> > > + XA_STATE(xas, &cache->reqs, cache->req_id_next);
> > >
> > > /*
> > > - * Search for a request that has not ever been processed, to prevent
> > > - * requests from being processed repeatedly.
> > > + * Cyclically search for a request that has not ever been processed,
> > > + * to prevent requests from being processed repeatedly, and make
> > > + * request distribution fair.
> > > */
> > > xa_lock(&cache->reqs);
> > > req = xas_find_marked(&xas, UINT_MAX, CACHEFILES_REQ_NEW);
> > > + if (!req && cache->req_id_next > 0) {
> > > + xas_set(&xas, 0);
> > > + req = xas_find_marked(&xas, cache->req_id_next - 1, CACHEFILES_REQ_NEW);
> > > + }
> > > if (!req) {
> > > xa_unlock(&cache->reqs);
> > > return 0;
> > > @@ -260,6 +265,7 @@ ssize_t cachefiles_ondemand_daemon_read(struct cachefiles_cache *cache,
> > > }
> > >
> > > xas_clear_mark(&xas, CACHEFILES_REQ_NEW);
> > > + cache->req_id_next = xas.xa_index + 1;
> > > xa_unlock(&cache->reqs);
> > >
> > > id = xas.xa_index;
> > > --
> > > 2.25.1
> > >
> > > --
> > > Linux-cachefs mailing list
> > > Linux-cachefs@redhat.com
> > > https://listman.redhat.com/mailman/listinfo/linux-cachefs
>
> --
> Linux-cachefs mailing list
> Linux-cachefs@redhat.com
> https://listman.redhat.com/mailman/listinfo/linux-cachefs
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] cachefiles: make on-demand request distribution fairer
2022-08-17 6:52 [PATCH] cachefiles: make on-demand request distribution fairer Xin Yin
2022-08-17 7:14 ` [Linux-cachefs] " Gao Xiang
@ 2022-08-17 12:15 ` JeffleXu
2022-08-24 10:25 ` David Howells
2 siblings, 0 replies; 11+ messages in thread
From: JeffleXu @ 2022-08-17 12:15 UTC (permalink / raw)
To: Xin Yin, dhowells, xiang
Cc: linux-cachefs, linux-fsdevel, zhujia.zj, Yongqing Li
On 8/17/22 2:52 PM, Xin Yin wrote:
> For now, enqueuing and dequeuing on-demand requests all start from
> idx 0, this makes request distribution unfair. In the weighty
> concurrent I/O scenario, the request stored in higher idx will starve.
>
> Searching requests cyclically in cachefiles_ondemand_daemon_read,
> makes distribution fairer.
>
> Reported-by: Yongqing Li <liyongqing@bytedance.com>
> Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
> ---
> fs/cachefiles/internal.h | 1 +
> fs/cachefiles/ondemand.c | 12 +++++++++---
> 2 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h
> index 6cba2c6de2f9..2ad58c465208 100644
> --- a/fs/cachefiles/internal.h
> +++ b/fs/cachefiles/internal.h
> @@ -111,6 +111,7 @@ struct cachefiles_cache {
> char *tag; /* cache binding tag */
> refcount_t unbind_pincount;/* refcount to do daemon unbind */
> struct xarray reqs; /* xarray of pending on-demand requests */
> + unsigned long req_id_next;
> struct xarray ondemand_ids; /* xarray for ondemand_id allocation */
> u32 ondemand_id_next;
> };
> diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c
> index 1fee702d5529..247961d65369 100644
> --- a/fs/cachefiles/ondemand.c
> +++ b/fs/cachefiles/ondemand.c
> @@ -238,14 +238,19 @@ ssize_t cachefiles_ondemand_daemon_read(struct cachefiles_cache *cache,
> unsigned long id = 0;
> size_t n;
> int ret = 0;
> - XA_STATE(xas, &cache->reqs, 0);
> + XA_STATE(xas, &cache->reqs, cache->req_id_next);
>
> /*
> - * Search for a request that has not ever been processed, to prevent
> - * requests from being processed repeatedly.
> + * Cyclically search for a request that has not ever been processed,
> + * to prevent requests from being processed repeatedly, and make
> + * request distribution fair.
> */
> xa_lock(&cache->reqs);
> req = xas_find_marked(&xas, UINT_MAX, CACHEFILES_REQ_NEW);
> + if (!req && cache->req_id_next > 0) {
> + xas_set(&xas, 0);> + req = xas_find_marked(&xas, cache->req_id_next - 1,
CACHEFILES_REQ_NEW);
LGTM.
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
> + }
> if (!req) {
> xa_unlock(&cache->reqs);
> return 0;
> @@ -260,6 +265,7 @@ ssize_t cachefiles_ondemand_daemon_read(struct cachefiles_cache *cache,
> }
>
> xas_clear_mark(&xas, CACHEFILES_REQ_NEW);
> + cache->req_id_next = xas.xa_index + 1;
> xa_unlock(&cache->reqs);
>
> id = xas.xa_index;
--
Thanks,
Jingbo
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Linux-cachefs] [External] Re: [PATCH] cachefiles: make on-demand request distribution fairer
2022-08-17 9:16 ` [External] " Xin Yin
2022-08-17 9:34 ` [Linux-cachefs] [External] " Gao Xiang
@ 2022-08-24 10:24 ` David Howells
2022-08-24 11:00 ` Gao Xiang
1 sibling, 1 reply; 11+ messages in thread
From: David Howells @ 2022-08-24 10:24 UTC (permalink / raw)
To: Gao Xiang
Cc: dhowells, Xin Yin, xiang, jefflexu, linux-fsdevel, zhujia.zj,
linux-cachefs, Yongqing Li
Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> If David is fine with "req_id_next", I'm okay with that as well.
I can live with it.
Did you want to give me an R-b line?
David
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] cachefiles: make on-demand request distribution fairer
2022-08-17 6:52 [PATCH] cachefiles: make on-demand request distribution fairer Xin Yin
2022-08-17 7:14 ` [Linux-cachefs] " Gao Xiang
2022-08-17 12:15 ` JeffleXu
@ 2022-08-24 10:25 ` David Howells
2022-08-25 1:36 ` [External] " Xin Yin
2022-08-25 14:34 ` David Howells
2 siblings, 2 replies; 11+ messages in thread
From: David Howells @ 2022-08-24 10:25 UTC (permalink / raw)
To: Xin Yin
Cc: dhowells, xiang, jefflexu, linux-cachefs, linux-fsdevel,
zhujia.zj, Yongqing Li
Xin Yin <yinxin.x@bytedance.com> wrote:
> Reported-by: Yongqing Li <liyongqing@bytedance.com>
> Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
Can you give me a Fixes: line please?
David
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Linux-cachefs] [External] Re: [PATCH] cachefiles: make on-demand request distribution fairer
2022-08-24 10:24 ` David Howells
@ 2022-08-24 11:00 ` Gao Xiang
0 siblings, 0 replies; 11+ messages in thread
From: Gao Xiang @ 2022-08-24 11:00 UTC (permalink / raw)
To: David Howells
Cc: Xin Yin, xiang, jefflexu, linux-fsdevel, zhujia.zj,
linux-cachefs, Yongqing Li
Hi David,
On Wed, Aug 24, 2022 at 11:24:29AM +0100, David Howells wrote:
> Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
>
> > If David is fine with "req_id_next", I'm okay with that as well.
>
> I can live with it.
>
> Did you want to give me an R-b line?
Yeah, thanks, much appreciated! As far as I know, such unfairness can
cause starvation in Bytedance's test environment, it would be better
to fix it as above.
Thanks,
Gao Xiang
>
> David
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [External] Re: [PATCH] cachefiles: make on-demand request distribution fairer
2022-08-24 10:25 ` David Howells
@ 2022-08-25 1:36 ` Xin Yin
2022-08-25 14:34 ` David Howells
1 sibling, 0 replies; 11+ messages in thread
From: Xin Yin @ 2022-08-25 1:36 UTC (permalink / raw)
To: David Howells
Cc: xiang, jefflexu, linux-cachefs, linux-fsdevel, zhujia.zj, Yongqing Li
On Wed, Aug 24, 2022 at 6:25 PM David Howells <dhowells@redhat.com> wrote:
>
> Xin Yin <yinxin.x@bytedance.com> wrote:
>
> > Reported-by: Yongqing Li <liyongqing@bytedance.com>
> > Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
>
> Can you give me a Fixes: line please?
>
Sure , I will send a V2 patch and add the Fixes line.
Thanks
Xin Yin
> David
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [External] Re: [PATCH] cachefiles: make on-demand request distribution fairer
2022-08-24 10:25 ` David Howells
2022-08-25 1:36 ` [External] " Xin Yin
@ 2022-08-25 14:34 ` David Howells
2022-08-26 1:37 ` Xin Yin
1 sibling, 1 reply; 11+ messages in thread
From: David Howells @ 2022-08-25 14:34 UTC (permalink / raw)
To: Xin Yin
Cc: dhowells, xiang, jefflexu, linux-cachefs, linux-fsdevel,
zhujia.zj, Yongqing Li
Xin Yin <yinxin.x@bytedance.com> wrote:
> > Can you give me a Fixes: line please?
> >
> Sure , I will send a V2 patch and add the Fixes line.
Just giving me a Fixes line would do. I can insert it.
David
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [External] Re: [PATCH] cachefiles: make on-demand request distribution fairer
2022-08-25 14:34 ` David Howells
@ 2022-08-26 1:37 ` Xin Yin
0 siblings, 0 replies; 11+ messages in thread
From: Xin Yin @ 2022-08-26 1:37 UTC (permalink / raw)
To: David Howells
Cc: xiang, jefflexu, linux-cachefs, linux-fsdevel, zhujia.zj, Yongqing Li
On Thu, Aug 25, 2022 at 10:34 PM David Howells <dhowells@redhat.com> wrote:
>
> Xin Yin <yinxin.x@bytedance.com> wrote:
>
> > > Can you give me a Fixes: line please?
> > >
> > Sure , I will send a V2 patch and add the Fixes line.
>
> Just giving me a Fixes line would do. I can insert it.
>
Yeah, many thanks , the fixes line would be:
Fixes: c8383054506c ("cachefiles: notify the user daemon when looking
up cookie")
Thanks,
Xin Yin
> David
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-08-26 1:37 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-17 6:52 [PATCH] cachefiles: make on-demand request distribution fairer Xin Yin
2022-08-17 7:14 ` [Linux-cachefs] " Gao Xiang
2022-08-17 9:16 ` [External] " Xin Yin
2022-08-17 9:34 ` [Linux-cachefs] [External] " Gao Xiang
2022-08-24 10:24 ` David Howells
2022-08-24 11:00 ` Gao Xiang
2022-08-17 12:15 ` JeffleXu
2022-08-24 10:25 ` David Howells
2022-08-25 1:36 ` [External] " Xin Yin
2022-08-25 14:34 ` David Howells
2022-08-26 1:37 ` Xin Yin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.