All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Makefile: Unify condition for mpc85xx reset vector
@ 2022-08-03 21:56 Pali Rohár
  2022-08-17 21:08 ` Pali Rohár
  2022-08-18  1:13 ` Simon Glass
  0 siblings, 2 replies; 4+ messages in thread
From: Pali Rohár @ 2022-08-03 21:56 UTC (permalink / raw)
  To: Simon Glass; +Cc: u-boot

Use 'CONFIG_MPC85XX_HAVE_RESET_VECTOR && CONFIG_OF_SEPARATE' pattern
instead of 'CONFIG_MPC85XX_HAVE_RESET_VECTOR && !CONFIG_OF_EMBED' also in
OBJCOPYFLAGS_u-boot-nodtb.bin as this pattern is used in rest of Makefile.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index d659c8118cba..23bf0c8b1e62 100644
--- a/Makefile
+++ b/Makefile
@@ -1267,7 +1267,7 @@ spl/u-boot-spl.srec: spl/u-boot-spl FORCE
 
 OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
 		$(if $(CONFIG_X86_16BIT_INIT),-R .start16 -R .resetvec) \
-		$(if $(CONFIG_MPC85XX_HAVE_RESET_VECTOR),$(if $(CONFIG_OF_EMBED),,-R .bootpg -R .resetvec))
+		$(if $(CONFIG_MPC85XX_HAVE_RESET_VECTOR),$(if $(CONFIG_OF_SEPARATE),-R .bootpg -R .resetvec))
 
 binary_size_check: u-boot-nodtb.bin FORCE
 	@file_size=$(shell wc -c u-boot-nodtb.bin | awk '{print $$1}') ; \
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: Unify condition for mpc85xx reset vector
  2022-08-03 21:56 [PATCH] Makefile: Unify condition for mpc85xx reset vector Pali Rohár
@ 2022-08-17 21:08 ` Pali Rohár
  2022-08-18  1:13 ` Simon Glass
  1 sibling, 0 replies; 4+ messages in thread
From: Pali Rohár @ 2022-08-17 21:08 UTC (permalink / raw)
  To: Simon Glass; +Cc: u-boot

PING?

On Wednesday 03 August 2022 23:56:55 Pali Rohár wrote:
> Use 'CONFIG_MPC85XX_HAVE_RESET_VECTOR && CONFIG_OF_SEPARATE' pattern
> instead of 'CONFIG_MPC85XX_HAVE_RESET_VECTOR && !CONFIG_OF_EMBED' also in
> OBJCOPYFLAGS_u-boot-nodtb.bin as this pattern is used in rest of Makefile.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index d659c8118cba..23bf0c8b1e62 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1267,7 +1267,7 @@ spl/u-boot-spl.srec: spl/u-boot-spl FORCE
>  
>  OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
>  		$(if $(CONFIG_X86_16BIT_INIT),-R .start16 -R .resetvec) \
> -		$(if $(CONFIG_MPC85XX_HAVE_RESET_VECTOR),$(if $(CONFIG_OF_EMBED),,-R .bootpg -R .resetvec))
> +		$(if $(CONFIG_MPC85XX_HAVE_RESET_VECTOR),$(if $(CONFIG_OF_SEPARATE),-R .bootpg -R .resetvec))
>  
>  binary_size_check: u-boot-nodtb.bin FORCE
>  	@file_size=$(shell wc -c u-boot-nodtb.bin | awk '{print $$1}') ; \
> -- 
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: Unify condition for mpc85xx reset vector
  2022-08-03 21:56 [PATCH] Makefile: Unify condition for mpc85xx reset vector Pali Rohár
  2022-08-17 21:08 ` Pali Rohár
@ 2022-08-18  1:13 ` Simon Glass
  2022-08-18  7:56   ` Pali Rohár
  1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2022-08-18  1:13 UTC (permalink / raw)
  To: Pali Rohár; +Cc: U-Boot Mailing List

On Wed, 3 Aug 2022 at 15:57, Pali Rohár <pali@kernel.org> wrote:
>
> Use 'CONFIG_MPC85XX_HAVE_RESET_VECTOR && CONFIG_OF_SEPARATE' pattern
> instead of 'CONFIG_MPC85XX_HAVE_RESET_VECTOR && !CONFIG_OF_EMBED' also in
> OBJCOPYFLAGS_u-boot-nodtb.bin as this pattern is used in rest of Makefile.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Let's make a plan to move this to binman at some point.



>
> diff --git a/Makefile b/Makefile
> index d659c8118cba..23bf0c8b1e62 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1267,7 +1267,7 @@ spl/u-boot-spl.srec: spl/u-boot-spl FORCE
>
>  OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
>                 $(if $(CONFIG_X86_16BIT_INIT),-R .start16 -R .resetvec) \
> -               $(if $(CONFIG_MPC85XX_HAVE_RESET_VECTOR),$(if $(CONFIG_OF_EMBED),,-R .bootpg -R .resetvec))
> +               $(if $(CONFIG_MPC85XX_HAVE_RESET_VECTOR),$(if $(CONFIG_OF_SEPARATE),-R .bootpg -R .resetvec))
>
>  binary_size_check: u-boot-nodtb.bin FORCE
>         @file_size=$(shell wc -c u-boot-nodtb.bin | awk '{print $$1}') ; \
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: Unify condition for mpc85xx reset vector
  2022-08-18  1:13 ` Simon Glass
@ 2022-08-18  7:56   ` Pali Rohár
  0 siblings, 0 replies; 4+ messages in thread
From: Pali Rohár @ 2022-08-18  7:56 UTC (permalink / raw)
  To: Simon Glass; +Cc: U-Boot Mailing List

On Wednesday 17 August 2022 19:13:08 Simon Glass wrote:
> On Wed, 3 Aug 2022 at 15:57, Pali Rohár <pali@kernel.org> wrote:
> >
> > Use 'CONFIG_MPC85XX_HAVE_RESET_VECTOR && CONFIG_OF_SEPARATE' pattern
> > instead of 'CONFIG_MPC85XX_HAVE_RESET_VECTOR && !CONFIG_OF_EMBED' also in
> > OBJCOPYFLAGS_u-boot-nodtb.bin as this pattern is used in rest of Makefile.
> >
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> >  Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> Let's make a plan to move this to binman at some point.
> 

Once all mpc pending patches which are waiting there for months are
reviewed and merged, I can try to look at it. Until that I'm stopping
any development in this area. Ball is _not_ on my side.

> 
> >
> > diff --git a/Makefile b/Makefile
> > index d659c8118cba..23bf0c8b1e62 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1267,7 +1267,7 @@ spl/u-boot-spl.srec: spl/u-boot-spl FORCE
> >
> >  OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
> >                 $(if $(CONFIG_X86_16BIT_INIT),-R .start16 -R .resetvec) \
> > -               $(if $(CONFIG_MPC85XX_HAVE_RESET_VECTOR),$(if $(CONFIG_OF_EMBED),,-R .bootpg -R .resetvec))
> > +               $(if $(CONFIG_MPC85XX_HAVE_RESET_VECTOR),$(if $(CONFIG_OF_SEPARATE),-R .bootpg -R .resetvec))
> >
> >  binary_size_check: u-boot-nodtb.bin FORCE
> >         @file_size=$(shell wc -c u-boot-nodtb.bin | awk '{print $$1}') ; \
> > --
> > 2.20.1
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-18  7:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-03 21:56 [PATCH] Makefile: Unify condition for mpc85xx reset vector Pali Rohár
2022-08-17 21:08 ` Pali Rohár
2022-08-18  1:13 ` Simon Glass
2022-08-18  7:56   ` Pali Rohár

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.