All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src()
  2022-08-18  8:17 ` Yang Yingliang
@ 2022-08-18  8:14   ` Péter Ujfalusi
  -1 siblings, 0 replies; 6+ messages in thread
From: Péter Ujfalusi @ 2022-08-18  8:14 UTC (permalink / raw)
  To: Yang Yingliang, linux-kernel, alsa-devel, sound-open-firmware
  Cc: rander.wang, pierre-louis.bossart, ranjani.sridharan, broonie



On 18/08/2022 11:17, Yang Yingliang wrote:
> It should be size of the struct sof_ipc4_src, not data pointer pass to
> sof_update_ipc_object().

Good find, thank you.

Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

> Fixes: b85f4fc40d56 ("ASoC: SOF: add ipc4 SRC module support")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  sound/soc/sof/ipc4-topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c
> index af072b484a60..c6abfaf5d532 100644
> --- a/sound/soc/sof/ipc4-topology.c
> +++ b/sound/soc/sof/ipc4-topology.c
> @@ -771,7 +771,7 @@ static int sof_ipc4_widget_setup_comp_src(struct snd_sof_widget *swidget)
>  		goto err;
>  
>  	ret = sof_update_ipc_object(scomp, src, SOF_SRC_TOKENS, swidget->tuples,
> -				    swidget->num_tuples, sizeof(src), 1);
> +				    swidget->num_tuples, sizeof(*src), 1);
>  	if (ret) {
>  		dev_err(scomp->dev, "Parsing SRC tokens failed\n");
>  		goto err;

-- 
Péter

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src()
@ 2022-08-18  8:14   ` Péter Ujfalusi
  0 siblings, 0 replies; 6+ messages in thread
From: Péter Ujfalusi @ 2022-08-18  8:14 UTC (permalink / raw)
  To: Yang Yingliang, linux-kernel, alsa-devel, sound-open-firmware
  Cc: broonie, ranjani.sridharan, pierre-louis.bossart, rander.wang



On 18/08/2022 11:17, Yang Yingliang wrote:
> It should be size of the struct sof_ipc4_src, not data pointer pass to
> sof_update_ipc_object().

Good find, thank you.

Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

> Fixes: b85f4fc40d56 ("ASoC: SOF: add ipc4 SRC module support")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  sound/soc/sof/ipc4-topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c
> index af072b484a60..c6abfaf5d532 100644
> --- a/sound/soc/sof/ipc4-topology.c
> +++ b/sound/soc/sof/ipc4-topology.c
> @@ -771,7 +771,7 @@ static int sof_ipc4_widget_setup_comp_src(struct snd_sof_widget *swidget)
>  		goto err;
>  
>  	ret = sof_update_ipc_object(scomp, src, SOF_SRC_TOKENS, swidget->tuples,
> -				    swidget->num_tuples, sizeof(src), 1);
> +				    swidget->num_tuples, sizeof(*src), 1);
>  	if (ret) {
>  		dev_err(scomp->dev, "Parsing SRC tokens failed\n");
>  		goto err;

-- 
Péter

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src()
@ 2022-08-18  8:17 ` Yang Yingliang
  0 siblings, 0 replies; 6+ messages in thread
From: Yang Yingliang @ 2022-08-18  8:17 UTC (permalink / raw)
  To: linux-kernel, alsa-devel, sound-open-firmware
  Cc: rander.wang, pierre-louis.bossart, ranjani.sridharan,
	peter.ujfalusi, broonie

It should be size of the struct sof_ipc4_src, not data pointer pass to
sof_update_ipc_object().

Fixes: b85f4fc40d56 ("ASoC: SOF: add ipc4 SRC module support")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 sound/soc/sof/ipc4-topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c
index af072b484a60..c6abfaf5d532 100644
--- a/sound/soc/sof/ipc4-topology.c
+++ b/sound/soc/sof/ipc4-topology.c
@@ -771,7 +771,7 @@ static int sof_ipc4_widget_setup_comp_src(struct snd_sof_widget *swidget)
 		goto err;
 
 	ret = sof_update_ipc_object(scomp, src, SOF_SRC_TOKENS, swidget->tuples,
-				    swidget->num_tuples, sizeof(src), 1);
+				    swidget->num_tuples, sizeof(*src), 1);
 	if (ret) {
 		dev_err(scomp->dev, "Parsing SRC tokens failed\n");
 		goto err;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src()
@ 2022-08-18  8:17 ` Yang Yingliang
  0 siblings, 0 replies; 6+ messages in thread
From: Yang Yingliang @ 2022-08-18  8:17 UTC (permalink / raw)
  To: linux-kernel, alsa-devel, sound-open-firmware
  Cc: peter.ujfalusi, broonie, ranjani.sridharan, pierre-louis.bossart,
	rander.wang

It should be size of the struct sof_ipc4_src, not data pointer pass to
sof_update_ipc_object().

Fixes: b85f4fc40d56 ("ASoC: SOF: add ipc4 SRC module support")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 sound/soc/sof/ipc4-topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c
index af072b484a60..c6abfaf5d532 100644
--- a/sound/soc/sof/ipc4-topology.c
+++ b/sound/soc/sof/ipc4-topology.c
@@ -771,7 +771,7 @@ static int sof_ipc4_widget_setup_comp_src(struct snd_sof_widget *swidget)
 		goto err;
 
 	ret = sof_update_ipc_object(scomp, src, SOF_SRC_TOKENS, swidget->tuples,
-				    swidget->num_tuples, sizeof(src), 1);
+				    swidget->num_tuples, sizeof(*src), 1);
 	if (ret) {
 		dev_err(scomp->dev, "Parsing SRC tokens failed\n");
 		goto err;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src()
  2022-08-18  8:17 ` Yang Yingliang
@ 2022-08-18 15:11   ` Mark Brown
  -1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2022-08-18 15:11 UTC (permalink / raw)
  To: linux-kernel, sound-open-firmware, Yang Yingliang, alsa-devel
  Cc: rander.wang, peter.ujfalusi, pierre-louis.bossart, ranjani.sridharan

On Thu, 18 Aug 2022 16:17:51 +0800, Yang Yingliang wrote:
> It should be size of the struct sof_ipc4_src, not data pointer pass to
> sof_update_ipc_object().
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src()
      commit: ecdb10df7e0d83bfd12fb8f71e28ea4753e3716a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src()
@ 2022-08-18 15:11   ` Mark Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2022-08-18 15:11 UTC (permalink / raw)
  To: linux-kernel, sound-open-firmware, Yang Yingliang, alsa-devel
  Cc: ranjani.sridharan, peter.ujfalusi, pierre-louis.bossart, rander.wang

On Thu, 18 Aug 2022 16:17:51 +0800, Yang Yingliang wrote:
> It should be size of the struct sof_ipc4_src, not data pointer pass to
> sof_update_ipc_object().
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src()
      commit: ecdb10df7e0d83bfd12fb8f71e28ea4753e3716a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-18 15:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-18  8:17 [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src() Yang Yingliang
2022-08-18  8:17 ` Yang Yingliang
2022-08-18  8:14 ` Péter Ujfalusi
2022-08-18  8:14   ` Péter Ujfalusi
2022-08-18 15:11 ` Mark Brown
2022-08-18 15:11   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.