* [PATCH] fs/btrfs: Use atomic_try_cmpxchg in free_extent_buffer
@ 2022-08-09 16:36 Uros Bizjak
2022-08-15 21:36 ` Boris Burkov
2022-08-18 17:14 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: Uros Bizjak @ 2022-08-09 16:36 UTC (permalink / raw)
To: linux-btrfs, linux-kernel
Cc: Uros Bizjak, Chris Mason, Josef Bacik, David Sterba
Use `atomic_try_cmpxchg(ptr, &old, new)` instead of
`atomic_cmpxchg(ptr, old, new) == old` in free_extent_buffer. This
has two benefits:
- The x86 cmpxchg instruction returns success in the ZF flag, so this
change saves a compare after cmpxchg, as well as a related move
instruction in the front of cmpxchg.
- atomic_try_cmpxchg implicitly assigns the *ptr value to &old when
cmpxchg fails, enabling further code simplifications.
This patch has no functional change.
Cc: Chris Mason <clm@fb.com>
Cc: Josef Bacik <josef@toxicpanda.com>
Cc: David Sterba <dsterba@suse.com>
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
---
fs/btrfs/extent_io.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index bfae67c593c5..15ff196cbd6d 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -6328,18 +6328,16 @@ static int release_extent_buffer(struct extent_buffer *eb)
void free_extent_buffer(struct extent_buffer *eb)
{
int refs;
- int old;
if (!eb)
return;
+ refs = atomic_read(&eb->refs);
while (1) {
- refs = atomic_read(&eb->refs);
if ((!test_bit(EXTENT_BUFFER_UNMAPPED, &eb->bflags) && refs <= 3)
|| (test_bit(EXTENT_BUFFER_UNMAPPED, &eb->bflags) &&
refs == 1))
break;
- old = atomic_cmpxchg(&eb->refs, refs, refs - 1);
- if (old == refs)
+ if (atomic_try_cmpxchg(&eb->refs, &refs, refs - 1))
return;
}
--
2.37.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/btrfs: Use atomic_try_cmpxchg in free_extent_buffer
2022-08-09 16:36 [PATCH] fs/btrfs: Use atomic_try_cmpxchg in free_extent_buffer Uros Bizjak
@ 2022-08-15 21:36 ` Boris Burkov
2022-08-18 17:14 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Boris Burkov @ 2022-08-15 21:36 UTC (permalink / raw)
To: Uros Bizjak
Cc: linux-btrfs, linux-kernel, Chris Mason, Josef Bacik, David Sterba
On Tue, Aug 09, 2022 at 06:36:33PM +0200, Uros Bizjak wrote:
> Use `atomic_try_cmpxchg(ptr, &old, new)` instead of
> `atomic_cmpxchg(ptr, old, new) == old` in free_extent_buffer. This
> has two benefits:
>
> - The x86 cmpxchg instruction returns success in the ZF flag, so this
> change saves a compare after cmpxchg, as well as a related move
> instruction in the front of cmpxchg.
>
> - atomic_try_cmpxchg implicitly assigns the *ptr value to &old when
> cmpxchg fails, enabling further code simplifications.
>
> This patch has no functional change.
>
> Cc: Chris Mason <clm@fb.com>
> Cc: Josef Bacik <josef@toxicpanda.com>
> Cc: David Sterba <dsterba@suse.com>
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Reviewed-by: Boris Burkov <boris@bur.io>
> ---
> fs/btrfs/extent_io.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index bfae67c593c5..15ff196cbd6d 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -6328,18 +6328,16 @@ static int release_extent_buffer(struct extent_buffer *eb)
> void free_extent_buffer(struct extent_buffer *eb)
> {
> int refs;
> - int old;
> if (!eb)
> return;
>
> + refs = atomic_read(&eb->refs);
> while (1) {
> - refs = atomic_read(&eb->refs);
> if ((!test_bit(EXTENT_BUFFER_UNMAPPED, &eb->bflags) && refs <= 3)
> || (test_bit(EXTENT_BUFFER_UNMAPPED, &eb->bflags) &&
> refs == 1))
> break;
> - old = atomic_cmpxchg(&eb->refs, refs, refs - 1);
> - if (old == refs)
> + if (atomic_try_cmpxchg(&eb->refs, &refs, refs - 1))
> return;
> }
>
> --
> 2.37.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/btrfs: Use atomic_try_cmpxchg in free_extent_buffer
2022-08-09 16:36 [PATCH] fs/btrfs: Use atomic_try_cmpxchg in free_extent_buffer Uros Bizjak
2022-08-15 21:36 ` Boris Burkov
@ 2022-08-18 17:14 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2022-08-18 17:14 UTC (permalink / raw)
To: Uros Bizjak
Cc: linux-btrfs, linux-kernel, Chris Mason, Josef Bacik, David Sterba
On Tue, Aug 09, 2022 at 06:36:33PM +0200, Uros Bizjak wrote:
> Use `atomic_try_cmpxchg(ptr, &old, new)` instead of
> `atomic_cmpxchg(ptr, old, new) == old` in free_extent_buffer. This
> has two benefits:
>
> - The x86 cmpxchg instruction returns success in the ZF flag, so this
> change saves a compare after cmpxchg, as well as a related move
> instruction in the front of cmpxchg.
>
> - atomic_try_cmpxchg implicitly assigns the *ptr value to &old when
> cmpxchg fails, enabling further code simplifications.
>
> This patch has no functional change.
>
> Cc: Chris Mason <clm@fb.com>
> Cc: Josef Bacik <josef@toxicpanda.com>
> Cc: David Sterba <dsterba@suse.com>
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
It's not in a performance critical code but resulting code is slightly
more efficient. Added to misc-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-18 17:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-09 16:36 [PATCH] fs/btrfs: Use atomic_try_cmpxchg in free_extent_buffer Uros Bizjak
2022-08-15 21:36 ` Boris Burkov
2022-08-18 17:14 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.