* [PATCH] arm: k3: Correct an awk warning
@ 2022-08-07 13:12 Simon Glass
2022-08-07 13:29 ` Tom Rini
2022-08-20 23:02 ` Tom Rini
0 siblings, 2 replies; 4+ messages in thread
From: Simon Glass @ 2022-08-07 13:12 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Yogesh Siraswar, Simon Glass, Albert Aribaud, Dave Gerlach, Tom Rini
The k3_gen_x509_cert.sh script produced this warning on gitlab and also
on my machine, e.g. with j7200_evm_r5:
awk: cmd. line:1: warning: regexp escape sequence `\ ' is not a known
regexp operator
There is no need to escape spaces, so drop the backslashes. Also split
the line so it is a more reasonable length.
This script should really be deleted and binman used instead.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
tools/k3_gen_x509_cert.sh | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/k3_gen_x509_cert.sh b/tools/k3_gen_x509_cert.sh
index 24cfc4e5fb5..029247c1059 100755
--- a/tools/k3_gen_x509_cert.sh
+++ b/tools/k3_gen_x509_cert.sh
@@ -88,7 +88,10 @@ EOF
}
parse_key() {
- sed '/\ \ \ \ /s/://g' key.txt | awk '!/\ \ \ \ / {printf("\n%s\n", $0)}; /\ \ \ \ / {printf("%s", $0)}' | sed 's/\ \ \ \ //g' | awk "/$1:/{getline; print}"
+ sed '/ /s/://g' key.txt | \
+ awk '!/ / {printf("\n%s\n", $0)}; / / {printf("%s", $0)}' | \
+ sed 's/ //g' | \
+ awk "/$1:/{getline; print}"
}
gen_degen_key() {
--
2.37.1.559.g78731f0fdb-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: k3: Correct an awk warning
2022-08-07 13:12 [PATCH] arm: k3: Correct an awk warning Simon Glass
@ 2022-08-07 13:29 ` Tom Rini
2022-08-07 18:49 ` Simon Glass
2022-08-20 23:02 ` Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: Tom Rini @ 2022-08-07 13:29 UTC (permalink / raw)
To: Simon Glass, Neha Francis, Andrew Davis
Cc: U-Boot Mailing List, Yogesh Siraswar, Dave Gerlach
[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]
On Sun, Aug 07, 2022 at 07:12:19AM -0600, Simon Glass wrote:
> The k3_gen_x509_cert.sh script produced this warning on gitlab and also
> on my machine, e.g. with j7200_evm_r5:
>
> awk: cmd. line:1: warning: regexp escape sequence `\ ' is not a known
> regexp operator
>
> There is no need to escape spaces, so drop the backslashes. Also split
> the line so it is a more reasonable length.
>
> This script should really be deleted and binman used instead.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> tools/k3_gen_x509_cert.sh | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/k3_gen_x509_cert.sh b/tools/k3_gen_x509_cert.sh
> index 24cfc4e5fb5..029247c1059 100755
> --- a/tools/k3_gen_x509_cert.sh
> +++ b/tools/k3_gen_x509_cert.sh
> @@ -88,7 +88,10 @@ EOF
> }
>
> parse_key() {
> - sed '/\ \ \ \ /s/://g' key.txt | awk '!/\ \ \ \ / {printf("\n%s\n", $0)}; /\ \ \ \ / {printf("%s", $0)}' | sed 's/\ \ \ \ //g' | awk "/$1:/{getline; print}"
> + sed '/ /s/://g' key.txt | \
> + awk '!/ / {printf("\n%s\n", $0)}; / / {printf("%s", $0)}' | \
> + sed 's/ //g' | \
> + awk "/$1:/{getline; print}"
> }
>
> gen_degen_key() {
Since this is HS related content, and Neha has been working on a series
to move these platforms to binman
(https://patchwork.ozlabs.org/project/uboot/list/?series=304821&state=*)
adding a few more people.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: k3: Correct an awk warning
2022-08-07 13:29 ` Tom Rini
@ 2022-08-07 18:49 ` Simon Glass
0 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2022-08-07 18:49 UTC (permalink / raw)
To: Tom Rini
Cc: Neha Francis, Andrew Davis, U-Boot Mailing List, Yogesh Siraswar,
Dave Gerlach
Hi Tom,
On Sun, 7 Aug 2022 at 07:29, Tom Rini <trini@konsulko.com> wrote:
>
> On Sun, Aug 07, 2022 at 07:12:19AM -0600, Simon Glass wrote:
>
> > The k3_gen_x509_cert.sh script produced this warning on gitlab and also
> > on my machine, e.g. with j7200_evm_r5:
> >
> > awk: cmd. line:1: warning: regexp escape sequence `\ ' is not a known
> > regexp operator
> >
> > There is no need to escape spaces, so drop the backslashes. Also split
> > the line so it is a more reasonable length.
> >
> > This script should really be deleted and binman used instead.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> > tools/k3_gen_x509_cert.sh | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/k3_gen_x509_cert.sh b/tools/k3_gen_x509_cert.sh
> > index 24cfc4e5fb5..029247c1059 100755
> > --- a/tools/k3_gen_x509_cert.sh
> > +++ b/tools/k3_gen_x509_cert.sh
> > @@ -88,7 +88,10 @@ EOF
> > }
> >
> > parse_key() {
> > - sed '/\ \ \ \ /s/://g' key.txt | awk '!/\ \ \ \ / {printf("\n%s\n", $0)}; /\ \ \ \ / {printf("%s", $0)}' | sed 's/\ \ \ \ //g' | awk "/$1:/{getline; print}"
> > + sed '/ /s/://g' key.txt | \
> > + awk '!/ / {printf("\n%s\n", $0)}; / / {printf("%s", $0)}' | \
> > + sed 's/ //g' | \
> > + awk "/$1:/{getline; print}"
> > }
> >
> > gen_degen_key() {
>
> Since this is HS related content, and Neha has been working on a series
> to move these platforms to binman
> (https://patchwork.ozlabs.org/project/uboot/list/?series=304821&state=*)
> adding a few more people.
OK, good. It looks like the next step is a new version of that series.
Regards,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: k3: Correct an awk warning
2022-08-07 13:12 [PATCH] arm: k3: Correct an awk warning Simon Glass
2022-08-07 13:29 ` Tom Rini
@ 2022-08-20 23:02 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2022-08-20 23:02 UTC (permalink / raw)
To: Simon Glass
Cc: U-Boot Mailing List, Yogesh Siraswar, Albert Aribaud, Dave Gerlach
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
On Sun, Aug 07, 2022 at 07:12:19AM -0600, Simon Glass wrote:
> The k3_gen_x509_cert.sh script produced this warning on gitlab and also
> on my machine, e.g. with j7200_evm_r5:
>
> awk: cmd. line:1: warning: regexp escape sequence `\ ' is not a known
> regexp operator
>
> There is no need to escape spaces, so drop the backslashes. Also split
> the line so it is a more reasonable length.
>
> This script should really be deleted and binman used instead.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-20 23:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-07 13:12 [PATCH] arm: k3: Correct an awk warning Simon Glass
2022-08-07 13:29 ` Tom Rini
2022-08-07 18:49 ` Simon Glass
2022-08-20 23:02 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.