* [Buildroot] [PATCH] package/Makefile.in: only error out when no C library is configured when building
@ 2022-08-21 19:01 Thomas Petazzoni via buildroot
2022-08-21 19:31 ` Yann E. MORIN
2022-09-17 9:59 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-08-21 19:01 UTC (permalink / raw)
To: buildroot; +Cc: Thomas Petazzoni
Commit fda53f0791f5657d41735a40a29df3c8d0e8ae79 ("package/Makefile.in:
add detection for the lack of C library") added an $(error ...)
message when no C library is available for the currently selected
architecture.
However, this error message pops up not just when building, so for
example, the command:
make BR2_HAVE_DOT_CONFIG=y VARS=%_LICENSE printvars
no longer works (this command is used by the pkg-stats script).
We restore a functional behavior by doing the check only when
BR_BUILDING=y.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/Makefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/Makefile.in b/package/Makefile.in
index ff60f85092..43d214bcbe 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -53,7 +53,7 @@ else ifeq ($(BR2_TOOLCHAIN_USES_MUSL),y)
LIBC = musl
else ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
LIBC = gnu
-else
+else ifeq ($(BR_BUILDING),y)
# This happens if there is a bug in Buildroot that allows an
# architecture configuration that isn't supported by any library.
$(error No C library enabled, this is not possible.)
--
2.37.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/Makefile.in: only error out when no C library is configured when building
2022-08-21 19:01 [Buildroot] [PATCH] package/Makefile.in: only error out when no C library is configured when building Thomas Petazzoni via buildroot
@ 2022-08-21 19:31 ` Yann E. MORIN
2022-09-17 9:59 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2022-08-21 19:31 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: buildroot
Thomas, All,
On 2022-08-21 21:01 +0200, Thomas Petazzoni via buildroot spake thusly:
> Commit fda53f0791f5657d41735a40a29df3c8d0e8ae79 ("package/Makefile.in:
> add detection for the lack of C library") added an $(error ...)
> message when no C library is available for the currently selected
> architecture.
>
> However, this error message pops up not just when building, so for
> example, the command:
>
> make BR2_HAVE_DOT_CONFIG=y VARS=%_LICENSE printvars
>
> no longer works (this command is used by the pkg-stats script).
>
> We restore a functional behavior by doing the check only when
> BR_BUILDING=y.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/Makefile.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index ff60f85092..43d214bcbe 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -53,7 +53,7 @@ else ifeq ($(BR2_TOOLCHAIN_USES_MUSL),y)
> LIBC = musl
> else ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
> LIBC = gnu
> -else
> +else ifeq ($(BR_BUILDING),y)
> # This happens if there is a bug in Buildroot that allows an
> # architecture configuration that isn't supported by any library.
> $(error No C library enabled, this is not possible.)
> --
> 2.37.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/Makefile.in: only error out when no C library is configured when building
2022-08-21 19:01 [Buildroot] [PATCH] package/Makefile.in: only error out when no C library is configured when building Thomas Petazzoni via buildroot
2022-08-21 19:31 ` Yann E. MORIN
@ 2022-09-17 9:59 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-09-17 9:59 UTC (permalink / raw)
To: Thomas Petazzoni via buildroot; +Cc: Thomas Petazzoni
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> Commit fda53f0791f5657d41735a40a29df3c8d0e8ae79 ("package/Makefile.in:
> add detection for the lack of C library") added an $(error ...)
> message when no C library is available for the currently selected
> architecture.
> However, this error message pops up not just when building, so for
> example, the command:
> make BR2_HAVE_DOT_CONFIG=y VARS=%_LICENSE printvars
> no longer works (this command is used by the pkg-stats script).
> We restore a functional behavior by doing the check only when
> BR_BUILDING=y.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2022.05.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-17 9:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-21 19:01 [Buildroot] [PATCH] package/Makefile.in: only error out when no C library is configured when building Thomas Petazzoni via buildroot
2022-08-21 19:31 ` Yann E. MORIN
2022-09-17 9:59 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.