All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: timer: Add missing (unevaluated|additional)Properties on child nodes
@ 2022-08-23 14:56 Rob Herring
  2022-08-25  8:20 ` Krzysztof Kozlowski
  2022-08-31 20:47 ` Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2022-08-23 14:56 UTC (permalink / raw)
  To: Daniel Lezcano, Thomas Gleixner, Krzysztof Kozlowski,
	Marc Zyngier, Mark Rutland, Paul Cercueil
  Cc: linux-kernel, devicetree

In order to ensure only documented properties are present, node schemas
must have unevaluatedProperties or additionalProperties set to false
(typically).

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml        | 1 +
 Documentation/devicetree/bindings/timer/ingenic,tcu.yaml      | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
index cd2176cad53a..f6efa48c4256 100644
--- a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
+++ b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
@@ -62,6 +62,7 @@ properties:
 patternProperties:
   '^frame@[0-9a-z]*$':
     type: object
+    additionalProperties: false
     description: A timer node has up to 8 frame sub-nodes, each with the following properties.
     properties:
       frame-number:
diff --git a/Documentation/devicetree/bindings/timer/ingenic,tcu.yaml b/Documentation/devicetree/bindings/timer/ingenic,tcu.yaml
index 0a01e4f5eddb..a84fef0fe628 100644
--- a/Documentation/devicetree/bindings/timer/ingenic,tcu.yaml
+++ b/Documentation/devicetree/bindings/timer/ingenic,tcu.yaml
@@ -114,6 +114,8 @@ patternProperties:
   "^watchdog@[a-f0-9]+$":
     type: object
     $ref: /schemas/watchdog/watchdog.yaml#
+    unevaluatedProperties: false
+
     properties:
       compatible:
         oneOf:
@@ -146,6 +148,8 @@ patternProperties:
   "^pwm@[a-f0-9]+$":
     type: object
     $ref: /schemas/pwm/pwm.yaml#
+    unevaluatedProperties: false
+
     properties:
       compatible:
         oneOf:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: timer: Add missing (unevaluated|additional)Properties on child nodes
  2022-08-23 14:56 [PATCH] dt-bindings: timer: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
@ 2022-08-25  8:20 ` Krzysztof Kozlowski
  2022-08-31 20:47 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-25  8:20 UTC (permalink / raw)
  To: Rob Herring, Daniel Lezcano, Thomas Gleixner,
	Krzysztof Kozlowski, Marc Zyngier, Mark Rutland, Paul Cercueil
  Cc: linux-kernel, devicetree

On 23/08/2022 17:56, Rob Herring wrote:
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: timer: Add missing (unevaluated|additional)Properties on child nodes
  2022-08-23 14:56 [PATCH] dt-bindings: timer: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
  2022-08-25  8:20 ` Krzysztof Kozlowski
@ 2022-08-31 20:47 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-08-31 20:47 UTC (permalink / raw)
  To: Rob Herring
  Cc: devicetree, Thomas Gleixner, Mark Rutland, linux-kernel,
	Krzysztof Kozlowski, Daniel Lezcano, Paul Cercueil, Marc Zyngier

On Tue, 23 Aug 2022 09:56:47 -0500, Rob Herring wrote:
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml        | 1 +
>  Documentation/devicetree/bindings/timer/ingenic,tcu.yaml      | 4 ++++
>  2 files changed, 5 insertions(+)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-08-31 20:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23 14:56 [PATCH] dt-bindings: timer: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
2022-08-25  8:20 ` Krzysztof Kozlowski
2022-08-31 20:47 ` Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.