Re: [PATCH v3 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > LED is present by checking WMI ASUS_WMI_DEVID_MICMUTE_LED, we will add a
> > mic-mute LED classdev, asus::micmute, in the asus-wmi driver to control
> > it. The binding of mic-mute LED controls will be swithched with LED
> > trigger.
> > 
> > Signed-off-by: PaddyKP_Yao <PaddyKP_Yao@asus.com>
> > ---
> > V1 -> V2: fix typo for 'present' and remove unnecessary pr_info() log
> > V2 -> V3: resend patch again by gmail to avoid Asus legal in the mail
> 
> Thank you for your patch, I've applied this patch to my review-hans 
> branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
> 
> Once I've run some tests on this branch the patches there will be
> added to the platform-drivers-x86/for-next branch and eventually
> will be included in the pdx86 pull-request to Linus for the next
> merge-window.

> > +	if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MICMUTE_LED)) {
> > +		asus->micmute_led.name = "asus::micmute";

It would be good to get the API right before it hits mainline release.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html