From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
PaddyKP_Yao <ispaddy@gmail.com>
Cc: Mark Gross <mgross@linux.intel.com>,
Corentin Chary <corentin.chary@gmail.com>,
Luke Jones <luke@ljones.dev>,
PaddyKP_Yao@asus.com,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
acpi4asus-user <acpi4asus-user@lists.sourceforge.net>
Subject: Re: [PATCH 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support
Date: Sat, 9 Jul 2022 16:48:13 +0200 [thread overview]
Message-ID: <5c6c0516-7540-b668-9e7d-95db44ff336d@redhat.com> (raw)
In-Reply-To: <CAHp75Vc-5Py8heCJ4bKh1-7y+U+ycJxRuYdFwiT=NM5=gLqwQw@mail.gmail.com>
Hi,
On 7/9/22 13:44, Andy Shevchenko wrote:
> You have sent two patches with the same version, your submission
> confuses everybody, which one are we supposed to consider?
Also the From of this email: PaddyKP_Yao <ispaddy@gmail.com> and
the Signed-off-by:
>
> On Fri, Jul 8, 2022 at 11:08 AM PaddyKP_Yao <ispaddy@gmail.com> wrote:
>>
>> In some new ASUS devices, hotkey Fn+F13 is used for mic mute. If mic-mute
>> LED is present by checking WMI ASUS_WMI_DEVID_MICMUTE_LED, we will add a
>> mic-mute LED classdev, asus::micmute, in the asus-wmi driver to control
>> it. The binding of mic-mute LED controls will be swithched with LED
>
> switched
>
>> trigger.
>
> ...
>
> Not reviewing code because of the above.
>
> Hint: `git format-patch -vX ...`, where X is a version number will
> help. And when cooking a new version don't forget to add a changelog
> between versions.
>
next prev parent reply other threads:[~2022-07-09 14:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 8:48 [PATCH 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support PaddyKP_Yao
2022-07-08 9:07 ` PaddyKP_Yao
2022-07-09 11:44 ` Andy Shevchenko
2022-07-09 14:48 ` Hans de Goede [this message]
2022-07-09 14:49 ` Hans de Goede
2022-07-11 2:12 ` PaddyKP Yao(姚國鵬)
2022-07-11 2:40 ` [PATCH v2 " PaddyKP_Yao
2022-07-11 2:47 ` PaddyKP_Yao
2022-07-11 8:50 ` Andy Shevchenko
2022-07-11 11:41 ` PaddyKP Yao
2022-07-11 11:47 ` Hans de Goede
2022-07-11 11:51 ` [PATCH v3 " PaddyKP_Yao
2022-07-14 20:04 ` Hans de Goede
2022-08-24 10:06 ` Pavel Machek
2022-08-24 10:59 ` PaddyKP Yao
2022-08-25 7:55 ` Pavel Machek
2022-08-25 8:05 ` PaddyKP Yao
2022-08-24 10:06 ` [PATCH v2 " Pavel Machek
2022-08-24 11:09 ` PaddyKP Yao
2022-08-24 11:11 ` Hans de Goede
2022-08-24 11:17 ` PaddyKP Yao
2022-08-25 1:29 ` PaddyKP Yao
2022-08-25 8:13 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c6c0516-7540-b668-9e7d-95db44ff336d@redhat.com \
--to=hdegoede@redhat.com \
--cc=PaddyKP_Yao@asus.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=andy.shevchenko@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=ispaddy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.