[PATCH linux-next v2] drm/mediatek: Remove the unneeded result

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH linux-next v2] drm/mediatek: Remove the unneeded result
@ 2022-08-25  7:23 ` cgel.zte
  0 siblings, 0 replies; 9+ messages in thread
From: cgel.zte @ 2022-08-25  7:23 UTC (permalink / raw)
  To: matthias.bgg
  Cc: chunkuang.hu, p.zabel, airlied, daniel, dri-devel,
	linux-mediatek, linux-arm-kernel, linux-kernel, ye xingchen,
	Zeal Robot

From: ye xingchen <ye.xingchen@zte.com.cn>

Return the value drm_mode_config_helper_suspend() directly instead of
 storing it in another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
v1 -> v2
Add all the mailinglists that get_maintainers.pl give.
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 5f02f8d0e4fc..91f58db5915f 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
 {
 	struct mtk_drm_private *private = dev_get_drvdata(dev);
 	struct drm_device *drm = private->drm;
-	int ret;
-
-	ret = drm_mode_config_helper_suspend(drm);
 
-	return ret;
+	return drm_mode_config_helper_suspend(drm);
 }
 
 static void mtk_drm_sys_complete(struct device *dev)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH linux-next v2] drm/mediatek: Remove the unneeded result
@ 2022-08-25  7:23 ` cgel.zte
  0 siblings, 0 replies; 9+ messages in thread
From: cgel.zte @ 2022-08-25  7:23 UTC (permalink / raw)
  To: matthias.bgg
  Cc: chunkuang.hu, p.zabel, airlied, daniel, dri-devel,
	linux-mediatek, linux-arm-kernel, linux-kernel, ye xingchen,
	Zeal Robot

From: ye xingchen <ye.xingchen@zte.com.cn>

Return the value drm_mode_config_helper_suspend() directly instead of
 storing it in another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
v1 -> v2
Add all the mailinglists that get_maintainers.pl give.
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 5f02f8d0e4fc..91f58db5915f 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
 {
 	struct mtk_drm_private *private = dev_get_drvdata(dev);
 	struct drm_device *drm = private->drm;
-	int ret;
-
-	ret = drm_mode_config_helper_suspend(drm);
 
-	return ret;
+	return drm_mode_config_helper_suspend(drm);
 }
 
 static void mtk_drm_sys_complete(struct device *dev)
-- 
2.25.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH linux-next v2] drm/mediatek: Remove the unneeded result
@ 2022-08-25  7:23 ` cgel.zte
  0 siblings, 0 replies; 9+ messages in thread
From: cgel.zte @ 2022-08-25  7:23 UTC (permalink / raw)
  To: matthias.bgg
  Cc: chunkuang.hu, airlied, ye xingchen, Zeal Robot, linux-kernel,
	dri-devel, linux-mediatek, linux-arm-kernel

From: ye xingchen <ye.xingchen@zte.com.cn>

Return the value drm_mode_config_helper_suspend() directly instead of
 storing it in another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
v1 -> v2
Add all the mailinglists that get_maintainers.pl give.
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 5f02f8d0e4fc..91f58db5915f 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
 {
 	struct mtk_drm_private *private = dev_get_drvdata(dev);
 	struct drm_device *drm = private->drm;
-	int ret;
-
-	ret = drm_mode_config_helper_suspend(drm);
 
-	return ret;
+	return drm_mode_config_helper_suspend(drm);
 }
 
 static void mtk_drm_sys_complete(struct device *dev)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result
  2022-08-25  7:23 ` cgel.zte
  (?)
@ 2022-08-25 13:09   ` Matthias Brugger
  -1 siblings, 0 replies; 9+ messages in thread
From: Matthias Brugger @ 2022-08-25 13:09 UTC (permalink / raw)
  To: cgel.zte
  Cc: chunkuang.hu, p.zabel, airlied, daniel, dri-devel,
	linux-mediatek, linux-arm-kernel, linux-kernel, ye xingchen,
	Zeal Robot



On 25/08/2022 09:23, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Return the value drm_mode_config_helper_suspend() directly instead of
>   storing it in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

I thought I already did this in v1, anyway here we go again:

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
> v1 -> v2
> Add all the mailinglists that get_maintainers.pl give.
>   drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 5f02f8d0e4fc..91f58db5915f 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
>   {
>   	struct mtk_drm_private *private = dev_get_drvdata(dev);
>   	struct drm_device *drm = private->drm;
> -	int ret;
> -
> -	ret = drm_mode_config_helper_suspend(drm);
>   
> -	return ret;
> +	return drm_mode_config_helper_suspend(drm);
>   }
>   
>   static void mtk_drm_sys_complete(struct device *dev)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result
@ 2022-08-25 13:09   ` Matthias Brugger
  0 siblings, 0 replies; 9+ messages in thread
From: Matthias Brugger @ 2022-08-25 13:09 UTC (permalink / raw)
  To: cgel.zte
  Cc: chunkuang.hu, airlied, ye xingchen, Zeal Robot, linux-kernel,
	dri-devel, linux-mediatek, linux-arm-kernel



On 25/08/2022 09:23, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Return the value drm_mode_config_helper_suspend() directly instead of
>   storing it in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

I thought I already did this in v1, anyway here we go again:

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
> v1 -> v2
> Add all the mailinglists that get_maintainers.pl give.
>   drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 5f02f8d0e4fc..91f58db5915f 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
>   {
>   	struct mtk_drm_private *private = dev_get_drvdata(dev);
>   	struct drm_device *drm = private->drm;
> -	int ret;
> -
> -	ret = drm_mode_config_helper_suspend(drm);
>   
> -	return ret;
> +	return drm_mode_config_helper_suspend(drm);
>   }
>   
>   static void mtk_drm_sys_complete(struct device *dev)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result
@ 2022-08-25 13:09   ` Matthias Brugger
  0 siblings, 0 replies; 9+ messages in thread
From: Matthias Brugger @ 2022-08-25 13:09 UTC (permalink / raw)
  To: cgel.zte
  Cc: chunkuang.hu, p.zabel, airlied, daniel, dri-devel,
	linux-mediatek, linux-arm-kernel, linux-kernel, ye xingchen,
	Zeal Robot



On 25/08/2022 09:23, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Return the value drm_mode_config_helper_suspend() directly instead of
>   storing it in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

I thought I already did this in v1, anyway here we go again:

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
> v1 -> v2
> Add all the mailinglists that get_maintainers.pl give.
>   drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 5f02f8d0e4fc..91f58db5915f 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
>   {
>   	struct mtk_drm_private *private = dev_get_drvdata(dev);
>   	struct drm_device *drm = private->drm;
> -	int ret;
> -
> -	ret = drm_mode_config_helper_suspend(drm);
>   
> -	return ret;
> +	return drm_mode_config_helper_suspend(drm);
>   }
>   
>   static void mtk_drm_sys_complete(struct device *dev)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result
  2022-08-25  7:23 ` cgel.zte
  (?)
@ 2022-08-25 23:38   ` Chun-Kuang Hu
  -1 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2022-08-25 23:38 UTC (permalink / raw)
  To: cgel.zte
  Cc: Matthias Brugger, Chun-Kuang Hu, Philipp Zabel, David Airlie,
	Daniel Vetter, DRI Development,
	moderated list:ARM/Mediatek SoC support, Linux ARM, linux-kernel,
	ye xingchen, Zeal Robot

Hi, cgel:

<cgel.zte@gmail.com> 於 2022年8月25日 週四 下午3:24寫道：
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value drm_mode_config_helper_suspend() directly instead of
>  storing it in another redundant variable.

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> v1 -> v2
> Add all the mailinglists that get_maintainers.pl give.
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 5f02f8d0e4fc..91f58db5915f 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
>  {
>         struct mtk_drm_private *private = dev_get_drvdata(dev);
>         struct drm_device *drm = private->drm;
> -       int ret;
> -
> -       ret = drm_mode_config_helper_suspend(drm);
>
> -       return ret;
> +       return drm_mode_config_helper_suspend(drm);
>  }
>
>  static void mtk_drm_sys_complete(struct device *dev)
> --
> 2.25.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result
@ 2022-08-25 23:38   ` Chun-Kuang Hu
  0 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2022-08-25 23:38 UTC (permalink / raw)
  To: cgel.zte
  Cc: Chun-Kuang Hu, David Airlie, ye xingchen, Zeal Robot,
	linux-kernel, DRI Development,
	moderated list:ARM/Mediatek SoC support, Matthias Brugger,
	Linux ARM

Hi, cgel:

<cgel.zte@gmail.com> 於 2022年8月25日 週四 下午3:24寫道：
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value drm_mode_config_helper_suspend() directly instead of
>  storing it in another redundant variable.

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> v1 -> v2
> Add all the mailinglists that get_maintainers.pl give.
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 5f02f8d0e4fc..91f58db5915f 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
>  {
>         struct mtk_drm_private *private = dev_get_drvdata(dev);
>         struct drm_device *drm = private->drm;
> -       int ret;
> -
> -       ret = drm_mode_config_helper_suspend(drm);
>
> -       return ret;
> +       return drm_mode_config_helper_suspend(drm);
>  }
>
>  static void mtk_drm_sys_complete(struct device *dev)
> --
> 2.25.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result
@ 2022-08-25 23:38   ` Chun-Kuang Hu
  0 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2022-08-25 23:38 UTC (permalink / raw)
  To: cgel.zte
  Cc: Matthias Brugger, Chun-Kuang Hu, Philipp Zabel, David Airlie,
	Daniel Vetter, DRI Development,
	moderated list:ARM/Mediatek SoC support, Linux ARM, linux-kernel,
	ye xingchen, Zeal Robot

Hi, cgel:

<cgel.zte@gmail.com> 於 2022年8月25日 週四 下午3:24寫道：
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value drm_mode_config_helper_suspend() directly instead of
>  storing it in another redundant variable.

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> v1 -> v2
> Add all the mailinglists that get_maintainers.pl give.
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 5f02f8d0e4fc..91f58db5915f 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
>  {
>         struct mtk_drm_private *private = dev_get_drvdata(dev);
>         struct drm_device *drm = private->drm;
> -       int ret;
> -
> -       ret = drm_mode_config_helper_suspend(drm);
>
> -       return ret;
> +       return drm_mode_config_helper_suspend(drm);
>  }
>
>  static void mtk_drm_sys_complete(struct device *dev)
> --
> 2.25.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-08-25 23:40 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-25  7:23 [PATCH linux-next v2] drm/mediatek: Remove the unneeded result cgel.zte
2022-08-25  7:23 ` cgel.zte
2022-08-25  7:23 ` cgel.zte
2022-08-25 13:09 ` Matthias Brugger
2022-08-25 13:09   ` Matthias Brugger
2022-08-25 13:09   ` Matthias Brugger
2022-08-25 23:38 ` Chun-Kuang Hu
2022-08-25 23:38   ` Chun-Kuang Hu
2022-08-25 23:38   ` Chun-Kuang Hu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.