* [PATCH linux-next] drm/msm/dsi: Remove the unneeded result variable
@ 2022-08-26 7:28 ` cgel.zte
0 siblings, 0 replies; 4+ messages in thread
From: cgel.zte @ 2022-08-26 7:28 UTC (permalink / raw)
To: robdclark
Cc: quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel, swboyd,
laurent.pinchart, vkoul, dianders, linux-arm-msm, dri-devel,
freedreno, ye xingchen, Zeal Robot
From: ye xingchen <ye.xingchen@zte.com.cn>
Return the value msm_dsi_phy_enable() directly instead of storing it in
another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/gpu/drm/msm/dsi/dsi_manager.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c
index cb84d185d73a..0b516a04945f 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_manager.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c
@@ -141,14 +141,11 @@ static int enable_phy(struct msm_dsi *msm_dsi,
struct msm_dsi_phy_shared_timings *shared_timings)
{
struct msm_dsi_phy_clk_request clk_req;
- int ret;
bool is_bonded_dsi = IS_BONDED_DSI();
msm_dsi_host_get_phy_clk_req(msm_dsi->host, &clk_req, is_bonded_dsi);
- ret = msm_dsi_phy_enable(msm_dsi->phy, &clk_req, shared_timings);
-
- return ret;
+ return msm_dsi_phy_enable(msm_dsi->phy, &clk_req, shared_timings);
}
static int
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH linux-next] drm/msm/dsi: Remove the unneeded result variable
@ 2022-08-26 7:28 ` cgel.zte
0 siblings, 0 replies; 4+ messages in thread
From: cgel.zte @ 2022-08-26 7:28 UTC (permalink / raw)
To: robdclark
Cc: freedreno, dianders, airlied, linux-arm-msm, Zeal Robot,
quic_abhinavk, dri-devel, swboyd, vkoul, laurent.pinchart,
ye xingchen, dmitry.baryshkov, sean
From: ye xingchen <ye.xingchen@zte.com.cn>
Return the value msm_dsi_phy_enable() directly instead of storing it in
another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/gpu/drm/msm/dsi/dsi_manager.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c
index cb84d185d73a..0b516a04945f 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_manager.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c
@@ -141,14 +141,11 @@ static int enable_phy(struct msm_dsi *msm_dsi,
struct msm_dsi_phy_shared_timings *shared_timings)
{
struct msm_dsi_phy_clk_request clk_req;
- int ret;
bool is_bonded_dsi = IS_BONDED_DSI();
msm_dsi_host_get_phy_clk_req(msm_dsi->host, &clk_req, is_bonded_dsi);
- ret = msm_dsi_phy_enable(msm_dsi->phy, &clk_req, shared_timings);
-
- return ret;
+ return msm_dsi_phy_enable(msm_dsi->phy, &clk_req, shared_timings);
}
static int
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] drm/msm/dsi: Remove the unneeded result variable
2022-08-26 7:28 ` cgel.zte
@ 2022-08-26 8:20 ` Dmitry Baryshkov
-1 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2022-08-26 8:20 UTC (permalink / raw)
To: cgel.zte, robdclark
Cc: quic_abhinavk, sean, airlied, daniel, swboyd, laurent.pinchart,
vkoul, dianders, linux-arm-msm, dri-devel, freedreno,
ye xingchen, Zeal Robot
On 26/08/2022 10:28, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value msm_dsi_phy_enable() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] drm/msm/dsi: Remove the unneeded result variable
@ 2022-08-26 8:20 ` Dmitry Baryshkov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2022-08-26 8:20 UTC (permalink / raw)
To: cgel.zte, robdclark
Cc: freedreno, dianders, airlied, linux-arm-msm, Zeal Robot,
quic_abhinavk, dri-devel, swboyd, vkoul, laurent.pinchart,
ye xingchen, sean
On 26/08/2022 10:28, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value msm_dsi_phy_enable() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-26 8:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-26 7:28 [PATCH linux-next] drm/msm/dsi: Remove the unneeded result variable cgel.zte
2022-08-26 7:28 ` cgel.zte
2022-08-26 8:20 ` Dmitry Baryshkov
2022-08-26 8:20 ` Dmitry Baryshkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.