* [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234
@ 2022-08-29 11:44 Sandipan Patra
2022-08-29 11:44 ` [PATCH 2/2] arm64: tegra: Add user PWM support on Jetson Orin Sandipan Patra
2022-08-30 9:50 ` [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234 Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Sandipan Patra @ 2022-08-29 11:44 UTC (permalink / raw)
To: thierry.reding, jonathanh, robh+dt, krzysztof.kozlowski+dt,
devicetree, linux-tegra, linux-kernel
Cc: bbasu, kyarlagadda, Sandipan Patra
Tegra234 has eight single-channel PWM controllers, one of them in the
AON block.
Signed-off-by: Sandipan Patra <spatra@nvidia.com>
---
arch/arm64/boot/dts/nvidia/tegra234.dtsi | 84 ++++++++++++++++++++++++
1 file changed, 84 insertions(+)
diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
index 81a0f599685f..c2dc651f0842 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
@@ -840,6 +840,90 @@
#pwm-cells = <2>;
};
+ pwm2: pwm@3290000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0x3290000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM2>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM2>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
+ pwm3: pwm@32a0000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0x32a0000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM3>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM3>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
+ pwm4: pwm@c340000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0xc340000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM4>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM4>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
+ pwm5: pwm@32c0000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0x32c0000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM5>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM5>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
+ pwm6: pwm@32d0000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0x32d0000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM6>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM6>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
+ pwm7: pwm@32e0000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0x32e0000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM7>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM7>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
+ pwm8: pwm@32f0000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0x32f0000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM8>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM8>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
spi@3300000 {
compatible = "nvidia,tegra234-qspi";
reg = <0x3300000 0x1000>;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] arm64: tegra: Add user PWM support on Jetson Orin
2022-08-29 11:44 [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234 Sandipan Patra
@ 2022-08-29 11:44 ` Sandipan Patra
2022-08-30 9:50 ` [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234 Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Sandipan Patra @ 2022-08-29 11:44 UTC (permalink / raw)
To: thierry.reding, jonathanh, robh+dt, krzysztof.kozlowski+dt,
devicetree, linux-tegra, linux-kernel
Cc: bbasu, kyarlagadda, Sandipan Patra
Enable in device tree and use it to drive the PWM controllers on
40 pin header of Orin dev-kit.
Signed-off-by: Sandipan Patra <spatra@nvidia.com>
---
V2: Overriding by node label instead of node path.
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
index a85993c85e45..5108013a18c6 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
@@ -3,3 +3,15 @@
/ {
compatible = "nvidia,p3737-0000";
};
+
+&pwm1 {
+ status = "okay";
+};
+
+&pwm5 {
+ status = "okay";
+};
+
+&pwm8 {
+ status = "okay";
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234
2022-08-29 11:44 [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234 Sandipan Patra
2022-08-29 11:44 ` [PATCH 2/2] arm64: tegra: Add user PWM support on Jetson Orin Sandipan Patra
@ 2022-08-30 9:50 ` Krzysztof Kozlowski
2022-09-06 8:47 ` Sandipan Patra
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-30 9:50 UTC (permalink / raw)
To: Sandipan Patra, thierry.reding, jonathanh, robh+dt,
krzysztof.kozlowski+dt, devicetree, linux-tegra, linux-kernel
Cc: bbasu, kyarlagadda
On 29/08/2022 14:44, Sandipan Patra wrote:
> Tegra234 has eight single-channel PWM controllers, one of them in the
> AON block.
>
> Signed-off-by: Sandipan Patra <spatra@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 84 ++++++++++++++++++++++++
> 1 file changed, 84 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> index 81a0f599685f..c2dc651f0842 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> @@ -840,6 +840,90 @@
> #pwm-cells = <2>;
> };
>
> + pwm2: pwm@3290000 {
> + compatible = "nvidia,tegra194-pwm",
> + "nvidia,tegra186-pwm";
This does not match bindings. Either DTS or bindings need to be fixed.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234
2022-08-30 9:50 ` [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234 Krzysztof Kozlowski
@ 2022-09-06 8:47 ` Sandipan Patra
0 siblings, 0 replies; 5+ messages in thread
From: Sandipan Patra @ 2022-09-06 8:47 UTC (permalink / raw)
To: Krzysztof Kozlowski, thierry.reding, Jonathan Hunter, robh+dt,
krzysztof.kozlowski+dt, devicetree, linux-tegra, linux-kernel
Cc: Bibek Basu, Krishna Yarlagadda
Hi Krzysztof,
> > + pwm2: pwm@3290000 {
> > + compatible = "nvidia,tegra194-pwm",
> > + "nvidia,tegra186-pwm";
>
> This does not match bindings. Either DTS or bindings need to be fixed.
Thanks for reviewing the patches.
Tegra234 uses same compatible as Tegra194.
And also we can clear "nvidia,tegra186-pwm" from the Tegra234 pwm compatible list.
I will update binding doc and push new patch.
Thanks & Regards,
Sandipan
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Tuesday, August 30, 2022 3:20 PM
> To: Sandipan Patra <spatra@nvidia.com>; thierry.reding@gmail.com;
> Jonathan Hunter <jonathanh@nvidia.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; devicetree@vger.kernel.org; linux-
> tegra@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Bibek Basu <bbasu@nvidia.com>; Krishna Yarlagadda
> <kyarlagadda@nvidia.com>
> Subject: Re: [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234
>
> External email: Use caution opening links or attachments
>
>
> On 29/08/2022 14:44, Sandipan Patra wrote:
> > Tegra234 has eight single-channel PWM controllers, one of them in the
> > AON block.
> >
> > Signed-off-by: Sandipan Patra <spatra@nvidia.com>
> > ---
> > arch/arm64/boot/dts/nvidia/tegra234.dtsi | 84
> > ++++++++++++++++++++++++
> > 1 file changed, 84 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > index 81a0f599685f..c2dc651f0842 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > @@ -840,6 +840,90 @@
> > #pwm-cells = <2>;
> > };
> >
> > + pwm2: pwm@3290000 {
> > + compatible = "nvidia,tegra194-pwm",
> > + "nvidia,tegra186-pwm";
>
> This does not match bindings. Either DTS or bindings need to be fixed.
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234
@ 2022-08-26 12:17 Sandipan Patra
0 siblings, 0 replies; 5+ messages in thread
From: Sandipan Patra @ 2022-08-26 12:17 UTC (permalink / raw)
To: thierry.reding, jonathanh, robh+dt, krzysztof.kozlowski+dt,
devicetree, linux-tegra, linux-kernel
Cc: bbasu, kyarlagadda, Sandipan Patra
Tegra234 has eight single-channel PWM controllers, one of them in the
AON block.
Signed-off-by: Sandipan Patra <spatra@nvidia.com>
---
arch/arm64/boot/dts/nvidia/tegra234.dtsi | 84 ++++++++++++++++++++++++
1 file changed, 84 insertions(+)
diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
index 81a0f599685f..c2dc651f0842 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
@@ -840,6 +840,90 @@
#pwm-cells = <2>;
};
+ pwm2: pwm@3290000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0x3290000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM2>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM2>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
+ pwm3: pwm@32a0000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0x32a0000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM3>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM3>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
+ pwm4: pwm@c340000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0xc340000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM4>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM4>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
+ pwm5: pwm@32c0000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0x32c0000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM5>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM5>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
+ pwm6: pwm@32d0000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0x32d0000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM6>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM6>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
+ pwm7: pwm@32e0000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0x32e0000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM7>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM7>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
+ pwm8: pwm@32f0000 {
+ compatible = "nvidia,tegra194-pwm",
+ "nvidia,tegra186-pwm";
+ reg = <0x32f0000 0x10000>;
+ clocks = <&bpmp TEGRA234_CLK_PWM8>;
+ clock-names = "pwm";
+ resets = <&bpmp TEGRA234_RESET_PWM8>;
+ reset-names = "pwm";
+ status = "disabled";
+ #pwm-cells = <2>;
+ };
+
spi@3300000 {
compatible = "nvidia,tegra234-qspi";
reg = <0x3300000 0x1000>;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-06 8:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 11:44 [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234 Sandipan Patra
2022-08-29 11:44 ` [PATCH 2/2] arm64: tegra: Add user PWM support on Jetson Orin Sandipan Patra
2022-08-30 9:50 ` [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234 Krzysztof Kozlowski
2022-09-06 8:47 ` Sandipan Patra
-- strict thread matches above, loose matches on Subject: below --
2022-08-26 12:17 Sandipan Patra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.