* [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure
@ 2022-08-29 12:04 ` Nirmoy Das
0 siblings, 0 replies; 8+ messages in thread
From: Nirmoy Das @ 2022-08-29 12:04 UTC (permalink / raw)
To: intel-gfx; +Cc: thomas.hellstrom, matthew.auld, dri-devel, chris.p.wilson
On system suspend when system memory is low then i915_gem_obj_copy_ttm()
could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough,
suspend shouldn't continue if i915_ttm_backup() throws an error.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6529
Suggested-by: Chris P Wilson <chris.p.wilson@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
index 9aad84059d56..6f5d5c0909b4 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
@@ -79,7 +79,12 @@ static int i915_ttm_backup(struct i915_gem_apply_to_region *apply,
goto out_no_populate;
err = i915_gem_obj_copy_ttm(backup, obj, pm_apply->allow_gpu, false);
- GEM_WARN_ON(err);
+ if (err) {
+ drm_err(&i915->drm,
+ "Unable to copy from device to system memory, err:%d\n",
+ err);
+ goto out_no_populate;
+ }
ttm_bo_wait_ctx(backup_bo, &ctx);
obj->ttm.backup = backup;
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure
@ 2022-08-29 12:04 ` Nirmoy Das
0 siblings, 0 replies; 8+ messages in thread
From: Nirmoy Das @ 2022-08-29 12:04 UTC (permalink / raw)
To: intel-gfx; +Cc: thomas.hellstrom, matthew.auld, dri-devel, chris.p.wilson
On system suspend when system memory is low then i915_gem_obj_copy_ttm()
could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough,
suspend shouldn't continue if i915_ttm_backup() throws an error.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6529
Suggested-by: Chris P Wilson <chris.p.wilson@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
index 9aad84059d56..6f5d5c0909b4 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
@@ -79,7 +79,12 @@ static int i915_ttm_backup(struct i915_gem_apply_to_region *apply,
goto out_no_populate;
err = i915_gem_obj_copy_ttm(backup, obj, pm_apply->allow_gpu, false);
- GEM_WARN_ON(err);
+ if (err) {
+ drm_err(&i915->drm,
+ "Unable to copy from device to system memory, err:%d\n",
+ err);
+ goto out_no_populate;
+ }
ttm_bo_wait_ctx(backup_bo, &ctx);
obj->ttm.backup = backup;
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: Abort suspend on i915_ttm_backup failure
2022-08-29 12:04 ` [Intel-gfx] " Nirmoy Das
(?)
@ 2022-08-29 15:18 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-08-29 15:18 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5439 bytes --]
== Series Details ==
Series: drm/i915/ttm: Abort suspend on i915_ttm_backup failure
URL : https://patchwork.freedesktop.org/series/107877/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12041 -> Patchwork_107877v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/index.html
Participating hosts (39 -> 36)
------------------------------
Additional (1): bat-dg2-10
Missing (4): fi-ctg-p8600 fi-hsw-4770 fi-bdw-samus fi-hsw-4200u
Known issues
------------
Here are the changes found in Patchwork_107877v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [PASS][1] -> [FAIL][2] ([i915#6298])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u: [DMESG-FAIL][3] ([i915#62]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@requests:
- {bat-rplp-1}: [INCOMPLETE][5] -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/bat-rplp-1/igt@i915_selftest@live@requests.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/bat-rplp-1/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@reset:
- {bat-rpls-1}: [DMESG-FAIL][7] ([i915#4983] / [i915#5828]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/bat-rpls-1/igt@i915_selftest@live@reset.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@ring_submission:
- fi-cfl-8109u: [DMESG-WARN][9] ([i915#5904]) -> [PASS][10] +30 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-cfl-8109u: [DMESG-WARN][11] ([i915#5904] / [i915#62]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-WARN][13] ([i915#62]) -> [PASS][14] +13 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828
[i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6579]: https://gitlab.freedesktop.org/drm/intel/issues/6579
Build changes
-------------
* Linux: CI_DRM_12041 -> Patchwork_107877v1
CI-20190529: 20190529
CI_DRM_12041: 39caa74872844a95d9d2423e97ad497c1f8d1f30 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6637: a23e8aed0b54018339647d0817267431bd2b7075 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107877v1: 39caa74872844a95d9d2423e97ad497c1f8d1f30 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
6774a1033186 drm/i915/ttm: Abort suspend on i915_ttm_backup failure
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/index.html
[-- Attachment #2: Type: text/html, Size: 5467 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ttm: Abort suspend on i915_ttm_backup failure
2022-08-29 12:04 ` [Intel-gfx] " Nirmoy Das
(?)
(?)
@ 2022-08-31 6:09 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-08-31 6:09 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 22245 bytes --]
== Series Details ==
Series: drm/i915/ttm: Abort suspend on i915_ttm_backup failure
URL : https://patchwork.freedesktop.org/series/107877/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12041_full -> Patchwork_107877v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (11 -> 12)
------------------------------
Additional (1): shard-rkl
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107877v1_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_hangman@engine-engine-hang@bcs0:
- {shard-rkl}: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-rkl-5/igt@i915_hangman@engine-engine-hang@bcs0.html
Known issues
------------
Here are the changes found in Patchwork_107877v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [PASS][2] -> [SKIP][3] ([i915#4525]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb1/igt@gem_exec_balancer@parallel-out-fence.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb6/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [PASS][4] -> [FAIL][5] ([i915#2842]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-kbl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-kbl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-glk9/igt@gem_exec_fair@basic-pace@vcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-glk6/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: NOTRUN -> [DMESG-WARN][8] ([i915#180])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl2/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1937])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-kbl1/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [PASS][10] -> [DMESG-WARN][11] ([i915#180]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-apl6/igt@i915_suspend@sysfs-reader.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl2/igt@i915_suspend@sysfs-reader.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#3886]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl2/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#3886])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-kbl1/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-hpd-storm-disable:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111827]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl7/igt@kms_chamelium@dp-hpd-storm-disable.html
* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-kbl1/igt@kms_chamelium@vga-hpd-for-each-pipe.html
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][16] ([i915#2105])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl7/igt@kms_content_protection@uevent.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-kbl: NOTRUN -> [SKIP][17] ([fdo#109271]) +25 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-kbl1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@cursor-vs-flip@atomic-transitions:
- shard-iclb: [PASS][18] -> [FAIL][19] ([i915#5072])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb5/igt@kms_cursor_legacy@cursor-vs-flip@atomic-transitions.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb7/igt@kms_cursor_legacy@cursor-vs-flip@atomic-transitions.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][20] ([i915#6375])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][21] ([i915#3555]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][22] ([i915#2672]) +9 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271]) +37 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1:
- shard-iclb: [PASS][24] -> [SKIP][25] ([i915#5235]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb7/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [PASS][26] -> [SKIP][27] ([fdo#109642] / [fdo#111068] / [i915#658])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb2/igt@kms_psr2_su@frontbuffer-xrgb8888.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb6/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-iclb: [PASS][28] -> [SKIP][29] ([fdo#109441]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb1/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: [PASS][30] -> [DMESG-WARN][31] ([i915#180]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-kbl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-kbl7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@sysfs_clients@sema-25:
- shard-apl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#2994]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl7/igt@sysfs_clients@sema-25.html
* igt@sysfs_clients@sema-50:
- shard-kbl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#2994])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-kbl1/igt@sysfs_clients@sema-50.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][34] ([i915#658]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb6/igt@feature_discovery@psr2.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_exec_balancer@parallel:
- shard-iclb: [SKIP][36] ([i915#4525]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb3/igt@gem_exec_balancer@parallel.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb2/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [FAIL][38] ([i915#2842]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-glk2/igt@gem_exec_fair@basic-none@rcs0.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-glk5/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-apl: [FAIL][40] ([i915#2842]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-apl3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][42] ([i915#2842]) -> [PASS][43] +3 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-kbl7/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][44] ([i915#454]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb5/igt@i915_pm_dc@dc6-psr.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [DMESG-WARN][46] ([i915#180]) -> [PASS][47] +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-apl2/igt@i915_suspend@debugfs-reader.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl7/igt@i915_suspend@debugfs-reader.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [FAIL][48] ([i915#79]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [SKIP][50] ([i915#5176]) -> [PASS][51] +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb6/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][52] ([fdo#109441]) -> [PASS][53] +3 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb6/igt@kms_psr@psr2_no_drrs.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][54] ([i915#658]) -> [SKIP][55] ([i915#588])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb3/igt@i915_pm_dc@dc3co-vpb-simulation.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][56] ([i915#658]) -> [SKIP][57] ([i915#2920])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb3/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][58] ([i915#2920]) -> [SKIP][59] ([fdo#111068] / [i915#658])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][60] ([fdo#111068] / [i915#658]) -> [SKIP][61] ([i915#2920])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-iclb7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
* igt@runner@aborted:
- shard-apl: ([FAIL][62], [FAIL][63], [FAIL][64], [FAIL][65], [FAIL][66]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][67], [FAIL][68], [FAIL][69], [FAIL][70], [FAIL][71], [FAIL][72]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-apl6/igt@runner@aborted.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-apl7/igt@runner@aborted.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-apl7/igt@runner@aborted.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-apl2/igt@runner@aborted.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12041/shard-apl2/igt@runner@aborted.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl3/igt@runner@aborted.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl3/igt@runner@aborted.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl6/igt@runner@aborted.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl2/igt@runner@aborted.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl6/igt@runner@aborted.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/shard-apl2/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#4998]: https://gitlab.freedesktop.org/drm/intel/issues/4998
[i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6375]: https://gitlab.freedesktop.org/drm/intel/issues/6375
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12041 -> Patchwork_107877v1
CI-20190529: 20190529
CI_DRM_12041: 39caa74872844a95d9d2423e97ad497c1f8d1f30 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6637: a23e8aed0b54018339647d0817267431bd2b7075 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107877v1: 39caa74872844a95d9d2423e97ad497c1f8d1f30 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107877v1/index.html
[-- Attachment #2: Type: text/html, Size: 21997 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure
2022-08-29 12:04 ` [Intel-gfx] " Nirmoy Das
@ 2022-08-31 15:50 ` Matthew Auld
-1 siblings, 0 replies; 8+ messages in thread
From: Matthew Auld @ 2022-08-31 15:50 UTC (permalink / raw)
To: Nirmoy Das, intel-gfx; +Cc: thomas.hellstrom, chris.p.wilson, dri-devel
On 29/08/2022 13:04, Nirmoy Das wrote:
> On system suspend when system memory is low then i915_gem_obj_copy_ttm()
> could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough,
> suspend shouldn't continue if i915_ttm_backup() throws an error.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6529
Does this fix it? Does CI not complain about the drm_err? Also do we
know what the actual error was?
> Suggested-by: Chris P Wilson <chris.p.wilson@intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Passing the error along seems reasonable to me,
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> index 9aad84059d56..6f5d5c0909b4 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> @@ -79,7 +79,12 @@ static int i915_ttm_backup(struct i915_gem_apply_to_region *apply,
> goto out_no_populate;
>
> err = i915_gem_obj_copy_ttm(backup, obj, pm_apply->allow_gpu, false);
> - GEM_WARN_ON(err);
> + if (err) {
> + drm_err(&i915->drm,
> + "Unable to copy from device to system memory, err:%d\n",
> + err);
> + goto out_no_populate;
> + }
> ttm_bo_wait_ctx(backup_bo, &ctx);
>
> obj->ttm.backup = backup;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure
@ 2022-08-31 15:50 ` Matthew Auld
0 siblings, 0 replies; 8+ messages in thread
From: Matthew Auld @ 2022-08-31 15:50 UTC (permalink / raw)
To: Nirmoy Das, intel-gfx; +Cc: thomas.hellstrom, chris.p.wilson, dri-devel
On 29/08/2022 13:04, Nirmoy Das wrote:
> On system suspend when system memory is low then i915_gem_obj_copy_ttm()
> could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough,
> suspend shouldn't continue if i915_ttm_backup() throws an error.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6529
Does this fix it? Does CI not complain about the drm_err? Also do we
know what the actual error was?
> Suggested-by: Chris P Wilson <chris.p.wilson@intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Passing the error along seems reasonable to me,
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> index 9aad84059d56..6f5d5c0909b4 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> @@ -79,7 +79,12 @@ static int i915_ttm_backup(struct i915_gem_apply_to_region *apply,
> goto out_no_populate;
>
> err = i915_gem_obj_copy_ttm(backup, obj, pm_apply->allow_gpu, false);
> - GEM_WARN_ON(err);
> + if (err) {
> + drm_err(&i915->drm,
> + "Unable to copy from device to system memory, err:%d\n",
> + err);
> + goto out_no_populate;
> + }
> ttm_bo_wait_ctx(backup_bo, &ctx);
>
> obj->ttm.backup = backup;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure
2022-08-31 15:50 ` [Intel-gfx] " Matthew Auld
(?)
@ 2022-08-31 16:09 ` Das, Nirmoy
-1 siblings, 0 replies; 8+ messages in thread
From: Das, Nirmoy @ 2022-08-31 16:09 UTC (permalink / raw)
To: Matthew Auld, Nirmoy Das, intel-gfx
Cc: thomas.hellstrom, dri-devel, chris.p.wilson
On 8/31/2022 5:50 PM, Matthew Auld wrote:
> On 29/08/2022 13:04, Nirmoy Das wrote:
>> On system suspend when system memory is low then i915_gem_obj_copy_ttm()
>> could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough,
>> suspend shouldn't continue if i915_ttm_backup() throws an error.
>>
>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6529
>
> Does this fix it? Does CI not complain about the drm_err? Also do we
> know what the actual error was?
The error isn't reoccurring so the best guess is: large framebuffer copy
took long time and wait_for_suspend()
timed out. This needs more coverage from IGT and I am looking into
that. Let's ignore the "Closes" tag from this
patch till I come up a IGT test for this.
Nirmoy
>
>> Suggested-by: Chris P Wilson <chris.p.wilson@intel.com>
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
>
> Passing the error along seems reasonable to me,
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
>> b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
>> index 9aad84059d56..6f5d5c0909b4 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
>> @@ -79,7 +79,12 @@ static int i915_ttm_backup(struct
>> i915_gem_apply_to_region *apply,
>> goto out_no_populate;
>> err = i915_gem_obj_copy_ttm(backup, obj, pm_apply->allow_gpu,
>> false);
>> - GEM_WARN_ON(err);
>> + if (err) {
>> + drm_err(&i915->drm,
>> + "Unable to copy from device to system memory, err:%d\n",
>> + err);
>> + goto out_no_populate;
>> + }
>> ttm_bo_wait_ctx(backup_bo, &ctx);
>> obj->ttm.backup = backup;
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure
@ 2022-08-31 16:18 Nirmoy Das
0 siblings, 0 replies; 8+ messages in thread
From: Nirmoy Das @ 2022-08-31 16:18 UTC (permalink / raw)
To: intel-gfx; +Cc: thomas.hellstrom, matthew.auld, dri-devel, chris.p.wilson
On system suspend when system memory is low then i915_gem_obj_copy_ttm()
could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough,
suspend shouldn't continue if i915_ttm_backup() throws an error.
References: https://gitlab.freedesktop.org/drm/intel/-/issues/6529
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Suggested-by: Chris P Wilson <chris.p.wilson@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
index 9aad84059d56..6f5d5c0909b4 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
@@ -79,7 +79,12 @@ static int i915_ttm_backup(struct i915_gem_apply_to_region *apply,
goto out_no_populate;
err = i915_gem_obj_copy_ttm(backup, obj, pm_apply->allow_gpu, false);
- GEM_WARN_ON(err);
+ if (err) {
+ drm_err(&i915->drm,
+ "Unable to copy from device to system memory, err:%d\n",
+ err);
+ goto out_no_populate;
+ }
ttm_bo_wait_ctx(backup_bo, &ctx);
obj->ttm.backup = backup;
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-08-31 16:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 12:04 [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure Nirmoy Das
2022-08-29 12:04 ` [Intel-gfx] " Nirmoy Das
2022-08-29 15:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-08-31 6:09 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-08-31 15:50 ` [PATCH] " Matthew Auld
2022-08-31 15:50 ` [Intel-gfx] " Matthew Auld
2022-08-31 16:09 ` Das, Nirmoy
2022-08-31 16:18 Nirmoy Das
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.