* [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
@ 2022-08-30 8:51 Mitul Golani
2022-08-30 16:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7) Patchwork
` (3 more replies)
0 siblings, 4 replies; 19+ messages in thread
From: Mitul Golani @ 2022-08-30 8:51 UTC (permalink / raw)
To: intel-gfx
While executing i915_selftest, wakeref imbalance warning is seen
with i915_selftest failure.
Currently when Driver is suspended, while doing unregister
it is taking wakeref without resuming the device.
This patch is resuming the device, if driver is already suspended
and doing unregister process.
Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
drivers/gpu/drm/i915/i915_driver.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index 1332c70370a6..be0d51c04cc5 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -953,7 +953,9 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
void i915_driver_remove(struct drm_i915_private *i915)
{
- disable_rpm_wakeref_asserts(&i915->runtime_pm);
+ intel_wakeref_t wakeref;
+
+ wakeref = intel_runtime_pm_get(&i915->runtime_pm);
i915_driver_unregister(i915);
@@ -977,18 +979,19 @@ void i915_driver_remove(struct drm_i915_private *i915)
i915_driver_hw_remove(i915);
- enable_rpm_wakeref_asserts(&i915->runtime_pm);
+ intel_runtime_pm_put(&i915->runtime_pm, wakeref);
}
static void i915_driver_release(struct drm_device *dev)
{
struct drm_i915_private *dev_priv = to_i915(dev);
struct intel_runtime_pm *rpm = &dev_priv->runtime_pm;
+ intel_wakeref_t wakeref;
if (!dev_priv->do_release)
return;
- disable_rpm_wakeref_asserts(rpm);
+ wakeref = intel_runtime_pm_get(rpm);
i915_gem_driver_release(dev_priv);
@@ -999,7 +1002,8 @@ static void i915_driver_release(struct drm_device *dev)
i915_driver_mmio_release(dev_priv);
- enable_rpm_wakeref_asserts(rpm);
+ intel_runtime_pm_put(rpm, wakeref);
+
intel_runtime_pm_driver_release(rpm);
i915_driver_late_release(dev_priv);
--
2.25.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7)
2022-08-30 8:51 [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref Mitul Golani
@ 2022-08-30 16:42 ` Patchwork
2022-08-31 11:54 ` [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref Imre Deak
` (2 subsequent siblings)
3 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2022-08-30 16:42 UTC (permalink / raw)
To: Golani, Mitulkumar Ajitkumar; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4956 bytes --]
== Series Details ==
Series: drm/i915/display: Fix warning callstack for imbalance wakeref (rev7)
URL : https://patchwork.freedesktop.org/series/107211/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12050 -> Patchwork_107211v7
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/index.html
Participating hosts (39 -> 36)
------------------------------
Missing (3): fi-ctg-p8600 bat-dg2-10 fi-hsw-4200u
Known issues
------------
Here are the changes found in Patchwork_107211v7 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [PASS][1] -> [DMESG-FAIL][2] ([i915#4494] / [i915#4957])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [PASS][3] -> [DMESG-FAIL][4] ([i915#4528])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/fi-pnv-d510/igt@i915_selftest@live@requests.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-g3258: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/fi-hsw-g3258/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-hsw-4770: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@runner@aborted:
- fi-bdw-5557u: NOTRUN -> [FAIL][7] ([i915#4312])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/fi-bdw-5557u/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- {bat-rplp-1}: [DMESG-WARN][8] ([i915#2867]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][10] ([i915#4785]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
- fi-hsw-g3258: [INCOMPLETE][12] ([i915#3303] / [i915#4785]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- {bat-rpls-1}: [INCOMPLETE][14] ([i915#6257] / [i915#6380]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/bat-rpls-1/igt@i915_selftest@live@requests.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/bat-rpls-1/igt@i915_selftest@live@requests.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6380]: https://gitlab.freedesktop.org/drm/intel/issues/6380
Build changes
-------------
* Linux: CI_DRM_12050 -> Patchwork_107211v7
CI-20190529: 20190529
CI_DRM_12050: 1be2e4f9c0376496419ad26a35c516de050f746d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6638: 9338ab3ec085292817ab1e74d1f2fb90b6a98332 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107211v7: 1be2e4f9c0376496419ad26a35c516de050f746d @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
577178681c46 drm/i915/display: Fix warning callstack for imbalance wakeref
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/index.html
[-- Attachment #2: Type: text/html, Size: 5966 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
2022-08-30 8:51 [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref Mitul Golani
2022-08-30 16:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7) Patchwork
@ 2022-08-31 11:54 ` Imre Deak
2022-08-31 15:02 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7) Patchwork
2022-08-31 15:28 ` [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref Andrzej Hajda
3 siblings, 0 replies; 19+ messages in thread
From: Imre Deak @ 2022-08-31 11:54 UTC (permalink / raw)
To: Mitul Golani; +Cc: intel-gfx
On Tue, Aug 30, 2022 at 02:21:58PM +0530, Mitul Golani wrote:
> While executing i915_selftest, wakeref imbalance warning is seen
> with i915_selftest failure.
>
> Currently when Driver is suspended, while doing unregister
> it is taking wakeref without resuming the device.
> This patch is resuming the device, if driver is already suspended
> and doing unregister process.
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/i915_driver.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index 1332c70370a6..be0d51c04cc5 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -953,7 +953,9 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>
> void i915_driver_remove(struct drm_i915_private *i915)
> {
> - disable_rpm_wakeref_asserts(&i915->runtime_pm);
> + intel_wakeref_t wakeref;
> +
> + wakeref = intel_runtime_pm_get(&i915->runtime_pm);
>
> i915_driver_unregister(i915);
>
> @@ -977,18 +979,19 @@ void i915_driver_remove(struct drm_i915_private *i915)
>
> i915_driver_hw_remove(i915);
>
> - enable_rpm_wakeref_asserts(&i915->runtime_pm);
> + intel_runtime_pm_put(&i915->runtime_pm, wakeref);
> }
>
> static void i915_driver_release(struct drm_device *dev)
> {
> struct drm_i915_private *dev_priv = to_i915(dev);
> struct intel_runtime_pm *rpm = &dev_priv->runtime_pm;
> + intel_wakeref_t wakeref;
>
> if (!dev_priv->do_release)
> return;
>
> - disable_rpm_wakeref_asserts(rpm);
> + wakeref = intel_runtime_pm_get(rpm);
>
> i915_gem_driver_release(dev_priv);
>
> @@ -999,7 +1002,8 @@ static void i915_driver_release(struct drm_device *dev)
>
> i915_driver_mmio_release(dev_priv);
>
> - enable_rpm_wakeref_asserts(rpm);
> + intel_runtime_pm_put(rpm, wakeref);
> +
> intel_runtime_pm_driver_release(rpm);
>
> i915_driver_late_release(dev_priv);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7)
2022-08-30 8:51 [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref Mitul Golani
2022-08-30 16:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7) Patchwork
2022-08-31 11:54 ` [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref Imre Deak
@ 2022-08-31 15:02 ` Patchwork
2022-09-01 11:14 ` Imre Deak
2022-08-31 15:28 ` [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref Andrzej Hajda
3 siblings, 1 reply; 19+ messages in thread
From: Patchwork @ 2022-08-31 15:02 UTC (permalink / raw)
To: Golani, Mitulkumar Ajitkumar; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 32734 bytes --]
== Series Details ==
Series: drm/i915/display: Fix warning callstack for imbalance wakeref (rev7)
URL : https://patchwork.freedesktop.org/series/107211/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12050_full -> Patchwork_107211v7_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (11 -> 12)
------------------------------
Additional (1): shard-rkl
Known issues
------------
Here are the changes found in Patchwork_107211v7_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_param@set-priority-not-supported:
- shard-tglb: NOTRUN -> [SKIP][1] ([fdo#109314])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@gem_ctx_param@set-priority-not-supported.html
* igt@gem_ctx_persistence@engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +2 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb4/igt@gem_ctx_persistence@engines-mixed-process.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-iclb: [PASS][3] -> [TIMEOUT][4] ([i915#3070])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-iclb7/igt@gem_eio@in-flight-contexts-1us.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb8/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_eio@unwedge-stress:
- shard-snb: NOTRUN -> [FAIL][5] ([i915#3354])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][6] -> [FAIL][7] ([i915#2846])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl7/igt@gem_exec_fair@basic-deadline.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl7/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][8] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb2/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-apl: NOTRUN -> [FAIL][9] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl7/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-tglb: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][14] -> [SKIP][15] ([i915#2190])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb1/igt@gem_huc_copy@huc-copy.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb6/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-apl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#4613]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl7/igt@gem_lmem_swapping@heavy-verify-random-ccs.html
* igt@gem_lmem_swapping@smem-oom:
- shard-kbl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4613])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@gem_lmem_swapping@smem-oom.html
* igt@gem_mmap_gtt@fault-concurrent-x:
- shard-snb: NOTRUN -> [INCOMPLETE][18] ([i915#5161])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb6/igt@gem_mmap_gtt@fault-concurrent-x.html
* igt@gem_pwrite@basic-exhaustion:
- shard-snb: NOTRUN -> [WARN][19] ([i915#2658])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb4/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-tglb: NOTRUN -> [SKIP][20] ([i915#3297])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][21] ([i915#2724])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb4/igt@gem_userptr_blits@vma-merge.html
* igt@gen9_exec_parse@allowed-single:
- shard-kbl: [PASS][22] -> [DMESG-WARN][23] ([i915#5566] / [i915#716])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@gen9_exec_parse@allowed-single.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@gen9_exec_parse@allowed-single.html
- shard-apl: [PASS][24] -> [DMESG-WARN][25] ([i915#5566] / [i915#716])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl6/igt@gen9_exec_parse@allowed-single.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl6/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@unaligned-access:
- shard-tglb: NOTRUN -> [SKIP][26] ([i915#2527] / [i915#2856])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@gen9_exec_parse@unaligned-access.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#1937])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][28] -> [INCOMPLETE][29] ([i915#3921])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-snb6/igt@i915_selftest@live@hangcheck.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb4/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][30] -> [DMESG-WARN][31] ([i915#180]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl1/igt@i915_suspend@debugfs-reader.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl3/igt@i915_suspend@debugfs-reader.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#111614]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_big_fb@x-tiled-8bpp-rotate-90.html
* igt@kms_ccs@pipe-a-random-ccs-data-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][33] ([fdo#111615] / [i915#3689])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_ccs@pipe-a-random-ccs-data-yf_tiled_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3886]) +7 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl7/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3886]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl7/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][36] ([i915#6095])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_chamelium@hdmi-audio-edid:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#109284] / [fdo#111827]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_chamelium@hdmi-audio-edid.html
* igt@kms_chamelium@vga-hpd:
- shard-snb: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +3 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb4/igt@kms_chamelium@vga-hpd.html
* igt@kms_color_chamelium@ctm-blue-to-red:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl2/igt@kms_color_chamelium@ctm-blue-to-red.html
* igt@kms_color_chamelium@ctm-red-to-blue:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +7 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl1/igt@kms_color_chamelium@ctm-red-to-blue.html
* igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1:
- shard-kbl: [PASS][41] -> [DMESG-WARN][42] ([i915#180]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl7/igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1.html
* igt@kms_flip@2x-flip-vs-suspend-interruptible:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#109274] / [fdo#111825] / [i915#3637])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][44] ([i915#2672]) +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb6/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][45] ([i915#3555])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][46] ([i915#6497])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-snb: NOTRUN -> [SKIP][47] ([fdo#109271]) +274 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb4/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271]) +85 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-render:
- shard-tglb: NOTRUN -> [SKIP][49] ([fdo#109280] / [fdo#111825]) +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-render.html
* igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1:
- shard-kbl: [PASS][50] -> [FAIL][51] ([i915#1188]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][52] ([fdo#108145] / [i915#265])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
* igt@kms_plane_multiple@atomic-pipe-d-tiling-x:
- shard-apl: NOTRUN -> [SKIP][53] ([fdo#109271]) +117 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl2/igt@kms_plane_multiple@atomic-pipe-d-tiling-x.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#658])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl3/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-kbl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#658]) +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl1/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][56] -> [SKIP][57] ([fdo#109441]) +3 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb5/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [PASS][58] -> [SKIP][59] ([i915#5519])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb6/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb5/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
* igt@kms_setmode@clone-exclusive-crtc:
- shard-tglb: NOTRUN -> [SKIP][60] ([i915#3555])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_setmode@clone-exclusive-crtc.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#533])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl7/igt@kms_vblank@pipe-d-wait-idle.html
* igt@nouveau_crc@ctx-flip-threshold-reset-after-capture:
- shard-tglb: NOTRUN -> [SKIP][62] ([i915#2530])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@nouveau_crc@ctx-flip-threshold-reset-after-capture.html
* igt@perf@polling-parameterized:
- shard-tglb: [PASS][63] -> [FAIL][64] ([i915#5639])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb3/igt@perf@polling-parameterized.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb2/igt@perf@polling-parameterized.html
* igt@prime_nv_api@nv_self_import:
- shard-tglb: NOTRUN -> [SKIP][65] ([fdo#109291])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@prime_nv_api@nv_self_import.html
* igt@sysfs_clients@create:
- shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#2994]) +2 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl1/igt@sysfs_clients@create.html
* igt@sysfs_clients@split-10:
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#2994])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@sysfs_clients@split-10.html
#### Possible fixes ####
* igt@device_reset@unbind-reset-rebind:
- shard-tglb: [INCOMPLETE][68] -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb2/igt@device_reset@unbind-reset-rebind.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@device_reset@unbind-reset-rebind.html
* igt@gem_busy@close-race:
- shard-snb: [TIMEOUT][70] ([i915#5748]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-snb4/igt@gem_busy@close-race.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb6/igt@gem_busy@close-race.html
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-kbl: [DMESG-WARN][72] ([i915#180]) -> [PASS][73] +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-tglb: [FAIL][74] ([i915#2842]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb5/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][76] ([i915#2842]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][78] ([i915#2842]) -> [PASS][79] +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][80] ([i915#180]) -> [PASS][81] +5 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl1/igt@i915_suspend@sysfs-reader.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl7/igt@i915_suspend@sysfs-reader.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-tglb: [FAIL][82] ([i915#3743]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb2/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_cursor_legacy@cursor-vs-flip@legacy:
- shard-iclb: [FAIL][84] ([i915#5072]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-iclb7/igt@kms_cursor_legacy@cursor-vs-flip@legacy.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb1/igt@kms_cursor_legacy@cursor-vs-flip@legacy.html
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-kbl: [DMESG-FAIL][86] ([i915#180]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][88] ([fdo#109441]) -> [PASS][89] +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
#### Warnings ####
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [FAIL][90] ([i915#4767]) -> [INCOMPLETE][91] ([i915#180] / [i915#4939] / [i915#6598])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][92] ([fdo#111068] / [i915#658]) -> [SKIP][93] ([i915#2920])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-iclb6/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@runner@aborted:
- shard-apl: ([FAIL][94], [FAIL][95], [FAIL][96], [FAIL][97], [FAIL][98], [FAIL][99], [FAIL][100], [FAIL][101]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][102], [FAIL][103], [FAIL][104], [FAIL][105], [FAIL][106]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl3/igt@runner@aborted.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl1/igt@runner@aborted.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl8/igt@runner@aborted.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl2/igt@runner@aborted.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl3/igt@runner@aborted.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl1/igt@runner@aborted.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl7/igt@runner@aborted.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl7/igt@runner@aborted.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl6/igt@runner@aborted.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl1/igt@runner@aborted.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl6/igt@runner@aborted.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl1/igt@runner@aborted.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl3/igt@runner@aborted.html
- shard-kbl: ([FAIL][107], [FAIL][108], [FAIL][109], [FAIL][110], [FAIL][111], [FAIL][112], [FAIL][113]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#716] / [i915#92])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl1/igt@runner@aborted.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@runner@aborted.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@runner@aborted.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@runner@aborted.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@runner@aborted.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@runner@aborted.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@runner@aborted.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl1/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3354]: https://gitlab.freedesktop.org/drm/intel/issues/3354
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072
[i915#5161]: https://gitlab.freedesktop.org/drm/intel/issues/5161
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5748]: https://gitlab.freedesktop.org/drm/intel/issues/5748
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* Linux: CI_DRM_12050 -> Patchwork_107211v7
CI-20190529: 20190529
CI_DRM_12050: 1be2e4f9c0376496419ad26a35c516de050f746d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6638: 9338ab3ec085292817ab1e74d1f2fb90b6a98332 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107211v7: 1be2e4f9c0376496419ad26a35c516de050f746d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/index.html
[-- Attachment #2: Type: text/html, Size: 35142 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
2022-08-30 8:51 [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref Mitul Golani
` (2 preceding siblings ...)
2022-08-31 15:02 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7) Patchwork
@ 2022-08-31 15:28 ` Andrzej Hajda
3 siblings, 0 replies; 19+ messages in thread
From: Andrzej Hajda @ 2022-08-31 15:28 UTC (permalink / raw)
To: Mitul Golani, intel-gfx
On 30.08.2022 10:51, Mitul Golani wrote:
> While executing i915_selftest, wakeref imbalance warning is seen
> with i915_selftest failure.
>
> Currently when Driver is suspended, while doing unregister
> it is taking wakeref without resuming the device.
> This patch is resuming the device, if driver is already suspended
> and doing unregister process.
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7)
2022-08-31 15:02 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7) Patchwork
@ 2022-09-01 11:14 ` Imre Deak
0 siblings, 0 replies; 19+ messages in thread
From: Imre Deak @ 2022-09-01 11:14 UTC (permalink / raw)
To: intel-gfx
On Wed, Aug 31, 2022 at 03:02:10PM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/display: Fix warning callstack for imbalance wakeref (rev7)
> URL : https://patchwork.freedesktop.org/series/107211/
> State : success
Thanks for the patch, pushed to drm-intel-next.
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12050_full -> Patchwork_107211v7_full
> ====================================================
>
> Summary
> -------
>
> **SUCCESS**
>
> No regressions found.
>
>
>
> Participating hosts (11 -> 12)
> ------------------------------
>
> Additional (1): shard-rkl
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_107211v7_full that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@gem_ctx_param@set-priority-not-supported:
> - shard-tglb: NOTRUN -> [SKIP][1] ([fdo#109314])
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@gem_ctx_param@set-priority-not-supported.html
>
> * igt@gem_ctx_persistence@engines-mixed-process:
> - shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +2 similar issues
> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb4/igt@gem_ctx_persistence@engines-mixed-process.html
>
> * igt@gem_eio@in-flight-contexts-1us:
> - shard-iclb: [PASS][3] -> [TIMEOUT][4] ([i915#3070])
> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-iclb7/igt@gem_eio@in-flight-contexts-1us.html
> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb8/igt@gem_eio@in-flight-contexts-1us.html
>
> * igt@gem_eio@unwedge-stress:
> - shard-snb: NOTRUN -> [FAIL][5] ([i915#3354])
> [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb6/igt@gem_eio@unwedge-stress.html
>
> * igt@gem_exec_fair@basic-deadline:
> - shard-kbl: [PASS][6] -> [FAIL][7] ([i915#2846])
> [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl7/igt@gem_exec_fair@basic-deadline.html
> [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl7/igt@gem_exec_fair@basic-deadline.html
>
> * igt@gem_exec_fair@basic-none@vcs1:
> - shard-iclb: NOTRUN -> [FAIL][8] ([i915#2842])
> [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb2/igt@gem_exec_fair@basic-none@vcs1.html
>
> * igt@gem_exec_fair@basic-pace-share@rcs0:
> - shard-apl: NOTRUN -> [FAIL][9] ([i915#2842])
> [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl7/igt@gem_exec_fair@basic-pace-share@rcs0.html
> - shard-tglb: [PASS][10] -> [FAIL][11] ([i915#2842])
> [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
> [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
>
> * igt@gem_exec_fair@basic-pace@rcs0:
> - shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842]) +3 similar issues
> [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
> [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
>
> * igt@gem_huc_copy@huc-copy:
> - shard-tglb: [PASS][14] -> [SKIP][15] ([i915#2190])
> [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb1/igt@gem_huc_copy@huc-copy.html
> [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb6/igt@gem_huc_copy@huc-copy.html
>
> * igt@gem_lmem_swapping@heavy-verify-random-ccs:
> - shard-apl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#4613]) +2 similar issues
> [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl7/igt@gem_lmem_swapping@heavy-verify-random-ccs.html
>
> * igt@gem_lmem_swapping@smem-oom:
> - shard-kbl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4613])
> [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@gem_lmem_swapping@smem-oom.html
>
> * igt@gem_mmap_gtt@fault-concurrent-x:
> - shard-snb: NOTRUN -> [INCOMPLETE][18] ([i915#5161])
> [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb6/igt@gem_mmap_gtt@fault-concurrent-x.html
>
> * igt@gem_pwrite@basic-exhaustion:
> - shard-snb: NOTRUN -> [WARN][19] ([i915#2658])
> [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb4/igt@gem_pwrite@basic-exhaustion.html
>
> * igt@gem_userptr_blits@dmabuf-unsync:
> - shard-tglb: NOTRUN -> [SKIP][20] ([i915#3297])
> [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@gem_userptr_blits@dmabuf-unsync.html
>
> * igt@gem_userptr_blits@vma-merge:
> - shard-snb: NOTRUN -> [FAIL][21] ([i915#2724])
> [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb4/igt@gem_userptr_blits@vma-merge.html
>
> * igt@gen9_exec_parse@allowed-single:
> - shard-kbl: [PASS][22] -> [DMESG-WARN][23] ([i915#5566] / [i915#716])
> [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@gen9_exec_parse@allowed-single.html
> [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@gen9_exec_parse@allowed-single.html
> - shard-apl: [PASS][24] -> [DMESG-WARN][25] ([i915#5566] / [i915#716])
> [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl6/igt@gen9_exec_parse@allowed-single.html
> [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl6/igt@gen9_exec_parse@allowed-single.html
>
> * igt@gen9_exec_parse@unaligned-access:
> - shard-tglb: NOTRUN -> [SKIP][26] ([i915#2527] / [i915#2856])
> [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@gen9_exec_parse@unaligned-access.html
>
> * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
> - shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#1937])
> [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
>
> * igt@i915_selftest@live@hangcheck:
> - shard-snb: [PASS][28] -> [INCOMPLETE][29] ([i915#3921])
> [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-snb6/igt@i915_selftest@live@hangcheck.html
> [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb4/igt@i915_selftest@live@hangcheck.html
>
> * igt@i915_suspend@debugfs-reader:
> - shard-apl: [PASS][30] -> [DMESG-WARN][31] ([i915#180]) +1 similar issue
> [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl1/igt@i915_suspend@debugfs-reader.html
> [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl3/igt@i915_suspend@debugfs-reader.html
>
> * igt@kms_big_fb@x-tiled-8bpp-rotate-90:
> - shard-tglb: NOTRUN -> [SKIP][32] ([fdo#111614]) +1 similar issue
> [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_big_fb@x-tiled-8bpp-rotate-90.html
>
> * igt@kms_ccs@pipe-a-random-ccs-data-yf_tiled_ccs:
> - shard-tglb: NOTRUN -> [SKIP][33] ([fdo#111615] / [i915#3689])
> [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_ccs@pipe-a-random-ccs-data-yf_tiled_ccs.html
>
> * igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
> - shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3886]) +7 similar issues
> [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl7/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
>
> * igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
> - shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3886]) +3 similar issues
> [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl7/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
>
> * igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs_cc:
> - shard-tglb: NOTRUN -> [SKIP][36] ([i915#6095])
> [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs_cc.html
>
> * igt@kms_chamelium@hdmi-audio-edid:
> - shard-tglb: NOTRUN -> [SKIP][37] ([fdo#109284] / [fdo#111827]) +1 similar issue
> [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_chamelium@hdmi-audio-edid.html
>
> * igt@kms_chamelium@vga-hpd:
> - shard-snb: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +3 similar issues
> [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb4/igt@kms_chamelium@vga-hpd.html
>
> * igt@kms_color_chamelium@ctm-blue-to-red:
> - shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +3 similar issues
> [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl2/igt@kms_color_chamelium@ctm-blue-to-red.html
>
> * igt@kms_color_chamelium@ctm-red-to-blue:
> - shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +7 similar issues
> [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl1/igt@kms_color_chamelium@ctm-red-to-blue.html
>
> * igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1:
> - shard-kbl: [PASS][41] -> [DMESG-WARN][42] ([i915#180]) +2 similar issues
> [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl7/igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1.html
> [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1.html
>
> * igt@kms_flip@2x-flip-vs-suspend-interruptible:
> - shard-tglb: NOTRUN -> [SKIP][43] ([fdo#109274] / [fdo#111825] / [i915#3637])
> [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
>
> * igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
> - shard-iclb: NOTRUN -> [SKIP][44] ([i915#2672]) +2 similar issues
> [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb6/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html
>
> * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
> - shard-iclb: NOTRUN -> [SKIP][45] ([i915#3555])
> [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
>
> * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt:
> - shard-tglb: NOTRUN -> [SKIP][46] ([i915#6497])
> [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
>
> * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-cpu:
> - shard-snb: NOTRUN -> [SKIP][47] ([fdo#109271]) +274 similar issues
> [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb4/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-cpu.html
>
> * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff:
> - shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271]) +85 similar issues
> [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff.html
>
> * igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-render:
> - shard-tglb: NOTRUN -> [SKIP][49] ([fdo#109280] / [fdo#111825]) +3 similar issues
> [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-render.html
>
> * igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1:
> - shard-kbl: [PASS][50] -> [FAIL][51] ([i915#1188]) +1 similar issue
> [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
> [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
>
> * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
> - shard-kbl: NOTRUN -> [FAIL][52] ([fdo#108145] / [i915#265])
> [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
>
> * igt@kms_plane_multiple@atomic-pipe-d-tiling-x:
> - shard-apl: NOTRUN -> [SKIP][53] ([fdo#109271]) +117 similar issues
> [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl2/igt@kms_plane_multiple@atomic-pipe-d-tiling-x.html
>
> * igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
> - shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#658])
> [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl3/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
>
> * igt@kms_psr2_su@page_flip-xrgb8888:
> - shard-kbl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#658]) +2 similar issues
> [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl1/igt@kms_psr2_su@page_flip-xrgb8888.html
>
> * igt@kms_psr@psr2_cursor_blt:
> - shard-iclb: [PASS][56] -> [SKIP][57] ([fdo#109441]) +3 similar issues
> [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
> [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb5/igt@kms_psr@psr2_cursor_blt.html
>
> * igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
> - shard-tglb: [PASS][58] -> [SKIP][59] ([i915#5519])
> [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb6/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
> [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb5/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
>
> * igt@kms_setmode@clone-exclusive-crtc:
> - shard-tglb: NOTRUN -> [SKIP][60] ([i915#3555])
> [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_setmode@clone-exclusive-crtc.html
>
> * igt@kms_vblank@pipe-d-wait-idle:
> - shard-kbl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#533])
> [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl7/igt@kms_vblank@pipe-d-wait-idle.html
>
> * igt@nouveau_crc@ctx-flip-threshold-reset-after-capture:
> - shard-tglb: NOTRUN -> [SKIP][62] ([i915#2530])
> [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@nouveau_crc@ctx-flip-threshold-reset-after-capture.html
>
> * igt@perf@polling-parameterized:
> - shard-tglb: [PASS][63] -> [FAIL][64] ([i915#5639])
> [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb3/igt@perf@polling-parameterized.html
> [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb2/igt@perf@polling-parameterized.html
>
> * igt@prime_nv_api@nv_self_import:
> - shard-tglb: NOTRUN -> [SKIP][65] ([fdo#109291])
> [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@prime_nv_api@nv_self_import.html
>
> * igt@sysfs_clients@create:
> - shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#2994]) +2 similar issues
> [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl1/igt@sysfs_clients@create.html
>
> * igt@sysfs_clients@split-10:
> - shard-tglb: NOTRUN -> [SKIP][67] ([i915#2994])
> [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@sysfs_clients@split-10.html
>
>
> #### Possible fixes ####
>
> * igt@device_reset@unbind-reset-rebind:
> - shard-tglb: [INCOMPLETE][68] -> [PASS][69]
> [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb2/igt@device_reset@unbind-reset-rebind.html
> [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@device_reset@unbind-reset-rebind.html
>
> * igt@gem_busy@close-race:
> - shard-snb: [TIMEOUT][70] ([i915#5748]) -> [PASS][71]
> [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-snb4/igt@gem_busy@close-race.html
> [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-snb6/igt@gem_busy@close-race.html
>
> * igt@gem_ctx_isolation@preservation-s3@bcs0:
> - shard-kbl: [DMESG-WARN][72] ([i915#180]) -> [PASS][73] +1 similar issue
> [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@gem_ctx_isolation@preservation-s3@bcs0.html
> [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@gem_ctx_isolation@preservation-s3@bcs0.html
>
> * igt@gem_exec_fair@basic-pace-solo@rcs0:
> - shard-tglb: [FAIL][74] ([i915#2842]) -> [PASS][75]
> [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb5/igt@gem_exec_fair@basic-pace-solo@rcs0.html
> [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
>
> * igt@gem_exec_fair@basic-pace@vcs1:
> - shard-kbl: [FAIL][76] ([i915#2842]) -> [PASS][77]
> [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
> [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
>
> * igt@gem_exec_fair@basic-throttle@rcs0:
> - shard-iclb: [FAIL][78] ([i915#2842]) -> [PASS][79] +1 similar issue
> [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html
> [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
>
> * igt@i915_suspend@sysfs-reader:
> - shard-apl: [DMESG-WARN][80] ([i915#180]) -> [PASS][81] +5 similar issues
> [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl1/igt@i915_suspend@sysfs-reader.html
> [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl7/igt@i915_suspend@sysfs-reader.html
>
> * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
> - shard-tglb: [FAIL][82] ([i915#3743]) -> [PASS][83]
> [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-tglb2/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
> [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-tglb7/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
>
> * igt@kms_cursor_legacy@cursor-vs-flip@legacy:
> - shard-iclb: [FAIL][84] ([i915#5072]) -> [PASS][85]
> [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-iclb7/igt@kms_cursor_legacy@cursor-vs-flip@legacy.html
> [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb1/igt@kms_cursor_legacy@cursor-vs-flip@legacy.html
>
> * igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
> - shard-kbl: [DMESG-FAIL][86] ([i915#180]) -> [PASS][87]
> [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
> [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
>
> * igt@kms_psr@psr2_sprite_plane_move:
> - shard-iclb: [SKIP][88] ([fdo#109441]) -> [PASS][89] +2 similar issues
> [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
> [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
>
>
> #### Warnings ####
>
> * igt@kms_fbcon_fbt@fbc-suspend:
> - shard-kbl: [FAIL][90] ([i915#4767]) -> [INCOMPLETE][91] ([i915#180] / [i915#4939] / [i915#6598])
> [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
> [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html
>
> * igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
> - shard-iclb: [SKIP][92] ([fdo#111068] / [i915#658]) -> [SKIP][93] ([i915#2920])
> [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-iclb6/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
> [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
>
> * igt@runner@aborted:
> - shard-apl: ([FAIL][94], [FAIL][95], [FAIL][96], [FAIL][97], [FAIL][98], [FAIL][99], [FAIL][100], [FAIL][101]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][102], [FAIL][103], [FAIL][104], [FAIL][105], [FAIL][106]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
> [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl3/igt@runner@aborted.html
> [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl1/igt@runner@aborted.html
> [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl8/igt@runner@aborted.html
> [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl2/igt@runner@aborted.html
> [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl3/igt@runner@aborted.html
> [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl1/igt@runner@aborted.html
> [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl7/igt@runner@aborted.html
> [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-apl7/igt@runner@aborted.html
> [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl6/igt@runner@aborted.html
> [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl1/igt@runner@aborted.html
> [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl6/igt@runner@aborted.html
> [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl1/igt@runner@aborted.html
> [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-apl3/igt@runner@aborted.html
> - shard-kbl: ([FAIL][107], [FAIL][108], [FAIL][109], [FAIL][110], [FAIL][111], [FAIL][112], [FAIL][113]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#716] / [i915#92])
> [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl1/igt@runner@aborted.html
> [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@runner@aborted.html
> [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@runner@aborted.html
> [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@runner@aborted.html
> [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@runner@aborted.html
> [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@runner@aborted.html
> [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12050/shard-kbl4/igt@runner@aborted.html
> [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
> [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
> [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
> [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
> [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
> [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl1/igt@runner@aborted.html
> [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
> [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
> [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/shard-kbl4/igt@runner@aborted.html
>
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
> [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
> [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
> [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
> [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
> [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
> [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
> [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
> [fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
> [fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
> [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
> [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
> [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
> [fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
> [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
> [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
> [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
> [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
> [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
> [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
> [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
> [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
> [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
> [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
> [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
> [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
> [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
> [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
> [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
> [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
> [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
> [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
> [i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
> [i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
> [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
> [i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
> [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
> [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
> [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
> [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
> [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
> [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
> [i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
> [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
> [i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
> [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
> [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
> [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
> [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
> [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
> [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
> [i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070
> [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
> [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
> [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
> [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
> [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
> [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
> [i915#3354]: https://gitlab.freedesktop.org/drm/intel/issues/3354
> [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
> [i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
> [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
> [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
> [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
> [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
> [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
> [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
> [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
> [i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
> [i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
> [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
> [i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
> [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
> [i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
> [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
> [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
> [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
> [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
> [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
> [i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
> [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
> [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
> [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
> [i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
> [i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
> [i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072
> [i915#5161]: https://gitlab.freedesktop.org/drm/intel/issues/5161
> [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
> [i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
> [i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
> [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
> [i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
> [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
> [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
> [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
> [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
> [i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
> [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
> [i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
> [i915#5748]: https://gitlab.freedesktop.org/drm/intel/issues/5748
> [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
> [i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
> [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
> [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
> [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
> [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
> [i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
> [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
> [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
> [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
> [i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
> [i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
> [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
> [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
>
>
> Build changes
> -------------
>
> * Linux: CI_DRM_12050 -> Patchwork_107211v7
>
> CI-20190529: 20190529
> CI_DRM_12050: 1be2e4f9c0376496419ad26a35c516de050f746d @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_6638: 9338ab3ec085292817ab1e74d1f2fb90b6a98332 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_107211v7: 1be2e4f9c0376496419ad26a35c516de050f746d @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v7/index.html
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
2022-08-29 14:46 ` Imre Deak
@ 2022-08-29 16:59 ` Golani, Mitulkumar Ajitkumar
0 siblings, 0 replies; 19+ messages in thread
From: Golani, Mitulkumar Ajitkumar @ 2022-08-29 16:59 UTC (permalink / raw)
To: Deak, Imre; +Cc: intel-gfx
Hi Imre,
> -----Original Message-----
> From: Deak, Imre <imre.deak@intel.com>
> Sent: 29 August 2022 20:16
> To: Golani, Mitulkumar Ajitkumar <mitulkumar.ajitkumar.golani@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for
> imbalance wakeref
>
> On Mon, Aug 29, 2022 at 09:45:53AM +0300, Golani, Mitulkumar Ajitkumar
> wrote:
> > Hi Imre,
> >
> > > [...]
> > > Still not sure what's going. Both i915_pci_probe() and
> > > i915_pci_remove()->i915_driver_remove() is called with a runtime PM
> > > reference - taken at local_pci_probe() and pci_device_remove() - and
> > > so the device should be runtime resumed at those points.
> > >
> >
> > Yes reference is being taken at local_pci_probe() and
> > pci_device_remove() but During i915_selftest@perf, it is loading and
> > unloading i915_pci_probe() and i915_pci_remove(), here
> > pci_device_remove() is not being called, that's why runtime PM reference is
> not present during i915_driver_remove().
>
> Ok, that explains it. Taking an actual RPM reference unconditionally in
> i915_driver_remove() should fix this (instead of the
> disable/enable_rpm_wakeref_asserts() calls there):
>
> wakeref = intel_runtime_pm_get();
> ...
> intel_runtime_pm_put(wakeref);
>
> While at it the same change should be applied in i915_driver_release() as
> well for consistency.
>
Thanks Imre. Verified on Target. This works.
Pushed changes : https://patchwork.freedesktop.org/patch/500180/?series=107211&rev=6
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
2022-08-29 6:45 ` Golani, Mitulkumar Ajitkumar
@ 2022-08-29 14:46 ` Imre Deak
2022-08-29 16:59 ` Golani, Mitulkumar Ajitkumar
0 siblings, 1 reply; 19+ messages in thread
From: Imre Deak @ 2022-08-29 14:46 UTC (permalink / raw)
To: Golani, Mitulkumar Ajitkumar; +Cc: intel-gfx
On Mon, Aug 29, 2022 at 09:45:53AM +0300, Golani, Mitulkumar Ajitkumar wrote:
> Hi Imre,
>
> > [...]
> > Still not sure what's going. Both i915_pci_probe() and
> > i915_pci_remove()->i915_driver_remove() is called with a runtime PM
> > reference - taken at local_pci_probe() and pci_device_remove() - and so the
> > device should be runtime resumed at those points.
> >
>
> Yes reference is being taken at local_pci_probe() and pci_device_remove() but
> During i915_selftest@perf, it is loading and unloading i915_pci_probe() and
> i915_pci_remove(), here pci_device_remove() is not being called, that's why
> runtime PM reference is not present during i915_driver_remove().
Ok, that explains it. Taking an actual RPM reference unconditionally in
i915_driver_remove() should fix this (instead of the
disable/enable_rpm_wakeref_asserts() calls there):
wakeref = intel_runtime_pm_get();
...
intel_runtime_pm_put(wakeref);
While at it the same change should be applied in i915_driver_release()
as well for consistency.
> > > > > > disable_rpm_wakeref_asserts(rpm);
> > > > > >
> > > > > > intel_opregion_notify_adapter(dev_priv, PCI_D0);
> > > > > > --
> > > > > > 2.25.1
> > > > > >
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
@ 2022-08-29 8:31 Mitul Golani
0 siblings, 0 replies; 19+ messages in thread
From: Mitul Golani @ 2022-08-29 8:31 UTC (permalink / raw)
To: intel-gfx
While executing i915_selftest, wakeref imbalance warning is seen
with i915_selftest failure.
Currently when Driver is suspended, while doing unregister
it is taking wakeref without resuming the device.
This patch is resuming the device, if driver is already suspended
and doing unregister process. It will check the suspend state and
if driver is not resumed before taking wakeref then resume before
it.
Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
drivers/gpu/drm/i915/i915_driver.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index 1332c70370a6..281bf6cd5e4c 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -953,7 +953,11 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
void i915_driver_remove(struct drm_i915_private *i915)
{
- disable_rpm_wakeref_asserts(&i915->runtime_pm);
+ intel_wakeref_t wakeref = 0;
+ /*
+ * Resuming Device if already suspended to complete driver unregistration
+ */
+ wakeref = intel_runtime_pm_get(&i915->runtime_pm);
i915_driver_unregister(i915);
@@ -977,18 +981,20 @@ void i915_driver_remove(struct drm_i915_private *i915)
i915_driver_hw_remove(i915);
- enable_rpm_wakeref_asserts(&i915->runtime_pm);
+ if (wakeref)
+ intel_runtime_pm_put(&i915->runtime_pm, wakeref);
}
static void i915_driver_release(struct drm_device *dev)
{
struct drm_i915_private *dev_priv = to_i915(dev);
struct intel_runtime_pm *rpm = &dev_priv->runtime_pm;
+ intel_wakeref_t wakeref = 0;
if (!dev_priv->do_release)
return;
- disable_rpm_wakeref_asserts(rpm);
+ wakeref = intel_runtime_pm_get(rpm);
i915_gem_driver_release(dev_priv);
@@ -999,7 +1005,9 @@ static void i915_driver_release(struct drm_device *dev)
i915_driver_mmio_release(dev_priv);
- enable_rpm_wakeref_asserts(rpm);
+ if (wakeref)
+ intel_runtime_pm_put(rpm, wakeref);
+
intel_runtime_pm_driver_release(rpm);
i915_driver_late_release(dev_priv);
--
2.25.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
2022-08-25 10:51 ` Imre Deak
@ 2022-08-29 6:45 ` Golani, Mitulkumar Ajitkumar
2022-08-29 14:46 ` Imre Deak
0 siblings, 1 reply; 19+ messages in thread
From: Golani, Mitulkumar Ajitkumar @ 2022-08-29 6:45 UTC (permalink / raw)
To: Deak, Imre; +Cc: intel-gfx
Hi Imre,
> -----Original Message-----
> From: Deak, Imre <imre.deak@intel.com>
> Sent: 25 August 2022 16:22
> To: Golani, Mitulkumar Ajitkumar <mitulkumar.ajitkumar.golani@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for
> imbalance wakeref
>
> On Tue, Aug 23, 2022 at 03:56:56PM +0300, Golani, Mitulkumar Ajitkumar
> wrote:
> > > Hi Imre,
> > >
> > > > On Fri, Aug 12, 2022 at 10:17:24AM +0530, Mitul Golani wrote:
> > > > > While executing i915_selftest, wakeref imbalance warning is seen
> > > > > with i915_selftest failure.
> > > > >
> > > > > When device is already suspended, wakeref is acquired by
> > > > > disable_rpm_wakeref_asserts and rpm ownership is transferred
> > > > > back to core. During this case wakeref_count will not be zero.
> > > > > Once driver is unregistered, this wakeref is released with
> > > > > enable_rpm_wakeref_asserts and balancing wakeref_count acquired
> > > > > by driver.
> > > > >
> > > > > This patch will fix the warning callstack by adding check if
> > > > > device is already suspended and rpm ownership transfer is going on.
> > > > >
> > > > > Signed-off-by: Mitul Golani
> > > > > <mitulkumar.ajitkumar.golani@intel.com>
> > > > > ---
> > > > > drivers/gpu/drm/i915/i915_driver.c | 8 +++++++-
> > > > > 1 file changed, 7 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/i915/i915_driver.c
> > > > > b/drivers/gpu/drm/i915/i915_driver.c
> > > > > index deb8a8b76965..6530a8680cfd 100644
> > > > > --- a/drivers/gpu/drm/i915/i915_driver.c
> > > > > +++ b/drivers/gpu/drm/i915/i915_driver.c
> > > > > @@ -1670,7 +1670,13 @@ static int intel_runtime_resume(struct
> > > > > device
> > > > > *kdev)
> > > > >
> > > > > drm_dbg(&dev_priv->drm, "Resuming device\n");
> > > > >
> > > > > - drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm-
> > > > >wakeref_count));
> > > > > + /*
> > > > > + * When device is already suspended, Wakeref is acquired by
> > > > disable_rpm_wakeref_asserts
> > > > > + * and rpm ownership is transferred back to core. During this
> > > > > + case
> > > > wakeref_count will
> > > > > + * not be zero. Once driver is unregistered, this wakeref is
> > > > > +released
> > > > with
> > > > > + * enable_rpm_wakeref_asserts and balancing wakeref_count
> > > > acquired by driver.
> > > > > + */
> > > > > + drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm-
> > > > >wakeref_count) &&
> > > > > +!rpm->suspended);
> > > >
> > > > I can't see how disable/enable_rpm_wakeref_asserts() can lead to
> > > > this WARN. They are always called in pairs both in
> > > > intel_runtime_suspend() and intel_runtime_resume(), leaving rpm-
> >wakeref_count unchanged.
> > > >
> > > > The root cause is probably somewhere else, incrementing
> > > > rpm->wakeref_count without runtime resuming the device.
> > > >
> > > > The WARN() condition is corret, we shouldn't get here with a
> > > > non-zero wakeref_count. rpm->suspended - set in
> > > > intel_runtime_suspend() and cleared in intel_runtime_resume() -
> > > > should be always false here, so the above change would just disable the
> WARN in all cases.
> > > >
> > > Yes, in case of DG2, after device is suspended, i915_driver_remove
> > > is being called. Here driver is taking wakeref with
> > > disable_rpm_wakeref_asserts when device was not resumed.
>
> > >
> > > As per logs,
> > > [ 395.872971] i915 0000:03:00.0: [drm:intel_runtime_suspend [i915]]
> > > Suspending device ...
> > > [ 403.553235] i915_driver_remove: START wakeref=0 [ 403.553288]
> > > i915_driver_remove: before unregister i915 wakeref=65537 (Wakeref
> > > Taken) [ 403.566086] i915 0000:03:00.0: [drm:intel_runtime_resume
> > > [i915]] Resuming device (Later Resuming Device)
> > >
> > > Pushed new change with :
> > > https://patchwork.freedesktop.org/series/107211/#rev5
> > >
> > Also when compared DG2 logs with ADLP working logs, Already 1 wakeref
> > was taken by DMC firmware(i915/adlp_dmc_ver2_16.bin (v2.16)), in-case
> of DG2 looks to be missing.
> > To support other targets and to prevent consecutive resuming device
> > added following check, if (i915->runtime_pm.suspended &&
> > !atomic_read(&i915->runtime_pm.wakeref_count))
> >
> > ADLP Logs:
> > ---------------
> > [ 99.502434] i915_driver_probe: START wakeref=0
> > [ 713.979074] i915 0000:00:02.0: [drm] Finished loading DMC firmware
> > i915/adlp_dmc_ver2_16.bin (v2.16) [ 102.455766] i915_driver_probe:
> > END wakeref=65538 ...
> > [ 103.448570] i915_driver_remove: START wakeref=65537 [ 103.448587]
> > i915_driver_remove: before unregister i915 wakeref=131074 ->
> > (disable_rpm_wakeref_assert) [ 103.585886] i915_driver_remove: END
> > wakeref=0
> >
> > DG2 Logs:
> > -------------
> > [ 1271.704314] i915_driver_probe: START wakeref=0 [ 383.050984] i915
> > 0000:03:00.0: [drm] Finished loading DMC firmware
> > i915/dg2_dmc_ver2_07.bin (v2.7) [ 1272.021133] i915_driver_probe: END
> > wakeref=1 ...
> > [ 395.883531] i915 0000:03:00.0: [drm:intel_runtime_suspend [i915]]
> > Device suspended ...
> > [ 1291.450841] i915_driver_remove: START wakeref=0 [ 1291.450877]
> > i915_driver_remove: before unregister i915 wakeref=65537 ->
> > (disable_rpm_wakeref_assert) [ 1291.603281] i915_driver_remove: END
> > wakeref=0
>
> Still not sure what's going. Both i915_pci_probe() and
> i915_pci_remove()->i915_driver_remove() is called with a runtime PM
> reference - taken at local_pci_probe() and pci_device_remove() - and so the
> device should be runtime resumed at those points.
>
Yes reference is being taken at local_pci_probe() and pci_device_remove() but
During i915_selftest@perf, it is loading and unloading i915_pci_probe() and
i915_pci_remove(), here pci_device_remove() is not being called, that's why
runtime PM reference is not present during i915_driver_remove().
> > > > > disable_rpm_wakeref_asserts(rpm);
> > > > >
> > > > > intel_opregion_notify_adapter(dev_priv, PCI_D0);
> > > > > --
> > > > > 2.25.1
> > > > >
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
2022-08-23 12:56 ` Golani, Mitulkumar Ajitkumar
@ 2022-08-25 10:51 ` Imre Deak
2022-08-29 6:45 ` Golani, Mitulkumar Ajitkumar
0 siblings, 1 reply; 19+ messages in thread
From: Imre Deak @ 2022-08-25 10:51 UTC (permalink / raw)
To: Golani, Mitulkumar Ajitkumar; +Cc: intel-gfx
On Tue, Aug 23, 2022 at 03:56:56PM +0300, Golani, Mitulkumar Ajitkumar wrote:
> > Hi Imre,
> >
> > > On Fri, Aug 12, 2022 at 10:17:24AM +0530, Mitul Golani wrote:
> > > > While executing i915_selftest, wakeref imbalance warning is seen
> > > > with i915_selftest failure.
> > > >
> > > > When device is already suspended, wakeref is acquired by
> > > > disable_rpm_wakeref_asserts and rpm ownership is transferred back to
> > > > core. During this case wakeref_count will not be zero.
> > > > Once driver is unregistered, this wakeref is released with
> > > > enable_rpm_wakeref_asserts and balancing wakeref_count acquired by
> > > > driver.
> > > >
> > > > This patch will fix the warning callstack by adding check if device
> > > > is already suspended and rpm ownership transfer is going on.
> > > >
> > > > Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/i915_driver.c | 8 +++++++-
> > > > 1 file changed, 7 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/i915_driver.c
> > > > b/drivers/gpu/drm/i915/i915_driver.c
> > > > index deb8a8b76965..6530a8680cfd 100644
> > > > --- a/drivers/gpu/drm/i915/i915_driver.c
> > > > +++ b/drivers/gpu/drm/i915/i915_driver.c
> > > > @@ -1670,7 +1670,13 @@ static int intel_runtime_resume(struct device
> > > > *kdev)
> > > >
> > > > drm_dbg(&dev_priv->drm, "Resuming device\n");
> > > >
> > > > - drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm-
> > > >wakeref_count));
> > > > + /*
> > > > + * When device is already suspended, Wakeref is acquired by
> > > disable_rpm_wakeref_asserts
> > > > + * and rpm ownership is transferred back to core. During this case
> > > wakeref_count will
> > > > + * not be zero. Once driver is unregistered, this wakeref is
> > > > +released
> > > with
> > > > + * enable_rpm_wakeref_asserts and balancing wakeref_count
> > > acquired by driver.
> > > > + */
> > > > + drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm-
> > > >wakeref_count) &&
> > > > +!rpm->suspended);
> > >
> > > I can't see how disable/enable_rpm_wakeref_asserts() can lead to this
> > > WARN. They are always called in pairs both in intel_runtime_suspend()
> > > and intel_runtime_resume(), leaving rpm->wakeref_count unchanged.
> > >
> > > The root cause is probably somewhere else, incrementing
> > > rpm->wakeref_count without runtime resuming the device.
> > >
> > > The WARN() condition is corret, we shouldn't get here with a non-zero
> > > wakeref_count. rpm->suspended - set in intel_runtime_suspend() and
> > > cleared in intel_runtime_resume() - should be always false here, so
> > > the above change would just disable the WARN in all cases.
> > >
> > Yes, in case of DG2, after device is suspended, i915_driver_remove
> > is being called. Here driver is taking wakeref with
> > disable_rpm_wakeref_asserts when device was not resumed.
> >
> > As per logs,
> > [ 395.872971] i915 0000:03:00.0: [drm:intel_runtime_suspend [i915]]
> > Suspending device ...
> > [ 403.553235] i915_driver_remove: START wakeref=0 [ 403.553288]
> > i915_driver_remove: before unregister i915 wakeref=65537 (Wakeref Taken)
> > [ 403.566086] i915 0000:03:00.0: [drm:intel_runtime_resume [i915]]
> > Resuming device (Later Resuming Device)
> >
> > Pushed new change with :
> > https://patchwork.freedesktop.org/series/107211/#rev5
> >
> Also when compared DG2 logs with ADLP working logs,
> Already 1 wakeref was taken by DMC firmware(i915/adlp_dmc_ver2_16.bin (v2.16)), in-case of DG2 looks to be missing.
> To support other targets and to prevent consecutive resuming device added following check,
> if (i915->runtime_pm.suspended && !atomic_read(&i915->runtime_pm.wakeref_count))
>
> ADLP Logs:
> ---------------
> [ 99.502434] i915_driver_probe: START wakeref=0
> [ 713.979074] i915 0000:00:02.0: [drm] Finished loading DMC firmware i915/adlp_dmc_ver2_16.bin (v2.16)
> [ 102.455766] i915_driver_probe: END wakeref=65538
> ...
> [ 103.448570] i915_driver_remove: START wakeref=65537
> [ 103.448587] i915_driver_remove: before unregister i915 wakeref=131074 -> (disable_rpm_wakeref_assert)
> [ 103.585886] i915_driver_remove: END wakeref=0
>
> DG2 Logs:
> -------------
> [ 1271.704314] i915_driver_probe: START wakeref=0
> [ 383.050984] i915 0000:03:00.0: [drm] Finished loading DMC firmware i915/dg2_dmc_ver2_07.bin (v2.7)
> [ 1272.021133] i915_driver_probe: END wakeref=1
> ...
> [ 395.883531] i915 0000:03:00.0: [drm:intel_runtime_suspend [i915]] Device suspended
> ...
> [ 1291.450841] i915_driver_remove: START wakeref=0
> [ 1291.450877] i915_driver_remove: before unregister i915 wakeref=65537 -> (disable_rpm_wakeref_assert)
> [ 1291.603281] i915_driver_remove: END wakeref=0
Still not sure what's going. Both i915_pci_probe() and
i915_pci_remove()->i915_driver_remove() is called with a runtime PM
reference - taken at local_pci_probe() and pci_device_remove() - and so
the device should be runtime resumed at those points.
> > > > disable_rpm_wakeref_asserts(rpm);
> > > >
> > > > intel_opregion_notify_adapter(dev_priv, PCI_D0);
> > > > --
> > > > 2.25.1
> > > >
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
2022-08-23 5:20 Mitul Golani
@ 2022-08-23 14:31 ` Jani Nikula
0 siblings, 0 replies; 19+ messages in thread
From: Jani Nikula @ 2022-08-23 14:31 UTC (permalink / raw)
To: Mitul Golani, intel-gfx
On Tue, 23 Aug 2022, Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> wrote:
> While executing i915_selftest, wakeref imbalance warning is seen
> with i915_selftest failure.
>
> Currently when Driver is suspended, while doing unregister
> it is taking wakeref without resuming the device.
> This patch is resuming the device, if driver is already suspended
> and doing unregister process. It will check the suspend state and
> if driver is not resumed before taking wakeref then resume before
> it.
Why have you sent the same patch multiple times in the same day?
Please see my earlier reply
https://lore.kernel.org/r/87k06zkyw3.fsf@intel.com
BR,
Jani.
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> ---
> drivers/gpu/drm/i915/i915_driver.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index deb8a8b76965..99d6df02dc67 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -948,6 +948,15 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>
> void i915_driver_remove(struct drm_i915_private *i915)
> {
> + int ret;
> + /*
> + * Resuming Device if already suspended to complete driver unregistration
> + */
> + if (i915->runtime_pm.suspended && !atomic_read(&i915->runtime_pm.wakeref_count)) {
> + ret = pm_runtime_get_sync(i915->runtime_pm.kdev);
> + drm_WARN_ONCE(&i915->drm, ret < 0, "pm_runtime_get_sync() failed: %d\n", ret);
> + }
> +
> disable_rpm_wakeref_asserts(&i915->runtime_pm);
>
> i915_driver_unregister(i915);
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
2022-08-23 12:39 ` Golani, Mitulkumar Ajitkumar
@ 2022-08-23 12:56 ` Golani, Mitulkumar Ajitkumar
2022-08-25 10:51 ` Imre Deak
0 siblings, 1 reply; 19+ messages in thread
From: Golani, Mitulkumar Ajitkumar @ 2022-08-23 12:56 UTC (permalink / raw)
To: Golani, Mitulkumar Ajitkumar, Deak, Imre; +Cc: intel-gfx
> Hi Imre,
>
> > On Fri, Aug 12, 2022 at 10:17:24AM +0530, Mitul Golani wrote:
> > > While executing i915_selftest, wakeref imbalance warning is seen
> > > with i915_selftest failure.
> > >
> > > When device is already suspended, wakeref is acquired by
> > > disable_rpm_wakeref_asserts and rpm ownership is transferred back to
> > > core. During this case wakeref_count will not be zero.
> > > Once driver is unregistered, this wakeref is released with
> > > enable_rpm_wakeref_asserts and balancing wakeref_count acquired by
> > > driver.
> > >
> > > This patch will fix the warning callstack by adding check if device
> > > is already suspended and rpm ownership transfer is going on.
> > >
> > > Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/i915_driver.c | 8 +++++++-
> > > 1 file changed, 7 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_driver.c
> > > b/drivers/gpu/drm/i915/i915_driver.c
> > > index deb8a8b76965..6530a8680cfd 100644
> > > --- a/drivers/gpu/drm/i915/i915_driver.c
> > > +++ b/drivers/gpu/drm/i915/i915_driver.c
> > > @@ -1670,7 +1670,13 @@ static int intel_runtime_resume(struct device
> > > *kdev)
> > >
> > > drm_dbg(&dev_priv->drm, "Resuming device\n");
> > >
> > > - drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm-
> > >wakeref_count));
> > > + /*
> > > + * When device is already suspended, Wakeref is acquired by
> > disable_rpm_wakeref_asserts
> > > + * and rpm ownership is transferred back to core. During this case
> > wakeref_count will
> > > + * not be zero. Once driver is unregistered, this wakeref is
> > > +released
> > with
> > > + * enable_rpm_wakeref_asserts and balancing wakeref_count
> > acquired by driver.
> > > + */
> > > + drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm-
> > >wakeref_count) &&
> > > +!rpm->suspended);
> >
> > I can't see how disable/enable_rpm_wakeref_asserts() can lead to this
> > WARN. They are always called in pairs both in intel_runtime_suspend()
> > and intel_runtime_resume(), leaving rpm->wakeref_count unchanged.
> >
> > The root cause is probably somewhere else, incrementing
> > rpm->wakeref_count without runtime resuming the device.
> >
> > The WARN() condition is corret, we shouldn't get here with a non-zero
> > wakeref_count. rpm->suspended - set in intel_runtime_suspend() and
> > cleared in intel_runtime_resume() - should be always false here, so
> > the above change would just disable the WARN in all cases.
> >
> Yes, in case of DG2, after device is suspended, i915_driver_remove is being
> called.
> Here driver is taking wakeref with disable_rpm_wakeref_asserts when device
> was not resumed.
>
> As per logs,
> [ 395.872971] i915 0000:03:00.0: [drm:intel_runtime_suspend [i915]]
> Suspending device ...
> [ 403.553235] i915_driver_remove: START wakeref=0 [ 403.553288]
> i915_driver_remove: before unregister i915 wakeref=65537 (Wakeref Taken)
> [ 403.566086] i915 0000:03:00.0: [drm:intel_runtime_resume [i915]]
> Resuming device (Later Resuming Device)
>
> Pushed new change with :
> https://patchwork.freedesktop.org/series/107211/#rev5
>
Also when compared DG2 logs with ADLP working logs,
Already 1 wakeref was taken by DMC firmware(i915/adlp_dmc_ver2_16.bin (v2.16)), in-case of DG2 looks to be missing.
To support other targets and to prevent consecutive resuming device added following check,
if (i915->runtime_pm.suspended && !atomic_read(&i915->runtime_pm.wakeref_count))
ADLP Logs:
---------------
[ 99.502434] i915_driver_probe: START wakeref=0
[ 713.979074] i915 0000:00:02.0: [drm] Finished loading DMC firmware i915/adlp_dmc_ver2_16.bin (v2.16)
[ 102.455766] i915_driver_probe: END wakeref=65538
...
[ 103.448570] i915_driver_remove: START wakeref=65537
[ 103.448587] i915_driver_remove: before unregister i915 wakeref=131074 -> (disable_rpm_wakeref_assert)
[ 103.585886] i915_driver_remove: END wakeref=0
DG2 Logs:
-------------
[ 1271.704314] i915_driver_probe: START wakeref=0
[ 383.050984] i915 0000:03:00.0: [drm] Finished loading DMC firmware i915/dg2_dmc_ver2_07.bin (v2.7)
[ 1272.021133] i915_driver_probe: END wakeref=1
...
[ 395.883531] i915 0000:03:00.0: [drm:intel_runtime_suspend [i915]] Device suspended
...
[ 1291.450841] i915_driver_remove: START wakeref=0
[ 1291.450877] i915_driver_remove: before unregister i915 wakeref=65537 -> (disable_rpm_wakeref_assert)
[ 1291.603281] i915_driver_remove: END wakeref=0
> > > disable_rpm_wakeref_asserts(rpm);
> > >
> > > intel_opregion_notify_adapter(dev_priv, PCI_D0);
> > > --
> > > 2.25.1
> > >
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
2022-08-17 12:49 ` Imre Deak
@ 2022-08-23 12:39 ` Golani, Mitulkumar Ajitkumar
2022-08-23 12:56 ` Golani, Mitulkumar Ajitkumar
0 siblings, 1 reply; 19+ messages in thread
From: Golani, Mitulkumar Ajitkumar @ 2022-08-23 12:39 UTC (permalink / raw)
To: Deak, Imre; +Cc: intel-gfx
Hi Imre,
> On Fri, Aug 12, 2022 at 10:17:24AM +0530, Mitul Golani wrote:
> > While executing i915_selftest, wakeref imbalance warning is seen with
> > i915_selftest failure.
> >
> > When device is already suspended, wakeref is acquired by
> > disable_rpm_wakeref_asserts and rpm ownership is transferred back to
> > core. During this case wakeref_count will not be zero.
> > Once driver is unregistered, this wakeref is released with
> > enable_rpm_wakeref_asserts and balancing wakeref_count acquired by
> > driver.
> >
> > This patch will fix the warning callstack by adding check if device is
> > already suspended and rpm ownership transfer is going on.
> >
> > Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_driver.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_driver.c
> > b/drivers/gpu/drm/i915/i915_driver.c
> > index deb8a8b76965..6530a8680cfd 100644
> > --- a/drivers/gpu/drm/i915/i915_driver.c
> > +++ b/drivers/gpu/drm/i915/i915_driver.c
> > @@ -1670,7 +1670,13 @@ static int intel_runtime_resume(struct device
> > *kdev)
> >
> > drm_dbg(&dev_priv->drm, "Resuming device\n");
> >
> > - drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm-
> >wakeref_count));
> > + /*
> > + * When device is already suspended, Wakeref is acquired by
> disable_rpm_wakeref_asserts
> > + * and rpm ownership is transferred back to core. During this case
> wakeref_count will
> > + * not be zero. Once driver is unregistered, this wakeref is released
> with
> > + * enable_rpm_wakeref_asserts and balancing wakeref_count
> acquired by driver.
> > + */
> > + drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm-
> >wakeref_count) &&
> > +!rpm->suspended);
>
> I can't see how disable/enable_rpm_wakeref_asserts() can lead to this
> WARN. They are always called in pairs both in intel_runtime_suspend() and
> intel_runtime_resume(), leaving rpm->wakeref_count unchanged.
>
> The root cause is probably somewhere else, incrementing
> rpm->wakeref_count without runtime resuming the device.
>
> The WARN() condition is corret, we shouldn't get here with a non-zero
> wakeref_count. rpm->suspended - set in intel_runtime_suspend() and
> cleared in intel_runtime_resume() - should be always false here, so the
> above change would just disable the WARN in all cases.
>
Yes, in case of DG2, after device is suspended, i915_driver_remove is being called.
Here driver is taking wakeref with disable_rpm_wakeref_asserts when device was not resumed.
As per logs,
[ 395.872971] i915 0000:03:00.0: [drm:intel_runtime_suspend [i915]] Suspending device
...
[ 403.553235] i915_driver_remove: START wakeref=0
[ 403.553288] i915_driver_remove: before unregister i915 wakeref=65537 (Wakeref Taken)
[ 403.566086] i915 0000:03:00.0: [drm:intel_runtime_resume [i915]] Resuming device (Later Resuming Device)
Pushed new change with : https://patchwork.freedesktop.org/series/107211/#rev5
> > disable_rpm_wakeref_asserts(rpm);
> >
> > intel_opregion_notify_adapter(dev_priv, PCI_D0);
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
2022-08-23 2:35 Mitul Golani
@ 2022-08-23 11:00 ` Jani Nikula
0 siblings, 0 replies; 19+ messages in thread
From: Jani Nikula @ 2022-08-23 11:00 UTC (permalink / raw)
To: Mitul Golani, intel-gfx
On Tue, 23 Aug 2022, Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> wrote:
> While executing i915_selftest, wakeref imbalance warning is seen
> with i915_selftest failure.
>
> Currently when Driver is suspended, while doing unregister
> it is taking wakeref without resuming the device.
> This patch is resuming the device, if driver is already suspended
> and doing unregister process. It will check the suspend state and
> if driver is not resumed before taking wakeref then resume before
> it.
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> ---
> drivers/gpu/drm/i915/i915_driver.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index deb8a8b76965..b3741bd49e2c 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -948,6 +948,15 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>
> void i915_driver_remove(struct drm_i915_private *i915)
> {
> + int ret;
> + /*
> + * Resuming Device if already suspended to complete driver unregistration
> + */
> + if (i915->runtime_pm.suspended && !atomic_read(&i915->runtime_pm.wakeref_count)) {
> + ret = pm_runtime_get_sync(rpm->kdev);
> + drm_WARN_ONCE(&i915->drm, ret < 0, "pm_runtime_get_sync() failed: %d\n", ret);
> + }
> +
I don't know what the right fix is, but under no circumstances are we
adding detailed low level code into high level function like
i915_driver_remove().
BR,
Jani.
> disable_rpm_wakeref_asserts(&i915->runtime_pm);
>
> i915_driver_unregister(i915);
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
@ 2022-08-23 5:20 Mitul Golani
2022-08-23 14:31 ` Jani Nikula
0 siblings, 1 reply; 19+ messages in thread
From: Mitul Golani @ 2022-08-23 5:20 UTC (permalink / raw)
To: intel-gfx
While executing i915_selftest, wakeref imbalance warning is seen
with i915_selftest failure.
Currently when Driver is suspended, while doing unregister
it is taking wakeref without resuming the device.
This patch is resuming the device, if driver is already suspended
and doing unregister process. It will check the suspend state and
if driver is not resumed before taking wakeref then resume before
it.
Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
drivers/gpu/drm/i915/i915_driver.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index deb8a8b76965..99d6df02dc67 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -948,6 +948,15 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
void i915_driver_remove(struct drm_i915_private *i915)
{
+ int ret;
+ /*
+ * Resuming Device if already suspended to complete driver unregistration
+ */
+ if (i915->runtime_pm.suspended && !atomic_read(&i915->runtime_pm.wakeref_count)) {
+ ret = pm_runtime_get_sync(i915->runtime_pm.kdev);
+ drm_WARN_ONCE(&i915->drm, ret < 0, "pm_runtime_get_sync() failed: %d\n", ret);
+ }
+
disable_rpm_wakeref_asserts(&i915->runtime_pm);
i915_driver_unregister(i915);
--
2.25.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
@ 2022-08-23 2:35 Mitul Golani
2022-08-23 11:00 ` Jani Nikula
0 siblings, 1 reply; 19+ messages in thread
From: Mitul Golani @ 2022-08-23 2:35 UTC (permalink / raw)
To: intel-gfx
While executing i915_selftest, wakeref imbalance warning is seen
with i915_selftest failure.
Currently when Driver is suspended, while doing unregister
it is taking wakeref without resuming the device.
This patch is resuming the device, if driver is already suspended
and doing unregister process. It will check the suspend state and
if driver is not resumed before taking wakeref then resume before
it.
Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
drivers/gpu/drm/i915/i915_driver.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index deb8a8b76965..b3741bd49e2c 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -948,6 +948,15 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
void i915_driver_remove(struct drm_i915_private *i915)
{
+ int ret;
+ /*
+ * Resuming Device if already suspended to complete driver unregistration
+ */
+ if (i915->runtime_pm.suspended && !atomic_read(&i915->runtime_pm.wakeref_count)) {
+ ret = pm_runtime_get_sync(rpm->kdev);
+ drm_WARN_ONCE(&i915->drm, ret < 0, "pm_runtime_get_sync() failed: %d\n", ret);
+ }
+
disable_rpm_wakeref_asserts(&i915->runtime_pm);
i915_driver_unregister(i915);
--
2.25.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
2022-08-12 4:47 Mitul Golani
@ 2022-08-17 12:49 ` Imre Deak
2022-08-23 12:39 ` Golani, Mitulkumar Ajitkumar
0 siblings, 1 reply; 19+ messages in thread
From: Imre Deak @ 2022-08-17 12:49 UTC (permalink / raw)
To: Mitul Golani; +Cc: intel-gfx
On Fri, Aug 12, 2022 at 10:17:24AM +0530, Mitul Golani wrote:
> While executing i915_selftest, wakeref imbalance warning is seen
> with i915_selftest failure.
>
> When device is already suspended, wakeref is acquired by
> disable_rpm_wakeref_asserts and rpm ownership is transferred back
> to core. During this case wakeref_count will not be zero.
> Once driver is unregistered, this wakeref is released with
> enable_rpm_wakeref_asserts and balancing wakeref_count acquired
> by driver.
>
> This patch will fix the warning callstack by adding check if device
> is already suspended and rpm ownership transfer is going on.
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> ---
> drivers/gpu/drm/i915/i915_driver.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index deb8a8b76965..6530a8680cfd 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -1670,7 +1670,13 @@ static int intel_runtime_resume(struct device *kdev)
>
> drm_dbg(&dev_priv->drm, "Resuming device\n");
>
> - drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm->wakeref_count));
> + /*
> + * When device is already suspended, Wakeref is acquired by disable_rpm_wakeref_asserts
> + * and rpm ownership is transferred back to core. During this case wakeref_count will
> + * not be zero. Once driver is unregistered, this wakeref is released with
> + * enable_rpm_wakeref_asserts and balancing wakeref_count acquired by driver.
> + */
> + drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm->wakeref_count) && !rpm->suspended);
I can't see how disable/enable_rpm_wakeref_asserts() can lead to this
WARN. They are always called in pairs both in intel_runtime_suspend()
and intel_runtime_resume(), leaving rpm->wakeref_count unchanged.
The root cause is probably somewhere else, incrementing
rpm->wakeref_count without runtime resuming the device.
The WARN() condition is corret, we shouldn't get here with a non-zero
wakeref_count. rpm->suspended - set in intel_runtime_suspend() and
cleared in intel_runtime_resume() - should be always false here, so the
above change would just disable the WARN in all cases.
> disable_rpm_wakeref_asserts(rpm);
>
> intel_opregion_notify_adapter(dev_priv, PCI_D0);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref
@ 2022-08-12 4:47 Mitul Golani
2022-08-17 12:49 ` Imre Deak
0 siblings, 1 reply; 19+ messages in thread
From: Mitul Golani @ 2022-08-12 4:47 UTC (permalink / raw)
To: intel-gfx; +Cc: Mitul Golani
While executing i915_selftest, wakeref imbalance warning is seen
with i915_selftest failure.
When device is already suspended, wakeref is acquired by
disable_rpm_wakeref_asserts and rpm ownership is transferred back
to core. During this case wakeref_count will not be zero.
Once driver is unregistered, this wakeref is released with
enable_rpm_wakeref_asserts and balancing wakeref_count acquired
by driver.
This patch will fix the warning callstack by adding check if device
is already suspended and rpm ownership transfer is going on.
Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
drivers/gpu/drm/i915/i915_driver.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index deb8a8b76965..6530a8680cfd 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -1670,7 +1670,13 @@ static int intel_runtime_resume(struct device *kdev)
drm_dbg(&dev_priv->drm, "Resuming device\n");
- drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm->wakeref_count));
+ /*
+ * When device is already suspended, Wakeref is acquired by disable_rpm_wakeref_asserts
+ * and rpm ownership is transferred back to core. During this case wakeref_count will
+ * not be zero. Once driver is unregistered, this wakeref is released with
+ * enable_rpm_wakeref_asserts and balancing wakeref_count acquired by driver.
+ */
+ drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm->wakeref_count) && !rpm->suspended);
disable_rpm_wakeref_asserts(rpm);
intel_opregion_notify_adapter(dev_priv, PCI_D0);
--
2.25.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
end of thread, other threads:[~2022-09-01 11:14 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-30 8:51 [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref Mitul Golani
2022-08-30 16:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7) Patchwork
2022-08-31 11:54 ` [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref Imre Deak
2022-08-31 15:02 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7) Patchwork
2022-09-01 11:14 ` Imre Deak
2022-08-31 15:28 ` [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref Andrzej Hajda
-- strict thread matches above, loose matches on Subject: below --
2022-08-29 8:31 Mitul Golani
2022-08-23 5:20 Mitul Golani
2022-08-23 14:31 ` Jani Nikula
2022-08-23 2:35 Mitul Golani
2022-08-23 11:00 ` Jani Nikula
2022-08-12 4:47 Mitul Golani
2022-08-17 12:49 ` Imre Deak
2022-08-23 12:39 ` Golani, Mitulkumar Ajitkumar
2022-08-23 12:56 ` Golani, Mitulkumar Ajitkumar
2022-08-25 10:51 ` Imre Deak
2022-08-29 6:45 ` Golani, Mitulkumar Ajitkumar
2022-08-29 14:46 ` Imre Deak
2022-08-29 16:59 ` Golani, Mitulkumar Ajitkumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.