* [PATCH linux-next] drm/radeon/ci_dpm: Remove the unneeded result variable
@ 2022-09-02 7:31 ` cgel.zte
0 siblings, 0 replies; 5+ messages in thread
From: cgel.zte @ 2022-09-02 7:31 UTC (permalink / raw)
To: alexander.deucher
Cc: christian.koenig, Xinhui.Pan, airlied, daniel, amd-gfx,
dri-devel, linux-kernel, ye xingchen, Zeal Robot
From: ye xingchen <ye.xingchen@zte.com.cn>
Return the value ci_load_smc_ucode() directly instead of storing it in
another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/gpu/drm/radeon/ci_dpm.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c
index ac006bed4743..8ef25ab305ae 100644
--- a/drivers/gpu/drm/radeon/ci_dpm.c
+++ b/drivers/gpu/drm/radeon/ci_dpm.c
@@ -2056,7 +2056,7 @@ static void ci_clear_vc(struct radeon_device *rdev)
static int ci_upload_firmware(struct radeon_device *rdev)
{
struct ci_power_info *pi = ci_get_pi(rdev);
- int i, ret;
+ int i;
for (i = 0; i < rdev->usec_timeout; i++) {
if (RREG32_SMC(RCU_UC_EVENTS) & BOOT_SEQ_DONE)
@@ -2067,9 +2067,7 @@ static int ci_upload_firmware(struct radeon_device *rdev)
ci_stop_smc_clock(rdev);
ci_reset_smc(rdev);
- ret = ci_load_smc_ucode(rdev, pi->sram_end);
-
- return ret;
+ return ci_load_smc_ucode(rdev, pi->sram_end);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH linux-next] drm/radeon/ci_dpm: Remove the unneeded result variable
@ 2022-09-02 7:31 ` cgel.zte
0 siblings, 0 replies; 5+ messages in thread
From: cgel.zte @ 2022-09-02 7:31 UTC (permalink / raw)
To: alexander.deucher
Cc: airlied, ye xingchen, Zeal Robot, Xinhui.Pan, linux-kernel,
dri-devel, amd-gfx, christian.koenig
From: ye xingchen <ye.xingchen@zte.com.cn>
Return the value ci_load_smc_ucode() directly instead of storing it in
another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/gpu/drm/radeon/ci_dpm.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c
index ac006bed4743..8ef25ab305ae 100644
--- a/drivers/gpu/drm/radeon/ci_dpm.c
+++ b/drivers/gpu/drm/radeon/ci_dpm.c
@@ -2056,7 +2056,7 @@ static void ci_clear_vc(struct radeon_device *rdev)
static int ci_upload_firmware(struct radeon_device *rdev)
{
struct ci_power_info *pi = ci_get_pi(rdev);
- int i, ret;
+ int i;
for (i = 0; i < rdev->usec_timeout; i++) {
if (RREG32_SMC(RCU_UC_EVENTS) & BOOT_SEQ_DONE)
@@ -2067,9 +2067,7 @@ static int ci_upload_firmware(struct radeon_device *rdev)
ci_stop_smc_clock(rdev);
ci_reset_smc(rdev);
- ret = ci_load_smc_ucode(rdev, pi->sram_end);
-
- return ret;
+ return ci_load_smc_ucode(rdev, pi->sram_end);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH linux-next] drm/radeon/ci_dpm: Remove the unneeded result variable
@ 2022-09-02 7:31 ` cgel.zte
0 siblings, 0 replies; 5+ messages in thread
From: cgel.zte @ 2022-09-02 7:31 UTC (permalink / raw)
To: alexander.deucher
Cc: airlied, ye xingchen, Zeal Robot, Xinhui.Pan, linux-kernel,
dri-devel, amd-gfx, daniel, christian.koenig
From: ye xingchen <ye.xingchen@zte.com.cn>
Return the value ci_load_smc_ucode() directly instead of storing it in
another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/gpu/drm/radeon/ci_dpm.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c
index ac006bed4743..8ef25ab305ae 100644
--- a/drivers/gpu/drm/radeon/ci_dpm.c
+++ b/drivers/gpu/drm/radeon/ci_dpm.c
@@ -2056,7 +2056,7 @@ static void ci_clear_vc(struct radeon_device *rdev)
static int ci_upload_firmware(struct radeon_device *rdev)
{
struct ci_power_info *pi = ci_get_pi(rdev);
- int i, ret;
+ int i;
for (i = 0; i < rdev->usec_timeout; i++) {
if (RREG32_SMC(RCU_UC_EVENTS) & BOOT_SEQ_DONE)
@@ -2067,9 +2067,7 @@ static int ci_upload_firmware(struct radeon_device *rdev)
ci_stop_smc_clock(rdev);
ci_reset_smc(rdev);
- ret = ci_load_smc_ucode(rdev, pi->sram_end);
-
- return ret;
+ return ci_load_smc_ucode(rdev, pi->sram_end);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH linux-next] drm/radeon/ci_dpm: Remove the unneeded result variable
2022-09-02 7:31 ` cgel.zte
@ 2022-09-09 20:45 ` Alex Deucher
-1 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-09-09 20:45 UTC (permalink / raw)
To: cgel.zte
Cc: alexander.deucher, airlied, ye xingchen, Zeal Robot, Xinhui.Pan,
linux-kernel, dri-devel, amd-gfx, christian.koenig
Applied. Thanks!
On Fri, Sep 2, 2022 at 3:32 AM <cgel.zte@gmail.com> wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value ci_load_smc_ucode() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/gpu/drm/radeon/ci_dpm.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c
> index ac006bed4743..8ef25ab305ae 100644
> --- a/drivers/gpu/drm/radeon/ci_dpm.c
> +++ b/drivers/gpu/drm/radeon/ci_dpm.c
> @@ -2056,7 +2056,7 @@ static void ci_clear_vc(struct radeon_device *rdev)
> static int ci_upload_firmware(struct radeon_device *rdev)
> {
> struct ci_power_info *pi = ci_get_pi(rdev);
> - int i, ret;
> + int i;
>
> for (i = 0; i < rdev->usec_timeout; i++) {
> if (RREG32_SMC(RCU_UC_EVENTS) & BOOT_SEQ_DONE)
> @@ -2067,9 +2067,7 @@ static int ci_upload_firmware(struct radeon_device *rdev)
> ci_stop_smc_clock(rdev);
> ci_reset_smc(rdev);
>
> - ret = ci_load_smc_ucode(rdev, pi->sram_end);
> -
> - return ret;
> + return ci_load_smc_ucode(rdev, pi->sram_end);
>
> }
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH linux-next] drm/radeon/ci_dpm: Remove the unneeded result variable
@ 2022-09-09 20:45 ` Alex Deucher
0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-09-09 20:45 UTC (permalink / raw)
To: cgel.zte
Cc: airlied, ye xingchen, Zeal Robot, Xinhui.Pan, linux-kernel,
dri-devel, amd-gfx, alexander.deucher, christian.koenig
Applied. Thanks!
On Fri, Sep 2, 2022 at 3:32 AM <cgel.zte@gmail.com> wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value ci_load_smc_ucode() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/gpu/drm/radeon/ci_dpm.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c
> index ac006bed4743..8ef25ab305ae 100644
> --- a/drivers/gpu/drm/radeon/ci_dpm.c
> +++ b/drivers/gpu/drm/radeon/ci_dpm.c
> @@ -2056,7 +2056,7 @@ static void ci_clear_vc(struct radeon_device *rdev)
> static int ci_upload_firmware(struct radeon_device *rdev)
> {
> struct ci_power_info *pi = ci_get_pi(rdev);
> - int i, ret;
> + int i;
>
> for (i = 0; i < rdev->usec_timeout; i++) {
> if (RREG32_SMC(RCU_UC_EVENTS) & BOOT_SEQ_DONE)
> @@ -2067,9 +2067,7 @@ static int ci_upload_firmware(struct radeon_device *rdev)
> ci_stop_smc_clock(rdev);
> ci_reset_smc(rdev);
>
> - ret = ci_load_smc_ucode(rdev, pi->sram_end);
> -
> - return ret;
> + return ci_load_smc_ucode(rdev, pi->sram_end);
>
> }
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-09 20:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-02 7:31 [PATCH linux-next] drm/radeon/ci_dpm: Remove the unneeded result variable cgel.zte
2022-09-02 7:31 ` cgel.zte
2022-09-02 7:31 ` cgel.zte
2022-09-09 20:45 ` Alex Deucher
2022-09-09 20:45 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.