[PATCH linux-next] xfrm: Remove the unneeded result variable

* [PATCH linux-next] xfrm: Remove the unneeded result variable
@ 2022-09-02  7:37 cgel.zte
  0 siblings, 0 replies; only message in thread
From: cgel.zte @ 2022-09-02  7:37 UTC (permalink / raw)
  To: steffen.klassert
  Cc: herbert, davem, edumazet, kuba, pabeni, netdev, linux-kernel,
	zhang songyi, Zeal Robot

From: zhang songyi <zhang.songyi@zte.com.cn>

Return the xfrmi_create() directly instead of storing it in another
redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
 net/xfrm/xfrm_interface.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c
index 5a67b120c4db..5508dc11ce42 100644
--- a/net/xfrm/xfrm_interface.c
+++ b/net/xfrm/xfrm_interface.c
@@ -774,7 +774,6 @@ static int xfrmi_newlink(struct net *src_net, struct net_device *dev,
 	struct net *net = dev_net(dev);
 	struct xfrm_if_parms p = {};
 	struct xfrm_if *xi;
-	int err;
 
 	xfrmi_netlink_parms(data, &p);
 	if (p.collect_md) {
@@ -804,8 +803,7 @@ static int xfrmi_newlink(struct net *src_net, struct net_device *dev,
 	xi->net = net;
 	xi->dev = dev;
 
-	err = xfrmi_create(dev);
-	return err;
+	return xfrmi_create(dev);
 }
 
 static void xfrmi_dellink(struct net_device *dev, struct list_head *head)
-- 
2.25.1



^ permalink raw reply related	[flat|nested] only message in thread