From: Maxime Ripard <maxime@cerno.tech>
To: "Maíra Canal" <mairacanal@riseup.net>
Cc: michal.winiarski@intel.com, "David Gow" <davidgow@google.com>,
siqueirajordao@riseup.net, magalilemes00@gmail.com,
"David Airlie" <airlied@linux.ie>,
tales.aparecida@gmail.com, "Arthur Grillo" <arthur.grillo@usp.br>,
brendanhiggins@google.com,
"Javier Martinez Canillas" <javierm@redhat.com>,
linux-kernel@vger.kernel.org, mwen@igalia.com,
dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com,
"José Expósito" <jose.exposito89@gmail.com>,
"Isabella Basso" <isabbasso@riseup.net>,
andrealmeid@riseup.net
Subject: Re: [PATCH v2 2/2] drm/tests: Change "igt_" prefix to "test_drm_"
Date: Fri, 2 Sep 2022 10:08:17 +0200 [thread overview]
Message-ID: <20220902080817.is2dqqe5sxxhj6qo@houat> (raw)
In-Reply-To: <04aeba53-793c-3196-3137-915f0640dc2a@riseup.net>
[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]
On Thu, Sep 01, 2022 at 07:33:18PM -0300, Maíra Canal wrote:
> Hi Maxime,
>
> On 9/1/22 09:55, Maxime Ripard wrote:
> > Hi,
> >
> > On Thu, Sep 01, 2022 at 09:42:10AM -0300, Maíra Canal wrote:
> >> With the introduction of KUnit, IGT is no longer the only option to run
> >> the DRM unit tests, as the tests can be run through kunit-tool or on
> >> real hardware with CONFIG_KUNIT.
> >>
> >> Therefore, remove the "igt_" prefix from the tests and replace it with
> >> the "test_drm_" prefix, making the tests' names independent from the tool
> >> used.
> >>
> >> Signed-off-by: Maíra Canal <mairacanal@riseup.net>
> >>
> >> ---
> >> v1 -> v2: https://lore.kernel.org/dri-devel/20220830211603.191734-1-mairacanal@riseup.net/
> >> - Change "drm_" prefix to "test_drm_", as "drm_" can be a bit confusing (Jani Nikula).
> >
> > I appreciate it's a bit of a bikeshed but I disagree with this. The
> > majority of the kunit tests already out there start with the framework
> > name, including *all* the examples in the kunit doc. Plus, it's fairly
> > obvious that it's a test, kunit is only about running tests in the first
> > place.
>
> Would it be better to keep it as "drm_"?
>
> Currently, I don't think it is appropriate to hold the "igt_" prefix, as
> the tests are not IGT exclusive, but I don't have a strong opinion on
> using the "drm_" or the "test_drm" prefixes.
Yes, using drm as our prefix everywhere seems like a good idea :)
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: "Maíra Canal" <mairacanal@riseup.net>
Cc: "Isabella Basso" <isabbasso@riseup.net>,
magalilemes00@gmail.com, tales.aparecida@gmail.com,
mwen@igalia.com, andrealmeid@riseup.net,
siqueirajordao@riseup.net, "Trevor Woerner" <twoerner@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"David Gow" <davidgow@google.com>,
brendanhiggins@google.com, "Arthur Grillo" <arthur.grillo@usp.br>,
michal.winiarski@intel.com,
"José Expósito" <jose.exposito89@gmail.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
kunit-dev@googlegroups.com
Subject: Re: [PATCH v2 2/2] drm/tests: Change "igt_" prefix to "test_drm_"
Date: Fri, 2 Sep 2022 10:08:17 +0200 [thread overview]
Message-ID: <20220902080817.is2dqqe5sxxhj6qo@houat> (raw)
In-Reply-To: <04aeba53-793c-3196-3137-915f0640dc2a@riseup.net>
[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]
On Thu, Sep 01, 2022 at 07:33:18PM -0300, Maíra Canal wrote:
> Hi Maxime,
>
> On 9/1/22 09:55, Maxime Ripard wrote:
> > Hi,
> >
> > On Thu, Sep 01, 2022 at 09:42:10AM -0300, Maíra Canal wrote:
> >> With the introduction of KUnit, IGT is no longer the only option to run
> >> the DRM unit tests, as the tests can be run through kunit-tool or on
> >> real hardware with CONFIG_KUNIT.
> >>
> >> Therefore, remove the "igt_" prefix from the tests and replace it with
> >> the "test_drm_" prefix, making the tests' names independent from the tool
> >> used.
> >>
> >> Signed-off-by: Maíra Canal <mairacanal@riseup.net>
> >>
> >> ---
> >> v1 -> v2: https://lore.kernel.org/dri-devel/20220830211603.191734-1-mairacanal@riseup.net/
> >> - Change "drm_" prefix to "test_drm_", as "drm_" can be a bit confusing (Jani Nikula).
> >
> > I appreciate it's a bit of a bikeshed but I disagree with this. The
> > majority of the kunit tests already out there start with the framework
> > name, including *all* the examples in the kunit doc. Plus, it's fairly
> > obvious that it's a test, kunit is only about running tests in the first
> > place.
>
> Would it be better to keep it as "drm_"?
>
> Currently, I don't think it is appropriate to hold the "igt_" prefix, as
> the tests are not IGT exclusive, but I don't have a strong opinion on
> using the "drm_" or the "test_drm" prefixes.
Yes, using drm as our prefix everywhere seems like a good idea :)
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-09-02 8:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 12:42 [PATCH v2 1/2] drm/tests: Split drm_framebuffer_create_test into parameterized tests Maíra Canal
2022-09-01 12:42 ` Maíra Canal
2022-09-01 12:42 ` [PATCH v2 2/2] drm/tests: Change "igt_" prefix to "test_drm_" Maíra Canal
2022-09-01 12:42 ` Maíra Canal
2022-09-01 12:55 ` Maxime Ripard
2022-09-01 12:55 ` Maxime Ripard
2022-09-01 13:17 ` Javier Martinez Canillas
2022-09-01 13:17 ` Javier Martinez Canillas
2022-09-01 22:33 ` Maíra Canal
2022-09-01 22:33 ` Maíra Canal
2022-09-02 8:04 ` Jani Nikula
2022-09-02 8:04 ` Jani Nikula
2022-09-02 12:34 ` Maxime Ripard
2022-09-02 12:34 ` Maxime Ripard
2022-09-02 13:03 ` Jani Nikula
2022-09-02 13:03 ` Jani Nikula
2022-09-02 13:38 ` Michał Winiarski
2022-09-02 13:38 ` Michał Winiarski
2022-09-02 13:56 ` Jani Nikula
2022-09-02 13:56 ` Jani Nikula
2022-09-02 22:53 ` Maíra Canal
2022-09-02 22:53 ` Maíra Canal
2022-09-05 12:10 ` Maxime Ripard
2022-09-05 12:10 ` Maxime Ripard
2022-09-05 13:11 ` Michał Winiarski
2022-09-05 13:11 ` Michał Winiarski
2022-09-05 13:37 ` Maíra Canal
2022-09-05 13:37 ` Maíra Canal
2022-09-02 8:08 ` Maxime Ripard [this message]
2022-09-02 8:08 ` Maxime Ripard
2022-09-02 8:24 ` Jani Nikula
2022-09-02 8:24 ` Jani Nikula
2022-09-02 7:52 ` [PATCH v2 1/2] drm/tests: Split drm_framebuffer_create_test into parameterized tests David Gow
2022-09-02 7:52 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902080817.is2dqqe5sxxhj6qo@houat \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=andrealmeid@riseup.net \
--cc=arthur.grillo@usp.br \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=isabbasso@riseup.net \
--cc=javierm@redhat.com \
--cc=jose.exposito89@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=magalilemes00@gmail.com \
--cc=mairacanal@riseup.net \
--cc=michal.winiarski@intel.com \
--cc=mwen@igalia.com \
--cc=siqueirajordao@riseup.net \
--cc=tales.aparecida@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.