[PATCH 0/4] addition of configs for rockchip based roc-pc-rk3399 board

[PATCH 0/4] addition of configs for rockchip based roc-pc-rk3399 board

[Manoj Sai]

Patch 1/4 use preboot configuration to enable usb devices
Patch 2/4 fix up USB support which can recognize any USB1.1 devices
Patch 3/4 Enable crypto RNG support
Patch 4/4 Set the maximum slave SPI speed to 30MHz

Manoj Sai (4):
  configs: roc-pc-rk3399 :Enable preboot config .
  configs: roc-pc-rk3399:fix up USB support .
  configs: roc-pc-rk3399 :Enable crypto RNG support.
  configs: roc-pc-rk3399:Set the maximum slave SPI speed  and
            spi flash max frequency for environment to 30MHz.

 configs/roc-pc-rk3399_defconfig | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.25.1

[PATCH 1/4] configs:roc-pc-rk3399 :Enable CONFIG_USE_PREBOOT

[Manoj Sai]

use preboot configuration to enable usb devices

Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Signed-off-by: Da Xue <da.xue@libretech.co>
---
 configs/roc-pc-rk3399_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/roc-pc-rk3399_defconfig b/configs/roc-pc-rk3399_defconfig
index 4625e47537..84e82da3cf 100644
--- a/configs/roc-pc-rk3399_defconfig
+++ b/configs/roc-pc-rk3399_defconfig
@@ -20,6 +20,7 @@ CONFIG_DEBUG_UART=y
 CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
 CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
 # CONFIG_ANDROID_BOOT_IMAGE is not set
+CONFIG_USE_PREBOOT=y
 CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-roc-pc.dtb"
 CONFIG_DISPLAY_BOARDINFO_LATE=y
 CONFIG_SPL_MAX_SIZE=0x2e000
-- 
2.25.1

[PATCH 2/4] configs: roc-pc-rk3399:fix up USB support

[Manoj Sai]

- Fix up USB config options so keyboards and other USB devices work .

- Update the number of ports of the Usb root hub to configuration of
  CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS .

USB device tree:
  1  Hub (12 Mb/s, 0mA)
      U-Boot Root Hub
  1  Hub (12 Mb/s, 0mA)
  |   U-Boot Root Hub
  |
  +-2  Hub (12 Mb/s, 100mA)
        USB 2.0 Hub [MTT]

 1  Hub (5 Gb/s, 0mA)
    U-Boot XHCI Host Controller

Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Signed-off-by: Da Xue <da.xue@libretech.co>
Signed-off-by: dsx724 <da@lessconfused.com>
---
 configs/roc-pc-rk3399_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configs/roc-pc-rk3399_defconfig b/configs/roc-pc-rk3399_defconfig
index 84e82da3cf..ffd809687b 100644
--- a/configs/roc-pc-rk3399_defconfig
+++ b/configs/roc-pc-rk3399_defconfig
@@ -76,6 +76,9 @@ CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
+CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS=2
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
 CONFIG_USB_KEYBOARD=y
-- 
2.25.1

[PATCH 3/4] configs:roc-pc-rk3399 :Enable crypto RNG support

[Manoj Sai]

enable crypto RNG support for roc-pc-rk3399.

Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Signed-off-by: Da Xue <da.xue@libretech.co>
Signed-off-by: dsx724 <da@lessconfused.com
---
 configs/roc-pc-rk3399_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/roc-pc-rk3399_defconfig b/configs/roc-pc-rk3399_defconfig
index ffd809687b..84e72e8b60 100644
--- a/configs/roc-pc-rk3399_defconfig
+++ b/configs/roc-pc-rk3399_defconfig
@@ -67,6 +67,8 @@ CONFIG_PWM_ROCKCHIP=y
 # CONFIG_RAM_ROCKCHIP_DEBUG is not set
 CONFIG_RAM_RK3399_LPDDR4=y
 CONFIG_DM_RESET=y
+CONFIG_DM_RNG=y
+CONFIG_RNG_ROCKCHIP=y
 CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_ROCKCHIP_SPI=y
-- 
2.25.1

[PATCH 4/4] configs: roc-pc-rk3399:Set the maximum slave SPI speed to 30MHz

[Manoj Sai]

-While the SPI controller speed is defined by DTS, the maximum
slave speed (connected devices) is limited by the pre-defined
configuration value CONFIG_SF_DEFAULT_SPEED from 10 MHz to 30Mhz.

-set the Value of SPI flash max frequency for environment to 30Mhz.

This patch increases this maximum SPI slave device speed and
SPI flash max frequency for environment  to 30MHz .

difference in time of erase and update a region of SPI flash from memory
with 10Mhz and 30Mhz frequencey range updation  :

=> sf update 0x300000 0x800000 0x400000

with 10 Mhz frequency updation :-
4194304 bytes written, 0 bytes skipped in 36.819s, speed 119837 B/s

with 30Mhz frequency updation  :-
4194304 bytes written, 0 bytes skipped in 20.319s, speed 220752 B/s

Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Signed-off-by: Da Xue <da.xue@libretech.co>
Signed-off-by: dsx724 <da@lessconfused.com>
---
 configs/roc-pc-rk3399_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/roc-pc-rk3399_defconfig b/configs/roc-pc-rk3399_defconfig
index 84e72e8b60..7754cb8388 100644
--- a/configs/roc-pc-rk3399_defconfig
+++ b/configs/roc-pc-rk3399_defconfig
@@ -45,6 +45,7 @@ CONFIG_CMD_TIME=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
 CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_ENV_SPI_MAX_HZ=30000000
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_DM_SEQ_ALIAS=y
 CONFIG_ROCKCHIP_GPIO=y
@@ -55,6 +56,7 @@ CONFIG_MMC_DW_ROCKCHIP=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ROCKCHIP=y
 CONFIG_SF_DEFAULT_BUS=1
+CONFIG_SF_DEFAULT_SPEED=30000000
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
-- 
2.25.1

Re: [PATCH 0/4] addition of configs for rockchip based roc-pc-rk3399 board

[Kever Yang]

Hi Manoj,

     Please use "rockchip: roc-rk3399-pc:" as prefix of these patches,

and I think one patch to squash all these four patch is OK for they all 
only modify the config of roc-pc board,

just make sure the commit message is clear enough.


Thanks,

- Kever

On 2022/9/2 16:24, Manoj Sai wrote:
> Patch 1/4 use preboot configuration to enable usb devices
> Patch 2/4 fix up USB support which can recognize any USB1.1 devices
> Patch 3/4 Enable crypto RNG support
> Patch 4/4 Set the maximum slave SPI speed to 30MHz
>
> Manoj Sai (4):
>    configs: roc-pc-rk3399 :Enable preboot config .
>    configs: roc-pc-rk3399:fix up USB support .
>    configs: roc-pc-rk3399 :Enable crypto RNG support.
>    configs: roc-pc-rk3399:Set the maximum slave SPI speed  and
>              spi flash max frequency for environment to 30MHz.
>
>   configs/roc-pc-rk3399_defconfig | 8 ++++++++
>   1 file changed, 8 insertions(+)
>

[PATCH v2] configs:rockchip: roc-rk3399-pc: Enable the preboot configuration , USB 1.1 support , crypto RNG support and increase the spi flash default speed

[Manoj Sai]

This Patch enables the following details of configs to rockchip based roc-rk3399-pc board :

1) Enable preboot configuration to enable  usb devices .

2) Fix up USB config options so keyboards and other USB devices work and
   update the number of ports of the Usb root hub to configuration of
   CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS .

   - with this addition the updated USB device Tree :
     USB device tree:

	1  Hub (12 Mb/s, 0mA)
	U-Boot Root Hub
	1  Hub (12 Mb/s, 0mA)
	|   U-Boot Root Hub
	|
	+-2  Hub (12 Mb/s, 100mA)
	USB 2.0 Hub [MTT]

	1  Hub (5 Gb/s, 0mA)
	U-Boot XHCI Host Controller

3) enable crypto RNG ( random number generator ) support

4) Set the maximum slave SPI speed to 30MHz :
    - This patch increases the maximum SPI slave device speed and
      SPI flash max frequency for environment from 10Mhz to 30MHz .

    - difference in time of erase and update a region of SPI flash from memory
      with 10Mhz and 30Mhz frequencey range updation  follows :-

    with 10 Mhz frequency updation :-
    => sf update 0x300000 0x800000 0x400000
    4194304 bytes written, 0 bytes skipped in 36.819s, speed 119837 B/s

    with 30Mhz frequency updation  :-
    => sf update 0x300000 0x800000 0x400000
    4194304 bytes written, 0 bytes skipped in 20.319s, speed 220752 B/s

Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Signed-off-by: Da Xue <da.xue@libretech.co>
Signed-off-by: dsx724 <da@lessconfused.com>
---
Changes for v2 :-
- fixed prefix in commit message .
- squash the all four patches into single patch .
---
 configs/roc-pc-rk3399_defconfig | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/configs/roc-pc-rk3399_defconfig b/configs/roc-pc-rk3399_defconfig
index 4625e47537..7754cb8388 100644
--- a/configs/roc-pc-rk3399_defconfig
+++ b/configs/roc-pc-rk3399_defconfig
@@ -20,6 +20,7 @@ CONFIG_DEBUG_UART=y
 CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
 CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
 # CONFIG_ANDROID_BOOT_IMAGE is not set
+CONFIG_USE_PREBOOT=y
 CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-roc-pc.dtb"
 CONFIG_DISPLAY_BOARDINFO_LATE=y
 CONFIG_SPL_MAX_SIZE=0x2e000
@@ -44,6 +45,7 @@ CONFIG_CMD_TIME=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
 CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_ENV_SPI_MAX_HZ=30000000
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_DM_SEQ_ALIAS=y
 CONFIG_ROCKCHIP_GPIO=y
@@ -54,6 +56,7 @@ CONFIG_MMC_DW_ROCKCHIP=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ROCKCHIP=y
 CONFIG_SF_DEFAULT_BUS=1
+CONFIG_SF_DEFAULT_SPEED=30000000
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
@@ -66,6 +69,8 @@ CONFIG_PWM_ROCKCHIP=y
 # CONFIG_RAM_ROCKCHIP_DEBUG is not set
 CONFIG_RAM_RK3399_LPDDR4=y
 CONFIG_DM_RESET=y
+CONFIG_DM_RNG=y
+CONFIG_RNG_ROCKCHIP=y
 CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_ROCKCHIP_SPI=y
@@ -75,6 +80,9 @@ CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
+CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS=2
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
 CONFIG_USB_KEYBOARD=y
-- 
2.25.1

[PATCH v3] configs:rockchip:roc-rk3399-pc:Enable more configs

[Manoj Sai]

This patch enables the following:

1) use preboot configuration to enable usb devices.

2) Enable USB configs so keyboards and other USB devices work,
   update the number of ports of the usb root hub.

   - with this addition the updated USB device Tree:

	1  Hub (12 Mb/s, 0mA)
	U-Boot Root Hub
	1  Hub (12 Mb/s, 0mA)
	|   U-Boot Root Hub
	|
	+-2  Hub (12 Mb/s, 100mA)
	USB 2.0 Hub [MTT]

	1  Hub (5 Gb/s, 0mA)
	U-Boot XHCI Host Controller

3) enable crypto RNG support.

4) Change SPI speed and frequency:
    - increase the maximum SPI slave device speed,
      SPI flash max frequency for the environment from 10Mhz to 30MHz.

    - performance stats for speed update from 10MHz to 30MHz:

    	with 10Mhz speed update:
    	 => sf update 0x300000 0x800000 0x400000
    	    4194304 bytes written, 0 bytes skipped in 36.819s, speed 119837 B/s

        with 30Mhz speed update:
    	 => sf update 0x300000 0x800000 0x400000
    	    4194304 bytes written, 0 bytes skipped in 20.319s, speed 220752 B/s

Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Signed-off-by: Da Xue <da.xue@libretech.co>
Signed-off-by: dsx724 <da@lessconfused.com>
---
Changes for v3:
- shortened the commit header.
Changes for v2:
- fixed prefix in the commit message.
- squash all four patches into a single patch.
---
 configs/roc-pc-rk3399_defconfig | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/configs/roc-pc-rk3399_defconfig b/configs/roc-pc-rk3399_defconfig
index 4625e47537..7754cb8388 100644
--- a/configs/roc-pc-rk3399_defconfig
+++ b/configs/roc-pc-rk3399_defconfig
@@ -20,6 +20,7 @@ CONFIG_DEBUG_UART=y
 CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
 CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
 # CONFIG_ANDROID_BOOT_IMAGE is not set
+CONFIG_USE_PREBOOT=y
 CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-roc-pc.dtb"
 CONFIG_DISPLAY_BOARDINFO_LATE=y
 CONFIG_SPL_MAX_SIZE=0x2e000
@@ -44,6 +45,7 @@ CONFIG_CMD_TIME=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
 CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_ENV_SPI_MAX_HZ=30000000
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_DM_SEQ_ALIAS=y
 CONFIG_ROCKCHIP_GPIO=y
@@ -54,6 +56,7 @@ CONFIG_MMC_DW_ROCKCHIP=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ROCKCHIP=y
 CONFIG_SF_DEFAULT_BUS=1
+CONFIG_SF_DEFAULT_SPEED=30000000
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
@@ -66,6 +69,8 @@ CONFIG_PWM_ROCKCHIP=y
 # CONFIG_RAM_ROCKCHIP_DEBUG is not set
 CONFIG_RAM_RK3399_LPDDR4=y
 CONFIG_DM_RESET=y
+CONFIG_DM_RNG=y
+CONFIG_RNG_ROCKCHIP=y
 CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_ROCKCHIP_SPI=y
@@ -75,6 +80,9 @@ CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
+CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS=2
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
 CONFIG_USB_KEYBOARD=y
-- 
2.25.1

Re: [PATCH v3] configs:rockchip:roc-rk3399-pc:Enable more configs

[Kever Yang]

On 2022/9/15 15:23, Manoj Sai wrote:
> This patch enables the following:
>
> 1) use preboot configuration to enable usb devices.
>
> 2) Enable USB configs so keyboards and other USB devices work,
>     update the number of ports of the usb root hub.
>
>     - with this addition the updated USB device Tree:
>
> 	1  Hub (12 Mb/s, 0mA)
> 	U-Boot Root Hub
> 	1  Hub (12 Mb/s, 0mA)
> 	|   U-Boot Root Hub
> 	|
> 	+-2  Hub (12 Mb/s, 100mA)
> 	USB 2.0 Hub [MTT]
>
> 	1  Hub (5 Gb/s, 0mA)
> 	U-Boot XHCI Host Controller
>
> 3) enable crypto RNG support.
>
> 4) Change SPI speed and frequency:
>      - increase the maximum SPI slave device speed,
>        SPI flash max frequency for the environment from 10Mhz to 30MHz.
>
>      - performance stats for speed update from 10MHz to 30MHz:
>
>      	with 10Mhz speed update:
>      	 => sf update 0x300000 0x800000 0x400000
>      	    4194304 bytes written, 0 bytes skipped in 36.819s, speed 119837 B/s
>
>          with 30Mhz speed update:
>      	 => sf update 0x300000 0x800000 0x400000
>      	    4194304 bytes written, 0 bytes skipped in 20.319s, speed 220752 B/s
>
> Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> Signed-off-by: Da Xue <da.xue@libretech.co>
> Signed-off-by: dsx724 <da@lessconfused.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
> Changes for v3:
> - shortened the commit header.
> Changes for v2:
> - fixed prefix in the commit message.
> - squash all four patches into a single patch.
> ---
>   configs/roc-pc-rk3399_defconfig | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/configs/roc-pc-rk3399_defconfig b/configs/roc-pc-rk3399_defconfig
> index 4625e47537..7754cb8388 100644
> --- a/configs/roc-pc-rk3399_defconfig
> +++ b/configs/roc-pc-rk3399_defconfig
> @@ -20,6 +20,7 @@ CONFIG_DEBUG_UART=y
>   CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
>   CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
>   # CONFIG_ANDROID_BOOT_IMAGE is not set
> +CONFIG_USE_PREBOOT=y
>   CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-roc-pc.dtb"
>   CONFIG_DISPLAY_BOARDINFO_LATE=y
>   CONFIG_SPL_MAX_SIZE=0x2e000
> @@ -44,6 +45,7 @@ CONFIG_CMD_TIME=y
>   CONFIG_SPL_OF_CONTROL=y
>   CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
>   CONFIG_ENV_IS_IN_SPI_FLASH=y
> +CONFIG_ENV_SPI_MAX_HZ=30000000
>   CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>   CONFIG_SPL_DM_SEQ_ALIAS=y
>   CONFIG_ROCKCHIP_GPIO=y
> @@ -54,6 +56,7 @@ CONFIG_MMC_DW_ROCKCHIP=y
>   CONFIG_MMC_SDHCI=y
>   CONFIG_MMC_SDHCI_ROCKCHIP=y
>   CONFIG_SF_DEFAULT_BUS=1
> +CONFIG_SF_DEFAULT_SPEED=30000000
>   CONFIG_SPI_FLASH_WINBOND=y
>   CONFIG_ETH_DESIGNWARE=y
>   CONFIG_GMAC_ROCKCHIP=y
> @@ -66,6 +69,8 @@ CONFIG_PWM_ROCKCHIP=y
>   # CONFIG_RAM_ROCKCHIP_DEBUG is not set
>   CONFIG_RAM_RK3399_LPDDR4=y
>   CONFIG_DM_RESET=y
> +CONFIG_DM_RNG=y
> +CONFIG_RNG_ROCKCHIP=y
>   CONFIG_BAUDRATE=1500000
>   CONFIG_DEBUG_UART_SHIFT=2
>   CONFIG_ROCKCHIP_SPI=y
> @@ -75,6 +80,9 @@ CONFIG_USB_XHCI_HCD=y
>   CONFIG_USB_XHCI_DWC3=y
>   CONFIG_USB_EHCI_HCD=y
>   CONFIG_USB_EHCI_GENERIC=y
> +CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_OHCI_GENERIC=y
> +CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS=2
>   CONFIG_USB_DWC3=y
>   CONFIG_USB_DWC3_GENERIC=y
>   CONFIG_USB_KEYBOARD=y