[Buildroot] [PATCH] Tagging targets names without hyphens does not run gitlab CI

[Buildroot] [PATCH] Tagging targets names without hyphens does not run gitlab CI

[Thierry GUIBERT via buildroot]

Signed-off-by: Thierry GUIBERT <thierry.guibert@croix-rouge.fr>
---
 support/scripts/generate-gitlab-ci-yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/scripts/generate-gitlab-ci-yml b/support/scripts/generate-gitlab-ci-yml
index aa43aac019..4ae4d13be2 100755
--- a/support/scripts/generate-gitlab-ci-yml
+++ b/support/scripts/generate-gitlab-ci-yml
@@ -71,7 +71,7 @@ gen_tests() {
             defconfigs=( $(cd configs; LC_ALL=C ls -1 | grep ^${pattern}) )
             do_defconfigs=base
             ;;
-          (*-*_defconfig)
+          (*_defconfig)
             defconfigs=( "${CI_COMMIT_REF_NAME##*-}" )
             do_defconfigs=base
             ;;
-- 
2.37.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] Tagging targets names without hyphens does not run gitlab CI

[Yann E. MORIN]

Thierry, All,

On 2022-09-04 15:57 +0200, Thierry GUIBERT via buildroot spake thusly:
> Signed-off-by: Thierry GUIBERT <thierry.guibert@croix-rouge.fr>
> ---
>  support/scripts/generate-gitlab-ci-yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/scripts/generate-gitlab-ci-yml b/support/scripts/generate-gitlab-ci-yml
> index aa43aac019..4ae4d13be2 100755
> --- a/support/scripts/generate-gitlab-ci-yml
> +++ b/support/scripts/generate-gitlab-ci-yml
> @@ -71,7 +71,7 @@ gen_tests() {
>              defconfigs=( $(cd configs; LC_ALL=C ls -1 | grep ^${pattern}) )
>              do_defconfigs=base
>              ;;
> -          (*-*_defconfig)
> +          (*_defconfig)

This is in fact on purpose. The goal is to push a branch (not a tag, by
the way), such as:

    $ git push my-gitlab HEAD:test-my_board_defconfig

This is also how we trigger the other tests:

    $ git push my-gitlab HEAD:test-basics
    $ git push my-gitlab HEAD:test-all-defconfigs
    $ git push my-gitlab HEAD:test-all-runtime-tests

I.e. we are using a dash to allow pushing references into a "testing
namespace" that you clearly mark as tests, that wil not clash with a
naming scheme for the longer-term branches.

Regards,
Yann E. MORIN.

>              defconfigs=( "${CI_COMMIT_REF_NAME##*-}" )
>              do_defconfigs=base
>              ;;
> -- 
> 2.37.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot