All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arvind Yadav <Arvind.Yadav@amd.com>
To: <Christian.Koenig@amd.com>, <andrey.grodzovsky@amd.com>,
	<shashank.sharma@amd.com>, <amaranath.somalapuram@amd.com>,
	<Arunpravin.PaneerSelvam@amd.com>, <sumit.semwal@linaro.org>,
	<gustavo@padovan.org>, <airlied@linux.ie>, <daniel@ffwll.ch>,
	<linux-media@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	<linaro-mm-sig@lists.linaro.org>, <linux-kernel@vger.kernel.org>
Cc: Arvind Yadav <Arvind.Yadav@amd.com>
Subject: [PATCH v2 4/4] dma-buf: Check status of enable-signaling bit on debug
Date: Mon, 5 Sep 2022 22:05:02 +0530	[thread overview]
Message-ID: <20220905163502.4032-5-Arvind.Yadav@amd.com> (raw)
In-Reply-To: <20220905163502.4032-1-Arvind.Yadav@amd.com>

The core DMA-buf framework needs to enable signaling
before the fence is signaled. The core DMA-buf framework
can forget to enable signaling before the fence is signaled.
To avoid this scenario on the debug kernel, check the
DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT status bit before checking
the signaling bit status to confirm that enable_signaling
is enabled.

Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
---

Changes in v1 :
1- Addressing Christian's comment to replace
CONFIG_DEBUG_WW_MUTEX_SLOWPATH instead of CONFIG_DEBUG_FS.
2- As per Christian's comment moving this patch at last so
The version of this patch is also changed and previously
it was [PATCH 1/4]


---
 include/linux/dma-fence.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
index 775cdc0b4f24..ba1ddc14c5d4 100644
--- a/include/linux/dma-fence.h
+++ b/include/linux/dma-fence.h
@@ -428,6 +428,11 @@ dma_fence_is_signaled_locked(struct dma_fence *fence)
 static inline bool
 dma_fence_is_signaled(struct dma_fence *fence)
 {
+#ifdef CONFIG_DEBUG_WW_MUTEX_SLOWPATH
+	if (!test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, &fence->flags))
+		return false;
+#endif
+
 	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
 		return true;
 
-- 
2.25.1


  parent reply	other threads:[~2022-09-05 16:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-05 16:34 [PATCH v2 0/4] dma-buf: To check enable signaling before signaled Arvind Yadav
2022-09-05 16:34 ` [PATCH v2 1/4] drm/sched: Enable signaling for finished fence Arvind Yadav
2022-09-06  6:34   ` Christian König
2022-09-06 19:55     ` Andrey Grodzovsky
2022-09-07  6:37       ` Christian König
2022-09-07 16:18         ` Andrey Grodzovsky
2022-09-05 16:35 ` [PATCH v2 2/4] dma-buf: enable signaling for the stub fence on debug Arvind Yadav
2022-09-06  7:09   ` Christian König
2022-09-09 16:32     ` Yadav, Arvind
2022-09-05 16:35 ` [PATCH v2 3/4] dma-buf: enable signaling for selftest " Arvind Yadav
2022-09-06  7:11   ` Christian König
2022-09-05 16:35 ` Arvind Yadav [this message]
2022-09-06  8:39   ` [PATCH v2 4/4] dma-buf: Check status of enable-signaling bit " Christian König
2022-09-06 10:20     ` Tvrtko Ursulin
2022-09-06 10:43       ` Christian König
2022-09-06 11:21         ` Tvrtko Ursulin
2022-09-06 11:35           ` Christian König
2022-09-06 11:38           ` Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220905163502.4032-5-Arvind.Yadav@amd.com \
    --to=arvind.yadav@amd.com \
    --cc=Arunpravin.PaneerSelvam@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=airlied@linux.ie \
    --cc=amaranath.somalapuram@amd.com \
    --cc=andrey.grodzovsky@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo@padovan.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=shashank.sharma@amd.com \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.