From: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
To: "Christian König" <christian.koenig@amd.com>,
"Arvind Yadav" <Arvind.Yadav@amd.com>,
shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] drm/sched: Enable signaling for finished fence
Date: Tue, 6 Sep 2022 15:55:44 -0400 [thread overview]
Message-ID: <ffb5acca-7c20-4497-d7d0-25508a6566d2@amd.com> (raw)
In-Reply-To: <5568fad0-1503-a0f3-222e-c238fd4eefdd@amd.com>
On 2022-09-06 02:34, Christian König wrote:
> Am 05.09.22 um 18:34 schrieb Arvind Yadav:
>> Here's enabling software signaling for finished fence.
>>
>> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
>> ---
>>
>> Changes in v1 :
>> 1- Addressing Christian's comment to remove CONFIG_DEBUG_FS check from
>> this patch.
>> 2- The version of this patch is also changed and previously
>> it was [PATCH 2/4]
>>
>> ---
>> drivers/gpu/drm/scheduler/sched_main.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/scheduler/sched_main.c
>> b/drivers/gpu/drm/scheduler/sched_main.c
>> index e0ab14e0fb6b..fe72de0e2911 100644
>> --- a/drivers/gpu/drm/scheduler/sched_main.c
>> +++ b/drivers/gpu/drm/scheduler/sched_main.c
>> @@ -962,6 +962,8 @@ static int drm_sched_main(void *param)
>> /* Drop for original kref_init of the fence */
>> dma_fence_put(fence);
>> + dma_fence_enable_sw_signaling(&s_fence->finished);
>
> Ok, this makes it a lot clearer. Previously I though that we have some
> bug in dma_fence_add_callback().
>
> This is essentially the wrong place to call this, the finished fence
> should be enabled by the caller and not here.
>
> There is also another problem in dma_fence_enable_sw_signaling(), it
> returns early when the fence is already signaled:
>
> if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
> return;
>
> Please remove that one first.
Why we even need this explicit call if dma_fence_add_callback calls
__dma_fence_enable_signaling anyway ?
Andrey
>
> Thanks,
> Christian.
>
>
>> +
>> r = dma_fence_add_callback(fence, &sched_job->cb,
>> drm_sched_job_done_cb);
>> if (r == -ENOENT)
>
next prev parent reply other threads:[~2022-09-06 20:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 16:34 [PATCH v2 0/4] dma-buf: To check enable signaling before signaled Arvind Yadav
2022-09-05 16:34 ` [PATCH v2 1/4] drm/sched: Enable signaling for finished fence Arvind Yadav
2022-09-06 6:34 ` Christian König
2022-09-06 19:55 ` Andrey Grodzovsky [this message]
2022-09-07 6:37 ` Christian König
2022-09-07 16:18 ` Andrey Grodzovsky
2022-09-05 16:35 ` [PATCH v2 2/4] dma-buf: enable signaling for the stub fence on debug Arvind Yadav
2022-09-06 7:09 ` Christian König
2022-09-09 16:32 ` Yadav, Arvind
2022-09-05 16:35 ` [PATCH v2 3/4] dma-buf: enable signaling for selftest " Arvind Yadav
2022-09-06 7:11 ` Christian König
2022-09-05 16:35 ` [PATCH v2 4/4] dma-buf: Check status of enable-signaling bit " Arvind Yadav
2022-09-06 8:39 ` Christian König
2022-09-06 10:20 ` Tvrtko Ursulin
2022-09-06 10:43 ` Christian König
2022-09-06 11:21 ` Tvrtko Ursulin
2022-09-06 11:35 ` Christian König
2022-09-06 11:38 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffb5acca-7c20-4497-d7d0-25508a6566d2@amd.com \
--to=andrey.grodzovsky@amd.com \
--cc=Arunpravin.PaneerSelvam@amd.com \
--cc=Arvind.Yadav@amd.com \
--cc=airlied@linux.ie \
--cc=amaranath.somalapuram@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=shashank.sharma@amd.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.