All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Peng Fan <peng.fan@oss.nxp.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V8 4/6] soc: imx: add i.MX93 media blk ctrl driver
Date: Tue, 6 Sep 2022 10:09:17 +0800	[thread overview]
Message-ID: <20220906020917.GM1728671@dragon> (raw)
In-Reply-To: <26552553-b598-3179-40f8-170e766e3809@oss.nxp.com>

On Mon, Sep 05, 2022 at 02:47:16PM +0800, Peng Fan wrote:
[...]
> > > +struct imx93_blk_ctrl_data {
> > > +	const struct imx93_blk_ctrl_domain_data *domains;
> > > +	const struct imx93_blk_ctrl_domain_data *bus;
> > 
> > It looks confusing to claim 'bus' as an imx93_blk_ctrl_domain_data.  I
> > would suggest you have 'related' fields directly defined in
> > imx93_blk_ctrl_data.
> 
> This would implies a bit large change to this driver.
> 
> Should I use a new V1 for the patchset or continue V9 for next version?

I think v9 is fine.

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Peng Fan <peng.fan@oss.nxp.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V8 4/6] soc: imx: add i.MX93 media blk ctrl driver
Date: Tue, 6 Sep 2022 10:09:17 +0800	[thread overview]
Message-ID: <20220906020917.GM1728671@dragon> (raw)
In-Reply-To: <26552553-b598-3179-40f8-170e766e3809@oss.nxp.com>

On Mon, Sep 05, 2022 at 02:47:16PM +0800, Peng Fan wrote:
[...]
> > > +struct imx93_blk_ctrl_data {
> > > +	const struct imx93_blk_ctrl_domain_data *domains;
> > > +	const struct imx93_blk_ctrl_domain_data *bus;
> > 
> > It looks confusing to claim 'bus' as an imx93_blk_ctrl_domain_data.  I
> > would suggest you have 'related' fields directly defined in
> > imx93_blk_ctrl_data.
> 
> This would implies a bit large change to this driver.
> 
> Should I use a new V1 for the patchset or continue V9 for next version?

I think v9 is fine.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-09-06  2:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23  5:52 [PATCH V8 0/6] imx: support i.MX93 SRC and mediamix blk ctrl Peng Fan (OSS)
2022-08-23  5:52 ` Peng Fan (OSS)
2022-08-23  5:52 ` [PATCH V8 1/6] dt-bindings: soc: add i.MX93 SRC Peng Fan (OSS)
2022-08-23  5:52   ` Peng Fan (OSS)
2022-08-23  5:52 ` [PATCH V8 2/6] dt-bindings: soc: add i.MX93 mediamix blk ctrl Peng Fan (OSS)
2022-08-23  5:52   ` Peng Fan (OSS)
2022-08-23  5:52 ` [PATCH V8 3/6] soc: imx: add i.MX93 SRC power domain driver Peng Fan (OSS)
2022-08-23  5:52   ` Peng Fan (OSS)
2022-09-04  9:52   ` Shawn Guo
2022-09-04  9:52     ` Shawn Guo
2022-09-05  1:35     ` Peng Fan
2022-09-05  1:35       ` Peng Fan
2022-08-23  5:52 ` [PATCH V8 4/6] soc: imx: add i.MX93 media blk ctrl driver Peng Fan (OSS)
2022-08-23  5:52   ` Peng Fan (OSS)
2022-09-04 10:44   ` Shawn Guo
2022-09-04 10:44     ` Shawn Guo
2022-09-05  6:47     ` Peng Fan
2022-09-05  6:47       ` Peng Fan
2022-09-06  2:09       ` Shawn Guo [this message]
2022-09-06  2:09         ` Shawn Guo
2022-08-23  5:52 ` [PATCH V8 5/6] arm64: dts: imx93: add src node Peng Fan (OSS)
2022-08-23  5:52   ` Peng Fan (OSS)
2022-08-23  5:52 ` [PATCH V8 6/6] arm64: dts: imx93: add mediamix blk ctrl node Peng Fan (OSS)
2022-08-23  5:52   ` Peng Fan (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220906020917.GM1728671@dragon \
    --to=shawnguo@kernel.org \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.