From: Rob Herring <robh@kernel.org> To: Thierry Reding <thierry.reding@gmail.com> Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, Jon Hunter <jonathanh@nvidia.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-tegra@vger.kernel.org Subject: Re: [PATCH 2/6] dt-bindings: reserved-memory: Support framebuffer reserved memory Date: Tue, 6 Sep 2022 09:27:21 -0500 [thread overview] Message-ID: <20220906142721.GA427176-robh@kernel.org> (raw) In-Reply-To: <20220905163300.391692-3-thierry.reding@gmail.com> On Mon, Sep 05, 2022 at 06:32:56PM +0200, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Document the "framebuffer" compatible string for reserved memory nodes > to annotate reserved memory regions used for framebuffer carveouts. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > .../bindings/reserved-memory/framebuffer.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reserved-memory/framebuffer.yaml > > diff --git a/Documentation/devicetree/bindings/reserved-memory/framebuffer.yaml b/Documentation/devicetree/bindings/reserved-memory/framebuffer.yaml > new file mode 100644 > index 000000000000..80574854025d > --- /dev/null > +++ b/Documentation/devicetree/bindings/reserved-memory/framebuffer.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reserved-memory/framebuffer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: /reserved-memory framebuffer node bindings > + > +maintainers: > + - devicetree-spec@vger.kernel.org > + > +allOf: > + - $ref: "reserved-memory.yaml" Don't need quotes. > + > +properties: > + compatible: > + const: framebuffer > + description: > > + This indicates a region of memory meant to be used as a framebuffer for > + a set of display devices. It can be used by an operating system to keep > + the framebuffer from being overwritten and use it as the backing memory > + for a display device (such as simple-framebuffer). I'm on the fence whether we need this. It doesn't really add anything because 'simple-framebuffer' will reference this node and you can find it that way. I guess a bootloader may not setup 'simple-framebuffer', but then it should probably not have this node either. On the flip side, better to have compatibles than not to identify nodes. > + > +unevaluatedProperties: false > + > +examples: > + - | Use '/ {' to skip the boilerplate causing the error. > + chosen { > + framebuffer { > + compatible = "simple-framebuffer"; > + memory-region = <&fb>; > + }; > + }; > + > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + fb: framebuffer@80000000 { > + compatible = "framebuffer"; > + reg = <0x80000000 0x007e9000>; > + }; > + }; > + > +... > -- > 2.37.2 > >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Thierry Reding <thierry.reding@gmail.com> Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Jon Hunter <jonathanh@nvidia.com> Subject: Re: [PATCH 2/6] dt-bindings: reserved-memory: Support framebuffer reserved memory Date: Tue, 6 Sep 2022 09:27:21 -0500 [thread overview] Message-ID: <20220906142721.GA427176-robh@kernel.org> (raw) In-Reply-To: <20220905163300.391692-3-thierry.reding@gmail.com> On Mon, Sep 05, 2022 at 06:32:56PM +0200, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Document the "framebuffer" compatible string for reserved memory nodes > to annotate reserved memory regions used for framebuffer carveouts. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > .../bindings/reserved-memory/framebuffer.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reserved-memory/framebuffer.yaml > > diff --git a/Documentation/devicetree/bindings/reserved-memory/framebuffer.yaml b/Documentation/devicetree/bindings/reserved-memory/framebuffer.yaml > new file mode 100644 > index 000000000000..80574854025d > --- /dev/null > +++ b/Documentation/devicetree/bindings/reserved-memory/framebuffer.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reserved-memory/framebuffer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: /reserved-memory framebuffer node bindings > + > +maintainers: > + - devicetree-spec@vger.kernel.org > + > +allOf: > + - $ref: "reserved-memory.yaml" Don't need quotes. > + > +properties: > + compatible: > + const: framebuffer > + description: > > + This indicates a region of memory meant to be used as a framebuffer for > + a set of display devices. It can be used by an operating system to keep > + the framebuffer from being overwritten and use it as the backing memory > + for a display device (such as simple-framebuffer). I'm on the fence whether we need this. It doesn't really add anything because 'simple-framebuffer' will reference this node and you can find it that way. I guess a bootloader may not setup 'simple-framebuffer', but then it should probably not have this node either. On the flip side, better to have compatibles than not to identify nodes. > + > +unevaluatedProperties: false > + > +examples: > + - | Use '/ {' to skip the boilerplate causing the error. > + chosen { > + framebuffer { > + compatible = "simple-framebuffer"; > + memory-region = <&fb>; > + }; > + }; > + > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + fb: framebuffer@80000000 { > + compatible = "framebuffer"; > + reg = <0x80000000 0x007e9000>; > + }; > + }; > + > +... > -- > 2.37.2 > >
next prev parent reply other threads:[~2022-09-06 14:27 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-05 16:32 [PATCH 0/6] drm/simpledrm: Support system memory framebuffers Thierry Reding 2022-09-05 16:32 ` Thierry Reding 2022-09-05 16:32 ` [PATCH 1/6] dt-bindings: display: simple-framebuffer: " Thierry Reding 2022-09-05 16:32 ` Thierry Reding 2022-09-05 16:32 ` [PATCH 2/6] dt-bindings: reserved-memory: Support framebuffer reserved memory Thierry Reding 2022-09-05 16:32 ` Thierry Reding 2022-09-06 2:29 ` Rob Herring 2022-09-06 2:29 ` Rob Herring 2022-09-06 14:27 ` Rob Herring [this message] 2022-09-06 14:27 ` Rob Herring 2022-09-14 16:05 ` Thierry Reding 2022-09-14 16:05 ` Thierry Reding 2022-09-05 16:32 ` [PATCH 3/6] drm/simpledrm: Add support for system memory framebuffers Thierry Reding 2022-09-05 16:32 ` Thierry Reding 2022-09-24 11:43 ` kernel test robot 2022-09-24 11:43 ` kernel test robot 2022-09-05 16:32 ` [PATCH 4/6] drm/format-helper: Support the AB24 format Thierry Reding 2022-09-05 16:32 ` Thierry Reding 2022-09-07 7:23 ` Thomas Zimmermann 2022-09-14 16:09 ` Thierry Reding 2022-09-14 16:09 ` Thierry Reding 2022-09-05 16:32 ` [PATCH 5/6] drm/simpledrm: " Thierry Reding 2022-09-05 16:32 ` Thierry Reding 2022-09-07 7:12 ` Thomas Zimmermann 2022-09-05 16:33 ` [PATCH 6/6] arm64: tegra: Add simple framebuffer on Jetson Xavier NX Thierry Reding 2022-09-05 16:33 ` Thierry Reding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220906142721.GA427176-robh@kernel.org \ --to=robh@kernel.org \ --cc=airlied@linux.ie \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jonathanh@nvidia.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-tegra@vger.kernel.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.