* Re: [PATCH v2] ARM: dts: aspeed: yosemit V2: Update for Facebook Yosemite V2 BMC
@ 2022-09-12 22:32 ` Patrick Williams
0 siblings, 0 replies; 6+ messages in thread
From: Patrick Williams @ 2022-09-12 22:32 UTC (permalink / raw)
To: Karthikeyan Pasupathi
Cc: Rob Herring, Joel Stanley, Andrew Jeffery, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, openbmc
[-- Attachment #1.1: Type: text/plain, Size: 1129 bytes --]
On Wed, Sep 07, 2022 at 06:20:35PM +0530, Karthikeyan Pasupathi wrote:
Please improve the title and commit message here. "Update" is
insufficient for a title. There is no description of _why_ in the commit
message.
> Removed NIC EEPROM driver IPMB-12 channel and keeping it as
> "status ok".
>
> ---
> --- v2- Updated the title
> ---
>
> ---
> --- v1- Initial draft
> ---
>
> Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> index 8864e9c312a8..2293f10e94d6 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> @@ -207,12 +207,6 @@
>
> &i2c12 {
> status = "okay";
> - //MEZZ_FRU
> - eeprom@51 {
> - compatible = "atmel,24c64";
> - reg = <0x51>;
> - pagesize = <32>;
> - };
> };
>
> &pwm_tacho {
> --
> 2.17.1
>
--
Patrick Williams
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] ARM: dts: aspeed: yosemit V2: Update for Facebook Yosemite V2 BMC
@ 2022-09-12 22:32 ` Patrick Williams
0 siblings, 0 replies; 6+ messages in thread
From: Patrick Williams @ 2022-09-12 22:32 UTC (permalink / raw)
To: Karthikeyan Pasupathi
Cc: devicetree, linux-aspeed, Andrew Jeffery, openbmc, linux-kernel,
Rob Herring, Joel Stanley, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]
On Wed, Sep 07, 2022 at 06:20:35PM +0530, Karthikeyan Pasupathi wrote:
Please improve the title and commit message here. "Update" is
insufficient for a title. There is no description of _why_ in the commit
message.
> Removed NIC EEPROM driver IPMB-12 channel and keeping it as
> "status ok".
>
> ---
> --- v2- Updated the title
> ---
>
> ---
> --- v1- Initial draft
> ---
>
> Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> index 8864e9c312a8..2293f10e94d6 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> @@ -207,12 +207,6 @@
>
> &i2c12 {
> status = "okay";
> - //MEZZ_FRU
> - eeprom@51 {
> - compatible = "atmel,24c64";
> - reg = <0x51>;
> - pagesize = <32>;
> - };
> };
>
> &pwm_tacho {
> --
> 2.17.1
>
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] ARM: dts: aspeed: yosemit V2: Update for Facebook Yosemite V2 BMC
2022-09-12 22:32 ` Patrick Williams
(?)
(?)
@ 2022-09-13 10:04 ` karthikeyan P
-1 siblings, 0 replies; 6+ messages in thread
From: karthikeyan P @ 2022-09-13 10:04 UTC (permalink / raw)
To: Patrick Williams
Cc: devicetree, linux-aspeed, Andrew Jeffery, openbmc, linux-kernel,
Rob Herring, Joel Stanley, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]
Done.
On Tue, Sep 13, 2022 at 4:02 AM Patrick Williams <patrick@stwcx.xyz> wrote:
> On Wed, Sep 07, 2022 at 06:20:35PM +0530, Karthikeyan Pasupathi wrote:
>
> Please improve the title and commit message here. "Update" is
> insufficient for a title. There is no description of _why_ in the commit
> message.
>
> > Removed NIC EEPROM driver IPMB-12 channel and keeping it as
> > "status ok".
> >
> > ---
> > --- v2- Updated the title
> > ---
> >
> > ---
> > --- v1- Initial draft
> > ---
> >
> > Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> > ---
> > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> > index 8864e9c312a8..2293f10e94d6 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> > @@ -207,12 +207,6 @@
> >
> > &i2c12 {
> > status = "okay";
> > - //MEZZ_FRU
> > - eeprom@51 {
> > - compatible = "atmel,24c64";
> > - reg = <0x51>;
> > - pagesize = <32>;
> > - };
> > };
> >
> > &pwm_tacho {
> > --
> > 2.17.1
> >
>
> --
> Patrick Williams
>
[-- Attachment #2: Type: text/html, Size: 2005 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread