* [Intel-gfx] [PATCH] Revert "drm/i915/dg2: extend Wa_1409120013 to DG2"
@ 2022-09-07 20:26 Lucas De Marchi
2022-09-07 20:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-09-07 22:28 ` [Intel-gfx] [PATCH] " Matt Roper
0 siblings, 2 replies; 4+ messages in thread
From: Lucas De Marchi @ 2022-09-07 20:26 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi
This reverts commit 487970e8bb776c989013bb59d6cbb22e45b9afc6.
Updated bspec and workaround database note Wa_1409120013 is not needed
for DG2 (or any Display 13) platform.
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Matt Atwood <matthew.s.atwood@intel.com>
Cc: Clint Taylor <Clinton.A.Taylor@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 210c1f78cc90..6ff0b80e69ac 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -7614,9 +7614,9 @@ static void icl_init_clock_gating(struct drm_i915_private *dev_priv)
static void gen12lp_init_clock_gating(struct drm_i915_private *dev_priv)
{
- /* Wa_1409120013:tgl,rkl,adl-s,dg1,dg2 */
+ /* Wa_1409120013:tgl,rkl,adl-s,dg1 */
if (IS_TIGERLAKE(dev_priv) || IS_ROCKETLAKE(dev_priv) ||
- IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv) || IS_DG2(dev_priv))
+ IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv))
intel_uncore_write(&dev_priv->uncore, ILK_DPFC_CHICKEN(INTEL_FBC_A),
DPFC_CHICKEN_COMP_DUMMY_PIXEL);
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915/dg2: extend Wa_1409120013 to DG2"
2022-09-07 20:26 [Intel-gfx] [PATCH] Revert "drm/i915/dg2: extend Wa_1409120013 to DG2" Lucas De Marchi
@ 2022-09-07 20:56 ` Patchwork
2022-09-07 22:28 ` [Intel-gfx] [PATCH] " Matt Roper
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2022-09-07 20:56 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5065 bytes --]
== Series Details ==
Series: Revert "drm/i915/dg2: extend Wa_1409120013 to DG2"
URL : https://patchwork.freedesktop.org/series/108266/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12090 -> Patchwork_108266v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108266v1/index.html
Participating hosts (43 -> 41)
------------------------------
Additional (1): fi-snb-2600
Missing (3): fi-rkl-11600 fi-icl-u2 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_108266v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-snb-2600: NOTRUN -> [SKIP][1] ([fdo#109271]) +20 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108266v1/fi-snb-2600/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@gem:
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][2] ([i915#4528])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108266v1/fi-pnv-d510/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-g3258: [PASS][3] -> [INCOMPLETE][4] ([i915#3303] / [i915#4785])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12090/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108266v1/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@vga-hpd-fast:
- fi-snb-2600: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108266v1/fi-snb-2600/igt@kms_chamelium@vga-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [PASS][6] -> [FAIL][7] ([i915#6298])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12090/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108266v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
* igt@runner@aborted:
- fi-hsw-g3258: NOTRUN -> [FAIL][8] ([fdo#109271] / [i915#4312] / [i915#6246])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108266v1/fi-hsw-g3258/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- {bat-rplp-1}: [DMESG-WARN][9] ([i915#2867]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12090/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108266v1/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][11] ([i915#4528]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12090/fi-pnv-d510/igt@i915_selftest@live@requests.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108266v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@workarounds:
- {bat-rpls-1}: [DMESG-FAIL][13] -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12090/bat-rpls-1/igt@i915_selftest@live@workarounds.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108266v1/bat-rpls-1/igt@i915_selftest@live@workarounds.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6106]: https://gitlab.freedesktop.org/drm/intel/issues/6106
[i915#6246]: https://gitlab.freedesktop.org/drm/intel/issues/6246
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
Build changes
-------------
* Linux: CI_DRM_12090 -> Patchwork_108266v1
CI-20190529: 20190529
CI_DRM_12090: 7710b0d1501fc279a2f0e8571a48500017b6a4d3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6648: 3c9079c0b97445fbfc903b9c5a1d69707b80af80 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_108266v1: 7710b0d1501fc279a2f0e8571a48500017b6a4d3 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
6355bd71d308 Revert "drm/i915/dg2: extend Wa_1409120013 to DG2"
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108266v1/index.html
[-- Attachment #2: Type: text/html, Size: 5906 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] Revert "drm/i915/dg2: extend Wa_1409120013 to DG2"
2022-09-07 20:26 [Intel-gfx] [PATCH] Revert "drm/i915/dg2: extend Wa_1409120013 to DG2" Lucas De Marchi
2022-09-07 20:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-09-07 22:28 ` Matt Roper
2022-09-07 23:15 ` Lucas De Marchi
1 sibling, 1 reply; 4+ messages in thread
From: Matt Roper @ 2022-09-07 22:28 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Wed, Sep 07, 2022 at 01:26:06PM -0700, Lucas De Marchi wrote:
> This reverts commit 487970e8bb776c989013bb59d6cbb22e45b9afc6.
>
> Updated bspec and workaround database note Wa_1409120013 is not needed
> for DG2 (or any Display 13) platform.
This should probably say "Xe_LPD" to use standard terminology.
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Matt Atwood <matthew.s.atwood@intel.com>
> Cc: Clint Taylor <Clinton.A.Taylor@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 210c1f78cc90..6ff0b80e69ac 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -7614,9 +7614,9 @@ static void icl_init_clock_gating(struct drm_i915_private *dev_priv)
>
> static void gen12lp_init_clock_gating(struct drm_i915_private *dev_priv)
> {
> - /* Wa_1409120013:tgl,rkl,adl-s,dg1,dg2 */
> + /* Wa_1409120013:tgl,rkl,adl-s,dg1 */
When adding new workarounds lately I've been dropping the platform
trailers since it's obvious enough from the next few lines of code (and
it's easy for the comments to get out of sync with the code). I'd be
tempted to just shorten this to "/* Wa_1409120013 */" but up to you.
> if (IS_TIGERLAKE(dev_priv) || IS_ROCKETLAKE(dev_priv) ||
> - IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv) || IS_DG2(dev_priv))
> + IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv))
We could also go with
if (DISPLAY_VER(dev_priv) == 12)
to simplify.
Anway, both of the code suggestions are optional; up to you whether you
think they're worth incorporating or not.
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
with the small commit message tweak.
Matt
> intel_uncore_write(&dev_priv->uncore, ILK_DPFC_CHICKEN(INTEL_FBC_A),
> DPFC_CHICKEN_COMP_DUMMY_PIXEL);
>
> --
> 2.37.2
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] Revert "drm/i915/dg2: extend Wa_1409120013 to DG2"
2022-09-07 22:28 ` [Intel-gfx] [PATCH] " Matt Roper
@ 2022-09-07 23:15 ` Lucas De Marchi
0 siblings, 0 replies; 4+ messages in thread
From: Lucas De Marchi @ 2022-09-07 23:15 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Wed, Sep 07, 2022 at 03:28:30PM -0700, Matt Roper wrote:
>On Wed, Sep 07, 2022 at 01:26:06PM -0700, Lucas De Marchi wrote:
>> This reverts commit 487970e8bb776c989013bb59d6cbb22e45b9afc6.
>>
>> Updated bspec and workaround database note Wa_1409120013 is not needed
>> for DG2 (or any Display 13) platform.
>
>This should probably say "Xe_LPD" to use standard terminology.
>
>>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>> Cc: Matt Atwood <matthew.s.atwood@intel.com>
>> Cc: Clint Taylor <Clinton.A.Taylor@intel.com>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_pm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>> index 210c1f78cc90..6ff0b80e69ac 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -7614,9 +7614,9 @@ static void icl_init_clock_gating(struct drm_i915_private *dev_priv)
>>
>> static void gen12lp_init_clock_gating(struct drm_i915_private *dev_priv)
>> {
>> - /* Wa_1409120013:tgl,rkl,adl-s,dg1,dg2 */
>> + /* Wa_1409120013:tgl,rkl,adl-s,dg1 */
>
>When adding new workarounds lately I've been dropping the platform
>trailers since it's obvious enough from the next few lines of code (and
>it's easy for the comments to get out of sync with the code). I'd be
>tempted to just shorten this to "/* Wa_1409120013 */" but up to you.
>
>> if (IS_TIGERLAKE(dev_priv) || IS_ROCKETLAKE(dev_priv) ||
>> - IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv) || IS_DG2(dev_priv))
>> + IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv))
>
>We could also go with
>
> if (DISPLAY_VER(dev_priv) == 12)
>
>to simplify.
indeed, that is better. I will send a new version.
thanks
Lucas De Marchi
>
>Anway, both of the code suggestions are optional; up to you whether you
>think they're worth incorporating or not.
>
>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
>with the small commit message tweak.
>
>
>Matt
>
>> intel_uncore_write(&dev_priv->uncore, ILK_DPFC_CHICKEN(INTEL_FBC_A),
>> DPFC_CHICKEN_COMP_DUMMY_PIXEL);
>>
>> --
>> 2.37.2
>>
>
>--
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-07 23:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-07 20:26 [Intel-gfx] [PATCH] Revert "drm/i915/dg2: extend Wa_1409120013 to DG2" Lucas De Marchi
2022-09-07 20:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-09-07 22:28 ` [Intel-gfx] [PATCH] " Matt Roper
2022-09-07 23:15 ` Lucas De Marchi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.