All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: remove xfs_setattr_time() declaration
@ 2022-09-09  6:56 ` Gaosheng Cui
  2022-09-09  7:42   ` Carlos Maiolino
  2022-09-14 16:43   ` Darrick J. Wong
  0 siblings, 2 replies; 3+ messages in thread
From: Gaosheng Cui @ 2022-09-09  6:56 UTC (permalink / raw)
  To: djwong, cuigaosheng1; +Cc: linux-xfs, linux-kernel

xfs_setattr_time() has been removed since
commit e014f37db1a2 ("xfs: use setattr_copy to set vfs inode
attributes"), so remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 fs/xfs/xfs_iops.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_iops.h b/fs/xfs/xfs_iops.h
index cb5fc68c9ea0..e570dcb5df8d 100644
--- a/fs/xfs/xfs_iops.h
+++ b/fs/xfs/xfs_iops.h
@@ -13,7 +13,6 @@ extern const struct file_operations xfs_dir_file_operations;
 
 extern ssize_t xfs_vn_listxattr(struct dentry *, char *data, size_t size);
 
-extern void xfs_setattr_time(struct xfs_inode *ip, struct iattr *iattr);
 int xfs_vn_setattr_size(struct user_namespace *mnt_userns,
 		struct dentry *dentry, struct iattr *vap);
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs: remove xfs_setattr_time() declaration
  2022-09-09  6:56 ` [PATCH] xfs: remove xfs_setattr_time() declaration Gaosheng Cui
@ 2022-09-09  7:42   ` Carlos Maiolino
  2022-09-14 16:43   ` Darrick J. Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Carlos Maiolino @ 2022-09-09  7:42 UTC (permalink / raw)
  To: Gaosheng Cui; +Cc: djwong, linux-xfs, linux-kernel

On Fri, Sep 09, 2022 at 02:56:54PM +0800, Gaosheng Cui wrote:
> xfs_setattr_time() has been removed since
> commit e014f37db1a2 ("xfs: use setattr_copy to set vfs inode
> attributes"), so remove it.
> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> ---
>  fs/xfs/xfs_iops.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_iops.h b/fs/xfs/xfs_iops.h
> index cb5fc68c9ea0..e570dcb5df8d 100644
> --- a/fs/xfs/xfs_iops.h
> +++ b/fs/xfs/xfs_iops.h
> @@ -13,7 +13,6 @@ extern const struct file_operations xfs_dir_file_operations;
> 
>  extern ssize_t xfs_vn_listxattr(struct dentry *, char *data, size_t size);
> 
> -extern void xfs_setattr_time(struct xfs_inode *ip, struct iattr *iattr);
>  int xfs_vn_setattr_size(struct user_namespace *mnt_userns,
>  		struct dentry *dentry, struct iattr *vap);
> 
> --
> 2.25.1
> 

-- 
Carlos Maiolino

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs: remove xfs_setattr_time() declaration
  2022-09-09  6:56 ` [PATCH] xfs: remove xfs_setattr_time() declaration Gaosheng Cui
  2022-09-09  7:42   ` Carlos Maiolino
@ 2022-09-14 16:43   ` Darrick J. Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2022-09-14 16:43 UTC (permalink / raw)
  To: Gaosheng Cui; +Cc: linux-xfs, linux-kernel

On Fri, Sep 09, 2022 at 02:56:54PM +0800, Gaosheng Cui wrote:
> xfs_setattr_time() has been removed since
> commit e014f37db1a2 ("xfs: use setattr_copy to set vfs inode
> attributes"), so remove it.
> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>

LGTM
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_iops.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_iops.h b/fs/xfs/xfs_iops.h
> index cb5fc68c9ea0..e570dcb5df8d 100644
> --- a/fs/xfs/xfs_iops.h
> +++ b/fs/xfs/xfs_iops.h
> @@ -13,7 +13,6 @@ extern const struct file_operations xfs_dir_file_operations;
>  
>  extern ssize_t xfs_vn_listxattr(struct dentry *, char *data, size_t size);
>  
> -extern void xfs_setattr_time(struct xfs_inode *ip, struct iattr *iattr);
>  int xfs_vn_setattr_size(struct user_namespace *mnt_userns,
>  		struct dentry *dentry, struct iattr *vap);
>  
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-14 16:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <5ULHhpqphBoOnMKjmfB_koRPr8gBCbu0c-YxXp0hWk_bW7qfDW1s_UDSEf9DgGb6e44nKcEmuQyZiD5rLWiKOQ==@protonmail.internalid>
2022-09-09  6:56 ` [PATCH] xfs: remove xfs_setattr_time() declaration Gaosheng Cui
2022-09-09  7:42   ` Carlos Maiolino
2022-09-14 16:43   ` Darrick J. Wong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.