All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Banajit Goswami <bgoswami@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v4 13/15] ASoC: dt-bindings: qcom,q6dsp-lpass-clocks: cleanup example
Date: Sat, 10 Sep 2022 11:14:26 +0200	[thread overview]
Message-ID: <20220910091428.50418-14-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20220910091428.50418-1-krzysztof.kozlowski@linaro.org>

Cleanup the example DTS by adding APR and service compatibles, adding
typical properties, using proper device node names for services and
fixing indentation to 4-spaces.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

---

Changes since v1:
1. Add few more properties.
2. Adjust indentation (better).
---
 .../sound/qcom,q6dsp-lpass-clocks.yaml        | 20 ++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-clocks.yaml b/Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-clocks.yaml
index 604861d84ffa..fd567d20417d 100644
--- a/Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-clocks.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-clocks.yaml
@@ -38,17 +38,22 @@ examples:
     #include <dt-bindings/soc/qcom,apr.h>
     #include <dt-bindings/sound/qcom,q6afe.h>
     apr {
+        compatible = "qcom,apr-v2";
+        qcom,domain = <APR_DOMAIN_ADSP>;
         #address-cells = <1>;
         #size-cells = <0>;
-        apr-service@4 {
+
+        service@4 {
+            compatible = "qcom,q6afe";
             reg = <APR_SVC_AFE>;
+            qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
 
             clock-controller {
-              compatible = "qcom,q6afe-clocks";
-              #clock-cells = <2>;
+                compatible = "qcom,q6afe-clocks";
+                #clock-cells = <2>;
             };
         };
-      };
+    };
 
   - |
     #include <dt-bindings/soc/qcom,gpr.h>
@@ -57,13 +62,14 @@ examples:
         qcom,domain = <GPR_DOMAIN_ID_ADSP>;
         #address-cells = <1>;
         #size-cells = <0>;
+
         service@2 {
             reg = <GPR_PRM_MODULE_IID>;
             compatible = "qcom,q6prm";
 
             clock-controller {
-              compatible = "qcom,q6prm-lpass-clocks";
-              #clock-cells = <2>;
+                compatible = "qcom,q6prm-lpass-clocks";
+                #clock-cells = <2>;
             };
         };
-      };
+    };
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Banajit Goswami <bgoswami@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v4 13/15] ASoC: dt-bindings: qcom, q6dsp-lpass-clocks: cleanup example
Date: Sat, 10 Sep 2022 11:14:26 +0200	[thread overview]
Message-ID: <20220910091428.50418-14-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20220910091428.50418-1-krzysztof.kozlowski@linaro.org>

Cleanup the example DTS by adding APR and service compatibles, adding
typical properties, using proper device node names for services and
fixing indentation to 4-spaces.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

---

Changes since v1:
1. Add few more properties.
2. Adjust indentation (better).
---
 .../sound/qcom,q6dsp-lpass-clocks.yaml        | 20 ++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-clocks.yaml b/Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-clocks.yaml
index 604861d84ffa..fd567d20417d 100644
--- a/Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-clocks.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-clocks.yaml
@@ -38,17 +38,22 @@ examples:
     #include <dt-bindings/soc/qcom,apr.h>
     #include <dt-bindings/sound/qcom,q6afe.h>
     apr {
+        compatible = "qcom,apr-v2";
+        qcom,domain = <APR_DOMAIN_ADSP>;
         #address-cells = <1>;
         #size-cells = <0>;
-        apr-service@4 {
+
+        service@4 {
+            compatible = "qcom,q6afe";
             reg = <APR_SVC_AFE>;
+            qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
 
             clock-controller {
-              compatible = "qcom,q6afe-clocks";
-              #clock-cells = <2>;
+                compatible = "qcom,q6afe-clocks";
+                #clock-cells = <2>;
             };
         };
-      };
+    };
 
   - |
     #include <dt-bindings/soc/qcom,gpr.h>
@@ -57,13 +62,14 @@ examples:
         qcom,domain = <GPR_DOMAIN_ID_ADSP>;
         #address-cells = <1>;
         #size-cells = <0>;
+
         service@2 {
             reg = <GPR_PRM_MODULE_IID>;
             compatible = "qcom,q6prm";
 
             clock-controller {
-              compatible = "qcom,q6prm-lpass-clocks";
-              #clock-cells = <2>;
+                compatible = "qcom,q6prm-lpass-clocks";
+                #clock-cells = <2>;
             };
         };
-      };
+    };
-- 
2.34.1


  parent reply	other threads:[~2022-09-10  9:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-10  9:14 [PATCH v4 00/15] ASoC/qcom/arm64: Qualcomm ADSP DTS and binding fixes Krzysztof Kozlowski
2022-09-10  9:14 ` [PATCH v4 01/15] arm64: dts: qcom: sdm630: align APR services node names with dtschema Krzysztof Kozlowski
2022-09-23 20:28   ` Krzysztof Kozlowski
2022-09-23 20:28     ` Krzysztof Kozlowski
2022-09-10  9:14 ` [PATCH v4 02/15] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2022-09-10  9:14 ` [PATCH v4 03/15] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
2022-09-10  9:14 ` [PATCH v4 04/15] arm64: dts: qcom: msm8996: fix APR services nodes Krzysztof Kozlowski
2022-09-10  9:14 ` [PATCH v4 05/15] arm64: dts: qcom: sdm845: align dai node names with dtschema Krzysztof Kozlowski
2022-09-10  9:14 ` [PATCH v4 06/15] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
2022-09-10  9:14 ` [PATCH v4 07/15] arm64: dts: qcom: qrb5165-rb5: " Krzysztof Kozlowski
2022-09-10  9:14 ` [PATCH v4 08/15] arm64: dts: qcom: sm8250: use generic name for LPASS clock controller Krzysztof Kozlowski
2022-09-10  9:14 ` [PATCH v4 09/15] dt-bindings: soc: qcom: apr: correct service children Krzysztof Kozlowski
2022-09-10  9:14   ` Krzysztof Kozlowski
2022-09-10  9:14 ` [PATCH v4 10/15] ASoC: dt-bindings: qcom,q6asm: convert to dtschema Krzysztof Kozlowski
2022-09-13  9:09   ` Krzysztof Kozlowski
2022-09-10  9:14 ` [PATCH v4 11/15] ASoC: dt-bindings: qcom,q6adm: " Krzysztof Kozlowski
2022-09-13 14:52   ` Rob Herring
2022-09-13 14:52     ` Rob Herring
2022-09-10  9:14 ` [PATCH v4 12/15] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: cleanup example Krzysztof Kozlowski
2022-09-10  9:14   ` [PATCH v4 12/15] ASoC: dt-bindings: qcom, q6dsp-lpass-ports: " Krzysztof Kozlowski
2022-09-13 14:53   ` [PATCH v4 12/15] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: " Rob Herring
2022-09-13 14:53     ` Rob Herring
2022-09-10  9:14 ` Krzysztof Kozlowski [this message]
2022-09-10  9:14   ` [PATCH v4 13/15] ASoC: dt-bindings: qcom, q6dsp-lpass-clocks: " Krzysztof Kozlowski
2022-09-13 14:53   ` [PATCH v4 13/15] ASoC: dt-bindings: qcom,q6dsp-lpass-clocks: " Rob Herring
2022-09-13 14:53     ` Rob Herring
2022-09-10  9:14 ` [PATCH v4 14/15] ASoC: dt-bindings: qcom,q6apm-dai: adjust indentation in example Krzysztof Kozlowski
2022-09-10  9:14   ` [PATCH v4 14/15] ASoC: dt-bindings: qcom, q6apm-dai: " Krzysztof Kozlowski
2022-09-13 14:54   ` [PATCH v4 14/15] ASoC: dt-bindings: qcom,q6apm-dai: " Rob Herring
2022-09-13 14:54     ` Rob Herring
2022-09-10  9:14 ` [PATCH v4 15/15] dt-bindings: soc: qcom: apr: add missing properties Krzysztof Kozlowski
2022-09-13 14:54   ` Rob Herring
2022-09-13 14:54     ` Rob Herring
2022-09-15  9:31 ` (subset) [PATCH v4 00/15] ASoC/qcom/arm64: Qualcomm ADSP DTS and binding fixes Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220910091428.50418-14-krzysztof.kozlowski@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andersson@kernel.org \
    --cc=bgoswami@quicinc.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.