[PATCH 0/8] Remove unused declarations for media

[PATCH 0/8] Remove unused declarations for media

[Gaosheng Cui]

This series contains a few cleanup patches, to remove unused
declarations which have been removed. Thanks!

Gaosheng Cui (8):
  media: dvb-frontends: remove unused drx_dap_fasi_funct_g declaration
  media: platform: remove unused vsp1_subdev_internal_ops declaration
  media: cxd2820r: remove unused cxd2820r_debug declaration
  media: saa7134: remove unused declarations in saa7134.h
  [media] saa7164: remove unused saa7164_call_i2c_clients declaration
  [media] cx25821: remove unused cx25821_video_wakeup() declaration
  [media] bttv: remove unused tea5757_set_freq declaration
  media: zoran: remove unused declarations in zoran_device.h

 drivers/media/dvb-frontends/cxd2820r_priv.h         | 2 --
 drivers/media/dvb-frontends/drx39xyj/drx_dap_fasi.h | 2 --
 drivers/media/pci/bt8xx/bttv.h                      | 1 -
 drivers/media/pci/cx25821/cx25821-video.h           | 3 ---
 drivers/media/pci/saa7134/saa7134.h                 | 4 ----
 drivers/media/pci/saa7164/saa7164.h                 | 2 --
 drivers/media/pci/zoran/zoran_device.h              | 2 --
 drivers/media/platform/renesas/vsp1/vsp1_entity.h   | 2 --
 8 files changed, 18 deletions(-)

-- 
2.25.1

[PATCH 1/8] media: dvb-frontends: remove unused drx_dap_fasi_funct_g declaration

[Gaosheng Cui]

drx_dap_fasi_funct_g has been removed since
commit 80bff4b07595 ("[media] drx-j: get rid of struct
drx_dap_fasi_funct_g"), so remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/media/dvb-frontends/drx39xyj/drx_dap_fasi.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/dvb-frontends/drx39xyj/drx_dap_fasi.h b/drivers/media/dvb-frontends/drx39xyj/drx_dap_fasi.h
index 739dc5590fa4..9df34c10d22b 100644
--- a/drivers/media/dvb-frontends/drx39xyj/drx_dap_fasi.h
+++ b/drivers/media/dvb-frontends/drx39xyj/drx_dap_fasi.h
@@ -234,8 +234,6 @@
 
 /*-------- Public API functions ----------------------------------------------*/
 
-extern struct drx_access_func drx_dap_fasi_funct_g;
-
 #define DRXDAP_FASI_RMW           0x10000000
 #define DRXDAP_FASI_BROADCAST     0x20000000
 #define DRXDAP_FASI_CLEARCRC      0x80000000
-- 
2.25.1

[PATCH 2/8] media: platform: remove unused vsp1_subdev_internal_ops declaration

[Gaosheng Cui]

vsp1_subdev_internal_ops has been removed since
commit 0efdf0f5eaaf ("[media] v4l: vsp1: Implement and use the
subdev pad::init_cfg configuration"), so remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/media/platform/renesas/vsp1/vsp1_entity.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/platform/renesas/vsp1/vsp1_entity.h b/drivers/media/platform/renesas/vsp1/vsp1_entity.h
index f22724439cdc..17f98a6a972e 100644
--- a/drivers/media/platform/renesas/vsp1/vsp1_entity.h
+++ b/drivers/media/platform/renesas/vsp1/vsp1_entity.h
@@ -130,8 +130,6 @@ int vsp1_entity_init(struct vsp1_device *vsp1, struct vsp1_entity *entity,
 		     const struct v4l2_subdev_ops *ops, u32 function);
 void vsp1_entity_destroy(struct vsp1_entity *entity);
 
-extern const struct v4l2_subdev_internal_ops vsp1_subdev_internal_ops;
-
 int vsp1_entity_link_setup(struct media_entity *entity,
 			   const struct media_pad *local,
 			   const struct media_pad *remote, u32 flags);
-- 
2.25.1

[PATCH 3/8] media: cxd2820r: remove unused cxd2820r_debug declaration

[Gaosheng Cui]

cxd2820r_debug has been removed since
commit 75aeafc9d0e2 ("[media] cxd2820r: switch to Kernel
dev_* logging"), so remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/media/dvb-frontends/cxd2820r_priv.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/dvb-frontends/cxd2820r_priv.h b/drivers/media/dvb-frontends/cxd2820r_priv.h
index 09c42bcef971..9b4d9cf8563d 100644
--- a/drivers/media/dvb-frontends/cxd2820r_priv.h
+++ b/drivers/media/dvb-frontends/cxd2820r_priv.h
@@ -52,8 +52,6 @@ struct cxd2820r_priv {
 
 /* cxd2820r_core.c */
 
-extern int cxd2820r_debug;
-
 int cxd2820r_gpio(struct dvb_frontend *fe, u8 *gpio);
 
 int cxd2820r_wr_reg_val_mask_tab(struct cxd2820r_priv *priv,
-- 
2.25.1

[PATCH 4/8] media: saa7134: remove unused declarations in saa7134.h

[Gaosheng Cui]

saa7134_mixer_fops and saa7134_dsp_fops have been removed
in media/video since commit 166fb6b4721f ("V4L/DVB (6623):
remove saa7134-oss").

Then the media/video has beed renamed to media/pci since
commit b285192a43f0 ("[media] rename most media/video pci
drivers to media/pci").

saa7134_vbi_template has been removed since
commit a9622391acbc ("V4L/DVB (6792): Fix VBI support").

so saa7134_mixer_fops, saa7134_dsp_fops and saa7134_vbi_template
are unused declarations, remove them.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/media/pci/saa7134/saa7134.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/media/pci/saa7134/saa7134.h b/drivers/media/pci/saa7134/saa7134.h
index 49fe0f6bacba..5c9b2912a9d1 100644
--- a/drivers/media/pci/saa7134/saa7134.h
+++ b/drivers/media/pci/saa7134/saa7134.h
@@ -866,7 +866,6 @@ int saa7134_ts_stop(struct saa7134_dev *dev);
 /* saa7134-vbi.c                                               */
 
 extern const struct vb2_ops saa7134_vbi_qops;
-extern struct video_device saa7134_vbi_template;
 
 int saa7134_vbi_init1(struct saa7134_dev *dev);
 int saa7134_vbi_fini(struct saa7134_dev *dev);
@@ -897,9 +896,6 @@ void saa7134_enable_i2s(struct saa7134_dev *dev);
 /* ----------------------------------------------------------- */
 /* saa7134-oss.c                                               */
 
-extern const struct file_operations saa7134_dsp_fops;
-extern const struct file_operations saa7134_mixer_fops;
-
 int saa7134_oss_init1(struct saa7134_dev *dev);
 int saa7134_oss_fini(struct saa7134_dev *dev);
 void saa7134_irq_oss_done(struct saa7134_dev *dev, unsigned long status);
-- 
2.25.1

[PATCH 5/8] [media] saa7164: remove unused saa7164_call_i2c_clients declaration

[Gaosheng Cui]

saa7164_call_i2c_clients has been removed in media/video since
commit 5a6fa3fe9a46 ("[media] saa7164: Remove unused
saa7164_call_i2c_clients()").

Then media/video has beed renamed media/pci since
commit b285192a43f0 ("[media] rename most media/video pci
drivers to media/pci").

So saa7164_call_i2c_clients is a unused declaration, remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/media/pci/saa7164/saa7164.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/pci/saa7164/saa7164.h b/drivers/media/pci/saa7164/saa7164.h
index 4b4eb156e214..eede47b686a3 100644
--- a/drivers/media/pci/saa7164/saa7164.h
+++ b/drivers/media/pci/saa7164/saa7164.h
@@ -493,8 +493,6 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev);
 /* saa7164-i2c.c                                               */
 extern int saa7164_i2c_register(struct saa7164_i2c *bus);
 extern int saa7164_i2c_unregister(struct saa7164_i2c *bus);
-extern void saa7164_call_i2c_clients(struct saa7164_i2c *bus,
-	unsigned int cmd, void *arg);
 
 /* ----------------------------------------------------------- */
 /* saa7164-bus.c                                               */
-- 
2.25.1

[PATCH 6/8] [media] cx25821: remove unused cx25821_video_wakeup() declaration

[Gaosheng Cui]

cx25821_video_wakeup() has been removed since
commit b671ae6bdc1a ("[media] cx25821: convert to vb2").

So cx25821_video_wakeup is a unused declaration, remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/media/pci/cx25821/cx25821-video.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/media/pci/cx25821/cx25821-video.h b/drivers/media/pci/cx25821/cx25821-video.h
index cf0d3f5509e7..080c8490a250 100644
--- a/drivers/media/pci/cx25821/cx25821-video.h
+++ b/drivers/media/pci/cx25821/cx25821-video.h
@@ -36,9 +36,6 @@ do {									\
 } while (0)
 
 #define FORMAT_FLAGS_PACKED       0x01
-extern void cx25821_video_wakeup(struct cx25821_dev *dev,
-				 struct cx25821_dmaqueue *q, u32 count);
-
 extern int cx25821_start_video_dma(struct cx25821_dev *dev,
 				   struct cx25821_dmaqueue *q,
 				   struct cx25821_buffer *buf,
-- 
2.25.1

[PATCH 7/8] [media] bttv: remove unused tea5757_set_freq declaration

[Gaosheng Cui]

tea5757_set_freq has been removed since
commit 1b500373157c ("[media] bttv: Convert to generic
TEA575x interface").

So tea5757_set_freq is a unused declaration, remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/media/pci/bt8xx/bttv.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/pci/bt8xx/bttv.h b/drivers/media/pci/bt8xx/bttv.h
index d24b9ef9f59f..eed7eeb3b963 100644
--- a/drivers/media/pci/bt8xx/bttv.h
+++ b/drivers/media/pci/bt8xx/bttv.h
@@ -289,7 +289,6 @@ extern void bttv_init_card2(struct bttv *btv);
 extern void bttv_init_tuner(struct bttv *btv);
 
 /* card-specific functions */
-extern void tea5757_set_freq(struct bttv *btv, unsigned short freq);
 extern u32 bttv_tda9880_setnorm(struct bttv *btv, u32 gpiobits);
 
 /* extra tweaks for some chipsets */
-- 
2.25.1

[PATCH 8/8] media: zoran: remove unused declarations in zoran_device.h

[Gaosheng Cui]

jpg_bufsize and v4l_bufsize have been removed since
commit 202ddbc9a33b ("media: staging: media: zoran:
clean unused code"), so remove them.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/media/pci/zoran/zoran_device.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/pci/zoran/zoran_device.h b/drivers/media/pci/zoran/zoran_device.h
index 34fd5cc914eb..237e830ae726 100644
--- a/drivers/media/pci/zoran/zoran_device.h
+++ b/drivers/media/pci/zoran/zoran_device.h
@@ -47,8 +47,6 @@ void zr36057_restart(struct zoran *zr);
 
 extern const struct zoran_format zoran_formats[];
 
-extern int v4l_bufsize;
-extern int jpg_bufsize;
 extern int pass_through;
 
 /* i2c */
-- 
2.25.1

Re: [PATCH 2/8] media: platform: remove unused vsp1_subdev_internal_ops declaration

[Kieran Bingham]

Quoting Gaosheng Cui (2022-09-11 10:15:13)
> vsp1_subdev_internal_ops has been removed since
> commit 0efdf0f5eaaf ("[media] v4l: vsp1: Implement and use the
> subdev pad::init_cfg configuration"), so remove it.
> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>

It does look lonely indeed.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
>  drivers/media/platform/renesas/vsp1/vsp1_entity.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_entity.h b/drivers/media/platform/renesas/vsp1/vsp1_entity.h
> index f22724439cdc..17f98a6a972e 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_entity.h
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_entity.h
> @@ -130,8 +130,6 @@ int vsp1_entity_init(struct vsp1_device *vsp1, struct vsp1_entity *entity,
>                      const struct v4l2_subdev_ops *ops, u32 function);
>  void vsp1_entity_destroy(struct vsp1_entity *entity);
>  
> -extern const struct v4l2_subdev_internal_ops vsp1_subdev_internal_ops;
> -
>  int vsp1_entity_link_setup(struct media_entity *entity,
>                            const struct media_pad *local,
>                            const struct media_pad *remote, u32 flags);
> -- 
> 2.25.1
>

Re: [PATCH 2/8] media: platform: remove unused vsp1_subdev_internal_ops declaration

[Laurent Pinchart]

On Sun, Sep 11, 2022 at 02:38:19PM +0100, Kieran Bingham wrote:
> Quoting Gaosheng Cui (2022-09-11 10:15:13)
> > vsp1_subdev_internal_ops has been removed since
> > commit 0efdf0f5eaaf ("[media] v4l: vsp1: Implement and use the
> > subdev pad::init_cfg configuration"), so remove it.
> > 
> > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> 
> It does look lonely indeed.
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

The subject line should start with "media: platform: vsp1:". I'll fix
this when applying.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > ---
> >  drivers/media/platform/renesas/vsp1/vsp1_entity.h | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_entity.h b/drivers/media/platform/renesas/vsp1/vsp1_entity.h
> > index f22724439cdc..17f98a6a972e 100644
> > --- a/drivers/media/platform/renesas/vsp1/vsp1_entity.h
> > +++ b/drivers/media/platform/renesas/vsp1/vsp1_entity.h
> > @@ -130,8 +130,6 @@ int vsp1_entity_init(struct vsp1_device *vsp1, struct vsp1_entity *entity,
> >                      const struct v4l2_subdev_ops *ops, u32 function);
> >  void vsp1_entity_destroy(struct vsp1_entity *entity);
> >  
> > -extern const struct v4l2_subdev_internal_ops vsp1_subdev_internal_ops;
> > -
> >  int vsp1_entity_link_setup(struct media_entity *entity,
> >                            const struct media_pad *local,
> >                            const struct media_pad *remote, u32 flags);

-- 
Regards,

Laurent Pinchart