* [PATCH] MIPS: ath25: clean up non-kernel-doc comment warning
@ 2022-08-23 2:54 Randy Dunlap
2022-08-23 8:13 ` Sergey Ryazanov
2022-09-12 13:40 ` Thomas Bogendoerfer
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2022-08-23 2:54 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Aditya Srivastava,
Thomas Bogendoerfer, linux-mips, Sergey Ryazanov
Don't use "/**" kernel-doc notation for comments that are not in
kernel-doc format.
Eliminates one warning:
arch/mips/pci/pci-ar2315.c:6: warning: This comment starts with
'/**', but isn't a kernel-doc comment. Refer
Documentation/doc-guide/kernel-doc.rst
* Both AR2315 and AR2316 chips have PCI interface unit, which supports DMA
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Aditya Srivastava <yashsri421@gmail.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
Cc: Sergey Ryazanov <ryazanov.s.a@gmail.com>
---
Fixes: 3ed7a2a702dc ("MIPS: ath25: add AR2315 PCI host controller driver")
but backport is not needed.
arch/mips/pci/pci-ar2315.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/mips/pci/pci-ar2315.c
+++ b/arch/mips/pci/pci-ar2315.c
@@ -2,7 +2,7 @@
/*
*/
-/**
+/*
* Both AR2315 and AR2316 chips have PCI interface unit, which supports DMA
* and interrupt. PCI interface supports MMIO access method, but does not
* seem to support I/O ports.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: ath25: clean up non-kernel-doc comment warning
2022-08-23 2:54 [PATCH] MIPS: ath25: clean up non-kernel-doc comment warning Randy Dunlap
@ 2022-08-23 8:13 ` Sergey Ryazanov
2022-08-23 8:21 ` Bagas Sanjaya
2022-09-12 13:40 ` Thomas Bogendoerfer
1 sibling, 1 reply; 4+ messages in thread
From: Sergey Ryazanov @ 2022-08-23 8:13 UTC (permalink / raw)
To: Randy Dunlap, Bagas Sanjaya
Cc: open list, kernel test robot, Aditya Srivastava,
Thomas Bogendoerfer, linux-mips
On Tue, Aug 23, 2022 at 5:54 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Don't use "/**" kernel-doc notation for comments that are not in
> kernel-doc format.
>
> Eliminates one warning:
>
> arch/mips/pci/pci-ar2315.c:6: warning: This comment starts with
> '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
> * Both AR2315 and AR2316 chips have PCI interface unit, which supports DMA
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Aditya Srivastava <yashsri421@gmail.com>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> Cc: Sergey Ryazanov <ryazanov.s.a@gmail.com>
> ---
> Fixes: 3ed7a2a702dc ("MIPS: ath25: add AR2315 PCI host controller driver")
> but backport is not needed.
Acked-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Randy, Bagas, which one of these patches should be applied:
* https://patchwork.kernel.org/project/linux-mips/patch/20220823030056.123709-1-bagasdotme@gmail.com/
* https://patchwork.kernel.org/project/linux-mips/patch/20220823025441.30708-1-rdunlap@infradead.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: ath25: clean up non-kernel-doc comment warning
2022-08-23 8:13 ` Sergey Ryazanov
@ 2022-08-23 8:21 ` Bagas Sanjaya
0 siblings, 0 replies; 4+ messages in thread
From: Bagas Sanjaya @ 2022-08-23 8:21 UTC (permalink / raw)
To: Sergey Ryazanov, Randy Dunlap
Cc: open list, kernel test robot, Aditya Srivastava,
Thomas Bogendoerfer, linux-mips
On 8/23/22 15:13, Sergey Ryazanov wrote:
> Acked-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
>
> Randy, Bagas, which one of these patches should be applied:
> * https://patchwork.kernel.org/project/linux-mips/patch/20220823030056.123709-1-bagasdotme@gmail.com/
> * https://patchwork.kernel.org/project/linux-mips/patch/20220823025441.30708-1-rdunlap@infradead.org/
Hi Sergey, thanks for replying.
Oh, I don't see Randy's patch, since it wasn't CCed to linux-doc list.
I prefer to choose Randy's one, because the description wording is
clearer.
Thanks.
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: ath25: clean up non-kernel-doc comment warning
2022-08-23 2:54 [PATCH] MIPS: ath25: clean up non-kernel-doc comment warning Randy Dunlap
2022-08-23 8:13 ` Sergey Ryazanov
@ 2022-09-12 13:40 ` Thomas Bogendoerfer
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2022-09-12 13:40 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, Aditya Srivastava, linux-mips,
Sergey Ryazanov
On Mon, Aug 22, 2022 at 07:54:41PM -0700, Randy Dunlap wrote:
> Don't use "/**" kernel-doc notation for comments that are not in
> kernel-doc format.
>
> Eliminates one warning:
>
> arch/mips/pci/pci-ar2315.c:6: warning: This comment starts with
> '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
> * Both AR2315 and AR2316 chips have PCI interface unit, which supports DMA
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Aditya Srivastava <yashsri421@gmail.com>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> Cc: Sergey Ryazanov <ryazanov.s.a@gmail.com>
> ---
> Fixes: 3ed7a2a702dc ("MIPS: ath25: add AR2315 PCI host controller driver")
> but backport is not needed.
>
> arch/mips/pci/pci-ar2315.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/mips/pci/pci-ar2315.c
> +++ b/arch/mips/pci/pci-ar2315.c
> @@ -2,7 +2,7 @@
> /*
> */
>
> -/**
> +/*
> * Both AR2315 and AR2316 chips have PCI interface unit, which supports DMA
> * and interrupt. PCI interface supports MMIO access method, but does not
> * seem to support I/O ports.
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-12 14:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23 2:54 [PATCH] MIPS: ath25: clean up non-kernel-doc comment warning Randy Dunlap
2022-08-23 8:13 ` Sergey Ryazanov
2022-08-23 8:21 ` Bagas Sanjaya
2022-09-12 13:40 ` Thomas Bogendoerfer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.