* [Intel-gfx] [PATCH 0/2] drm/i915/gem: Really move i915_gem_context.link under ref protection
@ 2022-09-13 16:10 Janusz Krzysztofik
2022-09-13 16:10 ` [Intel-gfx] [PATCH 1/2] drm/i915/gem: Flush contexts on driver release Janusz Krzysztofik
` (7 more replies)
0 siblings, 8 replies; 16+ messages in thread
From: Janusz Krzysztofik @ 2022-09-13 16:10 UTC (permalink / raw)
To: intel-gfx; +Cc: drm-devel, Daniel Vetter, Chris Wilson
i915_perf assumes that it can use the i915_gem_context reference to
protect its i915->gem.contexts.list iteration. However, this requires
that we do not remove the context from the list until after we drop the
final reference and release the struct. If, as currently, we remove the
context from the list during context_close(), the link.next pointer may
be poisoned while we are holding the context reference and cause a GPF:
[ 4070.573157] i915 0000:00:02.0: [drm:i915_perf_open_ioctl [i915]] filtering on ctx_id=0x
1fffff ctx_id_mask=0x1fffff
[ 4070.574881] general protection fault, probably for non-canonical address 0xdead00000000
0100: 0000 [#1] PREEMPT SMP
[ 4070.574897] CPU: 1 PID: 284392 Comm: amd_performance Tainted: G E 5.17.9
#180
[ 4070.574903] Hardware name: Intel Corporation NUC7i5BNK/NUC7i5BNB, BIOS BNKBL357.86A.0052.2017.0918.1346 09/18/2017
[ 4070.574907] RIP: 0010:oa_configure_all_contexts.isra.0+0x222/0x350 [i915]
[ 4070.574982] Code: 08 e8 32 6e 10 e1 4d 8b 6d 50 b8 ff ff ff ff 49 83 ed 50 f0 41 0f c1 04 24 83 f8 01 0f 84 e3 00 00 00 85 c0 0f 8e fa 00 00 00 <49> 8b 45 50 48 8d 70 b0 49 8d 45 50 48 39 44 24 10 0f 85 34 fe ff
[ 4070.574990] RSP: 0018:ffffc90002077b78 EFLAGS: 00010202
[ 4070.574995] RAX: 0000000000000002 RBX: 0000000000000002 RCX: 0000000000000000
[ 4070.575000] RDX: 0000000000000001 RSI: ffffc90002077b20 RDI: ffff88810ddc7c68
[ 4070.575004] RBP: 0000000000000001 R08: ffff888103242648 R09: fffffffffffffffc
[ 4070.575008] R10: ffffffff82c50bc0 R11: 0000000000025c80 R12: ffff888101bf1860
[ 4070.575012] R13: dead0000000000b0 R14: ffffc90002077c04 R15: ffff88810be5cabc
[ 4070.575016] FS: 00007f1ed50c0780(0000) GS:ffff88885ec80000(0000) knlGS:0000000000000000
[ 4070.575021] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 4070.575025] CR2: 00007f1ed5590280 CR3: 000000010ef6f005 CR4: 00000000003706e0
[ 4070.575029] Call Trace:
[ 4070.575033] <TASK>
[ 4070.575037] lrc_configure_all_contexts+0x13e/0x150 [i915]
[ 4070.575103] gen8_enable_metric_set+0x4d/0x90 [i915]
[ 4070.575164] i915_perf_open_ioctl+0xbc0/0x1500 [i915]
[ 4070.575224] ? asm_common_interrupt+0x1e/0x40
[ 4070.575232] ? i915_oa_init_reg_state+0x110/0x110 [i915]
[ 4070.575290] drm_ioctl_kernel+0x85/0x110
[ 4070.575296] ? update_load_avg+0x5f/0x5e0
[ 4070.575302] drm_ioctl+0x1d3/0x370
[ 4070.575307] ? i915_oa_init_reg_state+0x110/0x110 [i915]
[ 4070.575382] ? gen8_gt_irq_handler+0x46/0x130 [i915]
[ 4070.575445] __x64_sys_ioctl+0x3c4/0x8d0
[ 4070.575451] ? __do_softirq+0xaa/0x1d2
[ 4070.575456] do_syscall_64+0x35/0x80
[ 4070.575461] entry_SYSCALL_64_after_hwframe+0x44/0xae
[ 4070.575467] RIP: 0033:0x7f1ed5c10397
[ 4070.575471] Code: 3c 1c e8 1c ff ff ff 85 c0 79 87 49 c7 c4 ff ff ff ff 5b 5d 4c 89 e0 41 5c c3 66 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d a9 da 0d 00 f7 d8 64 89 01 48
[ 4070.575478] RSP: 002b:00007ffd65c8d7a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
[ 4070.575484] RAX: ffffffffffffffda RBX: 0000000000000006 RCX: 00007f1ed5c10397
[ 4070.575488] RDX: 00007ffd65c8d7c0 RSI: 0000000040106476 RDI: 0000000000000006
[ 4070.575492] RBP: 00005620972f9c60 R08: 000000000000000a R09: 0000000000000005
[ 4070.575496] R10: 000000000000000d R11: 0000000000000246 R12: 000000000000000a
[ 4070.575500] R13: 000000000000000d R14: 0000000000000000 R15: 00007ffd65c8d7c0
[ 4070.575505] </TASK>
[ 4070.575507] Modules linked in: nls_ascii(E) nls_cp437(E) vfat(E) fat(E) i915(E) x86_pkg_temp_thermal(E) intel_powerclamp(E) crct10dif_pclmul(E) crc32_pclmul(E) crc32c_intel(E) aesni_intel(E) crypto_simd(E) intel_gtt(E) cryptd(E) ttm(E) rapl(E) intel_cstate(E) drm_kms_helper(E) cfbfillrect(E) syscopyarea(E) cfbimgblt(E) intel_uncore(E) sysfillrect(E) mei_me(E) sysimgblt(E) i2c_i801(E) fb_sys_fops(E) mei(E) intel_pch_thermal(E) i2c_smbus(E) cfbcopyarea(E) video(E) button(E) efivarfs(E) autofs4(E)
[ 4070.575549] ---[ end trace 0000000000000000 ]---
However, there is a risk of triggering kernel warning on contexts list not
empty at driver release time if we deleagate that task to a worker for
i915_gem_context_release_work(), unless that work is flushed first.
Unfortunately, it is not flushed on driver release. Fix it.
Chris Wilson (1):
drm/i915/gem: Really move i915_gem_context.link under ref protection
Janusz Krzysztofik (1):
drm/i915/gem: Flush contexts on driver release
drivers/gpu/drm/i915/gem/i915_gem_context.c | 14 +++++++-------
drivers/gpu/drm/i915/i915_gem.c | 3 ++-
drivers/gpu/drm/i915/i915_perf.c | 18 ++++++++++--------
drivers/gpu/drm/i915/i915_sysfs.c | 8 ++++----
4 files changed, 23 insertions(+), 20 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] [PATCH 1/2] drm/i915/gem: Flush contexts on driver release
2022-09-13 16:10 [Intel-gfx] [PATCH 0/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
@ 2022-09-13 16:10 ` Janusz Krzysztofik
2022-09-14 13:56 ` Andi Shyti
2022-09-13 16:10 ` [Intel-gfx] [PATCH 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
` (6 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Janusz Krzysztofik @ 2022-09-13 16:10 UTC (permalink / raw)
To: intel-gfx; +Cc: drm-devel, Daniel Vetter, Chris Wilson
Due to i915_perf assuming that it can use the i915_gem_context reference
to protect its i915->gem.contexts.list iteration, we need to defer removal
of the context from the list until last reference to the context is put.
However, there is a risk of triggering kernel warning on contexts list not
empty at driver release time if we deleagate that task to a worker for
i915_gem_context_release_work(), unless that work is flushed first.
Unfortunately, it is not flushed on driver release. Fix it.
Instead of additionally calling flush_workqueue(), either directly of via
a new dedicated wrapper around it, replace last call to
i915_gem_drain_freed_objects() with existing i915_gem_drain_workqueue()
that performs both tasks.
Fixes: 75eefd82581f ("drm/i915: Release i915_gem_context from a worker")
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: stable@kernel.org # v5.16+
---
drivers/gpu/drm/i915/i915_gem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index a3373699835d7..31c197f2d8cb9 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1191,7 +1191,8 @@ void i915_gem_driver_release(struct drm_i915_private *dev_priv)
intel_uc_cleanup_firmwares(&to_gt(dev_priv)->uc);
- i915_gem_drain_freed_objects(dev_priv);
+ /* Flush any outstanding work, including i915_gem_context.release_work. */
+ i915_gem_drain_workqueue(dev_priv);
drm_WARN_ON(&dev_priv->drm, !list_empty(&dev_priv->gem.contexts.list));
}
--
2.25.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection
2022-09-13 16:10 [Intel-gfx] [PATCH 0/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
2022-09-13 16:10 ` [Intel-gfx] [PATCH 1/2] drm/i915/gem: Flush contexts on driver release Janusz Krzysztofik
@ 2022-09-13 16:10 ` Janusz Krzysztofik
2022-09-14 15:15 ` Andi Shyti
2022-09-14 15:37 ` Tvrtko Ursulin
2022-09-13 21:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2) Patchwork
` (5 subsequent siblings)
7 siblings, 2 replies; 16+ messages in thread
From: Janusz Krzysztofik @ 2022-09-13 16:10 UTC (permalink / raw)
To: intel-gfx; +Cc: drm-devel, Daniel Vetter, Chris Wilson
From: Chris Wilson <chris@chris-wilson.co.uk>
i915_perf assumes that it can use the i915_gem_context reference to
protect its i915->gem.contexts.list iteration. However, this requires
that we do not remove the context from the list until after we drop the
final reference and release the struct. If, as currently, we remove the
context from the list during context_close(), the link.next pointer may
be poisoned while we are holding the context reference and cause a GPF:
[ 4070.573157] i915 0000:00:02.0: [drm:i915_perf_open_ioctl [i915]] filtering on ctx_id=0x1fffff ctx_id_mask=0x1fffff
[ 4070.574881] general protection fault, probably for non-canonical address 0xdead000000000100: 0000 [#1] PREEMPT SMP
[ 4070.574897] CPU: 1 PID: 284392 Comm: amd_performance Tainted: G E 5.17.9 #180
[ 4070.574903] Hardware name: Intel Corporation NUC7i5BNK/NUC7i5BNB, BIOS BNKBL357.86A.0052.2017.0918.1346 09/18/2017
[ 4070.574907] RIP: 0010:oa_configure_all_contexts.isra.0+0x222/0x350 [i915]
[ 4070.574982] Code: 08 e8 32 6e 10 e1 4d 8b 6d 50 b8 ff ff ff ff 49 83 ed 50 f0 41 0f c1 04 24 83 f8 01 0f 84 e3 00 00 00 85 c0 0f 8e fa 00 00 00 <49> 8b 45 50 48 8d 70 b0 49 8d 45 50 48 39 44 24 10 0f 85 34 fe ff
[ 4070.574990] RSP: 0018:ffffc90002077b78 EFLAGS: 00010202
[ 4070.574995] RAX: 0000000000000002 RBX: 0000000000000002 RCX: 0000000000000000
[ 4070.575000] RDX: 0000000000000001 RSI: ffffc90002077b20 RDI: ffff88810ddc7c68
[ 4070.575004] RBP: 0000000000000001 R08: ffff888103242648 R09: fffffffffffffffc
[ 4070.575008] R10: ffffffff82c50bc0 R11: 0000000000025c80 R12: ffff888101bf1860
[ 4070.575012] R13: dead0000000000b0 R14: ffffc90002077c04 R15: ffff88810be5cabc
[ 4070.575016] FS: 00007f1ed50c0780(0000) GS:ffff88885ec80000(0000) knlGS:0000000000000000
[ 4070.575021] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 4070.575025] CR2: 00007f1ed5590280 CR3: 000000010ef6f005 CR4: 00000000003706e0
[ 4070.575029] Call Trace:
[ 4070.575033] <TASK>
[ 4070.575037] lrc_configure_all_contexts+0x13e/0x150 [i915]
[ 4070.575103] gen8_enable_metric_set+0x4d/0x90 [i915]
[ 4070.575164] i915_perf_open_ioctl+0xbc0/0x1500 [i915]
[ 4070.575224] ? asm_common_interrupt+0x1e/0x40
[ 4070.575232] ? i915_oa_init_reg_state+0x110/0x110 [i915]
[ 4070.575290] drm_ioctl_kernel+0x85/0x110
[ 4070.575296] ? update_load_avg+0x5f/0x5e0
[ 4070.575302] drm_ioctl+0x1d3/0x370
[ 4070.575307] ? i915_oa_init_reg_state+0x110/0x110 [i915]
[ 4070.575382] ? gen8_gt_irq_handler+0x46/0x130 [i915]
[ 4070.575445] __x64_sys_ioctl+0x3c4/0x8d0
[ 4070.575451] ? __do_softirq+0xaa/0x1d2
[ 4070.575456] do_syscall_64+0x35/0x80
[ 4070.575461] entry_SYSCALL_64_after_hwframe+0x44/0xae
[ 4070.575467] RIP: 0033:0x7f1ed5c10397
[ 4070.575471] Code: 3c 1c e8 1c ff ff ff 85 c0 79 87 49 c7 c4 ff ff ff ff 5b 5d 4c 89 e0 41 5c c3 66 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d a9 da 0d 00 f7 d8 64 89 01 48
[ 4070.575478] RSP: 002b:00007ffd65c8d7a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
[ 4070.575484] RAX: ffffffffffffffda RBX: 0000000000000006 RCX: 00007f1ed5c10397
[ 4070.575488] RDX: 00007ffd65c8d7c0 RSI: 0000000040106476 RDI: 0000000000000006
[ 4070.575492] RBP: 00005620972f9c60 R08: 000000000000000a R09: 0000000000000005
[ 4070.575496] R10: 000000000000000d R11: 0000000000000246 R12: 000000000000000a
[ 4070.575500] R13: 000000000000000d R14: 0000000000000000 R15: 00007ffd65c8d7c0
[ 4070.575505] </TASK>
[ 4070.575507] Modules linked in: nls_ascii(E) nls_cp437(E) vfat(E) fat(E) i915(E) x86_pkg_temp_thermal(E) intel_powerclamp(E) crct10dif_pclmul(E) crc32_pclmul(E) crc32c_intel(E) aesni_intel(E) crypto_simd(E) intel_gtt(E) cryptd(E) ttm(E) rapl(E) intel_cstate(E) drm_kms_helper(E) cfbfillrect(E) syscopyarea(E) cfbimgblt(E) intel_uncore(E) sysfillrect(E) mei_me(E) sysimgblt(E) i2c_i801(E) fb_sys_fops(E) mei(E) intel_pch_thermal(E) i2c_smbus(E) cfbcopyarea(E) video(E) button(E) efivarfs(E) autofs4(E)
[ 4070.575549] ---[ end trace 0000000000000000 ]---
Reported-by: Mark Janes <mark.janes@intel.com>
Closes: https://gitlab.freedesktop.org/drm/intel/issues/6222
References: a4e7ccdac38e ("drm/i915: Move context management under GEM")
Fixes: f8246cf4d9a9 ("drm/i915/gem: Drop free_work for GEM contexts")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: <stable@vger.kernel.org> # v5.12+
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 14 +++++++-------
drivers/gpu/drm/i915/i915_perf.c | 18 ++++++++++--------
drivers/gpu/drm/i915/i915_sysfs.c | 8 ++++----
3 files changed, 21 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index dabdfe09f5e51..9d7142ab63c05 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -1133,7 +1133,6 @@ static struct i915_gem_engines *default_engines(struct i915_gem_context *ctx,
err = ERR_PTR(ret);
goto free_engines;
}
-
}
return e;
@@ -1265,10 +1264,15 @@ static void i915_gem_context_release_work(struct work_struct *work)
struct i915_gem_context *ctx = container_of(work, typeof(*ctx),
release_work);
struct i915_address_space *vm;
+ unsigned long flags;
trace_i915_context_free(ctx);
GEM_BUG_ON(!i915_gem_context_is_closed(ctx));
+ spin_lock_irqsave(&ctx->i915->gem.contexts.lock, flags);
+ list_del(&ctx->link);
+ spin_unlock_irqrestore(&ctx->i915->gem.contexts.lock, flags);
+
if (ctx->syncobj)
drm_syncobj_put(ctx->syncobj);
@@ -1521,10 +1525,6 @@ static void context_close(struct i915_gem_context *ctx)
ctx->file_priv = ERR_PTR(-EBADF);
- spin_lock(&ctx->i915->gem.contexts.lock);
- list_del(&ctx->link);
- spin_unlock(&ctx->i915->gem.contexts.lock);
-
client = ctx->client;
if (client) {
spin_lock(&client->ctx_lock);
@@ -1717,9 +1717,9 @@ static void gem_context_register(struct i915_gem_context *ctx,
list_add_tail_rcu(&ctx->client_link, &ctx->client->ctx_list);
spin_unlock(&ctx->client->ctx_lock);
- spin_lock(&i915->gem.contexts.lock);
+ spin_lock_irq(&i915->gem.contexts.lock);
list_add_tail(&ctx->link, &i915->gem.contexts.list);
- spin_unlock(&i915->gem.contexts.lock);
+ spin_unlock_irq(&i915->gem.contexts.lock);
}
int i915_gem_context_open(struct drm_i915_private *i915,
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index f3c23fe9ad9ce..83bb71466f8f0 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -2379,24 +2379,26 @@ oa_configure_all_contexts(struct i915_perf_stream *stream,
* context. Contexts idle at the time of reconfiguration are not
* trapped behind the barrier.
*/
- spin_lock(&i915->gem.contexts.lock);
+ spin_lock_irq(&i915->gem.contexts.lock);
list_for_each_entry_safe(ctx, cn, &i915->gem.contexts.list, link) {
if (!kref_get_unless_zero(&ctx->ref))
continue;
- spin_unlock(&i915->gem.contexts.lock);
+ spin_unlock_irq(&i915->gem.contexts.lock);
- err = gen8_configure_context(ctx, regs, num_regs);
- if (err) {
- i915_gem_context_put(ctx);
- return err;
+ if (!i915_gem_context_is_closed(ctx)) {
+ err = gen8_configure_context(ctx, regs, num_regs);
+ if (err) {
+ i915_gem_context_put(ctx);
+ return err;
+ }
}
- spin_lock(&i915->gem.contexts.lock);
+ spin_lock_irq(&i915->gem.contexts.lock);
list_safe_reset_next(ctx, cn, link);
i915_gem_context_put(ctx);
}
- spin_unlock(&i915->gem.contexts.lock);
+ spin_unlock_irq(&i915->gem.contexts.lock);
/*
* After updating all other contexts, we need to modify ourselves.
diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
index 1e27502108313..40c7671fc0591 100644
--- a/drivers/gpu/drm/i915/i915_sysfs.c
+++ b/drivers/gpu/drm/i915/i915_sysfs.c
@@ -77,12 +77,12 @@ i915_l3_read(struct file *filp, struct kobject *kobj,
count = min_t(size_t, GEN7_L3LOG_SIZE - offset, count);
memset(buf, 0, count);
- spin_lock(&i915->gem.contexts.lock);
+ spin_lock_irq(&i915->gem.contexts.lock);
if (i915->l3_parity.remap_info[slice])
memcpy(buf,
i915->l3_parity.remap_info[slice] + offset / sizeof(u32),
count);
- spin_unlock(&i915->gem.contexts.lock);
+ spin_unlock_irq(&i915->gem.contexts.lock);
return count;
}
@@ -110,7 +110,7 @@ i915_l3_write(struct file *filp, struct kobject *kobj,
if (!remap_info)
return -ENOMEM;
- spin_lock(&i915->gem.contexts.lock);
+ spin_lock_irq(&i915->gem.contexts.lock);
if (i915->l3_parity.remap_info[slice]) {
freeme = remap_info;
@@ -126,7 +126,7 @@ i915_l3_write(struct file *filp, struct kobject *kobj,
list_for_each_entry(ctx, &i915->gem.contexts.list, link)
ctx->remap_slice |= BIT(slice);
- spin_unlock(&i915->gem.contexts.lock);
+ spin_unlock_irq(&i915->gem.contexts.lock);
kfree(freeme);
/*
--
2.25.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2)
2022-09-13 16:10 [Intel-gfx] [PATCH 0/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
2022-09-13 16:10 ` [Intel-gfx] [PATCH 1/2] drm/i915/gem: Flush contexts on driver release Janusz Krzysztofik
2022-09-13 16:10 ` [Intel-gfx] [PATCH 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
@ 2022-09-13 21:39 ` Patchwork
2022-09-13 21:39 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (4 subsequent siblings)
7 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2022-09-13 21:39 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2)
URL : https://patchwork.freedesktop.org/series/105975/
State : warning
== Summary ==
Error: dim checkpatch failed
64a2e617c114 drm/i915/gem: Flush contexts on driver release
d1be3d2a7270 drm/i915/gem: Really move i915_gem_context.link under ref protection
-:59: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit a4e7ccdac38e ("drm/i915: Move context management under GEM")'
#59:
References: a4e7ccdac38e ("drm/i915: Move context management under GEM")
total: 1 errors, 0 warnings, 0 checks, 107 lines checked
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2)
2022-09-13 16:10 [Intel-gfx] [PATCH 0/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
` (2 preceding siblings ...)
2022-09-13 21:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2) Patchwork
@ 2022-09-13 21:39 ` Patchwork
2022-09-13 22:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
7 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2022-09-13 21:39 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2)
URL : https://patchwork.freedesktop.org/series/105975/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:117:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:148:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:150:9: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:154:26: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:156:16: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:156:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:174:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:176:9: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:180:35: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:182:16: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:182:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:186:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:188:9: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:192:35: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:195:16: warning: unreplaced symbol 'oldbit'
+./arch/x86/include/asm/bitops.h:195:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:237:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:239:9: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return'
+./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val'
+./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val'
+./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p'
+./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old'
+./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask'
+./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return'
+./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return'
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2)
2022-09-13 16:10 [Intel-gfx] [PATCH 0/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
` (3 preceding siblings ...)
2022-09-13 21:39 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2022-09-13 22:08 ` Patchwork
2022-09-14 12:20 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (2 subsequent siblings)
7 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2022-09-13 22:08 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6089 bytes --]
== Series Details ==
Series: drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2)
URL : https://patchwork.freedesktop.org/series/105975/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12131 -> Patchwork_105975v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/index.html
Participating hosts (44 -> 41)
------------------------------
Missing (3): fi-ctg-p8600 fi-icl-u2 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_105975v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][1] -> [INCOMPLETE][2] ([i915#5847])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/fi-bsw-nick/igt@i915_selftest@live@execlists.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-pnv-d510: NOTRUN -> [SKIP][3] ([fdo#109271])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/fi-pnv-d510/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-blb-e6850: NOTRUN -> [SKIP][4] ([fdo#109271])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/fi-blb-e6850/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [PASS][5] -> [FAIL][6] ([i915#6298])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
* igt@runner@aborted:
- fi-bsw-nick: NOTRUN -> [FAIL][7] ([fdo#109271] / [i915#4312])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/fi-bsw-nick/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@lmem0:
- {bat-dg2-11}: [DMESG-WARN][8] -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/bat-dg2-11/igt@gem_exec_suspend@basic-s3@lmem0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/bat-dg2-11/igt@gem_exec_suspend@basic-s3@lmem0.html
* igt@i915_selftest@live@gem:
- fi-blb-e6850: [DMESG-FAIL][10] ([i915#4528]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/fi-blb-e6850/igt@i915_selftest@live@gem.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/fi-blb-e6850/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][12] ([i915#4528]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/fi-pnv-d510/igt@i915_selftest@live@requests.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [FAIL][14] ([i915#6298]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2:
- {bat-dg2-11}: [FAIL][16] -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2.html
#### Warnings ####
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [DMESG-FAIL][18] ([i915#4494] / [i915#4957]) -> [DMESG-FAIL][19] ([i915#4957])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
[i915#5847]: https://gitlab.freedesktop.org/drm/intel/issues/5847
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6380]: https://gitlab.freedesktop.org/drm/intel/issues/6380
[i915#6580]: https://gitlab.freedesktop.org/drm/intel/issues/6580
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
Build changes
-------------
* Linux: CI_DRM_12131 -> Patchwork_105975v2
CI-20190529: 20190529
CI_DRM_12131: 3c82566040d2d01a9e98f740d8de4a9e18116818 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6653: 4f927248ebbf11f03f4c1ea2254f011e7575322f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105975v2: 3c82566040d2d01a9e98f740d8de4a9e18116818 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
e3b514be9d14 drm/i915/gem: Really move i915_gem_context.link under ref protection
1c190ff79d32 drm/i915/gem: Flush contexts on driver release
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/index.html
[-- Attachment #2: Type: text/html, Size: 6967 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2)
2022-09-13 16:10 [Intel-gfx] [PATCH 0/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
` (4 preceding siblings ...)
2022-09-13 22:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-09-14 12:20 ` Patchwork
2022-09-14 13:59 ` Andi Shyti
2022-09-14 15:45 ` Patchwork
2022-09-14 16:35 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
7 siblings, 1 reply; 16+ messages in thread
From: Patchwork @ 2022-09-14 12:20 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 35303 bytes --]
== Series Details ==
Series: drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2)
URL : https://patchwork.freedesktop.org/series/105975/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12131_full -> Patchwork_105975v2_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_105975v2_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_105975v2_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_105975v2_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-iclb: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-edp-1:
- shard-iclb: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb8/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-edp-1.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb6/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-edp-1.html
Known issues
------------
Here are the changes found in Patchwork_105975v2_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-skl: ([PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28]) -> ([PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [FAIL][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52]) ([i915#5032])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl4/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl4/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl4/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl3/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl9/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl9/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl9/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl9/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl3/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl3/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl3/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-contexts-10ms:
- shard-snb: [PASS][53] -> [FAIL][54] ([i915#4409])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-snb2/igt@gem_eio@in-flight-contexts-10ms.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-snb6/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-iclb: [PASS][55] -> [TIMEOUT][56] ([i915#3070])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@gem_eio@in-flight-contexts-1us.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_balancer@parallel:
- shard-iclb: [PASS][57] -> [SKIP][58] ([i915#4525])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb4/igt@gem_exec_balancer@parallel.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb5/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][59] -> [FAIL][60] ([i915#2842])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: NOTRUN -> [FAIL][61] ([i915#2842])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][62] ([i915#2842])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][63] -> [FAIL][64] ([i915#2842])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][65] -> [SKIP][66] ([i915#2190])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglb5/igt@gem_huc_copy@huc-copy.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#4613])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl8/igt@gem_lmem_swapping@parallel-random.html
* igt@gem_lmem_swapping@verify-ccs:
- shard-glk: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#4613])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@gem_lmem_swapping@verify-ccs.html
* igt@gem_softpin@evict-snoop-interruptible:
- shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109312])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@gem_softpin@evict-snoop-interruptible.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-iclb: NOTRUN -> [SKIP][70] ([i915#5286]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#3886]) +3 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109278]) +3 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs.html
* igt@kms_chamelium@hdmi-audio:
- shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271] / [fdo#111827]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl8/igt@kms_chamelium@hdmi-audio.html
* igt@kms_color_chamelium@ctm-blue-to-red:
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109284] / [fdo#111827])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_color_chamelium@ctm-blue-to-red.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][75] -> [FAIL][76] ([i915#72])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][77] -> [FAIL][78] ([i915#79]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#2587] / [i915#2672]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][80] ([i915#2672])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][81] -> [SKIP][82] ([i915#3555])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][83] ([i915#2672] / [i915#3555])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-glk: NOTRUN -> [SKIP][84] ([fdo#109271]) +24 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-apl: NOTRUN -> [SKIP][85] ([fdo#109271]) +31 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][86] ([fdo#109280])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-glk: NOTRUN -> [FAIL][87] ([fdo#108145] / [i915#265]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#658])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [PASS][89] -> [SKIP][90] ([fdo#109441]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109441])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_psr@psr2_primary_blt.html
* igt@perf@non-zero-reason:
- shard-iclb: [PASS][92] -> [FAIL][93] ([i915#3089])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@perf@non-zero-reason.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@perf@non-zero-reason.html
* igt@prime_nv_api@i915_nv_import_vs_close:
- shard-iclb: NOTRUN -> [SKIP][94] ([fdo#109291])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@prime_nv_api@i915_nv_import_vs_close.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][95] ([i915#6268]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglu-4/igt@gem_ctx_exec@basic-nohangcheck.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglu-3/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [TIMEOUT][97] ([i915#3070]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb4/igt@gem_eio@unwedge-stress.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb8/igt@gem_eio@unwedge-stress.html
- {shard-tglu}: [TIMEOUT][99] ([i915#3063]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglu-4/igt@gem_eio@unwedge-stress.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglu-3/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][101] ([i915#4525]) -> [PASS][102] +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb6/igt@gem_exec_balancer@parallel-keep-in-fence.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb4/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-deadline:
- shard-iclb: [DMESG-WARN][103] ([i915#4391]) -> [PASS][104] +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb7/igt@gem_exec_fair@basic-deadline.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][105] ([i915#2842]) -> [PASS][106] +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-tglb: [FAIL][107] ([i915#2842]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_reloc@basic-write-read-active:
- {shard-rkl}: [SKIP][109] ([i915#3281]) -> [PASS][110] +3 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-rkl-1/igt@gem_exec_reloc@basic-write-read-active.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-rkl-5/igt@gem_exec_reloc@basic-write-read-active.html
* igt@gen9_exec_parse@bb-large:
- shard-apl: [TIMEOUT][111] -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl7/igt@gen9_exec_parse@bb-large.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl2/igt@gen9_exec_parse@bb-large.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][113] ([i915#454]) -> [PASS][114] +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][115] ([i915#4281]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb5/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_selftest@live@gt_pm:
- {shard-tglu}: [DMESG-FAIL][117] ([i915#3987]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglu-2/igt@i915_selftest@live@gt_pm.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglu-4/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][119] ([i915#180]) -> [PASS][120] +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl8/igt@i915_suspend@fence-restore-tiled2untiled.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl3/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][121] ([i915#79]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [SKIP][123] ([i915#5176]) -> [PASS][124] +2 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][125] ([i915#5235]) -> [PASS][126] +2 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][127] ([fdo#109441]) -> [PASS][128] +2 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@perf@stress-open-close:
- shard-glk: [INCOMPLETE][129] ([i915#5213]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk9/igt@perf@stress-open-close.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@perf@stress-open-close.html
* igt@prime_vgem@basic-write:
- {shard-rkl}: [SKIP][131] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-rkl-1/igt@prime_vgem@basic-write.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-rkl-5/igt@prime_vgem@basic-write.html
#### Warnings ####
* igt@gem_eio@unwedge-stress:
- shard-tglb: [FAIL][133] ([i915#5784]) -> [TIMEOUT][134] ([i915#3063])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglb1/igt@gem_eio@unwedge-stress.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][135] ([i915#6117]) -> [SKIP][136] ([i915#4525])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@gem_exec_balancer@parallel-ordering.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@gem_exec_balancer@parallel-ordering.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][137] ([i915#2920]) -> [SKIP][138] ([i915#658])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@runner@aborted:
- shard-apl: ([FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][143], [FAIL][144]) ([i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl3/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl1/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl8/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl8/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl3/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl1/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070
[i915#3089]: https://gitlab.freedesktop.org/drm/intel/issues/3089
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4409]: https://gitlab.freedesktop.org/drm/intel/issues/4409
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5032]: https://gitlab.freedesktop.org/drm/intel/issues/5032
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12131 -> Patchwork_105975v2
CI-20190529: 20190529
CI_DRM_12131: 3c82566040d2d01a9e98f740d8de4a9e18116818 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6653: 4f927248ebbf11f03f4c1ea2254f011e7575322f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105975v2: 3c82566040d2d01a9e98f740d8de4a9e18116818 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/index.html
[-- Attachment #2: Type: text/html, Size: 33476 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/gem: Flush contexts on driver release
2022-09-13 16:10 ` [Intel-gfx] [PATCH 1/2] drm/i915/gem: Flush contexts on driver release Janusz Krzysztofik
@ 2022-09-14 13:56 ` Andi Shyti
0 siblings, 0 replies; 16+ messages in thread
From: Andi Shyti @ 2022-09-14 13:56 UTC (permalink / raw)
To: Janusz Krzysztofik; +Cc: intel-gfx, drm-devel, Daniel Vetter, Chris Wilson
Hi Krzysztofik,
On Tue, Sep 13, 2022 at 06:10:38PM +0200, Janusz Krzysztofik wrote:
> Due to i915_perf assuming that it can use the i915_gem_context reference
> to protect its i915->gem.contexts.list iteration, we need to defer removal
> of the context from the list until last reference to the context is put.
> However, there is a risk of triggering kernel warning on contexts list not
> empty at driver release time if we deleagate that task to a worker for
> i915_gem_context_release_work(), unless that work is flushed first.
> Unfortunately, it is not flushed on driver release. Fix it.
>
> Instead of additionally calling flush_workqueue(), either directly of via
> a new dedicated wrapper around it, replace last call to
> i915_gem_drain_freed_objects() with existing i915_gem_drain_workqueue()
> that performs both tasks.
>
> Fixes: 75eefd82581f ("drm/i915: Release i915_gem_context from a worker")
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> Cc: stable@kernel.org # v5.16+
Thanks for the fix and for taking this on you!
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
> ---
> drivers/gpu/drm/i915/i915_gem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index a3373699835d7..31c197f2d8cb9 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1191,7 +1191,8 @@ void i915_gem_driver_release(struct drm_i915_private *dev_priv)
>
> intel_uc_cleanup_firmwares(&to_gt(dev_priv)->uc);
>
> - i915_gem_drain_freed_objects(dev_priv);
> + /* Flush any outstanding work, including i915_gem_context.release_work. */
> + i915_gem_drain_workqueue(dev_priv);
>
> drm_WARN_ON(&dev_priv->drm, !list_empty(&dev_priv->gem.contexts.list));
> }
> --
> 2.25.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2)
2022-09-14 12:20 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-09-14 13:59 ` Andi Shyti
0 siblings, 0 replies; 16+ messages in thread
From: Andi Shyti @ 2022-09-14 13:59 UTC (permalink / raw)
To: intel-gfx
Hi,
> Possible new issues
>
> Here are the unknown changes that may have been introduced in
> Patchwork_105975v2_full:
>
> IGT changes
>
> Possible regressions
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc
> :
> + shard-iclb: [3]PASS -> [4]DMESG-WARN
> * igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-edp-1:
> + shard-iclb: [5]PASS -> [6]INCOMPLETE
this looks unrelated to the patch.
Andi
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection
2022-09-13 16:10 ` [Intel-gfx] [PATCH 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
@ 2022-09-14 15:15 ` Andi Shyti
2022-09-14 16:09 ` Janusz Krzysztofik
2022-09-14 15:37 ` Tvrtko Ursulin
1 sibling, 1 reply; 16+ messages in thread
From: Andi Shyti @ 2022-09-14 15:15 UTC (permalink / raw)
To: Janusz Krzysztofik; +Cc: intel-gfx, drm-devel, Daniel Vetter, Chris Wilson
Hi Krzysztofik,
if you are going to resend it, I just have a little thing if you
don't mind,
On Tue, Sep 13, 2022 at 06:10:39PM +0200, Janusz Krzysztofik wrote:
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> i915_perf assumes that it can use the i915_gem_context reference to
> protect its i915->gem.contexts.list iteration. However, this requires
> that we do not remove the context from the list until after we drop the
> final reference and release the struct. If, as currently, we remove the
> context from the list during context_close(), the link.next pointer may
> be poisoned while we are holding the context reference and cause a GPF:
>
> [ 4070.573157] i915 0000:00:02.0: [drm:i915_perf_open_ioctl [i915]] filtering on ctx_id=0x1fffff ctx_id_mask=0x1fffff
> [ 4070.574881] general protection fault, probably for non-canonical address 0xdead000000000100: 0000 [#1] PREEMPT SMP
> [ 4070.574897] CPU: 1 PID: 284392 Comm: amd_performance Tainted: G E 5.17.9 #180
> [ 4070.574903] Hardware name: Intel Corporation NUC7i5BNK/NUC7i5BNB, BIOS BNKBL357.86A.0052.2017.0918.1346 09/18/2017
> [ 4070.574907] RIP: 0010:oa_configure_all_contexts.isra.0+0x222/0x350 [i915]
> [ 4070.574982] Code: 08 e8 32 6e 10 e1 4d 8b 6d 50 b8 ff ff ff ff 49 83 ed 50 f0 41 0f c1 04 24 83 f8 01 0f 84 e3 00 00 00 85 c0 0f 8e fa 00 00 00 <49> 8b 45 50 48 8d 70 b0 49 8d 45 50 48 39 44 24 10 0f 85 34 fe ff
> [ 4070.574990] RSP: 0018:ffffc90002077b78 EFLAGS: 00010202
> [ 4070.574995] RAX: 0000000000000002 RBX: 0000000000000002 RCX: 0000000000000000
> [ 4070.575000] RDX: 0000000000000001 RSI: ffffc90002077b20 RDI: ffff88810ddc7c68
> [ 4070.575004] RBP: 0000000000000001 R08: ffff888103242648 R09: fffffffffffffffc
> [ 4070.575008] R10: ffffffff82c50bc0 R11: 0000000000025c80 R12: ffff888101bf1860
> [ 4070.575012] R13: dead0000000000b0 R14: ffffc90002077c04 R15: ffff88810be5cabc
> [ 4070.575016] FS: 00007f1ed50c0780(0000) GS:ffff88885ec80000(0000) knlGS:0000000000000000
> [ 4070.575021] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 4070.575025] CR2: 00007f1ed5590280 CR3: 000000010ef6f005 CR4: 00000000003706e0
> [ 4070.575029] Call Trace:
> [ 4070.575033] <TASK>
> [ 4070.575037] lrc_configure_all_contexts+0x13e/0x150 [i915]
> [ 4070.575103] gen8_enable_metric_set+0x4d/0x90 [i915]
> [ 4070.575164] i915_perf_open_ioctl+0xbc0/0x1500 [i915]
> [ 4070.575224] ? asm_common_interrupt+0x1e/0x40
> [ 4070.575232] ? i915_oa_init_reg_state+0x110/0x110 [i915]
> [ 4070.575290] drm_ioctl_kernel+0x85/0x110
> [ 4070.575296] ? update_load_avg+0x5f/0x5e0
> [ 4070.575302] drm_ioctl+0x1d3/0x370
> [ 4070.575307] ? i915_oa_init_reg_state+0x110/0x110 [i915]
> [ 4070.575382] ? gen8_gt_irq_handler+0x46/0x130 [i915]
> [ 4070.575445] __x64_sys_ioctl+0x3c4/0x8d0
> [ 4070.575451] ? __do_softirq+0xaa/0x1d2
> [ 4070.575456] do_syscall_64+0x35/0x80
> [ 4070.575461] entry_SYSCALL_64_after_hwframe+0x44/0xae
> [ 4070.575467] RIP: 0033:0x7f1ed5c10397
> [ 4070.575471] Code: 3c 1c e8 1c ff ff ff 85 c0 79 87 49 c7 c4 ff ff ff ff 5b 5d 4c 89 e0 41 5c c3 66 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d a9 da 0d 00 f7 d8 64 89 01 48
> [ 4070.575478] RSP: 002b:00007ffd65c8d7a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> [ 4070.575484] RAX: ffffffffffffffda RBX: 0000000000000006 RCX: 00007f1ed5c10397
> [ 4070.575488] RDX: 00007ffd65c8d7c0 RSI: 0000000040106476 RDI: 0000000000000006
> [ 4070.575492] RBP: 00005620972f9c60 R08: 000000000000000a R09: 0000000000000005
> [ 4070.575496] R10: 000000000000000d R11: 0000000000000246 R12: 000000000000000a
> [ 4070.575500] R13: 000000000000000d R14: 0000000000000000 R15: 00007ffd65c8d7c0
> [ 4070.575505] </TASK>
> [ 4070.575507] Modules linked in: nls_ascii(E) nls_cp437(E) vfat(E) fat(E) i915(E) x86_pkg_temp_thermal(E) intel_powerclamp(E) crct10dif_pclmul(E) crc32_pclmul(E) crc32c_intel(E) aesni_intel(E) crypto_simd(E) intel_gtt(E) cryptd(E) ttm(E) rapl(E) intel_cstate(E) drm_kms_helper(E) cfbfillrect(E) syscopyarea(E) cfbimgblt(E) intel_uncore(E) sysfillrect(E) mei_me(E) sysimgblt(E) i2c_i801(E) fb_sys_fops(E) mei(E) intel_pch_thermal(E) i2c_smbus(E) cfbcopyarea(E) video(E) button(E) efivarfs(E) autofs4(E)
> [ 4070.575549] ---[ end trace 0000000000000000 ]---
>
> Reported-by: Mark Janes <mark.janes@intel.com>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/6222
> References: a4e7ccdac38e ("drm/i915: Move context management under GEM")
> Fixes: f8246cf4d9a9 ("drm/i915/gem: Drop free_work for GEM contexts")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: <stable@vger.kernel.org> # v5.12+
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 14 +++++++-------
> drivers/gpu/drm/i915/i915_perf.c | 18 ++++++++++--------
> drivers/gpu/drm/i915/i915_sysfs.c | 8 ++++----
> 3 files changed, 21 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index dabdfe09f5e51..9d7142ab63c05 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -1133,7 +1133,6 @@ static struct i915_gem_engines *default_engines(struct i915_gem_context *ctx,
> err = ERR_PTR(ret);
> goto free_engines;
> }
> -
can you please remove this cahnge? It's not even geographically
close to the changes we are sending :)
But don't mind it if you have already packed everything.
Andi
> }
>
> return e;
> @@ -1265,10 +1264,15 @@ static void i915_gem_context_release_work(struct work_struct *work)
> struct i915_gem_context *ctx = container_of(work, typeof(*ctx),
> release_work);
> struct i915_address_space *vm;
> + unsigned long flags;
>
> trace_i915_context_free(ctx);
> GEM_BUG_ON(!i915_gem_context_is_closed(ctx));
>
> + spin_lock_irqsave(&ctx->i915->gem.contexts.lock, flags);
> + list_del(&ctx->link);
> + spin_unlock_irqrestore(&ctx->i915->gem.contexts.lock, flags);
> +
> if (ctx->syncobj)
> drm_syncobj_put(ctx->syncobj);
>
> @@ -1521,10 +1525,6 @@ static void context_close(struct i915_gem_context *ctx)
>
> ctx->file_priv = ERR_PTR(-EBADF);
>
> - spin_lock(&ctx->i915->gem.contexts.lock);
> - list_del(&ctx->link);
> - spin_unlock(&ctx->i915->gem.contexts.lock);
> -
> client = ctx->client;
> if (client) {
> spin_lock(&client->ctx_lock);
> @@ -1717,9 +1717,9 @@ static void gem_context_register(struct i915_gem_context *ctx,
> list_add_tail_rcu(&ctx->client_link, &ctx->client->ctx_list);
> spin_unlock(&ctx->client->ctx_lock);
>
> - spin_lock(&i915->gem.contexts.lock);
> + spin_lock_irq(&i915->gem.contexts.lock);
> list_add_tail(&ctx->link, &i915->gem.contexts.list);
> - spin_unlock(&i915->gem.contexts.lock);
> + spin_unlock_irq(&i915->gem.contexts.lock);
> }
>
> int i915_gem_context_open(struct drm_i915_private *i915,
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index f3c23fe9ad9ce..83bb71466f8f0 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -2379,24 +2379,26 @@ oa_configure_all_contexts(struct i915_perf_stream *stream,
> * context. Contexts idle at the time of reconfiguration are not
> * trapped behind the barrier.
> */
> - spin_lock(&i915->gem.contexts.lock);
> + spin_lock_irq(&i915->gem.contexts.lock);
> list_for_each_entry_safe(ctx, cn, &i915->gem.contexts.list, link) {
> if (!kref_get_unless_zero(&ctx->ref))
> continue;
>
> - spin_unlock(&i915->gem.contexts.lock);
> + spin_unlock_irq(&i915->gem.contexts.lock);
>
> - err = gen8_configure_context(ctx, regs, num_regs);
> - if (err) {
> - i915_gem_context_put(ctx);
> - return err;
> + if (!i915_gem_context_is_closed(ctx)) {
> + err = gen8_configure_context(ctx, regs, num_regs);
> + if (err) {
> + i915_gem_context_put(ctx);
> + return err;
> + }
> }
>
> - spin_lock(&i915->gem.contexts.lock);
> + spin_lock_irq(&i915->gem.contexts.lock);
> list_safe_reset_next(ctx, cn, link);
> i915_gem_context_put(ctx);
> }
> - spin_unlock(&i915->gem.contexts.lock);
> + spin_unlock_irq(&i915->gem.contexts.lock);
>
> /*
> * After updating all other contexts, we need to modify ourselves.
> diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
> index 1e27502108313..40c7671fc0591 100644
> --- a/drivers/gpu/drm/i915/i915_sysfs.c
> +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> @@ -77,12 +77,12 @@ i915_l3_read(struct file *filp, struct kobject *kobj,
> count = min_t(size_t, GEN7_L3LOG_SIZE - offset, count);
> memset(buf, 0, count);
>
> - spin_lock(&i915->gem.contexts.lock);
> + spin_lock_irq(&i915->gem.contexts.lock);
> if (i915->l3_parity.remap_info[slice])
> memcpy(buf,
> i915->l3_parity.remap_info[slice] + offset / sizeof(u32),
> count);
> - spin_unlock(&i915->gem.contexts.lock);
> + spin_unlock_irq(&i915->gem.contexts.lock);
>
> return count;
> }
> @@ -110,7 +110,7 @@ i915_l3_write(struct file *filp, struct kobject *kobj,
> if (!remap_info)
> return -ENOMEM;
>
> - spin_lock(&i915->gem.contexts.lock);
> + spin_lock_irq(&i915->gem.contexts.lock);
>
> if (i915->l3_parity.remap_info[slice]) {
> freeme = remap_info;
> @@ -126,7 +126,7 @@ i915_l3_write(struct file *filp, struct kobject *kobj,
> list_for_each_entry(ctx, &i915->gem.contexts.list, link)
> ctx->remap_slice |= BIT(slice);
>
> - spin_unlock(&i915->gem.contexts.lock);
> + spin_unlock_irq(&i915->gem.contexts.lock);
> kfree(freeme);
>
> /*
> --
> 2.25.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection
2022-09-13 16:10 ` [Intel-gfx] [PATCH 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
2022-09-14 15:15 ` Andi Shyti
@ 2022-09-14 15:37 ` Tvrtko Ursulin
2022-09-14 16:24 ` Janusz Krzysztofik
2022-09-14 17:50 ` Andi Shyti
1 sibling, 2 replies; 16+ messages in thread
From: Tvrtko Ursulin @ 2022-09-14 15:37 UTC (permalink / raw)
To: Janusz Krzysztofik, intel-gfx; +Cc: drm-devel, Daniel Vetter, Chris Wilson
On 13/09/2022 17:10, Janusz Krzysztofik wrote:
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> i915_perf assumes that it can use the i915_gem_context reference to
> protect its i915->gem.contexts.list iteration. However, this requires
> that we do not remove the context from the list until after we drop the
> final reference and release the struct. If, as currently, we remove the
> context from the list during context_close(), the link.next pointer may
> be poisoned while we are holding the context reference and cause a GPF:
>
> [ 4070.573157] i915 0000:00:02.0: [drm:i915_perf_open_ioctl [i915]] filtering on ctx_id=0x1fffff ctx_id_mask=0x1fffff
> [ 4070.574881] general protection fault, probably for non-canonical address 0xdead000000000100: 0000 [#1] PREEMPT SMP
> [ 4070.574897] CPU: 1 PID: 284392 Comm: amd_performance Tainted: G E 5.17.9 #180
> [ 4070.574903] Hardware name: Intel Corporation NUC7i5BNK/NUC7i5BNB, BIOS BNKBL357.86A.0052.2017.0918.1346 09/18/2017
> [ 4070.574907] RIP: 0010:oa_configure_all_contexts.isra.0+0x222/0x350 [i915]
> [ 4070.574982] Code: 08 e8 32 6e 10 e1 4d 8b 6d 50 b8 ff ff ff ff 49 83 ed 50 f0 41 0f c1 04 24 83 f8 01 0f 84 e3 00 00 00 85 c0 0f 8e fa 00 00 00 <49> 8b 45 50 48 8d 70 b0 49 8d 45 50 48 39 44 24 10 0f 85 34 fe ff
> [ 4070.574990] RSP: 0018:ffffc90002077b78 EFLAGS: 00010202
> [ 4070.574995] RAX: 0000000000000002 RBX: 0000000000000002 RCX: 0000000000000000
> [ 4070.575000] RDX: 0000000000000001 RSI: ffffc90002077b20 RDI: ffff88810ddc7c68
> [ 4070.575004] RBP: 0000000000000001 R08: ffff888103242648 R09: fffffffffffffffc
> [ 4070.575008] R10: ffffffff82c50bc0 R11: 0000000000025c80 R12: ffff888101bf1860
> [ 4070.575012] R13: dead0000000000b0 R14: ffffc90002077c04 R15: ffff88810be5cabc
> [ 4070.575016] FS: 00007f1ed50c0780(0000) GS:ffff88885ec80000(0000) knlGS:0000000000000000
> [ 4070.575021] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 4070.575025] CR2: 00007f1ed5590280 CR3: 000000010ef6f005 CR4: 00000000003706e0
> [ 4070.575029] Call Trace:
> [ 4070.575033] <TASK>
> [ 4070.575037] lrc_configure_all_contexts+0x13e/0x150 [i915]
> [ 4070.575103] gen8_enable_metric_set+0x4d/0x90 [i915]
> [ 4070.575164] i915_perf_open_ioctl+0xbc0/0x1500 [i915]
> [ 4070.575224] ? asm_common_interrupt+0x1e/0x40
> [ 4070.575232] ? i915_oa_init_reg_state+0x110/0x110 [i915]
> [ 4070.575290] drm_ioctl_kernel+0x85/0x110
> [ 4070.575296] ? update_load_avg+0x5f/0x5e0
> [ 4070.575302] drm_ioctl+0x1d3/0x370
> [ 4070.575307] ? i915_oa_init_reg_state+0x110/0x110 [i915]
> [ 4070.575382] ? gen8_gt_irq_handler+0x46/0x130 [i915]
> [ 4070.575445] __x64_sys_ioctl+0x3c4/0x8d0
> [ 4070.575451] ? __do_softirq+0xaa/0x1d2
> [ 4070.575456] do_syscall_64+0x35/0x80
> [ 4070.575461] entry_SYSCALL_64_after_hwframe+0x44/0xae
> [ 4070.575467] RIP: 0033:0x7f1ed5c10397
> [ 4070.575471] Code: 3c 1c e8 1c ff ff ff 85 c0 79 87 49 c7 c4 ff ff ff ff 5b 5d 4c 89 e0 41 5c c3 66 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d a9 da 0d 00 f7 d8 64 89 01 48
> [ 4070.575478] RSP: 002b:00007ffd65c8d7a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> [ 4070.575484] RAX: ffffffffffffffda RBX: 0000000000000006 RCX: 00007f1ed5c10397
> [ 4070.575488] RDX: 00007ffd65c8d7c0 RSI: 0000000040106476 RDI: 0000000000000006
> [ 4070.575492] RBP: 00005620972f9c60 R08: 000000000000000a R09: 0000000000000005
> [ 4070.575496] R10: 000000000000000d R11: 0000000000000246 R12: 000000000000000a
> [ 4070.575500] R13: 000000000000000d R14: 0000000000000000 R15: 00007ffd65c8d7c0
> [ 4070.575505] </TASK>
> [ 4070.575507] Modules linked in: nls_ascii(E) nls_cp437(E) vfat(E) fat(E) i915(E) x86_pkg_temp_thermal(E) intel_powerclamp(E) crct10dif_pclmul(E) crc32_pclmul(E) crc32c_intel(E) aesni_intel(E) crypto_simd(E) intel_gtt(E) cryptd(E) ttm(E) rapl(E) intel_cstate(E) drm_kms_helper(E) cfbfillrect(E) syscopyarea(E) cfbimgblt(E) intel_uncore(E) sysfillrect(E) mei_me(E) sysimgblt(E) i2c_i801(E) fb_sys_fops(E) mei(E) intel_pch_thermal(E) i2c_smbus(E) cfbcopyarea(E) video(E) button(E) efivarfs(E) autofs4(E)
> [ 4070.575549] ---[ end trace 0000000000000000 ]---
>
> Reported-by: Mark Janes <mark.janes@intel.com>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/6222
> References: a4e7ccdac38e ("drm/i915: Move context management under GEM")
> Fixes: f8246cf4d9a9 ("drm/i915/gem: Drop free_work for GEM contexts")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: <stable@vger.kernel.org> # v5.12+
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 14 +++++++-------
> drivers/gpu/drm/i915/i915_perf.c | 18 ++++++++++--------
> drivers/gpu/drm/i915/i915_sysfs.c | 8 ++++----
> 3 files changed, 21 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index dabdfe09f5e51..9d7142ab63c05 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -1133,7 +1133,6 @@ static struct i915_gem_engines *default_engines(struct i915_gem_context *ctx,
> err = ERR_PTR(ret);
> goto free_engines;
> }
> -
Best avoid unrelated cleanups especially when there is a fixes tag.
> }
>
> return e;
> @@ -1265,10 +1264,15 @@ static void i915_gem_context_release_work(struct work_struct *work)
> struct i915_gem_context *ctx = container_of(work, typeof(*ctx),
> release_work);
> struct i915_address_space *vm;
> + unsigned long flags;
>
> trace_i915_context_free(ctx);
> GEM_BUG_ON(!i915_gem_context_is_closed(ctx));
>
> + spin_lock_irqsave(&ctx->i915->gem.contexts.lock, flags);
Why irqsave and the conversion to irq safe elsewhere? Worker context
does not require it and I don't see the connection to the change of
list_del location.
Regards,
Tvrtko
> + list_del(&ctx->link);
> + spin_unlock_irqrestore(&ctx->i915->gem.contexts.lock, flags);
> +
> if (ctx->syncobj)
> drm_syncobj_put(ctx->syncobj);
>
> @@ -1521,10 +1525,6 @@ static void context_close(struct i915_gem_context *ctx)
>
> ctx->file_priv = ERR_PTR(-EBADF);
>
> - spin_lock(&ctx->i915->gem.contexts.lock);
> - list_del(&ctx->link);
> - spin_unlock(&ctx->i915->gem.contexts.lock);
> -
> client = ctx->client;
> if (client) {
> spin_lock(&client->ctx_lock);
> @@ -1717,9 +1717,9 @@ static void gem_context_register(struct i915_gem_context *ctx,
> list_add_tail_rcu(&ctx->client_link, &ctx->client->ctx_list);
> spin_unlock(&ctx->client->ctx_lock);
>
> - spin_lock(&i915->gem.contexts.lock);
> + spin_lock_irq(&i915->gem.contexts.lock);
> list_add_tail(&ctx->link, &i915->gem.contexts.list);
> - spin_unlock(&i915->gem.contexts.lock);
> + spin_unlock_irq(&i915->gem.contexts.lock);
> }
>
> int i915_gem_context_open(struct drm_i915_private *i915,
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index f3c23fe9ad9ce..83bb71466f8f0 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -2379,24 +2379,26 @@ oa_configure_all_contexts(struct i915_perf_stream *stream,
> * context. Contexts idle at the time of reconfiguration are not
> * trapped behind the barrier.
> */
> - spin_lock(&i915->gem.contexts.lock);
> + spin_lock_irq(&i915->gem.contexts.lock);
> list_for_each_entry_safe(ctx, cn, &i915->gem.contexts.list, link) {
> if (!kref_get_unless_zero(&ctx->ref))
> continue;
>
> - spin_unlock(&i915->gem.contexts.lock);
> + spin_unlock_irq(&i915->gem.contexts.lock);
>
> - err = gen8_configure_context(ctx, regs, num_regs);
> - if (err) {
> - i915_gem_context_put(ctx);
> - return err;
> + if (!i915_gem_context_is_closed(ctx)) {
> + err = gen8_configure_context(ctx, regs, num_regs);
> + if (err) {
> + i915_gem_context_put(ctx);
> + return err;
> + }
> }
>
> - spin_lock(&i915->gem.contexts.lock);
> + spin_lock_irq(&i915->gem.contexts.lock);
> list_safe_reset_next(ctx, cn, link);
> i915_gem_context_put(ctx);
> }
> - spin_unlock(&i915->gem.contexts.lock);
> + spin_unlock_irq(&i915->gem.contexts.lock);
>
> /*
> * After updating all other contexts, we need to modify ourselves.
> diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
> index 1e27502108313..40c7671fc0591 100644
> --- a/drivers/gpu/drm/i915/i915_sysfs.c
> +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> @@ -77,12 +77,12 @@ i915_l3_read(struct file *filp, struct kobject *kobj,
> count = min_t(size_t, GEN7_L3LOG_SIZE - offset, count);
> memset(buf, 0, count);
>
> - spin_lock(&i915->gem.contexts.lock);
> + spin_lock_irq(&i915->gem.contexts.lock);
> if (i915->l3_parity.remap_info[slice])
> memcpy(buf,
> i915->l3_parity.remap_info[slice] + offset / sizeof(u32),
> count);
> - spin_unlock(&i915->gem.contexts.lock);
> + spin_unlock_irq(&i915->gem.contexts.lock);
>
> return count;
> }
> @@ -110,7 +110,7 @@ i915_l3_write(struct file *filp, struct kobject *kobj,
> if (!remap_info)
> return -ENOMEM;
>
> - spin_lock(&i915->gem.contexts.lock);
> + spin_lock_irq(&i915->gem.contexts.lock);
>
> if (i915->l3_parity.remap_info[slice]) {
> freeme = remap_info;
> @@ -126,7 +126,7 @@ i915_l3_write(struct file *filp, struct kobject *kobj,
> list_for_each_entry(ctx, &i915->gem.contexts.list, link)
> ctx->remap_slice |= BIT(slice);
>
> - spin_unlock(&i915->gem.contexts.lock);
> + spin_unlock_irq(&i915->gem.contexts.lock);
> kfree(freeme);
>
> /*
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2)
2022-09-13 16:10 [Intel-gfx] [PATCH 0/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
` (5 preceding siblings ...)
2022-09-14 12:20 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-09-14 15:45 ` Patchwork
2022-09-14 16:35 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
7 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2022-09-14 15:45 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 35385 bytes --]
== Series Details ==
Series: drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2)
URL : https://patchwork.freedesktop.org/series/105975/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12131_full -> Patchwork_105975v2_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_105975v2_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_105975v2_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_105975v2_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-iclb: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc.html
Known issues
------------
Here are the changes found in Patchwork_105975v2_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-skl: ([PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26]) -> ([PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [FAIL][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50]) ([i915#5032])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl9/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl9/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl9/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl9/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl3/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl3/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl3/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl3/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-contexts-10ms:
- shard-snb: [PASS][51] -> [FAIL][52] ([i915#4409])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-snb2/igt@gem_eio@in-flight-contexts-10ms.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-snb6/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-iclb: [PASS][53] -> [TIMEOUT][54] ([i915#3070])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@gem_eio@in-flight-contexts-1us.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_balancer@parallel:
- shard-iclb: [PASS][55] -> [SKIP][56] ([i915#4525])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb4/igt@gem_exec_balancer@parallel.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb5/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][57] -> [FAIL][58] ([i915#2842])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: NOTRUN -> [FAIL][59] ([i915#2842])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][60] ([i915#2842])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][61] -> [FAIL][62] ([i915#2842])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][63] -> [SKIP][64] ([i915#2190])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglb5/igt@gem_huc_copy@huc-copy.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random:
- shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#4613])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl8/igt@gem_lmem_swapping@parallel-random.html
* igt@gem_lmem_swapping@verify-ccs:
- shard-glk: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#4613])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@gem_lmem_swapping@verify-ccs.html
* igt@gem_softpin@evict-snoop-interruptible:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109312])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@gem_softpin@evict-snoop-interruptible.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-iclb: NOTRUN -> [SKIP][68] ([i915#5286]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#3886]) +3 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109278]) +3 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs.html
* igt@kms_chamelium@hdmi-audio:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271] / [fdo#111827]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl8/igt@kms_chamelium@hdmi-audio.html
* igt@kms_color_chamelium@ctm-blue-to-red:
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109284] / [fdo#111827])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_color_chamelium@ctm-blue-to-red.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][73] -> [FAIL][74] ([i915#72])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][75] -> [FAIL][76] ([i915#79]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][77] ([i915#2587] / [i915#2672]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][78] ([i915#2672])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][79] -> [SKIP][80] ([i915#3555])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][81] ([i915#2672] / [i915#3555])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-glk: NOTRUN -> [SKIP][82] ([fdo#109271]) +24 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271]) +31 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109280])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-edp-1:
- shard-iclb: [PASS][85] -> [INCOMPLETE][86] ([i915#6169])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb8/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-edp-1.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb6/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-edp-1.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-glk: NOTRUN -> [FAIL][87] ([fdo#108145] / [i915#265]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#658])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [PASS][89] -> [SKIP][90] ([fdo#109441]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109441])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_psr@psr2_primary_blt.html
* igt@perf@non-zero-reason:
- shard-iclb: [PASS][92] -> [FAIL][93] ([i915#3089])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@perf@non-zero-reason.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@perf@non-zero-reason.html
* igt@prime_nv_api@i915_nv_import_vs_close:
- shard-iclb: NOTRUN -> [SKIP][94] ([fdo#109291])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@prime_nv_api@i915_nv_import_vs_close.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][95] ([i915#6268]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglu-4/igt@gem_ctx_exec@basic-nohangcheck.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglu-3/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [TIMEOUT][97] ([i915#3070]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb4/igt@gem_eio@unwedge-stress.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb8/igt@gem_eio@unwedge-stress.html
- {shard-tglu}: [TIMEOUT][99] ([i915#3063]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglu-4/igt@gem_eio@unwedge-stress.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglu-3/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][101] ([i915#4525]) -> [PASS][102] +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb6/igt@gem_exec_balancer@parallel-keep-in-fence.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb4/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-deadline:
- shard-iclb: [DMESG-WARN][103] ([i915#4391]) -> [PASS][104] +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb7/igt@gem_exec_fair@basic-deadline.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][105] ([i915#2842]) -> [PASS][106] +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-tglb: [FAIL][107] ([i915#2842]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_reloc@basic-write-read-active:
- {shard-rkl}: [SKIP][109] ([i915#3281]) -> [PASS][110] +3 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-rkl-1/igt@gem_exec_reloc@basic-write-read-active.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-rkl-5/igt@gem_exec_reloc@basic-write-read-active.html
* igt@gen9_exec_parse@bb-large:
- shard-apl: [TIMEOUT][111] -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl7/igt@gen9_exec_parse@bb-large.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl2/igt@gen9_exec_parse@bb-large.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][113] ([i915#454]) -> [PASS][114] +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][115] ([i915#4281]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb5/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_selftest@live@gt_pm:
- {shard-tglu}: [DMESG-FAIL][117] ([i915#3987]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglu-2/igt@i915_selftest@live@gt_pm.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglu-4/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][119] ([i915#180]) -> [PASS][120] +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl8/igt@i915_suspend@fence-restore-tiled2untiled.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl3/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][121] ([i915#79]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [SKIP][123] ([i915#5176]) -> [PASS][124] +2 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][125] ([i915#5235]) -> [PASS][126] +2 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][127] ([fdo#109441]) -> [PASS][128] +2 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@perf@stress-open-close:
- shard-glk: [INCOMPLETE][129] ([i915#5213]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk9/igt@perf@stress-open-close.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@perf@stress-open-close.html
* igt@prime_vgem@basic-write:
- {shard-rkl}: [SKIP][131] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-rkl-1/igt@prime_vgem@basic-write.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-rkl-5/igt@prime_vgem@basic-write.html
#### Warnings ####
* igt@gem_eio@unwedge-stress:
- shard-tglb: [FAIL][133] ([i915#5784]) -> [TIMEOUT][134] ([i915#3063])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglb1/igt@gem_eio@unwedge-stress.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][135] ([i915#6117]) -> [SKIP][136] ([i915#4525])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@gem_exec_balancer@parallel-ordering.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@gem_exec_balancer@parallel-ordering.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][137] ([i915#2920]) -> [SKIP][138] ([i915#658])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@runner@aborted:
- shard-apl: ([FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][143], [FAIL][144]) ([i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl3/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl1/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl8/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl8/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl3/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl1/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070
[i915#3089]: https://gitlab.freedesktop.org/drm/intel/issues/3089
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4409]: https://gitlab.freedesktop.org/drm/intel/issues/4409
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5032]: https://gitlab.freedesktop.org/drm/intel/issues/5032
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6169]: https://gitlab.freedesktop.org/drm/intel/issues/6169
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12131 -> Patchwork_105975v2
CI-20190529: 20190529
CI_DRM_12131: 3c82566040d2d01a9e98f740d8de4a9e18116818 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6653: 4f927248ebbf11f03f4c1ea2254f011e7575322f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105975v2: 3c82566040d2d01a9e98f740d8de4a9e18116818 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/index.html
[-- Attachment #2: Type: text/html, Size: 33544 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection
2022-09-14 15:15 ` Andi Shyti
@ 2022-09-14 16:09 ` Janusz Krzysztofik
0 siblings, 0 replies; 16+ messages in thread
From: Janusz Krzysztofik @ 2022-09-14 16:09 UTC (permalink / raw)
To: Andi Shyti, Daniel Vetter; +Cc: intel-gfx, Chris Wilson
On Wednesday, 14 September 2022 17:15:02 CEST Andi Shyti wrote:
> Hi Krzysztofik,
>
> if you are going to resend it, I just have a little thing if you
> don't mind,
>
> On Tue, Sep 13, 2022 at 06:10:39PM +0200, Janusz Krzysztofik wrote:
> > From: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > i915_perf assumes that it can use the i915_gem_context reference to
> > protect its i915->gem.contexts.list iteration. However, this requires
> > that we do not remove the context from the list until after we drop the
> > final reference and release the struct. If, as currently, we remove the
> > context from the list during context_close(), the link.next pointer may
> > be poisoned while we are holding the context reference and cause a GPF:
> >
> > [ 4070.573157] i915 0000:00:02.0: [drm:i915_perf_open_ioctl [i915]] filtering on ctx_id=0x1fffff ctx_id_mask=0x1fffff
> > [ 4070.574881] general protection fault, probably for non-canonical address 0xdead000000000100: 0000 [#1] PREEMPT SMP
> > [ 4070.574897] CPU: 1 PID: 284392 Comm: amd_performance Tainted: G E 5.17.9 #180
> > [ 4070.574903] Hardware name: Intel Corporation NUC7i5BNK/NUC7i5BNB, BIOS BNKBL357.86A.0052.2017.0918.1346 09/18/2017
> > [ 4070.574907] RIP: 0010:oa_configure_all_contexts.isra.0+0x222/0x350 [i915]
> > [ 4070.574982] Code: 08 e8 32 6e 10 e1 4d 8b 6d 50 b8 ff ff ff ff 49 83 ed 50 f0 41 0f c1 04 24 83 f8 01 0f 84 e3 00 00 00 85 c0 0f 8e fa 00 00 00 <49> 8b 45 50 48 8d 70 b0 49 8d 45 50 48 39 44 24 10 0f 85 34 fe ff
> > [ 4070.574990] RSP: 0018:ffffc90002077b78 EFLAGS: 00010202
> > [ 4070.574995] RAX: 0000000000000002 RBX: 0000000000000002 RCX: 0000000000000000
> > [ 4070.575000] RDX: 0000000000000001 RSI: ffffc90002077b20 RDI: ffff88810ddc7c68
> > [ 4070.575004] RBP: 0000000000000001 R08: ffff888103242648 R09: fffffffffffffffc
> > [ 4070.575008] R10: ffffffff82c50bc0 R11: 0000000000025c80 R12: ffff888101bf1860
> > [ 4070.575012] R13: dead0000000000b0 R14: ffffc90002077c04 R15: ffff88810be5cabc
> > [ 4070.575016] FS: 00007f1ed50c0780(0000) GS:ffff88885ec80000(0000) knlGS:0000000000000000
> > [ 4070.575021] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [ 4070.575025] CR2: 00007f1ed5590280 CR3: 000000010ef6f005 CR4: 00000000003706e0
> > [ 4070.575029] Call Trace:
> > [ 4070.575033] <TASK>
> > [ 4070.575037] lrc_configure_all_contexts+0x13e/0x150 [i915]
> > [ 4070.575103] gen8_enable_metric_set+0x4d/0x90 [i915]
> > [ 4070.575164] i915_perf_open_ioctl+0xbc0/0x1500 [i915]
> > [ 4070.575224] ? asm_common_interrupt+0x1e/0x40
> > [ 4070.575232] ? i915_oa_init_reg_state+0x110/0x110 [i915]
> > [ 4070.575290] drm_ioctl_kernel+0x85/0x110
> > [ 4070.575296] ? update_load_avg+0x5f/0x5e0
> > [ 4070.575302] drm_ioctl+0x1d3/0x370
> > [ 4070.575307] ? i915_oa_init_reg_state+0x110/0x110 [i915]
> > [ 4070.575382] ? gen8_gt_irq_handler+0x46/0x130 [i915]
> > [ 4070.575445] __x64_sys_ioctl+0x3c4/0x8d0
> > [ 4070.575451] ? __do_softirq+0xaa/0x1d2
> > [ 4070.575456] do_syscall_64+0x35/0x80
> > [ 4070.575461] entry_SYSCALL_64_after_hwframe+0x44/0xae
> > [ 4070.575467] RIP: 0033:0x7f1ed5c10397
> > [ 4070.575471] Code: 3c 1c e8 1c ff ff ff 85 c0 79 87 49 c7 c4 ff ff ff ff 5b 5d 4c 89 e0 41 5c c3 66 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d a9 da 0d 00 f7 d8 64 89 01 48
> > [ 4070.575478] RSP: 002b:00007ffd65c8d7a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> > [ 4070.575484] RAX: ffffffffffffffda RBX: 0000000000000006 RCX: 00007f1ed5c10397
> > [ 4070.575488] RDX: 00007ffd65c8d7c0 RSI: 0000000040106476 RDI: 0000000000000006
> > [ 4070.575492] RBP: 00005620972f9c60 R08: 000000000000000a R09: 0000000000000005
> > [ 4070.575496] R10: 000000000000000d R11: 0000000000000246 R12: 000000000000000a
> > [ 4070.575500] R13: 000000000000000d R14: 0000000000000000 R15: 00007ffd65c8d7c0
> > [ 4070.575505] </TASK>
> > [ 4070.575507] Modules linked in: nls_ascii(E) nls_cp437(E) vfat(E) fat(E) i915(E) x86_pkg_temp_thermal(E) intel_powerclamp(E) crct10dif_pclmul(E) crc32_pclmul(E) crc32c_intel(E) aesni_intel(E) crypto_simd(E) intel_gtt(E) cryptd(E) ttm(E) rapl(E) intel_cstate(E) drm_kms_helper(E) cfbfillrect(E) syscopyarea(E) cfbimgblt(E) intel_uncore(E) sysfillrect(E) mei_me(E) sysimgblt(E) i2c_i801(E) fb_sys_fops(E) mei(E) intel_pch_thermal(E) i2c_smbus(E) cfbcopyarea(E) video(E) button(E) efivarfs(E) autofs4(E)
> > [ 4070.575549] ---[ end trace 0000000000000000 ]---
> >
> > Reported-by: Mark Janes <mark.janes@intel.com>
> > Closes: https://gitlab.freedesktop.org/drm/intel/issues/6222
> > References: a4e7ccdac38e ("drm/i915: Move context management under GEM")
> > Fixes: f8246cf4d9a9 ("drm/i915/gem: Drop free_work for GEM contexts")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: <stable@vger.kernel.org> # v5.12+
> > ---
> > drivers/gpu/drm/i915/gem/i915_gem_context.c | 14 +++++++-------
> > drivers/gpu/drm/i915/i915_perf.c | 18 ++++++++++--------
> > drivers/gpu/drm/i915/i915_sysfs.c | 8 ++++----
> > 3 files changed, 21 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > index dabdfe09f5e51..9d7142ab63c05 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > @@ -1133,7 +1133,6 @@ static struct i915_gem_engines *default_engines(struct i915_gem_context *ctx,
> > err = ERR_PTR(ret);
> > goto free_engines;
> > }
> > -
>
> can you please remove this cahnge? It's not even geographically
> close to the changes we are sending :)
Sure, that's what Tvrtko also raised in his review.
Thanks,
Janusz
>
> But don't mind it if you have already packed everything.
>
> Andi
>
> > }
> >
> > return e;
> > @@ -1265,10 +1264,15 @@ static void i915_gem_context_release_work(struct work_struct *work)
> > struct i915_gem_context *ctx = container_of(work, typeof(*ctx),
> > release_work);
> > struct i915_address_space *vm;
> > + unsigned long flags;
> >
> > trace_i915_context_free(ctx);
> > GEM_BUG_ON(!i915_gem_context_is_closed(ctx));
> >
> > + spin_lock_irqsave(&ctx->i915->gem.contexts.lock, flags);
> > + list_del(&ctx->link);
> > + spin_unlock_irqrestore(&ctx->i915->gem.contexts.lock, flags);
> > +
> > if (ctx->syncobj)
> > drm_syncobj_put(ctx->syncobj);
> >
> > @@ -1521,10 +1525,6 @@ static void context_close(struct i915_gem_context *ctx)
> >
> > ctx->file_priv = ERR_PTR(-EBADF);
> >
> > - spin_lock(&ctx->i915->gem.contexts.lock);
> > - list_del(&ctx->link);
> > - spin_unlock(&ctx->i915->gem.contexts.lock);
> > -
> > client = ctx->client;
> > if (client) {
> > spin_lock(&client->ctx_lock);
> > @@ -1717,9 +1717,9 @@ static void gem_context_register(struct i915_gem_context *ctx,
> > list_add_tail_rcu(&ctx->client_link, &ctx->client->ctx_list);
> > spin_unlock(&ctx->client->ctx_lock);
> >
> > - spin_lock(&i915->gem.contexts.lock);
> > + spin_lock_irq(&i915->gem.contexts.lock);
> > list_add_tail(&ctx->link, &i915->gem.contexts.list);
> > - spin_unlock(&i915->gem.contexts.lock);
> > + spin_unlock_irq(&i915->gem.contexts.lock);
> > }
> >
> > int i915_gem_context_open(struct drm_i915_private *i915,
> > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> > index f3c23fe9ad9ce..83bb71466f8f0 100644
> > --- a/drivers/gpu/drm/i915/i915_perf.c
> > +++ b/drivers/gpu/drm/i915/i915_perf.c
> > @@ -2379,24 +2379,26 @@ oa_configure_all_contexts(struct i915_perf_stream *stream,
> > * context. Contexts idle at the time of reconfiguration are not
> > * trapped behind the barrier.
> > */
> > - spin_lock(&i915->gem.contexts.lock);
> > + spin_lock_irq(&i915->gem.contexts.lock);
> > list_for_each_entry_safe(ctx, cn, &i915->gem.contexts.list, link) {
> > if (!kref_get_unless_zero(&ctx->ref))
> > continue;
> >
> > - spin_unlock(&i915->gem.contexts.lock);
> > + spin_unlock_irq(&i915->gem.contexts.lock);
> >
> > - err = gen8_configure_context(ctx, regs, num_regs);
> > - if (err) {
> > - i915_gem_context_put(ctx);
> > - return err;
> > + if (!i915_gem_context_is_closed(ctx)) {
> > + err = gen8_configure_context(ctx, regs, num_regs);
> > + if (err) {
> > + i915_gem_context_put(ctx);
> > + return err;
> > + }
> > }
> >
> > - spin_lock(&i915->gem.contexts.lock);
> > + spin_lock_irq(&i915->gem.contexts.lock);
> > list_safe_reset_next(ctx, cn, link);
> > i915_gem_context_put(ctx);
> > }
> > - spin_unlock(&i915->gem.contexts.lock);
> > + spin_unlock_irq(&i915->gem.contexts.lock);
> >
> > /*
> > * After updating all other contexts, we need to modify ourselves.
> > diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
> > index 1e27502108313..40c7671fc0591 100644
> > --- a/drivers/gpu/drm/i915/i915_sysfs.c
> > +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> > @@ -77,12 +77,12 @@ i915_l3_read(struct file *filp, struct kobject *kobj,
> > count = min_t(size_t, GEN7_L3LOG_SIZE - offset, count);
> > memset(buf, 0, count);
> >
> > - spin_lock(&i915->gem.contexts.lock);
> > + spin_lock_irq(&i915->gem.contexts.lock);
> > if (i915->l3_parity.remap_info[slice])
> > memcpy(buf,
> > i915->l3_parity.remap_info[slice] + offset / sizeof(u32),
> > count);
> > - spin_unlock(&i915->gem.contexts.lock);
> > + spin_unlock_irq(&i915->gem.contexts.lock);
> >
> > return count;
> > }
> > @@ -110,7 +110,7 @@ i915_l3_write(struct file *filp, struct kobject *kobj,
> > if (!remap_info)
> > return -ENOMEM;
> >
> > - spin_lock(&i915->gem.contexts.lock);
> > + spin_lock_irq(&i915->gem.contexts.lock);
> >
> > if (i915->l3_parity.remap_info[slice]) {
> > freeme = remap_info;
> > @@ -126,7 +126,7 @@ i915_l3_write(struct file *filp, struct kobject *kobj,
> > list_for_each_entry(ctx, &i915->gem.contexts.list, link)
> > ctx->remap_slice |= BIT(slice);
> >
> > - spin_unlock(&i915->gem.contexts.lock);
> > + spin_unlock_irq(&i915->gem.contexts.lock);
> > kfree(freeme);
> >
> > /*
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection
2022-09-14 15:37 ` Tvrtko Ursulin
@ 2022-09-14 16:24 ` Janusz Krzysztofik
2022-09-14 17:50 ` Andi Shyti
1 sibling, 0 replies; 16+ messages in thread
From: Janusz Krzysztofik @ 2022-09-14 16:24 UTC (permalink / raw)
To: intel-gfx, Tvrtko Ursulin, Daniel Vetter; +Cc: Chris Wilson
Hi Tvrtko,
Thanks for review.
On Wednesday, 14 September 2022 17:37:19 CEST Tvrtko Ursulin wrote:
>
> On 13/09/2022 17:10, Janusz Krzysztofik wrote:
> > From: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > i915_perf assumes that it can use the i915_gem_context reference to
> > protect its i915->gem.contexts.list iteration. However, this requires
> > that we do not remove the context from the list until after we drop the
> > final reference and release the struct. If, as currently, we remove the
> > context from the list during context_close(), the link.next pointer may
> > be poisoned while we are holding the context reference and cause a GPF:
> >
> > [ 4070.573157] i915 0000:00:02.0: [drm:i915_perf_open_ioctl [i915]] filtering on ctx_id=0x1fffff ctx_id_mask=0x1fffff
> > [ 4070.574881] general protection fault, probably for non-canonical address 0xdead000000000100: 0000 [#1] PREEMPT SMP
> > [ 4070.574897] CPU: 1 PID: 284392 Comm: amd_performance Tainted: G E 5.17.9 #180
> > [ 4070.574903] Hardware name: Intel Corporation NUC7i5BNK/NUC7i5BNB, BIOS BNKBL357.86A.0052.2017.0918.1346 09/18/2017
> > [ 4070.574907] RIP: 0010:oa_configure_all_contexts.isra.0+0x222/0x350 [i915]
> > [ 4070.574982] Code: 08 e8 32 6e 10 e1 4d 8b 6d 50 b8 ff ff ff ff 49 83 ed 50 f0 41 0f c1 04 24 83 f8 01 0f 84 e3 00 00 00 85 c0 0f 8e fa 00 00 00 <49> 8b 45 50 48 8d 70 b0 49 8d 45 50 48 39 44 24 10 0f 85 34 fe ff
> > [ 4070.574990] RSP: 0018:ffffc90002077b78 EFLAGS: 00010202
> > [ 4070.574995] RAX: 0000000000000002 RBX: 0000000000000002 RCX: 0000000000000000
> > [ 4070.575000] RDX: 0000000000000001 RSI: ffffc90002077b20 RDI: ffff88810ddc7c68
> > [ 4070.575004] RBP: 0000000000000001 R08: ffff888103242648 R09: fffffffffffffffc
> > [ 4070.575008] R10: ffffffff82c50bc0 R11: 0000000000025c80 R12: ffff888101bf1860
> > [ 4070.575012] R13: dead0000000000b0 R14: ffffc90002077c04 R15: ffff88810be5cabc
> > [ 4070.575016] FS: 00007f1ed50c0780(0000) GS:ffff88885ec80000(0000) knlGS:0000000000000000
> > [ 4070.575021] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [ 4070.575025] CR2: 00007f1ed5590280 CR3: 000000010ef6f005 CR4: 00000000003706e0
> > [ 4070.575029] Call Trace:
> > [ 4070.575033] <TASK>
> > [ 4070.575037] lrc_configure_all_contexts+0x13e/0x150 [i915]
> > [ 4070.575103] gen8_enable_metric_set+0x4d/0x90 [i915]
> > [ 4070.575164] i915_perf_open_ioctl+0xbc0/0x1500 [i915]
> > [ 4070.575224] ? asm_common_interrupt+0x1e/0x40
> > [ 4070.575232] ? i915_oa_init_reg_state+0x110/0x110 [i915]
> > [ 4070.575290] drm_ioctl_kernel+0x85/0x110
> > [ 4070.575296] ? update_load_avg+0x5f/0x5e0
> > [ 4070.575302] drm_ioctl+0x1d3/0x370
> > [ 4070.575307] ? i915_oa_init_reg_state+0x110/0x110 [i915]
> > [ 4070.575382] ? gen8_gt_irq_handler+0x46/0x130 [i915]
> > [ 4070.575445] __x64_sys_ioctl+0x3c4/0x8d0
> > [ 4070.575451] ? __do_softirq+0xaa/0x1d2
> > [ 4070.575456] do_syscall_64+0x35/0x80
> > [ 4070.575461] entry_SYSCALL_64_after_hwframe+0x44/0xae
> > [ 4070.575467] RIP: 0033:0x7f1ed5c10397
> > [ 4070.575471] Code: 3c 1c e8 1c ff ff ff 85 c0 79 87 49 c7 c4 ff ff ff ff 5b 5d 4c 89 e0 41 5c c3 66 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d a9 da 0d 00 f7 d8 64 89 01 48
> > [ 4070.575478] RSP: 002b:00007ffd65c8d7a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> > [ 4070.575484] RAX: ffffffffffffffda RBX: 0000000000000006 RCX: 00007f1ed5c10397
> > [ 4070.575488] RDX: 00007ffd65c8d7c0 RSI: 0000000040106476 RDI: 0000000000000006
> > [ 4070.575492] RBP: 00005620972f9c60 R08: 000000000000000a R09: 0000000000000005
> > [ 4070.575496] R10: 000000000000000d R11: 0000000000000246 R12: 000000000000000a
> > [ 4070.575500] R13: 000000000000000d R14: 0000000000000000 R15: 00007ffd65c8d7c0
> > [ 4070.575505] </TASK>
> > [ 4070.575507] Modules linked in: nls_ascii(E) nls_cp437(E) vfat(E) fat(E) i915(E) x86_pkg_temp_thermal(E) intel_powerclamp(E) crct10dif_pclmul(E) crc32_pclmul(E) crc32c_intel(E) aesni_intel(E) crypto_simd(E) intel_gtt(E) cryptd(E) ttm(E) rapl(E) intel_cstate(E) drm_kms_helper(E) cfbfillrect(E) syscopyarea(E) cfbimgblt(E) intel_uncore(E) sysfillrect(E) mei_me(E) sysimgblt(E) i2c_i801(E) fb_sys_fops(E) mei(E) intel_pch_thermal(E) i2c_smbus(E) cfbcopyarea(E) video(E) button(E) efivarfs(E) autofs4(E)
> > [ 4070.575549] ---[ end trace 0000000000000000 ]---
> >
> > Reported-by: Mark Janes <mark.janes@intel.com>
> > Closes: https://gitlab.freedesktop.org/drm/intel/issues/6222
> > References: a4e7ccdac38e ("drm/i915: Move context management under GEM")
> > Fixes: f8246cf4d9a9 ("drm/i915/gem: Drop free_work for GEM contexts")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: <stable@vger.kernel.org> # v5.12+
> > ---
> > drivers/gpu/drm/i915/gem/i915_gem_context.c | 14 +++++++-------
> > drivers/gpu/drm/i915/i915_perf.c | 18 ++++++++++--------
> > drivers/gpu/drm/i915/i915_sysfs.c | 8 ++++----
> > 3 files changed, 21 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > index dabdfe09f5e51..9d7142ab63c05 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > @@ -1133,7 +1133,6 @@ static struct i915_gem_engines *default_engines(struct i915_gem_context *ctx,
> > err = ERR_PTR(ret);
> > goto free_engines;
> > }
> > -
>
> Best avoid unrelated cleanups especially when there is a fixes tag.
Sure, I'll drop this.
>
> > }
> >
> > return e;
> > @@ -1265,10 +1264,15 @@ static void i915_gem_context_release_work(struct work_struct *work)
> > struct i915_gem_context *ctx = container_of(work, typeof(*ctx),
> > release_work);
> > struct i915_address_space *vm;
> > + unsigned long flags;
> >
> > trace_i915_context_free(ctx);
> > GEM_BUG_ON(!i915_gem_context_is_closed(ctx));
> >
> > + spin_lock_irqsave(&ctx->i915->gem.contexts.lock, flags);
>
> Why irqsave and the conversion to irq safe elsewhere? Worker context
> does not require it and I don't see the connection to the change of
> list_del location.
Yes, please let me revisit all those spin_locks on i915->gem.contexts.lock
then and reconsider which variants are most optimal for use in those several
different places we need them.
Thanks,
Janusz
>
> Regards,
>
> Tvrtko
>
> > + list_del(&ctx->link);
> > + spin_unlock_irqrestore(&ctx->i915->gem.contexts.lock, flags);
> > +
> > if (ctx->syncobj)
> > drm_syncobj_put(ctx->syncobj);
> >
> > @@ -1521,10 +1525,6 @@ static void context_close(struct i915_gem_context *ctx)
> >
> > ctx->file_priv = ERR_PTR(-EBADF);
> >
> > - spin_lock(&ctx->i915->gem.contexts.lock);
> > - list_del(&ctx->link);
> > - spin_unlock(&ctx->i915->gem.contexts.lock);
> > -
> > client = ctx->client;
> > if (client) {
> > spin_lock(&client->ctx_lock);
> > @@ -1717,9 +1717,9 @@ static void gem_context_register(struct i915_gem_context *ctx,
> > list_add_tail_rcu(&ctx->client_link, &ctx->client->ctx_list);
> > spin_unlock(&ctx->client->ctx_lock);
> >
> > - spin_lock(&i915->gem.contexts.lock);
> > + spin_lock_irq(&i915->gem.contexts.lock);
> > list_add_tail(&ctx->link, &i915->gem.contexts.list);
> > - spin_unlock(&i915->gem.contexts.lock);
> > + spin_unlock_irq(&i915->gem.contexts.lock);
> > }
> >
> > int i915_gem_context_open(struct drm_i915_private *i915,
> > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> > index f3c23fe9ad9ce..83bb71466f8f0 100644
> > --- a/drivers/gpu/drm/i915/i915_perf.c
> > +++ b/drivers/gpu/drm/i915/i915_perf.c
> > @@ -2379,24 +2379,26 @@ oa_configure_all_contexts(struct i915_perf_stream *stream,
> > * context. Contexts idle at the time of reconfiguration are not
> > * trapped behind the barrier.
> > */
> > - spin_lock(&i915->gem.contexts.lock);
> > + spin_lock_irq(&i915->gem.contexts.lock);
> > list_for_each_entry_safe(ctx, cn, &i915->gem.contexts.list, link) {
> > if (!kref_get_unless_zero(&ctx->ref))
> > continue;
> >
> > - spin_unlock(&i915->gem.contexts.lock);
> > + spin_unlock_irq(&i915->gem.contexts.lock);
> >
> > - err = gen8_configure_context(ctx, regs, num_regs);
> > - if (err) {
> > - i915_gem_context_put(ctx);
> > - return err;
> > + if (!i915_gem_context_is_closed(ctx)) {
> > + err = gen8_configure_context(ctx, regs, num_regs);
> > + if (err) {
> > + i915_gem_context_put(ctx);
> > + return err;
> > + }
> > }
> >
> > - spin_lock(&i915->gem.contexts.lock);
> > + spin_lock_irq(&i915->gem.contexts.lock);
> > list_safe_reset_next(ctx, cn, link);
> > i915_gem_context_put(ctx);
> > }
> > - spin_unlock(&i915->gem.contexts.lock);
> > + spin_unlock_irq(&i915->gem.contexts.lock);
> >
> > /*
> > * After updating all other contexts, we need to modify ourselves.
> > diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
> > index 1e27502108313..40c7671fc0591 100644
> > --- a/drivers/gpu/drm/i915/i915_sysfs.c
> > +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> > @@ -77,12 +77,12 @@ i915_l3_read(struct file *filp, struct kobject *kobj,
> > count = min_t(size_t, GEN7_L3LOG_SIZE - offset, count);
> > memset(buf, 0, count);
> >
> > - spin_lock(&i915->gem.contexts.lock);
> > + spin_lock_irq(&i915->gem.contexts.lock);
> > if (i915->l3_parity.remap_info[slice])
> > memcpy(buf,
> > i915->l3_parity.remap_info[slice] + offset / sizeof(u32),
> > count);
> > - spin_unlock(&i915->gem.contexts.lock);
> > + spin_unlock_irq(&i915->gem.contexts.lock);
> >
> > return count;
> > }
> > @@ -110,7 +110,7 @@ i915_l3_write(struct file *filp, struct kobject *kobj,
> > if (!remap_info)
> > return -ENOMEM;
> >
> > - spin_lock(&i915->gem.contexts.lock);
> > + spin_lock_irq(&i915->gem.contexts.lock);
> >
> > if (i915->l3_parity.remap_info[slice]) {
> > freeme = remap_info;
> > @@ -126,7 +126,7 @@ i915_l3_write(struct file *filp, struct kobject *kobj,
> > list_for_each_entry(ctx, &i915->gem.contexts.list, link)
> > ctx->remap_slice |= BIT(slice);
> >
> > - spin_unlock(&i915->gem.contexts.lock);
> > + spin_unlock_irq(&i915->gem.contexts.lock);
> > kfree(freeme);
> >
> > /*
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2)
2022-09-13 16:10 [Intel-gfx] [PATCH 0/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
` (6 preceding siblings ...)
2022-09-14 15:45 ` Patchwork
@ 2022-09-14 16:35 ` Patchwork
7 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2022-09-14 16:35 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 34960 bytes --]
== Series Details ==
Series: drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2)
URL : https://patchwork.freedesktop.org/series/105975/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12131_full -> Patchwork_105975v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_105975v2_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-skl: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24]) -> ([PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [FAIL][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48]) ([i915#5032])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl4/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl4/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl4/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl10/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl3/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl9/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl9/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl9/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl9/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-skl7/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl10/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl3/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl3/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl3/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl6/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl7/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-skl9/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-contexts-10ms:
- shard-snb: [PASS][49] -> [FAIL][50] ([i915#4409])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-snb2/igt@gem_eio@in-flight-contexts-10ms.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-snb6/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-iclb: [PASS][51] -> [TIMEOUT][52] ([i915#3070])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@gem_eio@in-flight-contexts-1us.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_balancer@parallel:
- shard-iclb: [PASS][53] -> [SKIP][54] ([i915#4525])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb4/igt@gem_exec_balancer@parallel.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb5/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][55] -> [FAIL][56] ([i915#2842])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: NOTRUN -> [FAIL][57] ([i915#2842])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][58] ([i915#2842])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][59] -> [FAIL][60] ([i915#2842])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][61] -> [SKIP][62] ([i915#2190])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglb5/igt@gem_huc_copy@huc-copy.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#4613])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl8/igt@gem_lmem_swapping@parallel-random.html
* igt@gem_lmem_swapping@verify-ccs:
- shard-glk: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#4613])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@gem_lmem_swapping@verify-ccs.html
* igt@gem_softpin@evict-snoop-interruptible:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109312])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@gem_softpin@evict-snoop-interruptible.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-iclb: NOTRUN -> [SKIP][66] ([i915#5286]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#3886]) +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109278]) +3 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs.html
* igt@kms_chamelium@hdmi-audio:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [fdo#111827]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl8/igt@kms_chamelium@hdmi-audio.html
* igt@kms_color_chamelium@ctm-blue-to-red:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109284] / [fdo#111827])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_color_chamelium@ctm-blue-to-red.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][71] -> [FAIL][72] ([i915#72])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][73] -> [FAIL][74] ([i915#79]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][75] ([i915#2587] / [i915#2672]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][76] ([i915#2672])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][77] -> [SKIP][78] ([i915#3555])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#2672] / [i915#3555])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-iclb: [PASS][80] -> [DMESG-WARN][81] ([i915#402])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-glk: NOTRUN -> [SKIP][82] ([fdo#109271]) +24 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271]) +31 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109280])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-edp-1:
- shard-iclb: [PASS][85] -> [INCOMPLETE][86] ([i915#6169])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb8/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-edp-1.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb6/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-edp-1.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-glk: NOTRUN -> [FAIL][87] ([fdo#108145] / [i915#265]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#658])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [PASS][89] -> [SKIP][90] ([fdo#109441]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109441])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@kms_psr@psr2_primary_blt.html
* igt@perf@non-zero-reason:
- shard-iclb: [PASS][92] -> [FAIL][93] ([i915#3089])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@perf@non-zero-reason.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@perf@non-zero-reason.html
* igt@prime_nv_api@i915_nv_import_vs_close:
- shard-iclb: NOTRUN -> [SKIP][94] ([fdo#109291])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@prime_nv_api@i915_nv_import_vs_close.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][95] ([i915#6268]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglu-4/igt@gem_ctx_exec@basic-nohangcheck.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglu-3/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [TIMEOUT][97] ([i915#3070]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb4/igt@gem_eio@unwedge-stress.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb8/igt@gem_eio@unwedge-stress.html
- {shard-tglu}: [TIMEOUT][99] ([i915#3063]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglu-4/igt@gem_eio@unwedge-stress.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglu-3/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][101] ([i915#4525]) -> [PASS][102] +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb6/igt@gem_exec_balancer@parallel-keep-in-fence.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb4/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-deadline:
- shard-iclb: [DMESG-WARN][103] ([i915#4391]) -> [PASS][104] +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb7/igt@gem_exec_fair@basic-deadline.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][105] ([i915#2842]) -> [PASS][106] +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-tglb: [FAIL][107] ([i915#2842]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_reloc@basic-write-read-active:
- {shard-rkl}: [SKIP][109] ([i915#3281]) -> [PASS][110] +3 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-rkl-1/igt@gem_exec_reloc@basic-write-read-active.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-rkl-5/igt@gem_exec_reloc@basic-write-read-active.html
* igt@gen9_exec_parse@bb-large:
- shard-apl: [TIMEOUT][111] -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl7/igt@gen9_exec_parse@bb-large.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl2/igt@gen9_exec_parse@bb-large.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][113] ([i915#454]) -> [PASS][114] +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][115] ([i915#4281]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb5/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_selftest@live@gt_pm:
- {shard-tglu}: [DMESG-FAIL][117] ([i915#3987]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglu-2/igt@i915_selftest@live@gt_pm.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglu-4/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][119] ([i915#180]) -> [PASS][120] +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl8/igt@i915_suspend@fence-restore-tiled2untiled.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl3/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][121] ([i915#79]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [SKIP][123] ([i915#5176]) -> [PASS][124] +2 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][125] ([i915#5235]) -> [PASS][126] +2 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][127] ([fdo#109441]) -> [PASS][128] +2 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@perf@stress-open-close:
- shard-glk: [INCOMPLETE][129] ([i915#5213]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-glk9/igt@perf@stress-open-close.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-glk3/igt@perf@stress-open-close.html
* igt@prime_vgem@basic-write:
- {shard-rkl}: [SKIP][131] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-rkl-1/igt@prime_vgem@basic-write.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-rkl-5/igt@prime_vgem@basic-write.html
#### Warnings ####
* igt@gem_eio@unwedge-stress:
- shard-tglb: [FAIL][133] ([i915#5784]) -> [TIMEOUT][134] ([i915#3063])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-tglb1/igt@gem_eio@unwedge-stress.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-tglb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][135] ([i915#6117]) -> [SKIP][136] ([i915#4525])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@gem_exec_balancer@parallel-ordering.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@gem_exec_balancer@parallel-ordering.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][137] ([i915#2920]) -> [SKIP][138] ([i915#658])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-iclb7/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@runner@aborted:
- shard-apl: ([FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][143], [FAIL][144]) ([i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl3/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl1/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl8/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl8/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl3/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/shard-apl1/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070
[i915#3089]: https://gitlab.freedesktop.org/drm/intel/issues/3089
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4409]: https://gitlab.freedesktop.org/drm/intel/issues/4409
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5032]: https://gitlab.freedesktop.org/drm/intel/issues/5032
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6169]: https://gitlab.freedesktop.org/drm/intel/issues/6169
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12131 -> Patchwork_105975v2
CI-20190529: 20190529
CI_DRM_12131: 3c82566040d2d01a9e98f740d8de4a9e18116818 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6653: 4f927248ebbf11f03f4c1ea2254f011e7575322f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105975v2: 3c82566040d2d01a9e98f740d8de4a9e18116818 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105975v2/index.html
[-- Attachment #2: Type: text/html, Size: 33100 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection
2022-09-14 15:37 ` Tvrtko Ursulin
2022-09-14 16:24 ` Janusz Krzysztofik
@ 2022-09-14 17:50 ` Andi Shyti
1 sibling, 0 replies; 16+ messages in thread
From: Andi Shyti @ 2022-09-14 17:50 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: intel-gfx, drm-devel, Daniel Vetter, Chris Wilson
Hi,
[...]
> > struct i915_address_space *vm;
> > + unsigned long flags;
> > trace_i915_context_free(ctx);
> > GEM_BUG_ON(!i915_gem_context_is_closed(ctx));
> > + spin_lock_irqsave(&ctx->i915->gem.contexts.lock, flags);
>
> Why irqsave and the conversion to irq safe elsewhere? Worker context does
> not require it and I don't see the connection to the change of list_del
> location.
yah! I think there is no reason, this is just inherited from
other code.
Andi
> Regards,
>
> Tvrtko
>
> > + list_del(&ctx->link);
> > + spin_unlock_irqrestore(&ctx->i915->gem.contexts.lock, flags);
> > +
> > if (ctx->syncobj)
> > drm_syncobj_put(ctx->syncobj);
...
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2022-09-14 17:50 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-13 16:10 [Intel-gfx] [PATCH 0/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
2022-09-13 16:10 ` [Intel-gfx] [PATCH 1/2] drm/i915/gem: Flush contexts on driver release Janusz Krzysztofik
2022-09-14 13:56 ` Andi Shyti
2022-09-13 16:10 ` [Intel-gfx] [PATCH 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
2022-09-14 15:15 ` Andi Shyti
2022-09-14 16:09 ` Janusz Krzysztofik
2022-09-14 15:37 ` Tvrtko Ursulin
2022-09-14 16:24 ` Janusz Krzysztofik
2022-09-14 17:50 ` Andi Shyti
2022-09-13 21:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2) Patchwork
2022-09-13 21:39 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-09-13 22:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-14 12:20 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-14 13:59 ` Andi Shyti
2022-09-14 15:45 ` Patchwork
2022-09-14 16:35 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.