All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Indu Bhagat <indu.bhagat@oracle.com>
Cc: linux-toolchains@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org,
	"Jose E. Marchesi" <jemarch@gnu.org>,
	Miroslav Benes <mbenes@suse.cz>,
	Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>,
	x86@kernel.org, linux-arm-kernel@lists.infradead.org,
	live-patching@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Chen Zhongjin <chenzhongjin@huawei.com>,
	Sathvika Vasireddy <sv@linux.ibm.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [RFC] Objtool toolchain proposal: -fannotate-{jump-table,noreturn}
Date: Wed, 14 Sep 2022 01:12:05 +0100	[thread overview]
Message-ID: <20220914001205.ygvmwya5wcawcodj@treble> (raw)
In-Reply-To: <9f01a8b9-9ec6-6759-ba14-ee529a5b973a@oracle.com>

On Tue, Sep 13, 2022 at 03:51:44PM -0700, Indu Bhagat wrote:
> Curious to know what all features of objtool rely on the need to reverse
> engineer the control flow graph. Is it a larger set or it is only for ORC
> generation ?

Objtool features which rely on the CFG:

- Frame pointer rule validation (when using
  CONFIG_UNWINDER_FRAME_POINTER)

- ORC metadata generation

- Intel SMAP rule validation - ensures EFLAGS #AC is only set during
  usercopy

- "noinstr" rule validation - ensures no instrumentation/tracing
  functions are called in certain critical sections

-- 
Josh

WARNING: multiple messages have this Message-ID (diff)
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Indu Bhagat <indu.bhagat@oracle.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linuxppc-dev@lists.ozlabs.org,
	Chen Zhongjin <chenzhongjin@huawei.com>,
	x86@kernel.org, Nick Desaulniers <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	Sathvika Vasireddy <sv@linux.ibm.com>,
	linux-toolchains@vger.kernel.org, live-patching@vger.kernel.org,
	Miroslav Benes <mbenes@suse.cz>, Will Deacon <will@kernel.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	"Jose E. Marchesi" <jemarch@gnu.org>
Subject: Re: [RFC] Objtool toolchain proposal: -fannotate-{jump-table,noreturn}
Date: Wed, 14 Sep 2022 01:12:05 +0100	[thread overview]
Message-ID: <20220914001205.ygvmwya5wcawcodj@treble> (raw)
In-Reply-To: <9f01a8b9-9ec6-6759-ba14-ee529a5b973a@oracle.com>

On Tue, Sep 13, 2022 at 03:51:44PM -0700, Indu Bhagat wrote:
> Curious to know what all features of objtool rely on the need to reverse
> engineer the control flow graph. Is it a larger set or it is only for ORC
> generation ?

Objtool features which rely on the CFG:

- Frame pointer rule validation (when using
  CONFIG_UNWINDER_FRAME_POINTER)

- ORC metadata generation

- Intel SMAP rule validation - ensures EFLAGS #AC is only set during
  usercopy

- "noinstr" rule validation - ensures no instrumentation/tracing
  functions are called in certain critical sections

-- 
Josh

WARNING: multiple messages have this Message-ID (diff)
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Indu Bhagat <indu.bhagat@oracle.com>
Cc: linux-toolchains@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org,
	"Jose E. Marchesi" <jemarch@gnu.org>,
	Miroslav Benes <mbenes@suse.cz>,
	Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>,
	x86@kernel.org, linux-arm-kernel@lists.infradead.org,
	live-patching@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Chen Zhongjin <chenzhongjin@huawei.com>,
	Sathvika Vasireddy <sv@linux.ibm.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [RFC] Objtool toolchain proposal: -fannotate-{jump-table,noreturn}
Date: Wed, 14 Sep 2022 01:12:05 +0100	[thread overview]
Message-ID: <20220914001205.ygvmwya5wcawcodj@treble> (raw)
In-Reply-To: <9f01a8b9-9ec6-6759-ba14-ee529a5b973a@oracle.com>

On Tue, Sep 13, 2022 at 03:51:44PM -0700, Indu Bhagat wrote:
> Curious to know what all features of objtool rely on the need to reverse
> engineer the control flow graph. Is it a larger set or it is only for ORC
> generation ?

Objtool features which rely on the CFG:

- Frame pointer rule validation (when using
  CONFIG_UNWINDER_FRAME_POINTER)

- ORC metadata generation

- Intel SMAP rule validation - ensures EFLAGS #AC is only set during
  usercopy

- "noinstr" rule validation - ensures no instrumentation/tracing
  functions are called in certain critical sections

-- 
Josh

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-09-14  0:12 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09 18:07 [RFC] Objtool toolchain proposal: -fannotate-{jump-table,noreturn} Josh Poimboeuf
2022-09-09 18:07 ` Josh Poimboeuf
2022-09-09 18:07 ` Josh Poimboeuf
2022-09-11 15:26 ` Peter Zijlstra
2022-09-11 15:26   ` Peter Zijlstra
2022-09-11 15:26   ` Peter Zijlstra
2022-09-11 15:31   ` Ard Biesheuvel
2022-09-11 15:31     ` Ard Biesheuvel
2022-09-11 15:31     ` Ard Biesheuvel
2022-09-12 10:52 ` Borislav Petkov
2022-09-12 10:52   ` Borislav Petkov
2022-09-12 10:52   ` Borislav Petkov
2022-09-12 14:17   ` Michael Matz
2022-09-12 14:17     ` Michael Matz
2022-09-12 14:17     ` Michael Matz
2022-09-14  0:04     ` Josh Poimboeuf
2022-09-14  0:04       ` Josh Poimboeuf
2022-09-14  0:04       ` Josh Poimboeuf
2022-09-14 14:00       ` Peter Zijlstra
2022-09-14 14:00         ` Peter Zijlstra
2022-09-14 14:00         ` Peter Zijlstra
2022-09-14 14:28         ` Michael Matz
2022-09-14 14:28           ` Michael Matz
2022-09-14 14:28           ` Michael Matz
2022-09-14 14:55           ` Peter Zijlstra
2022-09-14 14:55             ` Peter Zijlstra
2022-09-14 14:55             ` Peter Zijlstra
2022-09-14 17:34             ` Segher Boessenkool
2022-09-14 17:34               ` Segher Boessenkool
2022-09-14 17:34               ` Segher Boessenkool
2022-09-15  2:56     ` Chen Zhongjin
2022-09-15  2:56       ` Chen Zhongjin
2022-09-15  2:56       ` Chen Zhongjin
2022-09-15  8:47       ` Peter Zijlstra
2022-09-15  8:47         ` Peter Zijlstra
2022-09-15  8:47         ` Peter Zijlstra
2022-09-20 16:49         ` Ard Biesheuvel
2022-09-20 16:49           ` Ard Biesheuvel
2022-09-20 16:49           ` Ard Biesheuvel
2022-09-21  3:16           ` Chen Zhongjin
2022-09-21  3:16             ` Chen Zhongjin
2022-09-21  3:16             ` Chen Zhongjin
2022-09-12 11:31 ` Segher Boessenkool
2022-09-12 11:31   ` Segher Boessenkool
2022-09-12 11:31   ` Segher Boessenkool
2022-09-14 10:21   ` Josh Poimboeuf
2022-09-14 10:21     ` Josh Poimboeuf
2022-09-14 10:21     ` Josh Poimboeuf
2022-09-14 12:08     ` Michael Matz
2022-09-14 12:08       ` Michael Matz
2022-09-14 12:08       ` Michael Matz
2022-09-14 12:16     ` Segher Boessenkool
2022-09-14 12:16       ` Segher Boessenkool
2022-09-14 12:16       ` Segher Boessenkool
2022-09-13 22:51 ` Indu Bhagat
2022-09-13 22:51   ` Indu Bhagat
2022-09-13 22:51   ` Indu Bhagat
2022-09-14  0:12   ` Josh Poimboeuf [this message]
2022-09-14  0:12     ` Josh Poimboeuf
2022-09-14  0:12     ` Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220914001205.ygvmwya5wcawcodj@treble \
    --to=jpoimboe@kernel.org \
    --cc=ardb@kernel.org \
    --cc=broonie@kernel.org \
    --cc=chenzhongjin@huawei.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=indu.bhagat@oracle.com \
    --cc=jemarch@gnu.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-toolchains@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mbenes@suse.cz \
    --cc=ndesaulniers@google.com \
    --cc=peterz@infradead.org \
    --cc=sv@linux.ibm.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.