All of lore.kernel.org
 help / color / mirror / Atom feed
* [nacked] mm-damon-vaddr-indicate-the-target-is-invalid-when-nr_regions-is-zero.patch removed from -mm tree
@ 2022-09-14 22:39 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-09-14 22:39 UTC (permalink / raw)
  To: mm-commits, sj, kaixuxia, akpm


The quilt patch titled
     Subject: mm/damon/vaddr: indicate the target is invalid when 'nr_regions' is zero
has been removed from the -mm tree.  Its filename was
     mm-damon-vaddr-indicate-the-target-is-invalid-when-nr_regions-is-zero.patch

This patch was dropped because it was nacked

------------------------------------------------------
From: Kaixu Xia <kaixuxia@tencent.com>
Subject: mm/damon/vaddr: indicate the target is invalid when 'nr_regions' is zero
Date: Tue, 13 Sep 2022 17:11:27 +0800

When 'init()' and 'update()' DAMON operations failed and the number of the
damon_target regions is zero, the kdamond would do nothing to this
monitoring target in this case.  It makes no sense to run kdamond when all
of monitoring targets have no regions.  So add the judgement in
'target_valid()' operation to indicate the target is invalid when
'nr_regions' is zero.

Link: https://lkml.kernel.org/r/1663060287-30201-5-git-send-email-kaixuxia@tencent.com
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Cc: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/damon/vaddr.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/mm/damon/vaddr.c~mm-damon-vaddr-indicate-the-target-is-invalid-when-nr_regions-is-zero
+++ a/mm/damon/vaddr.c
@@ -598,6 +598,9 @@ static bool damon_va_target_valid(void *
 	struct damon_target *t = target;
 	struct task_struct *task;
 
+	if (!damon_nr_regions(t))
+		return false;
+
 	task = damon_get_task_struct(t);
 	if (task) {
 		put_task_struct(task);
_

Patches currently in -mm which might be from kaixuxia@tencent.com are

mm-damon-sysfs-simplify-the-judgement-whether-kdamonds-are-busy.patch
mm-damon-core-iterate-the-regions-list-from-current-point-in-damon_set_regions.patch
mm-damon-vaddr-add-a-comment-for-default-case-in-damon_va_apply_scheme.patch
mm-damon-sysfs-use-the-wrapper-directly-to-check-if-the-kdamond-is-running.patch
mm-damon-simplify-the-parameter-passing-for-prepare_access_checks.patch
mm-damon-sysfs-simplify-the-variable-pid-assignment-operation.patch
mm-damon-core-simplify-the-kdamond-stop-mechanism-by-removing-done.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-09-14 22:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-14 22:39 [nacked] mm-damon-vaddr-indicate-the-target-is-invalid-when-nr_regions-is-zero.patch removed from -mm tree Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.