All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: cy_huang <u0084500@gmail.com>,
	sre@kernel.org, alina_yu@richtek.com, alinayu829@gmail.com,
	linux-pm@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	cy_huang@richtek.com, mazziesaccount@gmail.com
Subject: Re: [PATCH v5 1/3] dt-bindings: power: supply: Add Richtek RT9471 battery charger
Date: Thu, 15 Sep 2022 06:59:03 -0500	[thread overview]
Message-ID: <20220915115903.GA984598-robh@kernel.org> (raw)
In-Reply-To: <20220915095121.lh5c5gbn53qedtgw@krzk-bin>

On Thu, Sep 15, 2022 at 10:51:21AM +0100, Krzysztof Kozlowski wrote:
> On Thu, 15 Sep 2022 00:30:13 +0800, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> > 
> > Add bindings for the Richtek RT9471 I2C controlled battery charger.
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Co-developed-by: Alina Yu <alina_yu@richtek.com>
> > Signed-off-by: Alina Yu <alina_yu@richtek.com>
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> > Since v3
> > - Move unevaluatedProperties line after $ref for binding patch.
> > - Add Reviewed-by tag for binding patch.
> > 
> > Since v2
> > - Remove the properties for interrupt controller things in the binding documentation.
> > - Fix dtc error for typo, it's 'regulator-name', not 'regulator-compatible'.
> > - Add regulator min/max microamp to allow otg vbus current adjustable in example.
> > - Specify the active-level for charge-enable-gpios in binding example.
> > 
> > ---
> >  .../bindings/power/supply/richtek,rt9471.yaml      | 73 ++++++++++++++++++++++
> >  1 file changed, 73 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/power/supply/richtek,rt9471.yaml
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.example.dtb: dma-router@a0: dma-masters:0: [4294967295, 4294967295] is too long
> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.example.dtb: dma-router@a0: dma-masters:0: [4294967295, 4294967295] is too long
> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/dma-router.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: dma-masters:0: [4294967295, 4294967295] is too long
> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/dma-router.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: dma-masters:0: [4294967295, 4294967295] is too long
> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: Unevaluated properties are not allowed ('dma-channels', 'dma-masters', 'dma-requests' were unexpected)
> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml

Ignore this. Unrelated.

Rob

  reply	other threads:[~2022-09-15 11:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14 16:30 [PATCH v5 0/3] Add Richtek RT9471 3A battery charger support cy_huang
2022-09-14 16:30 ` [PATCH v5 1/3] dt-bindings: power: supply: Add Richtek RT9471 battery charger cy_huang
2022-09-15  9:51   ` Krzysztof Kozlowski
2022-09-15 11:59     ` Rob Herring [this message]
2022-09-14 16:30 ` [PATCH v5 2/3] power: supply: rt9471: Add Richtek RT9471 charger driver cy_huang
2022-09-16 18:10   ` Sebastian Reichel
2022-09-14 16:30 ` [PATCH v5 3/3] Documentation: power: rt9471: Document exported sysfs entries cy_huang
2022-09-16 18:08   ` Sebastian Reichel
2022-09-19  1:11     ` ChiYuan Huang
2022-10-01 20:58       ` Sebastian Reichel
2022-10-03  2:00         ` ChiYuan Huang
2022-10-20  7:38           ` ChiYuan Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220915115903.GA984598-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alina_yu@richtek.com \
    --cc=alinayu829@gmail.com \
    --cc=cy_huang@richtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=sre@kernel.org \
    --cc=u0084500@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.