From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: cy_huang <u0084500@gmail.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
mazziesaccount@gmail.com, alina_yu@richtek.com,
cy_huang@richtek.com, alinayu829@gmail.com,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] power: supply: rt9471: Add Richtek RT9471 charger driver
Date: Fri, 16 Sep 2022 20:10:50 +0200 [thread overview]
Message-ID: <20220916181050.7cwu36euz4hvfkem@mercury.elektranox.org> (raw)
In-Reply-To: <1663173015-7934-3-git-send-email-u0084500@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
Hi,
On Thu, Sep 15, 2022 at 12:30:14AM +0800, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Add support for the RT9471 3A 1-Cell Li+ battery charger.
>
> The RT9471 is a highly-integrated 3A switch mode battery charger with
> low impedance power path to better optimize the charging efficiency.
>
> Co-developed-by: Alina Yu <alina_yu@richtek.com>
> Signed-off-by: Alina Yu <alina_yu@richtek.com>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> [...]
> +static DEVICE_ATTR_RW(sysoff_enable);
> +static DEVICE_ATTR_RW(port_detect_enable);
> +
> +static struct attribute *rt9471_sysfs_entries[] = {
> + &dev_attr_sysoff_enable.attr,
> + &dev_attr_port_detect_enable.attr,
> + NULL
> +};
> +
> +static const struct attribute_group rt9471_attr_group = {
> + .attrs = rt9471_sysfs_entries,
> +};
> +
> +static const struct attribute_group *rt9471_attr_groups[] = {
> + &rt9471_attr_group,
> + NULL
> +};
Iff these custom properties are required (see response to the last
patch), then 'ATTRIBUTE_GROUPS()' can be used to simplify this part
a bit.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-17 1:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 16:30 [PATCH v5 0/3] Add Richtek RT9471 3A battery charger support cy_huang
2022-09-14 16:30 ` [PATCH v5 1/3] dt-bindings: power: supply: Add Richtek RT9471 battery charger cy_huang
2022-09-15 9:51 ` Krzysztof Kozlowski
2022-09-15 11:59 ` Rob Herring
2022-09-14 16:30 ` [PATCH v5 2/3] power: supply: rt9471: Add Richtek RT9471 charger driver cy_huang
2022-09-16 18:10 ` Sebastian Reichel [this message]
2022-09-14 16:30 ` [PATCH v5 3/3] Documentation: power: rt9471: Document exported sysfs entries cy_huang
2022-09-16 18:08 ` Sebastian Reichel
2022-09-19 1:11 ` ChiYuan Huang
2022-10-01 20:58 ` Sebastian Reichel
2022-10-03 2:00 ` ChiYuan Huang
2022-10-20 7:38 ` ChiYuan Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220916181050.7cwu36euz4hvfkem@mercury.elektranox.org \
--to=sebastian.reichel@collabora.com \
--cc=alina_yu@richtek.com \
--cc=alinayu829@gmail.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=robh+dt@kernel.org \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.