All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] HID: hid-alps: use default remove for hid device
@ 2022-09-15 12:34 Marcus Folkesson
  2022-10-07  7:45 ` Marcus Folkesson
  0 siblings, 1 reply; 2+ messages in thread
From: Marcus Folkesson @ 2022-09-15 12:34 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires, Marcus Folkesson
  Cc: linux-kernel, linux-input

hid_device_remove() will call hid_hw_stop() as default .remove function
if no function is specified.

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
 drivers/hid/hid-alps.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
index 2b986d0dbde4..9abaff6f3afb 100644
--- a/drivers/hid/hid-alps.c
+++ b/drivers/hid/hid-alps.c
@@ -820,11 +820,6 @@ static int alps_probe(struct hid_device *hdev, const struct hid_device_id *id)
 	return 0;
 }
 
-static void alps_remove(struct hid_device *hdev)
-{
-	hid_hw_stop(hdev);
-}
-
 static const struct hid_device_id alps_id[] = {
 	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
 		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_DUAL) },
@@ -840,7 +835,6 @@ static struct hid_driver alps_driver = {
 	.name = "hid-alps",
 	.id_table		= alps_id,
 	.probe			= alps_probe,
-	.remove			= alps_remove,
 	.raw_event		= alps_raw_event,
 	.input_mapping		= alps_input_mapping,
 	.input_configured	= alps_input_configured,
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] HID: hid-alps: use default remove for hid device
  2022-09-15 12:34 [PATCH] HID: hid-alps: use default remove for hid device Marcus Folkesson
@ 2022-10-07  7:45 ` Marcus Folkesson
  0 siblings, 0 replies; 2+ messages in thread
From: Marcus Folkesson @ 2022-10-07  7:45 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires; +Cc: linux-kernel, linux-input

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

Hi,

On Thu, Sep 15, 2022 at 02:34:38PM +0200, Marcus Folkesson wrote:
> hid_device_remove() will call hid_hw_stop() as default .remove function
> if no function is specified.
> 
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>

Ping

Best regards,
Marcus Folkesson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-07  7:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-15 12:34 [PATCH] HID: hid-alps: use default remove for hid device Marcus Folkesson
2022-10-07  7:45 ` Marcus Folkesson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.