All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jia Zhu <zhujia.zj@bytedance.com>
To: linux-erofs@lists.ozlabs.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	yinxin.x@bytedance.com, jefflexu@linux.alibaba.com,
	Jia Zhu <zhujia.zj@bytedance.com>
Subject: [PATCH V5 1/6] erofs: use kill_anon_super() to kill super in fscache mode
Date: Fri, 16 Sep 2022 16:59:35 +0800	[thread overview]
Message-ID: <20220916085940.89392-2-zhujia.zj@bytedance.com> (raw)
In-Reply-To: <20220916085940.89392-1-zhujia.zj@bytedance.com>

Use kill_anon_super() instead of generic_shutdown_super() since the
mount() in erofs fscache mode uses get_tree_nodev() and associated
anon bdev needs to be freed.

Fixes: 9c0cc9c729657 ("erofs: add 'fsid' mount option")
Suggested-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Signed-off-by: Jia Zhu <zhujia.zj@bytedance.com>
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
---
 fs/erofs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 3173debeaa5a..9716d355a63e 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -879,7 +879,7 @@ static void erofs_kill_sb(struct super_block *sb)
 	WARN_ON(sb->s_magic != EROFS_SUPER_MAGIC);
 
 	if (erofs_is_fscache_mode(sb))
-		generic_shutdown_super(sb);
+		kill_anon_super(sb);
 	else
 		kill_block_super(sb);
 
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Jia Zhu <zhujia.zj@bytedance.com>
To: linux-erofs@lists.ozlabs.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	yinxin.x@bytedance.com
Subject: [PATCH V5 1/6] erofs: use kill_anon_super() to kill super in fscache mode
Date: Fri, 16 Sep 2022 16:59:35 +0800	[thread overview]
Message-ID: <20220916085940.89392-2-zhujia.zj@bytedance.com> (raw)
In-Reply-To: <20220916085940.89392-1-zhujia.zj@bytedance.com>

Use kill_anon_super() instead of generic_shutdown_super() since the
mount() in erofs fscache mode uses get_tree_nodev() and associated
anon bdev needs to be freed.

Fixes: 9c0cc9c729657 ("erofs: add 'fsid' mount option")
Suggested-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Signed-off-by: Jia Zhu <zhujia.zj@bytedance.com>
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
---
 fs/erofs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 3173debeaa5a..9716d355a63e 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -879,7 +879,7 @@ static void erofs_kill_sb(struct super_block *sb)
 	WARN_ON(sb->s_magic != EROFS_SUPER_MAGIC);
 
 	if (erofs_is_fscache_mode(sb))
-		generic_shutdown_super(sb);
+		kill_anon_super(sb);
 	else
 		kill_block_super(sb);
 
-- 
2.20.1


  reply	other threads:[~2022-09-16  9:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16  8:59 [PATCH V5 0/6] Introduce erofs shared domain Jia Zhu
2022-09-16  8:59 ` Jia Zhu
2022-09-16  8:59 ` Jia Zhu [this message]
2022-09-16  8:59   ` [PATCH V5 1/6] erofs: use kill_anon_super() to kill super in fscache mode Jia Zhu
2022-09-16  8:59 ` [PATCH V5 2/6] erofs: code clean up for fscache Jia Zhu
2022-09-16  8:59   ` Jia Zhu
2022-09-16  8:59 ` [PATCH V5 3/6] erofs: introduce fscache-based domain Jia Zhu
2022-09-16  8:59   ` Jia Zhu
2022-09-16  8:59 ` [PATCH V5 4/6] erofs: introduce a pseudo mnt to manage shared cookies Jia Zhu
2022-09-16  8:59   ` Jia Zhu
2022-09-16  8:59 ` [PATCH V5 5/6] erofs: Support sharing cookies in the same domain Jia Zhu
2022-09-16  8:59   ` Jia Zhu
2022-09-16  9:29   ` JeffleXu
2022-09-16  8:59 ` [PATCH V5 6/6] erofs: introduce 'domain_id' mount option Jia Zhu
2022-09-16  8:59   ` Jia Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220916085940.89392-2-zhujia.zj@bytedance.com \
    --to=zhujia.zj@bytedance.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yinxin.x@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.