* [PATCH v2] fs/ext4/xattr: check the return value of ext4_xattr_inode_dec_ref()
@ 2022-09-17 0:28 Li Zhong
2022-11-29 21:12 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Li Zhong @ 2022-09-17 0:28 UTC (permalink / raw)
To: linux-kernel, linux-ext4; +Cc: adilger.kernel, tytso, Li Zhong
Check the return value of ext4_xattr_inode_dec_ref(), which could return
error code and need to be warned.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
fs/ext4/xattr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 533216e80fa2..e6d62fd4ac31 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -1540,7 +1540,8 @@ static int ext4_xattr_inode_lookup_create(handle_t *handle, struct inode *inode,
err = ext4_xattr_inode_write(handle, ea_inode, value, value_len);
if (err) {
- ext4_xattr_inode_dec_ref(handle, ea_inode);
+ if (ext4_xattr_inode_dec_ref(handle, ea_inode))
+ ext4_warning_inode(ea_inode, "cleanup dec ref error %d", err);
iput(ea_inode);
return err;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] fs/ext4/xattr: check the return value of ext4_xattr_inode_dec_ref()
2022-09-17 0:28 [PATCH v2] fs/ext4/xattr: check the return value of ext4_xattr_inode_dec_ref() Li Zhong
@ 2022-11-29 21:12 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2022-11-29 21:12 UTC (permalink / raw)
To: linux-ext4, Li Zhong, linux-kernel; +Cc: Theodore Ts'o, adilger.kernel
On Fri, 16 Sep 2022 17:28:16 -0700, Li Zhong wrote:
> Check the return value of ext4_xattr_inode_dec_ref(), which could return
> error code and need to be warned.
>
>
Applied, thanks!
[1/1] fs/ext4/xattr: check the return value of ext4_xattr_inode_dec_ref()
commit: 883a86e4276a9facf1a0fe6950e504f52b841853
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-29 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-17 0:28 [PATCH v2] fs/ext4/xattr: check the return value of ext4_xattr_inode_dec_ref() Li Zhong
2022-11-29 21:12 ` Theodore Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.