* [PATCH -next] hwrng: Remove duplicate include
@ 2022-09-17 9:55 williamsukatube
2022-09-24 7:31 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: williamsukatube @ 2022-09-17 9:55 UTC (permalink / raw)
To: linux-crypto, linux-kernel; +Cc: William Dean
From: William Dean <williamsukatube@163.com>
In file: drivers/char/hw_random/core.c,
'#include <linux/random.h>' has included at line: 18,
now it is duplicated include at line: 24, so delete duplicated include.
Signed-off-by: William Dean <williamsukatube@163.com>
---
drivers/char/hw_random/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 16f227b995e8..56d171cd2fc6 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -21,7 +21,6 @@
#include <linux/sched/signal.h>
#include <linux/miscdevice.h>
#include <linux/module.h>
-#include <linux/random.h>
#include <linux/sched.h>
#include <linux/slab.h>
#include <linux/uaccess.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] hwrng: Remove duplicate include
2022-09-17 9:55 [PATCH -next] hwrng: Remove duplicate include williamsukatube
@ 2022-09-24 7:31 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2022-09-24 7:31 UTC (permalink / raw)
To: williamsukatube; +Cc: linux-crypto, linux-kernel, williamsukatube
williamsukatube@163.com wrote:
> From: William Dean <williamsukatube@163.com>
>
> In file: drivers/char/hw_random/core.c,
> '#include <linux/random.h>' has included at line: 18,
> now it is duplicated include at line: 24, so delete duplicated include.
>
> Signed-off-by: William Dean <williamsukatube@163.com>
> ---
> drivers/char/hw_random/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
> index 16f227b995e8..56d171cd2fc6 100644
> --- a/drivers/char/hw_random/core.c
> +++ b/drivers/char/hw_random/core.c
> @@ -21,7 +21,6 @@
> #include <linux/sched/signal.h>
> #include <linux/miscdevice.h>
> #include <linux/module.h>
> -#include <linux/random.h>
> #include <linux/sched.h>
> #include <linux/slab.h>
> #include <linux/uaccess.h>
This is supposed to be sorted so please remove the other inclusion
instead.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-24 7:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-17 9:55 [PATCH -next] hwrng: Remove duplicate include williamsukatube
2022-09-24 7:31 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.