All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c:26:16: warning: use of uninitialized value '<unknown>' [CWE-457]
@ 2022-09-17  5:48 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-09-17  5:48 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 5331 bytes --]

:::::: 
:::::: Manual check reason: "low confidence bisect report"
:::::: Manual check reason: "low confidence static check warning: drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c:26:16: warning: use of uninitialized value '<unknown>' [CWE-457] [-Wanalyzer-use-of-uninitialized-value]"
:::::: 

BCC: lkp(a)intel.com
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: "Marc Kleine-Budde" <mkl@pengutronix.de>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a335366bad1364a07f49df9da1fdfa6d411a5f39
commit: 55bc37c85587d0c53a666a685a49752e28a31396 can: mcp251xfd: move ring init into separate function
date:   8 months ago
:::::: branch date: 10 hours ago
:::::: commit date: 8 months ago
config: arm-randconfig-c002-20220915 (https://download.01.org/0day-ci/archive/20220917/202209171319.x5ZywRMh-lkp(a)intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=55bc37c85587d0c53a666a685a49752e28a31396
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 55bc37c85587d0c53a666a685a49752e28a31396
        # save the config file
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross ARCH=arm KBUILD_USERCFLAGS='-fanalyzer -Wno-error' 

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

gcc_analyzer warnings: (new ones prefixed by >>)
   drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c: In function 'mcp251xfd_cmd_prepare_write_reg':
>> drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c:26:16: warning: use of uninitialized value '<unknown>' [CWE-457] [-Wanalyzer-use-of-uninitialized-value]
      26 |         __le32 val_le32;
         |                ^~~~~~~~
     'mcp251xfd_cmd_prepare_write_reg': event 1
       |
       |   26 |         __le32 val_le32;
       |      |                ^~~~~~~~
       |      |                |
       |      |                (1) use of uninitialized value '<unknown>' here
       |

vim +26 drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c

55bc37c85587d0 Marc Kleine-Budde 2021-05-21  18  
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  19  static inline u8
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  20  mcp251xfd_cmd_prepare_write_reg(const struct mcp251xfd_priv *priv,
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  21  				union mcp251xfd_write_reg_buf *write_reg_buf,
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  22  				const u16 reg, const u32 mask, const u32 val)
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  23  {
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  24  	u8 first_byte, last_byte, len;
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  25  	u8 *data;
55bc37c85587d0 Marc Kleine-Budde 2021-05-21 @26  	__le32 val_le32;
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  27  
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  28  	first_byte = mcp251xfd_first_byte_set(mask);
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  29  	last_byte = mcp251xfd_last_byte_set(mask);
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  30  	len = last_byte - first_byte + 1;
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  31  
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  32  	data = mcp251xfd_spi_cmd_write(priv, write_reg_buf, reg + first_byte);
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  33  	val_le32 = cpu_to_le32(val >> BITS_PER_BYTE * first_byte);
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  34  	memcpy(data, &val_le32, len);
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  35  
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  36  	if (priv->devtype_data.quirks & MCP251XFD_QUIRK_CRC_REG) {
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  37  		u16 crc;
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  38  
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  39  		mcp251xfd_spi_cmd_crc_set_len_in_reg(&write_reg_buf->crc.cmd,
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  40  						     len);
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  41  		/* CRC */
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  42  		len += sizeof(write_reg_buf->crc.cmd);
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  43  		crc = mcp251xfd_crc16_compute(&write_reg_buf->crc, len);
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  44  		put_unaligned_be16(crc, (void *)write_reg_buf + len);
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  45  
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  46  		/* Total length */
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  47  		len += sizeof(write_reg_buf->crc.crc);
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  48  	} else {
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  49  		len += sizeof(write_reg_buf->nocrc.cmd);
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  50  	}
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  51  
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  52  	return len;
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  53  }
55bc37c85587d0 Marc Kleine-Budde 2021-05-21  54  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-09-17  5:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-17  5:48 drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c:26:16: warning: use of uninitialized value '<unknown>' [CWE-457] kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.