[Buildroot] [PATCH 1/2] package/weston: install to staging

[Buildroot] [PATCH 1/2] package/weston: install to staging

[James Hilliard]

We need to install weston to staging so that applications like cog
can use weston-direct-display.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/weston/weston.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/weston/weston.mk b/package/weston/weston.mk
index e6c54ee7aa..5e71473640 100644
--- a/package/weston/weston.mk
+++ b/package/weston/weston.mk
@@ -10,6 +10,7 @@ WESTON_SOURCE = weston-$(WESTON_VERSION).tar.xz
 WESTON_LICENSE = MIT
 WESTON_LICENSE_FILES = COPYING
 WESTON_CPE_ID_VENDOR = wayland
+WESTON_INSTALL_STAGING = YES
 
 WESTON_DEPENDENCIES = host-pkgconf wayland wayland-protocols \
 	libxkbcommon pixman libpng udev cairo libinput libdrm
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/cog: add weston direct display support

[James Hilliard]

Enable optional weston direct display support when weston is
available.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/cog/cog.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/package/cog/cog.mk b/package/cog/cog.mk
index 5f7abcab1f..1f24bebee4 100644
--- a/package/cog/cog.mk
+++ b/package/cog/cog.mk
@@ -14,11 +14,17 @@ COG_LICENSE_FILES = COPYING
 COG_CONF_OPTS = \
 	-DCOG_BUILD_PROGRAMS=ON \
 	-DCOG_PLATFORM_HEADLESS=ON \
-	-DCOG_WESTON_DIRECT_DISPLAY=OFF \
 	-DINSTALL_MAN_PAGES=OFF \
 	-DCOG_HOME_URI='$(call qstrip,$(BR2_PACKAGE_COG_PROGRAMS_HOME_URI))' \
 	-DUSE_SOUP2=ON
 
+ifeq ($(BR2_PACKAGE_WESTON),y)
+COG_CONF_OPTS += -DCOG_WESTON_DIRECT_DISPLAY=ON
+COG_DEPENDENCIES += weston
+else
+COG_CONF_OPTS += -DCOG_WESTON_DIRECT_DISPLAY=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_COG_PLATFORM_FDO),y)
 COG_CONF_OPTS += -DCOG_PLATFORM_WL=ON
 COG_DEPENDENCIES += libxkbcommon wayland-protocols
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/weston: install to staging

[Adrian Perez de Castro]

[-- Attachment #1.1: Type: text/plain, Size: 939 bytes --]

Hi,

Patch set LGTM.

On Thu, 08 Sep 2022 23:07:59 -0600 James Hilliard <james.hilliard1@gmail.com> wrote:
> We need to install weston to staging so that applications like cog
> can use weston-direct-display.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
>  package/weston/weston.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/weston/weston.mk b/package/weston/weston.mk
> index e6c54ee7aa..5e71473640 100644
> --- a/package/weston/weston.mk
> +++ b/package/weston/weston.mk
> @@ -10,6 +10,7 @@ WESTON_SOURCE = weston-$(WESTON_VERSION).tar.xz
>  WESTON_LICENSE = MIT
>  WESTON_LICENSE_FILES = COPYING
>  WESTON_CPE_ID_VENDOR = wayland
> +WESTON_INSTALL_STAGING = YES
>  
>  WESTON_DEPENDENCIES = host-pkgconf wayland wayland-protocols \
>  	libxkbcommon pixman libpng udev cairo libinput libdrm
> -- 
> 2.34.1
> 
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/cog: add weston direct display support

[Adrian Perez de Castro]

[-- Attachment #1.1: Type: text/plain, Size: 1371 bytes --]

Hi,

Patch set LGTM.

On Thu, 08 Sep 2022 23:08:00 -0600 James Hilliard <james.hilliard1@gmail.com> wrote:
> Enable optional weston direct display support when weston is
> available.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
>  package/cog/cog.mk | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/package/cog/cog.mk b/package/cog/cog.mk
> index 5f7abcab1f..1f24bebee4 100644
> --- a/package/cog/cog.mk
> +++ b/package/cog/cog.mk
> @@ -14,11 +14,17 @@ COG_LICENSE_FILES = COPYING
>  COG_CONF_OPTS = \
>  	-DCOG_BUILD_PROGRAMS=ON \
>  	-DCOG_PLATFORM_HEADLESS=ON \
> -	-DCOG_WESTON_DIRECT_DISPLAY=OFF \
>  	-DINSTALL_MAN_PAGES=OFF \
>  	-DCOG_HOME_URI='$(call qstrip,$(BR2_PACKAGE_COG_PROGRAMS_HOME_URI))' \
>  	-DUSE_SOUP2=ON
>  
> +ifeq ($(BR2_PACKAGE_WESTON),y)
> +COG_CONF_OPTS += -DCOG_WESTON_DIRECT_DISPLAY=ON
> +COG_DEPENDENCIES += weston
> +else
> +COG_CONF_OPTS += -DCOG_WESTON_DIRECT_DISPLAY=OFF
> +endif
> +
>  ifeq ($(BR2_PACKAGE_COG_PLATFORM_FDO),y)
>  COG_CONF_OPTS += -DCOG_PLATFORM_WL=ON
>  COG_DEPENDENCIES += libxkbcommon wayland-protocols
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/weston: install to staging

[Thomas Petazzoni]

On Thu,  8 Sep 2022 23:07:59 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> We need to install weston to staging so that applications like cog
> can use weston-direct-display.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/weston/weston.mk | 1 +
>  1 file changed, 1 insertion(+)

Both applied, thanks! And thanks Adrian for the review!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot