* [PATCH] of: base: fix repeated words in comments
@ 2022-09-18 9:59 Jilin Yuan
2022-09-18 14:03 ` Bagas Sanjaya
0 siblings, 1 reply; 2+ messages in thread
From: Jilin Yuan @ 2022-09-18 9:59 UTC (permalink / raw)
To: robh+dt, frowand.list; +Cc: devicetree, linux-kernel, Jilin Yuan
Delete the redundant word 'of'.
Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
drivers/of/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 8e96862d312e..9b8507fe6f9b 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1150,7 +1150,7 @@ const struct of_device_id *__of_match_node(const struct of_device_id *matches,
/**
* of_match_node - Tell if a device_node has a matching of_match structure
- * @matches: array of of device match structures to search in
+ * @matches: array of device match structures to search in
* @node: the of device structure to match against
*
* Low level utility function used by device matching.
@@ -1175,7 +1175,7 @@ EXPORT_SYMBOL(of_match_node);
* you pass will not be searched, only the next one
* will; typically, you pass what the previous call
* returned. of_node_put() will be called on it
- * @matches: array of of device match structures to search in
+ * @matches: array of device match structures to search in
* @match: Updated to point at the matches entry which matched
*
* Return: A node pointer with refcount incremented, use
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] of: base: fix repeated words in comments
2022-09-18 9:59 [PATCH] of: base: fix repeated words in comments Jilin Yuan
@ 2022-09-18 14:03 ` Bagas Sanjaya
0 siblings, 0 replies; 2+ messages in thread
From: Bagas Sanjaya @ 2022-09-18 14:03 UTC (permalink / raw)
To: Jilin Yuan; +Cc: robh+dt, frowand.list, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2059 bytes --]
On Sun, Sep 18, 2022 at 05:59:57PM +0800, Jilin Yuan wrote:
> /**
> * of_match_node - Tell if a device_node has a matching of_match structure
> - * @matches: array of of device match structures to search in
> + * @matches: array of device match structures to search in
> * @node: the of device structure to match against
> *
> * Low level utility function used by device matching.
> @@ -1175,7 +1175,7 @@ EXPORT_SYMBOL(of_match_node);
> * you pass will not be searched, only the next one
> * will; typically, you pass what the previous call
> * returned. of_node_put() will be called on it
> - * @matches: array of of device match structures to search in
> + * @matches: array of device match structures to search in
> * @match: Updated to point at the matches entry which matched
That second "of" is the device, so the fix doesn't make sense.
Also, PLEASE stop sending these mindless redundant word-stripping patches
as byproduct of whatever automated tool you use.
As Edward Cree said to one of your colleague [1]:
> #ifdef RANT
> NGL, getting kinda sick of these bogus comment text 'fixes' from people
> who clearly don't have enough mastery of English to copyedit it.
> (Previous one from this author was actually wrong too but I didn't catch
> it at the time.)
> English is a tricksy language, why would someone with a limited
> understanding of it think that grammar fixes are the best use of their
> time and energy?
> I can't help suspecting that this is a box-ticking exercise, where a
> certain corporate culture has a standard requirement that engineers
> must get X number of Linux / opensource commits in order to get
> promoted, and this kind of mindless patch is the easiest way for them
> to achieve that.
> #endif
If you really want to do real cleanup, consider joining kernel-janitors list.
Learn from above, thanks.
[1]: https://lore.kernel.org/netdev/30f2488d-9af3-fe8d-6e6f-713a7d38800b@gmail.com/
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-18 14:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-18 9:59 [PATCH] of: base: fix repeated words in comments Jilin Yuan
2022-09-18 14:03 ` Bagas Sanjaya
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.