* [PATCH] ext4: remove redundant checking in ext4_ioctl_checkpoint
@ 2022-09-18 11:52 Guoqing Jiang
2022-09-30 3:19 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Guoqing Jiang @ 2022-09-18 11:52 UTC (permalink / raw)
To: tytso, adilger.kernel; +Cc: linux-ext4
It is already checked after comment "check for invalid bits set",
so let's remove this one.
Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
---
fs/ext4/ioctl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 3cf3ec4b1c21..80678af1fa7c 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -1060,9 +1060,6 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
if (!EXT4_SB(sb)->s_journal)
return -ENODEV;
- if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID)
- return -EINVAL;
-
if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) &&
!bdev_max_discard_sectors(EXT4_SB(sb)->s_journal->j_dev))
return -EOPNOTSUPP;
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: remove redundant checking in ext4_ioctl_checkpoint
2022-09-18 11:52 [PATCH] ext4: remove redundant checking in ext4_ioctl_checkpoint Guoqing Jiang
@ 2022-09-30 3:19 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2022-09-30 3:19 UTC (permalink / raw)
To: adilger.kernel, guoqing.jiang; +Cc: Theodore Ts'o, linux-ext4
On Sun, 18 Sep 2022 19:52:19 +0800, Guoqing Jiang wrote:
> It is already checked after comment "check for invalid bits set",
> so let's remove this one.
>
>
Applied, thanks!
[1/1] ext4: remove redundant checking in ext4_ioctl_checkpoint
commit: 0a13172182a4d896bddfb42c06c85199fc526104
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-30 3:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-18 11:52 [PATCH] ext4: remove redundant checking in ext4_ioctl_checkpoint Guoqing Jiang
2022-09-30 3:19 ` Theodore Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.