[Buildroot] [PATCH 1/1] support/scripts/pyinstaller.py: revert mode back to 755

[Buildroot] [PATCH 1/1] support/scripts/pyinstaller.py: revert mode back to 755

[James Hilliard]

This was accidentially changed to 644 in:
d752f73b0c0e4ba50738cd1e7f4472f61fce9089

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 support/scripts/pyinstaller.py | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 support/scripts/pyinstaller.py

diff --git a/support/scripts/pyinstaller.py b/support/scripts/pyinstaller.py
old mode 100644
new mode 100755
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] support/scripts/pyinstaller.py: revert mode back to 755

[Yann E. MORIN]

James, All,

On 2022-08-22 04:04 -0600, James Hilliard spake thusly:
> This was accidentially changed to 644 in:
> d752f73b0c0e4ba50738cd1e7f4472f61fce9089

Indeed, I forgot to revert that when I applied your earlier patch.

Still, I think it does make sense to keep it as 0644, because this is
not an executable by itself, and we call it explicitly with our own
python interpreter. Besides, it is not supposed to be used outside of
our infra, so it is not expected to be a standalone script either.

So, unless we notice failurs in the autobuilders, that we can attrribute
to the script mode, I'd like we postpone applying this patch for now...

Regards,
Yann E. MORIN.

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  support/scripts/pyinstaller.py | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 support/scripts/pyinstaller.py
> 
> diff --git a/support/scripts/pyinstaller.py b/support/scripts/pyinstaller.py
> old mode 100644
> new mode 100755
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] support/scripts/pyinstaller.py: revert mode back to 755

[Thomas Petazzoni]

Hello James,

On Mon, 22 Aug 2022 04:04:33 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> This was accidentially changed to 644 in:
> d752f73b0c0e4ba50738cd1e7f4472f61fce9089
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  support/scripts/pyinstaller.py | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 support/scripts/pyinstaller.py

Based on Yann's feedback, and (apparently) the lack of autobuilder
failure, I have marked this patch as Rejected. As usual, we can
certainly revisit if there is some evidence that it is indeed needed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot