* [PATCH] arm: dts: imx8mn-beacon-kit-u-boot: Fix broken booting
@ 2022-07-31 17:16 Adam Ford
2022-07-31 17:27 ` Michael Nazzareno Trimarchi
2022-09-18 20:40 ` sbabic
0 siblings, 2 replies; 5+ messages in thread
From: Adam Ford @ 2022-07-31 17:16 UTC (permalink / raw)
To: u-boot
Cc: aford, Adam Ford, Stefano Babic, Fabio Estevam,
NXP i.MX U-Boot Team, Marcel Ziswiler
When the imx8mm.dtsi file was pulled in from Linux, the UARTs
were moved into an spba sub-node which wasn't being included
in the SPL device tree. This meant the references to the UART
weren't being handled properly and when booting the system would
constantly reboot. Fix this by adding the spba node to the spl
device tree to restore normal booting.
Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux")
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
index 5f83952402..0efa6862eb 100644
--- a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
+++ b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
@@ -106,6 +106,10 @@
u-boot,off-on-delay-us = <20000>;
};
+&spba1 {
+ u-boot,dm-spl;
+};
+
&uart2 {
u-boot,dm-spl;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm: dts: imx8mn-beacon-kit-u-boot: Fix broken booting
2022-07-31 17:16 [PATCH] arm: dts: imx8mn-beacon-kit-u-boot: Fix broken booting Adam Ford
@ 2022-07-31 17:27 ` Michael Nazzareno Trimarchi
2022-07-31 17:36 ` Adam Ford
2022-09-18 20:40 ` sbabic
1 sibling, 1 reply; 5+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-07-31 17:27 UTC (permalink / raw)
To: Adam Ford
Cc: u-boot, aford, Stefano Babic, Fabio Estevam,
NXP i.MX U-Boot Team, Marcel Ziswiler
Hi Adam
On Sun, Jul 31, 2022 at 7:16 PM Adam Ford <aford173@gmail.com> wrote:
>
> When the imx8mm.dtsi file was pulled in from Linux, the UARTs
> were moved into an spba sub-node which wasn't being included
> in the SPL device tree. This meant the references to the UART
> weren't being handled properly and when booting the system would
> constantly reboot. Fix this by adding the spba node to the spl
> device tree to restore normal booting.
>
> Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux")
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> index 5f83952402..0efa6862eb 100644
> --- a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> @@ -106,6 +106,10 @@
> u-boot,off-on-delay-us = <20000>;
> };
>
> +&spba1 {
> + u-boot,dm-spl;
> +};
> +
> &uart2 {
> u-boot,dm-spl;
> };
> --
> 2.34.1
>
Are you going to include it in imx8mn-u-boot.dtsi or do we need to
patch every single board?
Michael
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm: dts: imx8mn-beacon-kit-u-boot: Fix broken booting
2022-07-31 17:27 ` Michael Nazzareno Trimarchi
@ 2022-07-31 17:36 ` Adam Ford
2022-07-31 18:37 ` Adam Ford
0 siblings, 1 reply; 5+ messages in thread
From: Adam Ford @ 2022-07-31 17:36 UTC (permalink / raw)
To: Michael Nazzareno Trimarchi
Cc: U-Boot Mailing List, Adam Ford-BE, Stefano Babic, Fabio Estevam,
NXP i.MX U-Boot Team, Marcel Ziswiler
On Sun, Jul 31, 2022 at 12:28 PM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Hi Adam
>
> On Sun, Jul 31, 2022 at 7:16 PM Adam Ford <aford173@gmail.com> wrote:
> >
> > When the imx8mm.dtsi file was pulled in from Linux, the UARTs
> > were moved into an spba sub-node which wasn't being included
> > in the SPL device tree. This meant the references to the UART
> > weren't being handled properly and when booting the system would
> > constantly reboot. Fix this by adding the spba node to the spl
> > device tree to restore normal booting.
> >
> > Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux")
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> > index 5f83952402..0efa6862eb 100644
> > --- a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> > @@ -106,6 +106,10 @@
> > u-boot,off-on-delay-us = <20000>;
> > };
> >
> > +&spba1 {
> > + u-boot,dm-spl;
> > +};
> > +
> > &uart2 {
> > u-boot,dm-spl;
> > };
> > --
> > 2.34.1
> >
>
> Are you going to include it in imx8mn-u-boot.dtsi or do we need to
> patch every single board?
This is a temporary fix until I generate the common imx8mn-u-boot.dtsi
which will include this.
>
> Michael
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm: dts: imx8mn-beacon-kit-u-boot: Fix broken booting
2022-07-31 17:36 ` Adam Ford
@ 2022-07-31 18:37 ` Adam Ford
0 siblings, 0 replies; 5+ messages in thread
From: Adam Ford @ 2022-07-31 18:37 UTC (permalink / raw)
To: Michael Nazzareno Trimarchi
Cc: U-Boot Mailing List, Adam Ford-BE, Stefano Babic, Fabio Estevam,
NXP i.MX U-Boot Team, Marcel Ziswiler
On Sun, Jul 31, 2022 at 12:36 PM Adam Ford <aford173@gmail.com> wrote:
>
> On Sun, Jul 31, 2022 at 12:28 PM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Hi Adam
> >
> > On Sun, Jul 31, 2022 at 7:16 PM Adam Ford <aford173@gmail.com> wrote:
> > >
> > > When the imx8mm.dtsi file was pulled in from Linux, the UARTs
> > > were moved into an spba sub-node which wasn't being included
> > > in the SPL device tree. This meant the references to the UART
> > > weren't being handled properly and when booting the system would
> > > constantly reboot. Fix this by adding the spba node to the spl
> > > device tree to restore normal booting.
> > >
> > > Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux")
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > >
> > > diff --git a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> > > index 5f83952402..0efa6862eb 100644
> > > --- a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> > > +++ b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> > > @@ -106,6 +106,10 @@
> > > u-boot,off-on-delay-us = <20000>;
> > > };
> > >
> > > +&spba1 {
> > > + u-boot,dm-spl;
> > > +};
> > > +
> > > &uart2 {
> > > u-boot,dm-spl;
> > > };
> > > --
> > > 2.34.1
> > >
> >
> > Are you going to include it in imx8mn-u-boot.dtsi or do we need to
> > patch every single board?
>
> This is a temporary fix until I generate the common imx8mn-u-boot.dtsi
> which will include this.
I was hoping to finish this this afternoon, but a family emergency
came up. I'm going to try to finish it later tonight or tomorrow.
It's taking a bit longer because there are some boards with DDR4,
LPDDR4 and DDR3. I don't have most of them, but I plan to at least
generate a flash.bin file before posting it.
adam
>
> >
> > Michael
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm: dts: imx8mn-beacon-kit-u-boot: Fix broken booting
2022-07-31 17:16 [PATCH] arm: dts: imx8mn-beacon-kit-u-boot: Fix broken booting Adam Ford
2022-07-31 17:27 ` Michael Nazzareno Trimarchi
@ 2022-09-18 20:40 ` sbabic
1 sibling, 0 replies; 5+ messages in thread
From: sbabic @ 2022-09-18 20:40 UTC (permalink / raw)
To: Adam Ford, u-boot
> When the imx8mm.dtsi file was pulled in from Linux, the UARTs
> were moved into an spba sub-node which wasn't being included
> in the SPL device tree. This meant the references to the UART
> weren't being handled properly and when booting the system would
> constantly reboot. Fix this by adding the spba node to the spl
> device tree to restore normal booting.
> Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux")
> Signed-off-by: Adam Ford <aford173@gmail.com>
> diff --git a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> index 5f83952402..0efa6862eb 100644
> --- a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi
> @@ -106,6 +106,10 @@
> u-boot,off-on-delay-us = <20000>;
> };
>
> +&spba1 {
> + u-boot,dm-spl;
> +};
> +
> &uart2 {
> u-boot,dm-spl;
> };
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-18 20:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-31 17:16 [PATCH] arm: dts: imx8mn-beacon-kit-u-boot: Fix broken booting Adam Ford
2022-07-31 17:27 ` Michael Nazzareno Trimarchi
2022-07-31 17:36 ` Adam Ford
2022-07-31 18:37 ` Adam Ford
2022-09-18 20:40 ` sbabic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.