All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 1/1] net: sched: remove unused tcf_result extension
@ 2022-09-19 13:06 Jamal Hadi Salim
  2022-09-22  2:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Jamal Hadi Salim @ 2022-09-19 13:06 UTC (permalink / raw)
  To: davem, kuba, pabeni, edumazet
  Cc: xiyou.wangcong, jiri, netdev, kernel, Jamal Hadi Salim

Added by:
commit e5cf1baf92cb ("act_mirred: use TC_ACT_REINSERT when possible")
but no longer useful.

Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
 include/net/sch_generic.h | 5 -----
 net/sched/act_mirred.c    | 3 +--
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
index 7dc83400bde4..32819299937d 100644
--- a/include/net/sch_generic.h
+++ b/include/net/sch_generic.h
@@ -326,11 +326,6 @@ struct tcf_result {
 		};
 		const struct tcf_proto *goto_tp;
 
-		/* used in the skb_tc_reinsert function */
-		struct {
-			bool		ingress;
-			struct gnet_stats_queue *qstats;
-		};
 	};
 };
 
diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c
index f9c14d4188d4..b8ad6ae282c0 100644
--- a/net/sched/act_mirred.c
+++ b/net/sched/act_mirred.c
@@ -305,8 +305,7 @@ static int tcf_mirred_act(struct sk_buff *skb, const struct tc_action *a,
 
 		/* let's the caller reinsert the packet, if possible */
 		if (use_reinsert) {
-			res->ingress = want_ingress;
-			err = tcf_mirred_forward(res->ingress, skb);
+			err = tcf_mirred_forward(want_ingress, skb);
 			if (err)
 				tcf_action_inc_overlimit_qstats(&m->common);
 			__this_cpu_dec(mirred_rec_level);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next 1/1] net: sched: remove unused tcf_result extension
  2022-09-19 13:06 [PATCH net-next 1/1] net: sched: remove unused tcf_result extension Jamal Hadi Salim
@ 2022-09-22  2:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-22  2:00 UTC (permalink / raw)
  To: Jamal Hadi Salim
  Cc: davem, kuba, pabeni, edumazet, xiyou.wangcong, jiri, netdev, kernel

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 19 Sep 2022 13:06:27 +0000 you wrote:
> Added by:
> commit e5cf1baf92cb ("act_mirred: use TC_ACT_REINSERT when possible")
> but no longer useful.
> 
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
> ---
>  include/net/sch_generic.h | 5 -----
>  net/sched/act_mirred.c    | 3 +--
>  2 files changed, 1 insertion(+), 7 deletions(-)

Here is the summary with links:
  - [net-next,1/1] net: sched: remove unused tcf_result extension
    https://git.kernel.org/netdev/net-next/c/1d14b30b5a5e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-22  2:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 13:06 [PATCH net-next 1/1] net: sched: remove unused tcf_result extension Jamal Hadi Salim
2022-09-22  2:00 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.