* [PATCH net-next v2] net/8021q/vlan: check the return value of vlan_vid_add()
@ 2022-09-19 18:28 Li Zhong
0 siblings, 0 replies; only message in thread
From: Li Zhong @ 2022-09-19 18:28 UTC (permalink / raw)
To: netdev; +Cc: jgg, william.xuanziyang, pabeni, kuba, edumazet, davem, Li Zhong
Check the return value of vlan_vid_add() which could fail and return
error code.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
net/8021q/vlan.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index e40aa3e3641c..cb8048ce05f1 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -382,7 +382,9 @@ static int vlan_device_event(struct notifier_block *unused, unsigned long event,
(dev->features & NETIF_F_HW_VLAN_CTAG_FILTER)) {
pr_info("adding VLAN 0 to HW filter on device %s\n",
dev->name);
- vlan_vid_add(dev, htons(ETH_P_8021Q), 0);
+ err = vlan_vid_add(dev, htons(ETH_P_8021Q), 0);
+ if (err)
+ return notifier_from_errno(err);
}
if (event == NETDEV_DOWN &&
(dev->features & NETIF_F_HW_VLAN_CTAG_FILTER))
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-09-19 18:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 18:28 [PATCH net-next v2] net/8021q/vlan: check the return value of vlan_vid_add() Li Zhong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.