All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] selftests: forwarding: add shebang for sch_red.sh
@ 2022-09-22  2:44 Hangbin Liu
  2022-09-22 11:25 ` Petr Machata
  2022-09-22 14:40 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Hangbin Liu @ 2022-09-22  2:44 UTC (permalink / raw)
  To: netdev
  Cc: David S. Miller, Jakub Kicinski, Paolo Abeni, Shuah Khan,
	David Ahern, Petr Machata, Hangbin Liu

RHEL/Fedora RPM build checks are stricter, and complain when executable
files don't have a shebang line, e.g.

*** WARNING: ./kselftests/net/forwarding/sch_red.sh is executable but has no shebang, removing executable bit

Fix it by adding shebang line.

Fixes: 6cf0291f9517 ("selftests: forwarding: Add a RED test for SW datapath")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 tools/testing/selftests/net/forwarding/sch_red.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/forwarding/sch_red.sh b/tools/testing/selftests/net/forwarding/sch_red.sh
index e714bae473fb..81f31179ac88 100755
--- a/tools/testing/selftests/net/forwarding/sch_red.sh
+++ b/tools/testing/selftests/net/forwarding/sch_red.sh
@@ -1,3 +1,4 @@
+#!/bin/bash
 # SPDX-License-Identifier: GPL-2.0
 
 # This test sends one stream of traffic from H1 through a TBF shaper, to a RED
-- 
2.37.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] selftests: forwarding: add shebang for sch_red.sh
  2022-09-22  2:44 [PATCH net] selftests: forwarding: add shebang for sch_red.sh Hangbin Liu
@ 2022-09-22 11:25 ` Petr Machata
  2022-09-22 14:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Petr Machata @ 2022-09-22 11:25 UTC (permalink / raw)
  To: Hangbin Liu
  Cc: netdev, David S. Miller, Jakub Kicinski, Paolo Abeni, Shuah Khan,
	David Ahern, Petr Machata


Hangbin Liu <liuhangbin@gmail.com> writes:

> RHEL/Fedora RPM build checks are stricter, and complain when executable
> files don't have a shebang line, e.g.
>
> *** WARNING: ./kselftests/net/forwarding/sch_red.sh is executable but has no shebang, removing executable bit
>
> Fix it by adding shebang line.
>
> Fixes: 6cf0291f9517 ("selftests: forwarding: Add a RED test for SW datapath")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Reviewed-by: Petr Machata <petrm@nvidia.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] selftests: forwarding: add shebang for sch_red.sh
  2022-09-22  2:44 [PATCH net] selftests: forwarding: add shebang for sch_red.sh Hangbin Liu
  2022-09-22 11:25 ` Petr Machata
@ 2022-09-22 14:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-22 14:40 UTC (permalink / raw)
  To: Hangbin Liu; +Cc: netdev, davem, kuba, pabeni, shuah, dsahern, petrm

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 22 Sep 2022 10:44:53 +0800 you wrote:
> RHEL/Fedora RPM build checks are stricter, and complain when executable
> files don't have a shebang line, e.g.
> 
> *** WARNING: ./kselftests/net/forwarding/sch_red.sh is executable but has no shebang, removing executable bit
> 
> Fix it by adding shebang line.
> 
> [...]

Here is the summary with links:
  - [net] selftests: forwarding: add shebang for sch_red.sh
    https://git.kernel.org/netdev/net/c/83e4b196838d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-22 14:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22  2:44 [PATCH net] selftests: forwarding: add shebang for sch_red.sh Hangbin Liu
2022-09-22 11:25 ` Petr Machata
2022-09-22 14:40 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.