* [PATCH -next] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static
@ 2022-09-22 4:08 ` Wei Yongjun
0 siblings, 0 replies; 9+ messages in thread
From: Wei Yongjun @ 2022-09-22 4:08 UTC (permalink / raw)
To: Mark Brown, Neil Armstrong, Kevin Hilman
Cc: Wei Yongjun, linux-spi, linux-arm-kernel, linux-amlogic, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
The sparse tool complains as follows:
drivers/spi/spi-meson-spicc.c:570:22: warning:
symbol 'meson_spicc_pow2_clk_ops' was not declared. Should it be static?
This symbol is not used outside of spi-meson-spicc.c, so marks it static.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/spi/spi-meson-spicc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
index e4cb52e1fe26..85b4b9b267b1 100644
--- a/drivers/spi/spi-meson-spicc.c
+++ b/drivers/spi/spi-meson-spicc.c
@@ -567,7 +567,7 @@ static int meson_spicc_pow2_set_rate(struct clk_hw *hw, unsigned long rate,
return clk_divider_ops.set_rate(hw, rate, parent_rate);
}
-const struct clk_ops meson_spicc_pow2_clk_ops = {
+static const struct clk_ops meson_spicc_pow2_clk_ops = {
.recalc_rate = meson_spicc_pow2_recalc_rate,
.determine_rate = meson_spicc_pow2_determine_rate,
.set_rate = meson_spicc_pow2_set_rate,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH -next] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static
@ 2022-09-22 4:08 ` Wei Yongjun
0 siblings, 0 replies; 9+ messages in thread
From: Wei Yongjun @ 2022-09-22 4:08 UTC (permalink / raw)
To: Mark Brown, Neil Armstrong, Kevin Hilman
Cc: Wei Yongjun, linux-spi, linux-arm-kernel, linux-amlogic, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
The sparse tool complains as follows:
drivers/spi/spi-meson-spicc.c:570:22: warning:
symbol 'meson_spicc_pow2_clk_ops' was not declared. Should it be static?
This symbol is not used outside of spi-meson-spicc.c, so marks it static.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/spi/spi-meson-spicc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
index e4cb52e1fe26..85b4b9b267b1 100644
--- a/drivers/spi/spi-meson-spicc.c
+++ b/drivers/spi/spi-meson-spicc.c
@@ -567,7 +567,7 @@ static int meson_spicc_pow2_set_rate(struct clk_hw *hw, unsigned long rate,
return clk_divider_ops.set_rate(hw, rate, parent_rate);
}
-const struct clk_ops meson_spicc_pow2_clk_ops = {
+static const struct clk_ops meson_spicc_pow2_clk_ops = {
.recalc_rate = meson_spicc_pow2_recalc_rate,
.determine_rate = meson_spicc_pow2_determine_rate,
.set_rate = meson_spicc_pow2_set_rate,
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH -next] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static
2022-09-22 4:08 ` Wei Yongjun
(?)
@ 2022-09-22 9:23 ` Neil Armstrong
-1 siblings, 0 replies; 9+ messages in thread
From: Neil Armstrong @ 2022-09-22 9:23 UTC (permalink / raw)
To: Wei Yongjun, Mark Brown, Neil Armstrong, Kevin Hilman
Cc: Wei Yongjun, linux-spi, linux-arm-kernel, linux-amlogic, kernel-janitors
On 22/09/2022 06:08, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/spi/spi-meson-spicc.c:570:22: warning:
> symbol 'meson_spicc_pow2_clk_ops' was not declared. Should it be static?
>
> This symbol is not used outside of spi-meson-spicc.c, so marks it static.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/spi/spi-meson-spicc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
> index e4cb52e1fe26..85b4b9b267b1 100644
> --- a/drivers/spi/spi-meson-spicc.c
> +++ b/drivers/spi/spi-meson-spicc.c
> @@ -567,7 +567,7 @@ static int meson_spicc_pow2_set_rate(struct clk_hw *hw, unsigned long rate,
> return clk_divider_ops.set_rate(hw, rate, parent_rate);
> }
>
> -const struct clk_ops meson_spicc_pow2_clk_ops = {
> +static const struct clk_ops meson_spicc_pow2_clk_ops = {
> .recalc_rate = meson_spicc_pow2_recalc_rate,
> .determine_rate = meson_spicc_pow2_determine_rate,
> .set_rate = meson_spicc_pow2_set_rate,
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH -next] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static
@ 2022-09-22 9:23 ` Neil Armstrong
0 siblings, 0 replies; 9+ messages in thread
From: Neil Armstrong @ 2022-09-22 9:23 UTC (permalink / raw)
To: Wei Yongjun, Mark Brown, Neil Armstrong, Kevin Hilman
Cc: Wei Yongjun, linux-spi, linux-arm-kernel, linux-amlogic, kernel-janitors
On 22/09/2022 06:08, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/spi/spi-meson-spicc.c:570:22: warning:
> symbol 'meson_spicc_pow2_clk_ops' was not declared. Should it be static?
>
> This symbol is not used outside of spi-meson-spicc.c, so marks it static.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/spi/spi-meson-spicc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
> index e4cb52e1fe26..85b4b9b267b1 100644
> --- a/drivers/spi/spi-meson-spicc.c
> +++ b/drivers/spi/spi-meson-spicc.c
> @@ -567,7 +567,7 @@ static int meson_spicc_pow2_set_rate(struct clk_hw *hw, unsigned long rate,
> return clk_divider_ops.set_rate(hw, rate, parent_rate);
> }
>
> -const struct clk_ops meson_spicc_pow2_clk_ops = {
> +static const struct clk_ops meson_spicc_pow2_clk_ops = {
> .recalc_rate = meson_spicc_pow2_recalc_rate,
> .determine_rate = meson_spicc_pow2_determine_rate,
> .set_rate = meson_spicc_pow2_set_rate,
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH -next] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static
@ 2022-09-22 9:23 ` Neil Armstrong
0 siblings, 0 replies; 9+ messages in thread
From: Neil Armstrong @ 2022-09-22 9:23 UTC (permalink / raw)
To: Wei Yongjun, Mark Brown, Neil Armstrong, Kevin Hilman
Cc: Wei Yongjun, linux-spi, linux-arm-kernel, linux-amlogic, kernel-janitors
On 22/09/2022 06:08, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/spi/spi-meson-spicc.c:570:22: warning:
> symbol 'meson_spicc_pow2_clk_ops' was not declared. Should it be static?
>
> This symbol is not used outside of spi-meson-spicc.c, so marks it static.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/spi/spi-meson-spicc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
> index e4cb52e1fe26..85b4b9b267b1 100644
> --- a/drivers/spi/spi-meson-spicc.c
> +++ b/drivers/spi/spi-meson-spicc.c
> @@ -567,7 +567,7 @@ static int meson_spicc_pow2_set_rate(struct clk_hw *hw, unsigned long rate,
> return clk_divider_ops.set_rate(hw, rate, parent_rate);
> }
>
> -const struct clk_ops meson_spicc_pow2_clk_ops = {
> +static const struct clk_ops meson_spicc_pow2_clk_ops = {
> .recalc_rate = meson_spicc_pow2_recalc_rate,
> .determine_rate = meson_spicc_pow2_determine_rate,
> .set_rate = meson_spicc_pow2_set_rate,
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static
2022-09-22 4:08 ` Wei Yongjun
(?)
@ 2022-09-22 17:54 ` Mark Brown
-1 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2022-09-22 17:54 UTC (permalink / raw)
To: Wei Yongjun, Neil Armstrong, Kevin Hilman
Cc: linux-amlogic, kernel-janitors, linux-spi, linux-arm-kernel, Wei Yongjun
On Thu, 22 Sep 2022 04:08:07 +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/spi/spi-meson-spicc.c:570:22: warning:
> symbol 'meson_spicc_pow2_clk_ops' was not declared. Should it be static?
>
> [...]
Applied to
broonie/spi.git for-next
Thanks!
[1/1] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static
commit: 077dac343b54babfd56b1a52cf1f091518118957
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH -next] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static
@ 2022-09-22 17:54 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2022-09-22 17:54 UTC (permalink / raw)
To: Wei Yongjun, Neil Armstrong, Kevin Hilman
Cc: linux-amlogic, kernel-janitors, linux-spi, linux-arm-kernel, Wei Yongjun
On Thu, 22 Sep 2022 04:08:07 +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/spi/spi-meson-spicc.c:570:22: warning:
> symbol 'meson_spicc_pow2_clk_ops' was not declared. Should it be static?
>
> [...]
Applied to
broonie/spi.git for-next
Thanks!
[1/1] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static
commit: 077dac343b54babfd56b1a52cf1f091518118957
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH -next] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static
@ 2022-09-22 17:54 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2022-09-22 17:54 UTC (permalink / raw)
To: Wei Yongjun, Neil Armstrong, Kevin Hilman
Cc: linux-amlogic, kernel-janitors, linux-spi, linux-arm-kernel, Wei Yongjun
On Thu, 22 Sep 2022 04:08:07 +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/spi/spi-meson-spicc.c:570:22: warning:
> symbol 'meson_spicc_pow2_clk_ops' was not declared. Should it be static?
>
> [...]
Applied to
broonie/spi.git for-next
Thanks!
[1/1] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static
commit: 077dac343b54babfd56b1a52cf1f091518118957
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread