All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zhong <floridsleeves@gmail.com>
To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: jiapeng.chong@linux.alibaba.com, Xinhui.Pan@amd.com,
	guchun.chen@amd.com, airlied@linux.ie, lijo.lazar@amd.com,
	mario.limonciello@amd.com, darren.powell@amd.com,
	alexander.deucher@amd.com, evan.quan@amd.com,
	christian.koenig@amd.com, Li Zhong <floridsleeves@gmail.com>
Subject: [PATCH v2] drivers/amd/pm: check the return value of amdgpu_bo_kmap
Date: Wed, 21 Sep 2022 21:17:56 -0700	[thread overview]
Message-ID: <20220922041756.1681845-1-floridsleeves@gmail.com> (raw)

amdgpu_bo_kmap() returns error when fails to map buffer object. Add the
error check and propagate the error.

Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
 drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
index 1eb4e613b27a..ec055858eb95 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
@@ -1485,6 +1485,7 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size)
 {
 	struct pp_hwmgr *hwmgr = handle;
 	struct amdgpu_device *adev = hwmgr->adev;
+	int err;
 
 	if (!addr || !size)
 		return -EINVAL;
@@ -1492,7 +1493,9 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size)
 	*addr = NULL;
 	*size = 0;
 	if (adev->pm.smu_prv_buffer) {
-		amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
+		err = amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
+		if (err)
+			return err;
 		*size = adev->pm.smu_prv_buffer_size;
 	}
 
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Li Zhong <floridsleeves@gmail.com>
To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: jiapeng.chong@linux.alibaba.com, Xinhui.Pan@amd.com,
	guchun.chen@amd.com, airlied@linux.ie, lijo.lazar@amd.com,
	mario.limonciello@amd.com, daniel@ffwll.ch,
	darren.powell@amd.com, alexander.deucher@amd.com,
	evan.quan@amd.com, christian.koenig@amd.com,
	Li Zhong <floridsleeves@gmail.com>
Subject: [PATCH v2] drivers/amd/pm: check the return value of amdgpu_bo_kmap
Date: Wed, 21 Sep 2022 21:17:56 -0700	[thread overview]
Message-ID: <20220922041756.1681845-1-floridsleeves@gmail.com> (raw)

amdgpu_bo_kmap() returns error when fails to map buffer object. Add the
error check and propagate the error.

Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
 drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
index 1eb4e613b27a..ec055858eb95 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
@@ -1485,6 +1485,7 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size)
 {
 	struct pp_hwmgr *hwmgr = handle;
 	struct amdgpu_device *adev = hwmgr->adev;
+	int err;
 
 	if (!addr || !size)
 		return -EINVAL;
@@ -1492,7 +1493,9 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size)
 	*addr = NULL;
 	*size = 0;
 	if (adev->pm.smu_prv_buffer) {
-		amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
+		err = amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
+		if (err)
+			return err;
 		*size = adev->pm.smu_prv_buffer_size;
 	}
 
-- 
2.25.1


             reply	other threads:[~2022-09-22  7:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22  4:17 Li Zhong [this message]
2022-09-22  4:17 ` [PATCH v2] drivers/amd/pm: check the return value of amdgpu_bo_kmap Li Zhong
2022-09-22  4:23 ` Quan, Evan
2022-09-22  4:23   ` Quan, Evan
2022-09-22  6:49 ` Christian König
2022-09-22  6:49   ` Christian König
2022-09-22 14:42   ` Alex Deucher
2022-09-22 14:42     ` Alex Deucher
2022-09-24 22:19 Li Zhong
2022-09-24 22:19 ` Li Zhong
2022-09-30 14:42 ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220922041756.1681845-1-floridsleeves@gmail.com \
    --to=floridsleeves@gmail.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=darren.powell@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=evan.quan@amd.com \
    --cc=guchun.chen@amd.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=lijo.lazar@amd.com \
    --cc=mario.limonciello@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.